The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4dc2d09bd5461d5827f900023d264869427ca17

commit c4dc2d09bd5461d5827f900023d264869427ca17
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Aug 17 23:16:07 2017

Make browser_tests Network Service-ready

Refactors content_shell's NetworkServiceTest implementation into a
public test helper. Uses this in Chrome's test launcher to enable host
resolver overrides when the Network Service is enabled while running
browser_tests.

Because of the way the test suites are configured, this also affects
sync_performance_tests, performance_browser_tests, interactive_ui_tests,
and mash_browser_tests.

BUG= 721414 
R=jam@chromium.org

Change-Id: I0b345cfcef22ec207a40370b004433a435489e8d
Reviewed-on: https://chromium-review.googlesource.com/615607
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495373}
[modify] https://crrev.com/c4dc2d09bd5461d5827f900023d264869427ca17/chrome/test/base/chrome_test_launcher.cc
[modify] https://crrev.com/c4dc2d09bd5461d5827f900023d264869427ca17/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/c4dc2d09bd5461d5827f900023d264869427ca17/chrome/utility/chrome_content_utility_client.h
[add] https://crrev.com/c4dc2d09bd5461d5827f900023d264869427ca17/content/public/test/network_service_test_helper.cc
[add] https://crrev.com/c4dc2d09bd5461d5827f900023d264869427ca17/content/public/test/network_service_test_helper.h
[modify] https://crrev.com/c4dc2d09bd5461d5827f900023d264869427ca17/content/shell/utility/shell_content_utility_client.cc
[modify] https://crrev.com/c4dc2d09bd5461d5827f900023d264869427ca17/content/shell/utility/shell_content_utility_client.h
[modify] https://crrev.com/c4dc2d09bd5461d5827f900023d264869427ca17/content/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d503387f1c0f7bec7accb9f435f49a5705df8a41

commit d503387f1c0f7bec7accb9f435f49a5705df8a41
Author: Ken Rockot <rockot@chromium.org>
Date: Fri Sep 15 20:49:53 2017

Support multiple throttles on ThrottlingURLLoader

This enables ThrottlingURLLoader to support construction over multiple
sequential throttles.

Derived from work on
https://chromium-review.googlesource.com/c/chromium/src/+/612403

BUG= 754882 , 721414 

Change-Id: I16601f6bed46585b825481c732671bd7ffd5e15b
Reviewed-on: https://chromium-review.googlesource.com/668137
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502359}
[modify] https://crrev.com/d503387f1c0f7bec7accb9f435f49a5705df8a41/content/common/throttling_url_loader.cc
[modify] https://crrev.com/d503387f1c0f7bec7accb9f435f49a5705df8a41/content/common/throttling_url_loader.h
[modify] https://crrev.com/d503387f1c0f7bec7accb9f435f49a5705df8a41/content/common/throttling_url_loader_unittest.cc
[modify] https://crrev.com/d503387f1c0f7bec7accb9f435f49a5705df8a41/content/public/common/url_loader_throttle.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/950472bbce2d9b831859f398f7b0b001460539d2

commit 950472bbce2d9b831859f398f7b0b001460539d2
Author: Ken Rockot <rockot@chromium.org>
Date: Mon Sep 25 20:48:34 2017

Mojo: Add DataPipeStringWriter

Adds a utility class to the public C++ API for feeding arbitrary
string data into a data pipe producer handle. This takes care of
chunking the string data as necessary to account for limited data
pipe capacity.

BUG= 721414 
R=jcivelli@chromium.org

Change-Id: I45c9d8355ccf57cd7d1b22bf44caae1b50534248
Reviewed-on: https://chromium-review.googlesource.com/682634
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504156}
[modify] https://crrev.com/950472bbce2d9b831859f398f7b0b001460539d2/mojo/public/cpp/system/BUILD.gn
[add] https://crrev.com/950472bbce2d9b831859f398f7b0b001460539d2/mojo/public/cpp/system/data_pipe_string_writer.cc
[add] https://crrev.com/950472bbce2d9b831859f398f7b0b001460539d2/mojo/public/cpp/system/data_pipe_string_writer.h
[modify] https://crrev.com/950472bbce2d9b831859f398f7b0b001460539d2/mojo/public/cpp/system/tests/BUILD.gn
[add] https://crrev.com/950472bbce2d9b831859f398f7b0b001460539d2/mojo/public/cpp/system/tests/data_pipe_string_writer_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4cf93d4e5790fd025a31f6218fde58b3847b971

commit e4cf93d4e5790fd025a31f6218fde58b3847b971
Author: Ken Rockot <rockot@chromium.org>
Date: Tue Sep 26 23:53:54 2017

Mojo: Add FileDataPipeProducer

Introduces a helper to use a file (via base::File or base::FilePath)
as a data source for a Mojo data pipe producer handle. This helper
automatically feeds file data into a data pipe as long as it remains
alive and the file has more bytes left to read. It also ensures that
such work is scheduled on an appropriate sequence in the system where
blocking file I/O is acceptable.

BUG= 721414 

Change-Id: Ief1243a7529a05d8ba3287a46db3ad3406aefec0
Reviewed-on: https://chromium-review.googlesource.com/683356
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504525}
[modify] https://crrev.com/e4cf93d4e5790fd025a31f6218fde58b3847b971/mojo/public/cpp/system/BUILD.gn
[add] https://crrev.com/e4cf93d4e5790fd025a31f6218fde58b3847b971/mojo/public/cpp/system/file_data_pipe_producer.cc
[add] https://crrev.com/e4cf93d4e5790fd025a31f6218fde58b3847b971/mojo/public/cpp/system/file_data_pipe_producer.h
[modify] https://crrev.com/e4cf93d4e5790fd025a31f6218fde58b3847b971/mojo/public/cpp/system/tests/BUILD.gn
[modify] https://crrev.com/e4cf93d4e5790fd025a31f6218fde58b3847b971/mojo/public/cpp/system/tests/data_pipe_string_writer_unittest.cc
[add] https://crrev.com/e4cf93d4e5790fd025a31f6218fde58b3847b971/mojo/public/cpp/system/tests/file_data_pipe_producer_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4878545a4f99287f8f9fc5e76fc07e0c1575536a

commit 4878545a4f99287f8f9fc5e76fc07e0c1575536a
Author: Ken Rockot <rockot@chromium.org>
Date: Wed Oct 25 19:33:14 2017

Convert FrameMsg_CommitNavigation to mojom

Uses a Channel-associated interface to carry a new message mirroring
the contents of and replacing the legacy FrameMsg_CommitNavigation
IPC message.

This is a precursor to also sending a map of allowed protocol handler
URLLoaderFactoryPtrs to frames upon navigation, which would be much
more cumbersome using legacy IPC. This map will support things like
file URLs and any embedder-defined schemes (e.g. chrome-extension).

Bug:  759230 , 721414 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I9a679e58f6424c95029ce1ac63cb9fca7f7644e8
Reviewed-on: https://chromium-review.googlesource.com/736855
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511554}
[modify] https://crrev.com/4878545a4f99287f8f9fc5e76fc07e0c1575536a/components/subresource_filter/content/common/subresource_filter_messages.h
[modify] https://crrev.com/4878545a4f99287f8f9fc5e76fc07e0c1575536a/content/browser/frame_host/navigator_impl_unittest.cc
[modify] https://crrev.com/4878545a4f99287f8f9fc5e76fc07e0c1575536a/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/4878545a4f99287f8f9fc5e76fc07e0c1575536a/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/4878545a4f99287f8f9fc5e76fc07e0c1575536a/content/common/frame.mojom
[modify] https://crrev.com/4878545a4f99287f8f9fc5e76fc07e0c1575536a/content/common/frame_messages.h
[modify] https://crrev.com/4878545a4f99287f8f9fc5e76fc07e0c1575536a/content/common/navigation_params.h
[add] https://crrev.com/4878545a4f99287f8f9fc5e76fc07e0c1575536a/content/common/navigation_params.typemap
[modify] https://crrev.com/4878545a4f99287f8f9fc5e76fc07e0c1575536a/content/common/typemaps.gni
[modify] https://crrev.com/4878545a4f99287f8f9fc5e76fc07e0c1575536a/content/public/test/mock_render_process_host.h
[modify] https://crrev.com/4878545a4f99287f8f9fc5e76fc07e0c1575536a/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/4878545a4f99287f8f9fc5e76fc07e0c1575536a/content/renderer/render_frame_impl.h
[modify] https://crrev.com/4878545a4f99287f8f9fc5e76fc07e0c1575536a/content/renderer/renderer_webapplicationcachehost_impl.cc
[modify] https://crrev.com/4878545a4f99287f8f9fc5e76fc07e0c1575536a/content/test/test_render_frame.cc
[modify] https://crrev.com/4878545a4f99287f8f9fc5e76fc07e0c1575536a/content/test/test_render_frame_host.cc
[modify] https://crrev.com/4878545a4f99287f8f9fc5e76fc07e0c1575536a/content/test/test_render_frame_host.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bba21f276796f75e0d427fe3a224088e48f375e6

commit bba21f276796f75e0d427fe3a224088e48f375e6
Author: Ken Rockot <rockot@chromium.org>
Date: Mon Oct 30 09:25:40 2017

Always send subresource ULF on navigation

This changes the Network Service-enabled browser-side navigation path
to always send a default subresource URLLoaderFactory to the render
frame on navigation commit.

In addition to sending a default ULF, we also send one for blobs.
Ultimately the idea here is to have the browser, at navigation time,
send a frame everything it will need to request any accessible
subresources, making it easier to reason about what subresource
capabilities any given frame has.

This set of capabilities is encapsulated by a new
URLLoaderFactoryBundle type, which can be serialized over mojom and is
now passed in new-document navigation commit messages.

Follow-up usage of URLLoaderFactoryBundle will support loading things
like file:// and chrome-extension:// subresources when appropriate.

Note that this does not yet change how workers acquire ULFs for their
own resource requests.

Bug:  721414 , 759230 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I47b0897c7c012292633d5f08c874a18cc0fb1dcb
Reviewed-on: https://chromium-review.googlesource.com/740904
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512459}
[modify] https://crrev.com/bba21f276796f75e0d427fe3a224088e48f375e6/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/bba21f276796f75e0d427fe3a224088e48f375e6/content/common/BUILD.gn
[modify] https://crrev.com/bba21f276796f75e0d427fe3a224088e48f375e6/content/common/frame.mojom
[modify] https://crrev.com/bba21f276796f75e0d427fe3a224088e48f375e6/content/common/typemaps.gni
[add] https://crrev.com/bba21f276796f75e0d427fe3a224088e48f375e6/content/common/url_loader_factory_bundle.cc
[add] https://crrev.com/bba21f276796f75e0d427fe3a224088e48f375e6/content/common/url_loader_factory_bundle.h
[add] https://crrev.com/bba21f276796f75e0d427fe3a224088e48f375e6/content/common/url_loader_factory_bundle.mojom
[add] https://crrev.com/bba21f276796f75e0d427fe3a224088e48f375e6/content/common/url_loader_factory_bundle.typemap
[add] https://crrev.com/bba21f276796f75e0d427fe3a224088e48f375e6/content/common/url_loader_factory_bundle_struct_traits.cc
[add] https://crrev.com/bba21f276796f75e0d427fe3a224088e48f375e6/content/common/url_loader_factory_bundle_struct_traits.h
[modify] https://crrev.com/bba21f276796f75e0d427fe3a224088e48f375e6/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/bba21f276796f75e0d427fe3a224088e48f375e6/content/renderer/render_frame_impl.h
[modify] https://crrev.com/bba21f276796f75e0d427fe3a224088e48f375e6/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/bba21f276796f75e0d427fe3a224088e48f375e6/content/test/test_render_frame.cc
[modify] https://crrev.com/bba21f276796f75e0d427fe3a224088e48f375e6/content/test/test_render_frame_host.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02ed3cc1d6da1dc9263ad44f9c1bc662044d78c9

commit 02ed3cc1d6da1dc9263ad44f9c1bc662044d78c9
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Mon Oct 30 15:05:11 2017

Revert "Always send subresource ULF on navigation"

This reverts commit bba21f276796f75e0d427fe3a224088e48f375e6.

Suspected to cause lots of test failures on Mojo Linux bot.
https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/6676

>> Always send subresource ULF on navigation
>>
>> This changes the Network Service-enabled browser-side navigation path
>> to always send a default subresource URLLoaderFactory to the render
>> frame on navigation commit.
>>
>> In addition to sending a default ULF, we also send one for blobs.
>> Ultimately the idea here is to have the browser, at navigation time,
>> send a frame everything it will need to request any accessible
>> subresources, making it easier to reason about what subresource
>> capabilities any given frame has.
>>
>> This set of capabilities is encapsulated by a new
>> URLLoaderFactoryBundle type, which can be serialized over mojom and is
>> now passed in new-document navigation commit messages.
>>
>> Follow-up usage of URLLoaderFactoryBundle will support loading things
>> like file:// and chrome-extension:// subresources when appropriate.
>>
>> Note that this does not yet change how workers acquire ULFs for their
>> own resource requests.
>>
>> Bug:  721414 , 759230 
>> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
>> Change-Id: I47b0897c7c012292633d5f08c874a18cc0fb1dcb
>> Reviewed-on: https://chromium-review.googlesource.com/740904

TBR=jam@chromium.org, rockot@chromium.org, dcheng@chromium.org

Bug:  721414 ,  759230 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I7e7a0d5f57033369a8061cf2c189ef7b43b0ceb1
Reviewed-on: https://chromium-review.googlesource.com/743881
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512495}
[modify] https://crrev.com/02ed3cc1d6da1dc9263ad44f9c1bc662044d78c9/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/02ed3cc1d6da1dc9263ad44f9c1bc662044d78c9/content/common/BUILD.gn
[modify] https://crrev.com/02ed3cc1d6da1dc9263ad44f9c1bc662044d78c9/content/common/frame.mojom
[modify] https://crrev.com/02ed3cc1d6da1dc9263ad44f9c1bc662044d78c9/content/common/typemaps.gni
[delete] https://crrev.com/dd64a192d8b8a180fb40f389f4ecf8680467e968/content/common/url_loader_factory_bundle.cc
[delete] https://crrev.com/dd64a192d8b8a180fb40f389f4ecf8680467e968/content/common/url_loader_factory_bundle.h
[delete] https://crrev.com/dd64a192d8b8a180fb40f389f4ecf8680467e968/content/common/url_loader_factory_bundle.mojom
[delete] https://crrev.com/dd64a192d8b8a180fb40f389f4ecf8680467e968/content/common/url_loader_factory_bundle.typemap
[delete] https://crrev.com/dd64a192d8b8a180fb40f389f4ecf8680467e968/content/common/url_loader_factory_bundle_struct_traits.cc
[delete] https://crrev.com/dd64a192d8b8a180fb40f389f4ecf8680467e968/content/common/url_loader_factory_bundle_struct_traits.h
[modify] https://crrev.com/02ed3cc1d6da1dc9263ad44f9c1bc662044d78c9/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/02ed3cc1d6da1dc9263ad44f9c1bc662044d78c9/content/renderer/render_frame_impl.h
[modify] https://crrev.com/02ed3cc1d6da1dc9263ad44f9c1bc662044d78c9/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/02ed3cc1d6da1dc9263ad44f9c1bc662044d78c9/content/test/test_render_frame.cc
[modify] https://crrev.com/02ed3cc1d6da1dc9263ad44f9c1bc662044d78c9/content/test/test_render_frame_host.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e60ebbd1ae1e543a73b177fc097cadbf568d2c43

commit e60ebbd1ae1e543a73b177fc097cadbf568d2c43
Author: Ken Rockot <rockot@chromium.org>
Date: Tue Oct 31 01:50:59 2017

Reland "Always send subresource ULF on navigation"

This is a reland of bba21f276796f75e0d427fe3a224088e48f375e6
Original change's description:
> Always send subresource ULF on navigation
> 
> This changes the Network Service-enabled browser-side navigation path
> to always send a default subresource URLLoaderFactory to the render
> frame on navigation commit.
> 
> In addition to sending a default ULF, we also send one for blobs.
> Ultimately the idea here is to have the browser, at navigation time,
> send a frame everything it will need to request any accessible
> subresources, making it easier to reason about what subresource
> capabilities any given frame has.
> 
> This set of capabilities is encapsulated by a new
> URLLoaderFactoryBundle type, which can be serialized over mojom and is
> now passed in new-document navigation commit messages.
> 
> Follow-up usage of URLLoaderFactoryBundle will support loading things
> like file:// and chrome-extension:// subresources when appropriate.
> 
> Note that this does not yet change how workers acquire ULFs for their
> own resource requests.
> 
> Bug:  721414 , 759230 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Change-Id: I47b0897c7c012292633d5f08c874a18cc0fb1dcb
> Reviewed-on: https://chromium-review.googlesource.com/740904
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#512459}

Bug:  721414 ,  759230 
Change-Id: Ie13bcd97b7a5af8dbe4263a70239ba124205da15
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation

TBR=dcheng@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ie13bcd97b7a5af8dbe4263a70239ba124205da15
Reviewed-on: https://chromium-review.googlesource.com/744222
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512706}
[modify] https://crrev.com/e60ebbd1ae1e543a73b177fc097cadbf568d2c43/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/e60ebbd1ae1e543a73b177fc097cadbf568d2c43/content/common/BUILD.gn
[modify] https://crrev.com/e60ebbd1ae1e543a73b177fc097cadbf568d2c43/content/common/frame.mojom
[modify] https://crrev.com/e60ebbd1ae1e543a73b177fc097cadbf568d2c43/content/common/typemaps.gni
[add] https://crrev.com/e60ebbd1ae1e543a73b177fc097cadbf568d2c43/content/common/url_loader_factory_bundle.cc
[add] https://crrev.com/e60ebbd1ae1e543a73b177fc097cadbf568d2c43/content/common/url_loader_factory_bundle.h
[add] https://crrev.com/e60ebbd1ae1e543a73b177fc097cadbf568d2c43/content/common/url_loader_factory_bundle.mojom
[add] https://crrev.com/e60ebbd1ae1e543a73b177fc097cadbf568d2c43/content/common/url_loader_factory_bundle.typemap
[add] https://crrev.com/e60ebbd1ae1e543a73b177fc097cadbf568d2c43/content/common/url_loader_factory_bundle_struct_traits.cc
[add] https://crrev.com/e60ebbd1ae1e543a73b177fc097cadbf568d2c43/content/common/url_loader_factory_bundle_struct_traits.h
[modify] https://crrev.com/e60ebbd1ae1e543a73b177fc097cadbf568d2c43/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/e60ebbd1ae1e543a73b177fc097cadbf568d2c43/content/renderer/render_frame_impl.h
[modify] https://crrev.com/e60ebbd1ae1e543a73b177fc097cadbf568d2c43/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/e60ebbd1ae1e543a73b177fc097cadbf568d2c43/content/test/test_render_frame.cc
[modify] https://crrev.com/e60ebbd1ae1e543a73b177fc097cadbf568d2c43/content/test/test_render_frame_host.cc
[add] https://crrev.com/e60ebbd1ae1e543a73b177fc097cadbf568d2c43/third_party/WebKit/LayoutTests/fast/dom/Window/window-open-subresource-loading.html

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f409847329e8c94d3912d3c54e0121a06e778d0f

commit f409847329e8c94d3912d3c54e0121a06e778d0f
Author: Matt Menke <mmenke@chromium.org>
Date: Tue Oct 31 08:27:28 2017

Revert "Reland "Always send subresource ULF on navigation""

This reverts commit e60ebbd1ae1e543a73b177fc097cadbf568d2c43.

Reason for revert: Caused ~60 browser_tests and
content_browsertests to fail with the network service enabled.

Original change's description:
> Reland "Always send subresource ULF on navigation"
> 
> This is a reland of bba21f276796f75e0d427fe3a224088e48f375e6
> Original change's description:
> > Always send subresource ULF on navigation
> > 
> > This changes the Network Service-enabled browser-side navigation path
> > to always send a default subresource URLLoaderFactory to the render
> > frame on navigation commit.
> > 
> > In addition to sending a default ULF, we also send one for blobs.
> > Ultimately the idea here is to have the browser, at navigation time,
> > send a frame everything it will need to request any accessible
> > subresources, making it easier to reason about what subresource
> > capabilities any given frame has.
> > 
> > This set of capabilities is encapsulated by a new
> > URLLoaderFactoryBundle type, which can be serialized over mojom and is
> > now passed in new-document navigation commit messages.
> > 
> > Follow-up usage of URLLoaderFactoryBundle will support loading things
> > like file:// and chrome-extension:// subresources when appropriate.
> > 
> > Note that this does not yet change how workers acquire ULFs for their
> > own resource requests.
> > 
> > Bug:  721414 , 759230 
> > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> > Change-Id: I47b0897c7c012292633d5f08c874a18cc0fb1dcb
> > Reviewed-on: https://chromium-review.googlesource.com/740904
> > Commit-Queue: Ken Rockot <rockot@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#512459}
> 
> Bug:  721414 ,  759230 
> Change-Id: Ie13bcd97b7a5af8dbe4263a70239ba124205da15
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> 
> TBR=dcheng@chromium.org
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Change-Id: Ie13bcd97b7a5af8dbe4263a70239ba124205da15
> Reviewed-on: https://chromium-review.googlesource.com/744222
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#512706}

TBR=dcheng@chromium.org,jam@chromium.org,rockot@chromium.org

Change-Id: Iee7d5a63f105ac4c15d8320668a33d66972820b1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  721414 ,  759230 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/746302
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512779}
[modify] https://crrev.com/f409847329e8c94d3912d3c54e0121a06e778d0f/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/f409847329e8c94d3912d3c54e0121a06e778d0f/content/common/BUILD.gn
[modify] https://crrev.com/f409847329e8c94d3912d3c54e0121a06e778d0f/content/common/frame.mojom
[modify] https://crrev.com/f409847329e8c94d3912d3c54e0121a06e778d0f/content/common/typemaps.gni
[delete] https://crrev.com/d548ffaf774d421879ceaf5fee3d72772385de33/content/common/url_loader_factory_bundle.cc
[delete] https://crrev.com/d548ffaf774d421879ceaf5fee3d72772385de33/content/common/url_loader_factory_bundle.h
[delete] https://crrev.com/d548ffaf774d421879ceaf5fee3d72772385de33/content/common/url_loader_factory_bundle.mojom
[delete] https://crrev.com/d548ffaf774d421879ceaf5fee3d72772385de33/content/common/url_loader_factory_bundle.typemap
[delete] https://crrev.com/d548ffaf774d421879ceaf5fee3d72772385de33/content/common/url_loader_factory_bundle_struct_traits.cc
[delete] https://crrev.com/d548ffaf774d421879ceaf5fee3d72772385de33/content/common/url_loader_factory_bundle_struct_traits.h
[modify] https://crrev.com/f409847329e8c94d3912d3c54e0121a06e778d0f/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/f409847329e8c94d3912d3c54e0121a06e778d0f/content/renderer/render_frame_impl.h
[modify] https://crrev.com/f409847329e8c94d3912d3c54e0121a06e778d0f/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/f409847329e8c94d3912d3c54e0121a06e778d0f/content/test/test_render_frame.cc
[modify] https://crrev.com/f409847329e8c94d3912d3c54e0121a06e778d0f/content/test/test_render_frame_host.cc
[delete] https://crrev.com/d548ffaf774d421879ceaf5fee3d72772385de33/third_party/WebKit/LayoutTests/fast/dom/Window/window-open-subresource-loading.html

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be87ab32c0b113d05c061b355abbe1e257f5474c

commit be87ab32c0b113d05c061b355abbe1e257f5474c
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Nov 02 19:40:23 2017

Reland "Always send subresource ULF on navigation"

This is a reland of bba21f276796f75e0d427fe3a224088e48f375e6

Reland fixes a few things:

 - JS navs are special-cased renderer-side: even if such navigations
   result in a new document, we reuse the existing
   URLLoaderFactoryBundle since the document is from the same origin.
 - Some test code now passes a valid empty URLLoaderFactoryBundle
   instead of nullopt to avoid violating checks that are not
   relevant to these tests.
 - https://chromium-review.googlesource.com/c/chromium/src/+/747808
   properly configures and disables some failing SSL tests when the
   Network Service is enabled.

The only remaining failure seen from the original landing is
SafeBrowsingTriggeredInterceptingBrowserTest.AbusiveMetadata, which
appears to be failing both with and without Network Service enabled,
and both with and without this CL applied.

Original change's description:
> Always send subresource ULF on navigation
>
> This changes the Network Service-enabled browser-side navigation path
> to always send a default subresource URLLoaderFactory to the render
> frame on navigation commit.
>
> In addition to sending a default ULF, we also send one for blobs.
> Ultimately the idea here is to have the browser, at navigation time,
> send a frame everything it will need to request any accessible
> subresources, making it easier to reason about what subresource
> capabilities any given frame has.
>
> This set of capabilities is encapsulated by a new
> URLLoaderFactoryBundle type, which can be serialized over mojom and is
> now passed in new-document navigation commit messages.
>
> Follow-up usage of URLLoaderFactoryBundle will support loading things
> like file:// and chrome-extension:// subresources when appropriate.
>
> Note that this does not yet change how workers acquire ULFs for their
> own resource requests.
>
> Bug:  721414 , 759230 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Change-Id: I47b0897c7c012292633d5f08c874a18cc0fb1dcb
> Reviewed-on: https://chromium-review.googlesource.com/740904
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#512459}

Bug:  721414 ,  759230 
Change-Id: I1964aa51f837171d2fd6defedb629fc75012c35b
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_mojo

TBR=dcheng@chromium.org
TBR=jam@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_mojo

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I1964aa51f837171d2fd6defedb629fc75012c35b
Reviewed-on: https://chromium-review.googlesource.com/748266
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513584}
[modify] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/content/common/BUILD.gn
[modify] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/content/common/frame.mojom
[modify] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/content/common/typemaps.gni
[add] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/content/common/url_loader_factory_bundle.cc
[add] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/content/common/url_loader_factory_bundle.h
[add] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/content/common/url_loader_factory_bundle.mojom
[add] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/content/common/url_loader_factory_bundle.typemap
[add] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/content/common/url_loader_factory_bundle_struct_traits.cc
[add] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/content/common/url_loader_factory_bundle_struct_traits.h
[modify] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/content/renderer/render_frame_impl.h
[modify] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/content/test/test_render_frame.cc
[modify] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/content/test/test_render_frame_host.cc
[modify] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[add] https://crrev.com/be87ab32c0b113d05c061b355abbe1e257f5474c/third_party/WebKit/LayoutTests/fast/dom/Window/window-open-subresource-loading.html

Apologies, applied the wrong component in bulk.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/729e8949d6644132d5ffa9ab14eed468d115414c

commit 729e8949d6644132d5ffa9ab14eed468d115414c
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Dec 06 08:00:03 2017

Network Service: Update browser_test filter for DeclarativeNetRequest

The tests changed names in r521963:
DeclarativeNetRequestResourceTypeBrowserTest.Test1/0
DeclarativeNetRequestResourceTypeBrowserTest.Test1/1
DeclarativeNetRequestResourceTypeBrowserTest.Test2/1
DeclarativeNetRequestResourceTypeBrowserTest.Test2/0

Bug:  721414 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I9979c953d34305968f6a2eacc3873eadc2faae32
NOTRY: true
TBR: jam
Reviewed-on: https://chromium-review.googlesource.com/810445
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522039}
[modify] https://crrev.com/729e8949d6644132d5ffa9ab14eed468d115414c/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/019b53cca7c5fbd33fe122ef6c572134b8fe7949

commit 019b53cca7c5fbd33fe122ef6c572134b8fe7949
Author: Ken Rockot <rockot@chromium.org>
Date: Mon Dec 11 20:25:52 2017

Factor net::URLRequest out of extension code

This removes direct dependencies on net::URLRequest (and NetLog) from
most extensions code related to WebRequest and similar APIs, replacing
it with a new WebRequestInfo type which can be constructed from a
net::URLRequest or (eventually) some other source of request
information.

This is preparatory work for making these extensions APIs work when
the Network Service is enabled, where direct usage of net::URLRequest
in the browser will be forbidden.

Incidentally this change also allows for the persistence of frame
data throughout the lifetime of a request, fixing a long-standing bug.

Bug:  721414 , 522129
Change-Id: Ib427e5ddac66273bf0b23100c5cb4e74b7613506
Reviewed-on: https://chromium-review.googlesource.com/778461
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523189}
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/chrome/browser/extensions/api/declarative_net_request/declarative_net_request_browsertest.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/chrome/browser/extensions/api/declarative_net_request/ruleset_manager_unittest.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/chrome/browser/extensions/api/web_request/web_request_event_details_unittest.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/chrome/browser/net/chrome_extensions_network_delegate.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/chrome/test/data/extensions/api_test/webrequest/test_types.js
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/chrome/test/data/extensions/api_test/webrequest/test_websocket.js
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/chrome/test/data/extensions/api_test/webrequest/test_websocket_auth.js
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/declarative_net_request/ruleset_manager.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/declarative_net_request/ruleset_manager.h
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/declarative_webrequest/webrequest_action.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/declarative_webrequest/webrequest_condition.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/declarative_webrequest/webrequest_condition.h
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/web_request/BUILD.gn
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/web_request/web_request_api.h
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/web_request/web_request_api_helpers.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/web_request/web_request_api_helpers.h
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/web_request/web_request_event_details.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/web_request/web_request_event_details.h
[add] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/web_request/web_request_info.cc
[add] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/web_request/web_request_info.h
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/web_request/web_request_permissions.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/web_request/web_request_permissions.h
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/web_request/web_request_resource_type.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/browser/api/web_request/web_request_resource_type.h
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/extensions/shell/browser/shell_network_delegate.cc
[modify] https://crrev.com/019b53cca7c5fbd33fe122ef6c572134b8fe7949/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/387ddd5a62c7a5a1614d2d029552660998f3042d

commit 387ddd5a62c7a5a1614d2d029552660998f3042d
Author: Ken Rockot <rockot@chromium.org>
Date: Tue Jan 30 19:18:40 2018

Simplify ThrottlingURLLoader and clean up supporting code

Gets rid of the ThrottlingURLLoader::CreateLoaderAndStart override
which takes a callback instead of a SharedURLLoaderFactory.

Moves LoaderCallback into URLLoaderRequestHandler to clarify
its relation to implementations of that class.

Introduces SingleRequestURLLoaderFactory as an implementation of
SharedURLLoaderFactory that handles a single loader request using
a OnceCallback provided at construction time.

Adapts NavigationURLLoaderNetworkService to use the new API.

Bug:  721414 
Change-Id: I1030aef2096edeb4fe525999e6b7d1a626a4110c
Reviewed-on: https://chromium-review.googlesource.com/889650
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532985}
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/browser/appcache/appcache_request_handler.cc
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/browser/appcache/appcache_request_handler.h
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/browser/appcache/appcache_subresource_url_factory.cc
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/browser/appcache/appcache_url_loader_job.cc
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/browser/appcache/appcache_url_loader_job.h
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/browser/loader/url_loader_request_handler.h
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/browser/loader/web_package_request_handler.cc
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/browser/service_worker/service_worker_url_loader_job.cc
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/browser/service_worker/service_worker_url_loader_job.h
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/common/BUILD.gn
[add] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/common/single_request_url_loader_factory.cc
[add] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/common/single_request_url_loader_factory.h
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/common/throttling_url_loader.cc
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/common/throttling_url_loader.h
[modify] https://crrev.com/387ddd5a62c7a5a1614d2d029552660998f3042d/content/public/common/shared_url_loader_factory.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8

commit a0dfaca177b7deaf73a3c06852d59fbaa389e6c8
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Feb 15 07:26:25 2018

Add basic WebRequest API support for Network Service

Wires up URLLoaderFactory proxying support for content embedders and
uses this in Chrome to hook in a proxying URLLoaderFactory
implementation provided by the WebRequest API implementation.

This provides basic support for *non-blocking* WebRequest event
listeners, satisfying a subset of practical use cases.

Some new browser_tests pass as a result.

Bug:  721414 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I9f15d474fc952deddd1c8fe422065b5b63249a1c
Reviewed-on: https://chromium-review.googlesource.com/911872
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536963}
[modify] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/content/browser/file_url_loader_factory.cc
[modify] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/content/browser/loader/navigation_url_loader_network_service.h
[modify] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/content/public/browser/content_browser_client.h
[modify] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/content/public/browser/file_url_loader.h
[modify] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/extensions/browser/api/web_request/BUILD.gn
[modify] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/extensions/browser/api/web_request/web_request_api.h
[modify] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/extensions/browser/api/web_request/web_request_info.cc
[modify] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/extensions/browser/api/web_request/web_request_info.h
[add] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
[add] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
[modify] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/extensions/browser/extension_protocols.cc
[modify] https://crrev.com/a0dfaca177b7deaf73a3c06852d59fbaa389e6c8/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b74695cb7788315744b0ca5a91c88e54a575930

commit 0b74695cb7788315744b0ca5a91c88e54a575930
Author: Ken Rockot <rockot@chromium.org>
Date: Tue Feb 20 22:10:37 2018

WebRequest+NetworkService: Declarative APIs, response redirects

Because of some overlap in test coverage, this CL fixes two tangentially
related features of the WebRequest API when the Network Service is
enabled:

 - Registered declarative web and net request API rules elicit correct
   proxy establishment via WebRequestProxyingURLLoader, so both declarative
   APIs mostly work, modulo some cross-cutting features which affect all
   WebRequest behavior

 - onHeadersReceived handlers which modify response headers into a
   redirect are now handled properly

To support the declarative WebRequest changes in particular, all rules
registries now have a UI-thread cache. Registries for webviews, which
did not have a UI-thread cache before this change, are ephemeral and
do not persist in storage.

Re-enables a bunch of tests.

TBR=benwells@chromium.org

Bug:  721414 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I60aa27a3a44119f6119377b1f7ccac725b0678c7
Reviewed-on: https://chromium-review.googlesource.com/923432
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537900}
[modify] https://crrev.com/0b74695cb7788315744b0ca5a91c88e54a575930/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/0b74695cb7788315744b0ca5a91c88e54a575930/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc
[modify] https://crrev.com/0b74695cb7788315744b0ca5a91c88e54a575930/extensions/browser/api/declarative/rules_cache_delegate.cc
[modify] https://crrev.com/0b74695cb7788315744b0ca5a91c88e54a575930/extensions/browser/api/declarative/rules_cache_delegate.h
[modify] https://crrev.com/0b74695cb7788315744b0ca5a91c88e54a575930/extensions/browser/api/declarative/rules_registry.cc
[modify] https://crrev.com/0b74695cb7788315744b0ca5a91c88e54a575930/extensions/browser/api/declarative/rules_registry_service.cc
[modify] https://crrev.com/0b74695cb7788315744b0ca5a91c88e54a575930/extensions/browser/api/declarative/rules_registry_service.h
[modify] https://crrev.com/0b74695cb7788315744b0ca5a91c88e54a575930/extensions/browser/api/declarative_net_request/rules_monitor_service.cc
[modify] https://crrev.com/0b74695cb7788315744b0ca5a91c88e54a575930/extensions/browser/api/declarative_net_request/rules_monitor_service.h
[modify] https://crrev.com/0b74695cb7788315744b0ca5a91c88e54a575930/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/0b74695cb7788315744b0ca5a91c88e54a575930/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
[modify] https://crrev.com/0b74695cb7788315744b0ca5a91c88e54a575930/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
[modify] https://crrev.com/0b74695cb7788315744b0ca5a91c88e54a575930/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e9ae372f0f10eac4113e0c7492458aff0673eca

commit 7e9ae372f0f10eac4113e0c7492458aff0673eca
Author: Conley Owens <cco3@chromium.org>
Date: Thu Feb 22 18:21:09 2018

Use the frame's browser context in webrequest

This change uses the frame's BrowserContext to create the
WebRequestProxyingURLLoaderFactory.  This fixes a bug that doesn't
properly do incognito webrequests when NetworkService is enabled.

BUG= 721414 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic8220db4653f66c7dc9d8eb709c2f1e50a1eb8c5
Reviewed-on: https://chromium-review.googlesource.com/929885
Commit-Queue: Conley Owens <cco3@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538490}
[modify] https://crrev.com/7e9ae372f0f10eac4113e0c7492458aff0673eca/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/7e9ae372f0f10eac4113e0c7492458aff0673eca/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06d07e39a58c3bf45006c27bbb1289de5100e686

commit 06d07e39a58c3bf45006c27bbb1289de5100e686
Author: Ken Rockot <rockot@chromium.org>
Date: Tue Feb 27 16:24:22 2018

Fix <webview> WebRequest + NetworkService

Plumbs through some additional WebRequestInfo fields in the Network
Service path to enable <webview> WebRequest (and declarative WebRequest)
APIs to work as expected.

Bug:  721414 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I78eda1c4f286623f1d82e3e5be60dd9beff517bc
Reviewed-on: https://chromium-review.googlesource.com/938675
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539449}
[modify] https://crrev.com/06d07e39a58c3bf45006c27bbb1289de5100e686/chrome/browser/extensions/chrome_extensions_browser_client.cc
[modify] https://crrev.com/06d07e39a58c3bf45006c27bbb1289de5100e686/chrome/browser/extensions/chrome_extensions_browser_client.h
[modify] https://crrev.com/06d07e39a58c3bf45006c27bbb1289de5100e686/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/06d07e39a58c3bf45006c27bbb1289de5100e686/extensions/browser/api/web_request/web_request_info.cc
[modify] https://crrev.com/06d07e39a58c3bf45006c27bbb1289de5100e686/extensions/browser/api/web_request/web_request_info.h
[modify] https://crrev.com/06d07e39a58c3bf45006c27bbb1289de5100e686/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
[modify] https://crrev.com/06d07e39a58c3bf45006c27bbb1289de5100e686/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
[modify] https://crrev.com/06d07e39a58c3bf45006c27bbb1289de5100e686/extensions/browser/extension_navigation_ui_data.cc
[modify] https://crrev.com/06d07e39a58c3bf45006c27bbb1289de5100e686/extensions/browser/extension_navigation_ui_data.h
[modify] https://crrev.com/06d07e39a58c3bf45006c27bbb1289de5100e686/extensions/browser/extensions_browser_client.cc
[modify] https://crrev.com/06d07e39a58c3bf45006c27bbb1289de5100e686/extensions/browser/extensions_browser_client.h
[modify] https://crrev.com/06d07e39a58c3bf45006c27bbb1289de5100e686/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81d14ab26e1dbc69fc672ab816bf380eff3ad3a6

commit 81d14ab26e1dbc69fc672ab816bf380eff3ad3a6
Author: Ken Rockot <rockot@chromium.org>
Date: Wed Feb 28 01:09:09 2018

Fix some declarative net request test expectations with Network Service

Because the WebRequest API stack doesn't see network requests at all
when no listeners are installed and the Network Service is enabled, this
adjusts a few test expectations which are invalid in the Network Service
path.

Bug:  721414 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I52c830c1d8604beee5bff591351cca3fbe0765c3
Reviewed-on: https://chromium-review.googlesource.com/940445
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539602}
[modify] https://crrev.com/81d14ab26e1dbc69fc672ab816bf380eff3ad3a6/chrome/browser/extensions/api/declarative_net_request/declarative_net_request_browsertest.cc
[modify] https://crrev.com/81d14ab26e1dbc69fc672ab816bf380eff3ad3a6/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cf16c3154ce408d9cb0f6b83119655cad5e83c3

commit 0cf16c3154ce408d9cb0f6b83119655cad5e83c3
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Mar 01 16:50:49 2018

Port dev tools WebUI from URLFetcher to SimpleURLLoader

This needed to be done at some point. The motivation here was to fix an
extensions WebRequest API test with the Network Service enabled.

This also plumbs through a signal so extensions API test JS code can
detect whether Network Service is enabled. This is used to support
conditional expectations in WebRequest tests since the test-only
event behavior may differ slightly between Network Service and old
networking.

Bug:  721414 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I009061f038eb3171721fe7645444695a77f3cfd3
Reviewed-on: https://chromium-review.googlesource.com/940447
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540183}
[modify] https://crrev.com/0cf16c3154ce408d9cb0f6b83119655cad5e83c3/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/0cf16c3154ce408d9cb0f6b83119655cad5e83c3/chrome/browser/extensions/extension_apitest.cc
[modify] https://crrev.com/0cf16c3154ce408d9cb0f6b83119655cad5e83c3/chrome/browser/extensions/extension_apitest.h
[modify] https://crrev.com/0cf16c3154ce408d9cb0f6b83119655cad5e83c3/chrome/browser/ui/webui/devtools_ui.cc
[modify] https://crrev.com/0cf16c3154ce408d9cb0f6b83119655cad5e83c3/chrome/test/data/extensions/api_test/webrequest/framework.js
[modify] https://crrev.com/0cf16c3154ce408d9cb0f6b83119655cad5e83c3/chrome/test/data/extensions/api_test/webrequest/test_devtools.js
[modify] https://crrev.com/0cf16c3154ce408d9cb0f6b83119655cad5e83c3/content/public/test/url_loader_interceptor.cc
[modify] https://crrev.com/0cf16c3154ce408d9cb0f6b83119655cad5e83c3/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/818bea4e4f6a919a93f3af3e2375f69099d2dfe2

commit 818bea4e4f6a919a93f3af3e2375f69099d2dfe2
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Mar 08 22:30:05 2018

WebRequest+NetworkService: Request body data

Expose request body data to WebRequest listeners when Network Service is
enabled.

Bug:  721414 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I21d4a1baabd4f842a9af6a7442b070c4932b1b44
Reviewed-on: https://chromium-review.googlesource.com/954002
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541905}
[modify] https://crrev.com/818bea4e4f6a919a93f3af3e2375f69099d2dfe2/extensions/browser/api/web_request/form_data_parser.cc
[modify] https://crrev.com/818bea4e4f6a919a93f3af3e2375f69099d2dfe2/extensions/browser/api/web_request/form_data_parser.h
[modify] https://crrev.com/818bea4e4f6a919a93f3af3e2375f69099d2dfe2/extensions/browser/api/web_request/upload_data_presenter.cc
[modify] https://crrev.com/818bea4e4f6a919a93f3af3e2375f69099d2dfe2/extensions/browser/api/web_request/upload_data_presenter.h
[modify] https://crrev.com/818bea4e4f6a919a93f3af3e2375f69099d2dfe2/extensions/browser/api/web_request/upload_data_presenter_unittest.cc
[modify] https://crrev.com/818bea4e4f6a919a93f3af3e2375f69099d2dfe2/extensions/browser/api/web_request/web_request_info.cc
[modify] https://crrev.com/818bea4e4f6a919a93f3af3e2375f69099d2dfe2/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c2240a79be9457c38c9132196bcec3b6c66c2e4

commit 7c2240a79be9457c38c9132196bcec3b6c66c2e4
Author: Ken Rockot <rockot@chromium.org>
Date: Wed Apr 04 18:35:44 2018

Re-enable WebRequestApiTest.WebRequestClientsGoogleComProtection

Re-enables this test with the Network Service enabled.

This test did some things which the Network Service does not support and
does not need to support, or which otherwise made testing with the
Network Service more complex than necessary. The following changes have
been made:

  * We no longer attempt to load a network resource from a WebUI
    renderer. This will not be supported with Network Service and is no
    longer desirable to have working in production anyway. There should
    no longer be any WebUI pages making network requests.

  * Use http instead of https for the clients1.google.com requests. This
    allows such requests to be handled by the EmbeddedTestServer which
    already exists in BrowserTestBase, which is itself not configured to
    handle HTTPS requests. Since these requests are filtered by
    hostname, the scheme doesn't matter.

  * Switch the test to use a SimpleURLLoader instead of a
    FakeURLFetcher. This allows the test code to exercise the same
    behavior with or without the Network Service enabled.

Bug:  721414 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iad1f2deaec2e218b9cb168acbe71c90591dc6acf
Reviewed-on: https://chromium-review.googlesource.com/972425
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548137}
[modify] https://crrev.com/7c2240a79be9457c38c9132196bcec3b6c66c2e4/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/7c2240a79be9457c38c9132196bcec3b6c66c2e4/chrome/test/data/extensions/api_test/webrequest_clients_google_com/background.js
[modify] https://crrev.com/7c2240a79be9457c38c9132196bcec3b6c66c2e4/extensions/browser/api/web_request/web_request_permissions.cc
[modify] https://crrev.com/7c2240a79be9457c38c9132196bcec3b6c66c2e4/extensions/browser/api/web_request/web_request_permissions.h
[modify] https://crrev.com/7c2240a79be9457c38c9132196bcec3b6c66c2e4/extensions/browser/api/web_request/web_request_permissions_unittest.cc
[modify] https://crrev.com/7c2240a79be9457c38c9132196bcec3b6c66c2e4/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c317c0ee196eb1e5269388f648592be2b445a5af

commit c317c0ee196eb1e5269388f648592be2b445a5af
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Apr 05 16:08:20 2018

Revert "Re-enable WebRequestApiTest.WebRequestClientsGoogleComProtection"

This reverts commit 7c2240a79be9457c38c9132196bcec3b6c66c2e4.

Reason for revert:  https://crbug.com/829218 

Original change's description:
> Re-enable WebRequestApiTest.WebRequestClientsGoogleComProtection
> 
> Re-enables this test with the Network Service enabled.
> 
> This test did some things which the Network Service does not support and
> does not need to support, or which otherwise made testing with the
> Network Service more complex than necessary. The following changes have
> been made:
> 
>   * We no longer attempt to load a network resource from a WebUI
>     renderer. This will not be supported with Network Service and is no
>     longer desirable to have working in production anyway. There should
>     no longer be any WebUI pages making network requests.
> 
>   * Use http instead of https for the clients1.google.com requests. This
>     allows such requests to be handled by the EmbeddedTestServer which
>     already exists in BrowserTestBase, which is itself not configured to
>     handle HTTPS requests. Since these requests are filtered by
>     hostname, the scheme doesn't matter.
> 
>   * Switch the test to use a SimpleURLLoader instead of a
>     FakeURLFetcher. This allows the test code to exercise the same
>     behavior with or without the Network Service enabled.
> 
> Bug:  721414 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Iad1f2deaec2e218b9cb168acbe71c90591dc6acf
> Reviewed-on: https://chromium-review.googlesource.com/972425
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548137}

TBR=jam@chromium.org,rockot@chromium.org,karandeepb@chromium.org

Change-Id: I054a7e11a4945e379cd45405546a90ee4d1e9577
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  721414 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/998076
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548440}
[modify] https://crrev.com/c317c0ee196eb1e5269388f648592be2b445a5af/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/c317c0ee196eb1e5269388f648592be2b445a5af/chrome/test/data/extensions/api_test/webrequest_clients_google_com/background.js
[modify] https://crrev.com/c317c0ee196eb1e5269388f648592be2b445a5af/extensions/browser/api/web_request/web_request_permissions.cc
[modify] https://crrev.com/c317c0ee196eb1e5269388f648592be2b445a5af/extensions/browser/api/web_request/web_request_permissions.h
[modify] https://crrev.com/c317c0ee196eb1e5269388f648592be2b445a5af/extensions/browser/api/web_request/web_request_permissions_unittest.cc
[modify] https://crrev.com/c317c0ee196eb1e5269388f648592be2b445a5af/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0b9230da3f15665322bc1646b8d7da7fab1537e

commit f0b9230da3f15665322bc1646b8d7da7fab1537e
Author: Ken Rockot <rockot@chromium.org>
Date: Fri Apr 06 04:54:48 2018

[Reland] Re-enable WebRequestApiTest.WebRequestClientsGoogleComProtection

This is a reland of r548137 which now includes a whitelist to allow
print preview WebUI to fetch cloud print device information directly
from the network. See  https://crbug.com/829218  for additional context.
Original CL description follows.

==

Re-enables this test with the Network Service enabled.


This test did some things which the Network Service does not support and
does not need to support, or which otherwise made testing with the
Network Service more complex than necessary. The following changes have
been made:

  * We no longer attempt to load a network resource from a WebUI
    renderer. This will not be supported with Network Service and is no
    longer desirable to have working in production anyway. There should
    no longer be any WebUI pages making network requests.

  * Use http instead of https for the clients1.google.com requests. This
    allows such requests to be handled by the EmbeddedTestServer which
    already exists in BrowserTestBase, which is itself not configured to
    handle HTTPS requests. Since these requests are filtered by
    hostname, the scheme doesn't matter.

  * Switch the test to use a SimpleURLLoader instead of a
    FakeURLFetcher. This allows the test code to exercise the same
    behavior with or without the Network Service enabled.

TBR=karandeepb@chromium.org

Bug:  721414 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I57bf66dfd7e7e0726ac98c9571f7fa031243e328
Reviewed-on: https://chromium-review.googlesource.com/998449
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548673}
[modify] https://crrev.com/f0b9230da3f15665322bc1646b8d7da7fab1537e/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/f0b9230da3f15665322bc1646b8d7da7fab1537e/chrome/test/data/extensions/api_test/webrequest_clients_google_com/background.js
[modify] https://crrev.com/f0b9230da3f15665322bc1646b8d7da7fab1537e/extensions/browser/api/web_request/web_request_permissions.cc
[modify] https://crrev.com/f0b9230da3f15665322bc1646b8d7da7fab1537e/extensions/browser/api/web_request/web_request_permissions.h
[modify] https://crrev.com/f0b9230da3f15665322bc1646b8d7da7fab1537e/extensions/browser/api/web_request/web_request_permissions_unittest.cc
[modify] https://crrev.com/f0b9230da3f15665322bc1646b8d7da7fab1537e/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53d030a18b1965c20878d6300738ed29c3bfdd08

commit 53d030a18b1965c20878d6300738ed29c3bfdd08
Author: Karandeep Bhatia <karandeepb@chromium.org>
Date: Fri Apr 27 23:29:33 2018

Network servicification: Plumb ResourceContext through WebRequestProxyingURLLoaderFactory.

This CL plumbs the ResourceContext to the WebRequestInfo structure through
WebRequestProxyingURLLoaderFactory. This is necessary to fix
NTPInterceptionWebRequestAPITest.NTPRendererRequestsHidden for the network
servicification path.

BUG= 797461 ,  721414 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I2957c1ece0f8f7b44f15156aeb5e554b3a91ff01
Reviewed-on: https://chromium-review.googlesource.com/1029549
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554556}
[modify] https://crrev.com/53d030a18b1965c20878d6300738ed29c3bfdd08/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/53d030a18b1965c20878d6300738ed29c3bfdd08/extensions/browser/api/web_request/web_request_info.cc
[modify] https://crrev.com/53d030a18b1965c20878d6300738ed29c3bfdd08/extensions/browser/api/web_request/web_request_info.h
[modify] https://crrev.com/53d030a18b1965c20878d6300738ed29c3bfdd08/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
[modify] https://crrev.com/53d030a18b1965c20878d6300738ed29c3bfdd08/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
[modify] https://crrev.com/53d030a18b1965c20878d6300738ed29c3bfdd08/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2db59ceb705e135e36ae55d91fd226123b38d16d

commit 2db59ceb705e135e36ae55d91fd226123b38d16d
Author: Karandeep Bhatia <karandeepb@chromium.org>
Date: Wed May 09 19:31:57 2018

Extensions: Disable ExtensionWebRequestApiTest.WebRequestClientsGoogleComProtection with network service.

r548673 enabled the WebRequestApiTest.WebRequestClientsGoogleComProtection test
for network service. To make a network request from the browser, the test
replaced the usage of URLFetcher with SimpleURLLoader. However this network
request never reaches the WebRequest API layer, hence defeating the purpose of
the test. To sanity check that a browser request is intercepted by extension,
this CL makes another browser request. This causes the test to fail with the
network service.

BUG= 721414 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I6b18ed906b3f01c10521fd89a24414e9a4351edd
Reviewed-on: https://chromium-review.googlesource.com/1049276
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557274}
[modify] https://crrev.com/2db59ceb705e135e36ae55d91fd226123b38d16d/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/2db59ceb705e135e36ae55d91fd226123b38d16d/chrome/test/data/extensions/api_test/webrequest_clients_google_com/background.js
[modify] https://crrev.com/2db59ceb705e135e36ae55d91fd226123b38d16d/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Not going to have time to polish off all the corner cases here, marking available so it gets triaged appropriately.

I can take a look at this.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2d2076ea20a077a80cac20d8cc4be90061cb4c8

commit a2d2076ea20a077a80cac20d8cc4be90061cb4c8
Author: Clark DuVall <cduvall@chromium.org>
Date: Tue Jul 24 01:28:38 2018

Fix ExtensionWebRequestApiTest.WebRequestDeclarative2 with network service

This test was modifying Set-Cookie and removing User-Agent, which is no
longer supported with the network service (see  crbug.com/827582 ).

Bug:  827582 ,  721414 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I977bcc767188eafb76c6d560bb959871ed73808a
Reviewed-on: https://chromium-review.googlesource.com/1145941
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577395}
[modify] https://crrev.com/a2d2076ea20a077a80cac20d8cc4be90061cb4c8/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/a2d2076ea20a077a80cac20d8cc4be90061cb4c8/chrome/test/data/extensions/api_test/webrequest/test_declarative2.js
[modify] https://crrev.com/a2d2076ea20a077a80cac20d8cc4be90061cb4c8/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
[modify] https://crrev.com/a2d2076ea20a077a80cac20d8cc4be90061cb4c8/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76349e5be36c895e3ce8cb84ef1005cc442797c1

commit 76349e5be36c895e3ce8cb84ef1005cc442797c1
Author: Clark DuVall <cduvall@chromium.org>
Date: Tue Jul 24 22:45:43 2018

Fixes DevToolsFrontendInWebRequestApiTest.HiddenRequests with network service

This test was timing out with network service enabled, due to the
difference in behavior of the web request API in the network service.
With network service enabled, when the first web request rule or
listener is added, we reset all current URLLoaderFactories so they will
be proxied through WebRequestAPI. They are then rebound when the
connection error handler runs. This can lead to a situation where
messages are dropped, due to the error message arriving asynchronously.
For example:

(1) First web request listener added, URLLoaderFactory bindings cleared
(2) CreateLoaderAndStart is called on an existing URLLoaderFactory
(3) Error message reaches existing URLLoaderFactories, and they are reset

Due to the way mojo pipes work, the message from (2) will be dropped.
This change makes that much less likely by clearing the URLLoaderFactory
in the storage partition directly instead of waiting for the error
handler to be called.

Bug:  721414 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I633e3ea933f9170767371fde697bc9de2a5258af
Reviewed-on: https://chromium-review.googlesource.com/1147072
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577716}
[modify] https://crrev.com/76349e5be36c895e3ce8cb84ef1005cc442797c1/chrome/browser/extensions/api/declarative_net_request/declarative_net_request_browsertest.cc
[modify] https://crrev.com/76349e5be36c895e3ce8cb84ef1005cc442797c1/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/76349e5be36c895e3ce8cb84ef1005cc442797c1/content/browser/storage_partition_impl.h
[modify] https://crrev.com/76349e5be36c895e3ce8cb84ef1005cc442797c1/content/public/browser/storage_partition.h
[modify] https://crrev.com/76349e5be36c895e3ce8cb84ef1005cc442797c1/content/public/test/test_storage_partition.cc
[modify] https://crrev.com/76349e5be36c895e3ce8cb84ef1005cc442797c1/content/public/test/test_storage_partition.h
[modify] https://crrev.com/76349e5be36c895e3ce8cb84ef1005cc442797c1/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/76349e5be36c895e3ce8cb84ef1005cc442797c1/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1352fa135bc3a3b28d27ebc81519727831a5ba08

commit 1352fa135bc3a3b28d27ebc81519727831a5ba08
Author: Clark DuVall <cduvall@chromium.org>
Date: Mon Jul 30 19:25:07 2018

Fixes ExtensionWebRequestApiTest.WebRequestTypes with network service

Tests now wait for the webRequest listeners to be set up, and the
correct render_frame_id is now used in WebRequestInfo.

The reason tests need to wait for listeners to be set up with the
network service is that requests need to be proxied through
WebRequestProxyingURLLoaderFactory for web request listeners to be
called. Since this proxy is in the browser process, we only set it
up when necessary for performance reasons. This means that if there
are no web request listeners set up, we do not proxy requests, but
when the first listener is set up we then reset all
URLLoaderFactories, which causes them to be recreated with the
proxy. Because of this, there is a behavior difference in the
network service, where code like:

  chrome.webRequest.foo.addListener(...);
  sendSomeRequest(...);

will no longer work with network service. This should probably be
fine since this is a very rare occurrence. For more discussion on
this, see  crbug.com/784576#c19 .

Bug:  721414 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I92fb4a02b14641886624a726301acc9e95f53533
Reviewed-on: https://chromium-review.googlesource.com/1149407
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579115}
[modify] https://crrev.com/1352fa135bc3a3b28d27ebc81519727831a5ba08/chrome/test/data/extensions/api_test/webrequest/test_types.js
[modify] https://crrev.com/1352fa135bc3a3b28d27ebc81519727831a5ba08/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/1352fa135bc3a3b28d27ebc81519727831a5ba08/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/1352fa135bc3a3b28d27ebc81519727831a5ba08/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
[modify] https://crrev.com/1352fa135bc3a3b28d27ebc81519727831a5ba08/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
[modify] https://crrev.com/1352fa135bc3a3b28d27ebc81519727831a5ba08/services/network/public/cpp/resource_request.h
[modify] https://crrev.com/1352fa135bc3a3b28d27ebc81519727831a5ba08/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db56091963b87ed7121cb921a2c31e2922532bfd

commit db56091963b87ed7121cb921a2c31e2922532bfd
Author: Clark DuVall <cduvall@chromium.org>
Date: Thu Aug 02 23:04:09 2018

Fixes ExtensionWebRequestApiTest.WebRequestBlocking with network service

Getting this test working required a few fixes:
- Modifying a header rather than Set-Cookie for some tests, which
  required switching to XMLHttpRequest ( crbug.com/827582 )
- Handling redirect from http:// -> chrome-extension://, and bypassing
  security checks if this is from web request
- Plumbing through whether the request is async or not

This is not handling subresource redirects because subresource
redirects to schemes other than http/https/data are not supported
yet with network service ( crbug.com/868545 ).

Also adds a bunch of tests for redirects.

Bug:  721414 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iabca6e5890b0d5edd066fd8945b19bdbb5d52670
Reviewed-on: https://chromium-review.googlesource.com/1145956
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580365}
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/chrome/test/data/extensions/api_test/webrequest/framework.js
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/chrome/test/data/extensions/api_test/webrequest/test_blocking.js
[add] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/chrome/test/data/extensions/api_test/webrequest/test_blocking_cookie.html
[add] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/chrome/test/data/extensions/api_test/webrequest/test_blocking_cookie.js
[add] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/chrome/test/data/extensions/api_test/webrequest/test_redirects.html
[add] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/chrome/test/data/extensions/api_test/webrequest/test_redirects.js
[add] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/chrome/test/data/extensions/api_test/webrequest/test_subresource_redirects.html
[add] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/chrome/test/data/extensions/api_test/webrequest/test_subresource_redirects.js
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/content/browser/loader/navigation_url_loader_impl.h
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/content/public/browser/BUILD.gn
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/content/public/browser/content_browser_client.h
[add] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/content/public/browser/redirect_checker.h
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/extensions/browser/api/web_request/web_request_api.h
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/extensions/browser/api/web_request/web_request_info.cc
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/extensions/browser/api/web_request/web_request_info.h
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/extensions/browser/api/web_request/web_request_proxying_websocket.cc
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/extensions/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/extensions/shell/browser/shell_content_browser_client.h
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/db56091963b87ed7121cb921a2c31e2922532bfd/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef2b6478296baa49b49aff85eb75a06b5d5a7109

commit ef2b6478296baa49b49aff85eb75a06b5d5a7109
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Aug 03 07:22:46 2018

Revert "Fixes ExtensionWebRequestApiTest.WebRequestBlocking with network service"

This reverts commit db56091963b87ed7121cb921a2c31e2922532bfd.

Reason for revert: This made ExtensionWebRequestApiTest.WebRequestTestOSDD flaky.  crbug.com/870588 


Original change's description:
> Fixes ExtensionWebRequestApiTest.WebRequestBlocking with network service
> 
> Getting this test working required a few fixes:
> - Modifying a header rather than Set-Cookie for some tests, which
>   required switching to XMLHttpRequest ( crbug.com/827582 )
> - Handling redirect from http:// -> chrome-extension://, and bypassing
>   security checks if this is from web request
> - Plumbing through whether the request is async or not
> 
> This is not handling subresource redirects because subresource
> redirects to schemes other than http/https/data are not supported
> yet with network service ( crbug.com/868545 ).
> 
> Also adds a bunch of tests for redirects.
> 
> Bug:  721414 
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: Iabca6e5890b0d5edd066fd8945b19bdbb5d52670
> Reviewed-on: https://chromium-review.googlesource.com/1145956
> Reviewed-by: Nick Carter <nick@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580365}

TBR=nick@chromium.org,jam@chromium.org,reillyg@chromium.org,karandeepb@chromium.org,cduvall@chromium.org

Change-Id: Ib831aea7b5afeb6b0e06c79a1d80520d61e02dbf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  721414 , 870588 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1161821
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580467}
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/chrome/test/data/extensions/api_test/webrequest/framework.js
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/chrome/test/data/extensions/api_test/webrequest/test_blocking.js
[delete] https://crrev.com/f20f9a30606d80e1059c2976e73cc99f7de7d76e/chrome/test/data/extensions/api_test/webrequest/test_blocking_cookie.html
[delete] https://crrev.com/f20f9a30606d80e1059c2976e73cc99f7de7d76e/chrome/test/data/extensions/api_test/webrequest/test_blocking_cookie.js
[delete] https://crrev.com/f20f9a30606d80e1059c2976e73cc99f7de7d76e/chrome/test/data/extensions/api_test/webrequest/test_redirects.html
[delete] https://crrev.com/f20f9a30606d80e1059c2976e73cc99f7de7d76e/chrome/test/data/extensions/api_test/webrequest/test_redirects.js
[delete] https://crrev.com/f20f9a30606d80e1059c2976e73cc99f7de7d76e/chrome/test/data/extensions/api_test/webrequest/test_subresource_redirects.html
[delete] https://crrev.com/f20f9a30606d80e1059c2976e73cc99f7de7d76e/chrome/test/data/extensions/api_test/webrequest/test_subresource_redirects.js
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/content/browser/loader/navigation_url_loader_impl.h
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/content/public/browser/BUILD.gn
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/content/public/browser/content_browser_client.h
[delete] https://crrev.com/f20f9a30606d80e1059c2976e73cc99f7de7d76e/content/public/browser/redirect_checker.h
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/extensions/browser/api/web_request/web_request_api.h
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/extensions/browser/api/web_request/web_request_info.cc
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/extensions/browser/api/web_request/web_request_info.h
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/extensions/browser/api/web_request/web_request_proxying_websocket.cc
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/extensions/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/extensions/shell/browser/shell_content_browser_client.h
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/ef2b6478296baa49b49aff85eb75a06b5d5a7109/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf7722f9b73432d38b6e21087e5c5a6e62274aff

commit bf7722f9b73432d38b6e21087e5c5a6e62274aff
Author: Clark DuVall <cduvall@chromium.org>
Date: Fri Aug 03 18:03:33 2018

Reland "Fixes ExtensionWebRequestApiTest.WebRequestBlocking with network service"

This is a reland of db56091963b87ed7121cb921a2c31e2922532bfd

Reland disables flaky ExtensionWebRequestApiTest.WebRequestTestOSDD on
Windows.

Original change's description:
> Fixes ExtensionWebRequestApiTest.WebRequestBlocking with network service
>
> Getting this test working required a few fixes:
> - Modifying a header rather than Set-Cookie for some tests, which
>   required switching to XMLHttpRequest ( crbug.com/827582 )
> - Handling redirect from http:// -> chrome-extension://, and bypassing
>   security checks if this is from web request
> - Plumbing through whether the request is async or not
>
> This is not handling subresource redirects because subresource
> redirects to schemes other than http/https/data are not supported
> yet with network service ( crbug.com/868545 ).
>
> Also adds a bunch of tests for redirects.
>
> Bug:  721414 
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Reviewed-on: https://chromium-review.googlesource.com/1145956
> Reviewed-by: Nick Carter <nick@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580365}

TBR=nick@chromium.org,jam@chromium.org,reillyg@chromium.org,karandeepb@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I8c37f335c96aa8f43548e9118e96f095f2ae6362
Bug:  721414 
Reviewed-on: https://chromium-review.googlesource.com/1162274
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580595}
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/chrome/test/data/extensions/api_test/webrequest/framework.js
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/chrome/test/data/extensions/api_test/webrequest/test_blocking.js
[add] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/chrome/test/data/extensions/api_test/webrequest/test_blocking_cookie.html
[add] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/chrome/test/data/extensions/api_test/webrequest/test_blocking_cookie.js
[add] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/chrome/test/data/extensions/api_test/webrequest/test_redirects.html
[add] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/chrome/test/data/extensions/api_test/webrequest/test_redirects.js
[add] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/chrome/test/data/extensions/api_test/webrequest/test_subresource_redirects.html
[add] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/chrome/test/data/extensions/api_test/webrequest/test_subresource_redirects.js
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/content/browser/loader/navigation_url_loader_impl.h
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/content/public/browser/BUILD.gn
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/content/public/browser/content_browser_client.h
[add] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/content/public/browser/redirect_checker.h
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/extensions/browser/api/web_request/web_request_api.h
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/extensions/browser/api/web_request/web_request_info.cc
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/extensions/browser/api/web_request/web_request_info.h
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/extensions/browser/api/web_request/web_request_proxying_websocket.cc
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/extensions/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/extensions/shell/browser/shell_content_browser_client.h
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/bf7722f9b73432d38b6e21087e5c5a6e62274aff/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9cbab072a2c44b00d21f6b2a19b2699f60f8e71

commit c9cbab072a2c44b00d21f6b2a19b2699f60f8e71
Author: Clark DuVall <cduvall@chromium.org>
Date: Mon Aug 06 17:45:54 2018

Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service

The error event was not being sent when the client was reset.

Bug:  721414 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I951422061022d50644d8453900af14be27bb9eaf
Reviewed-on: https://chromium-review.googlesource.com/1150403
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580911}
[modify] https://crrev.com/c9cbab072a2c44b00d21f6b2a19b2699f60f8e71/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
[modify] https://crrev.com/c9cbab072a2c44b00d21f6b2a19b2699f60f8e71/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
[modify] https://crrev.com/c9cbab072a2c44b00d21f6b2a19b2699f60f8e71/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

All the browser tests referencing this bug in mojo.fyi.network_browser_tests.filter are fixed, Ken is there anything else you know of that needs to be done here, or can this be closed?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd32a2ee991e8110ac5c944f17970993a67c955d

commit dd32a2ee991e8110ac5c944f17970993a67c955d
Author: Clark DuVall <cduvall@chromium.org>
Date: Mon Aug 06 22:25:46 2018

Revert "Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service"

This reverts commit c9cbab072a2c44b00d21f6b2a19b2699f60f8e71.

Reason for revert: Breaking linux dbg bots: https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Tests%20(dbg)(1)/73603

Original change's description:
> Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service
> 
> The error event was not being sent when the client was reset.
> 
> Bug:  721414 
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I951422061022d50644d8453900af14be27bb9eaf
> Reviewed-on: https://chromium-review.googlesource.com/1150403
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580911}

TBR=jam@chromium.org,cduvall@chromium.org

Change-Id: I56a28f0f2ebd8f3ec57aa0af0a94e317d7cffcaa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  721414 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1164208
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581009}
[modify] https://crrev.com/dd32a2ee991e8110ac5c944f17970993a67c955d/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
[modify] https://crrev.com/dd32a2ee991e8110ac5c944f17970993a67c955d/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
[modify] https://crrev.com/dd32a2ee991e8110ac5c944f17970993a67c955d/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Modulo relanding what just got reverted, yeah, I assume it's OK to close out this bug if all the relevant browser tests are passing.

That of course doesn't mean that WebRequest is working perfectly with Network Service enabled, but it's at least as good as our test coverage. :)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41b81861d982406ad5fdc69315d40e6b13d59d52

commit 41b81861d982406ad5fdc69315d40e6b13d59d52
Author: Clark DuVall <cduvall@chromium.org>
Date: Tue Aug 07 00:40:10 2018

Reland "Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service"

This is a reland of c9cbab072a2c44b00d21f6b2a19b2699f60f8e71

request_completed_ was being set unnecessarily after RemoveRequest was called.

Original change's description:
> Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service
>
> The error event was not being sent when the client was reset.
>
> Bug:  721414 
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I951422061022d50644d8453900af14be27bb9eaf
> Reviewed-on: https://chromium-review.googlesource.com/1150403
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580911}

TBR=jam@chromium.org

Bug:  721414 
Change-Id: I48769a4b86d2a18acbe5fbcedb9de3ed478e4c54
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1164209
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581058}
[modify] https://crrev.com/41b81861d982406ad5fdc69315d40e6b13d59d52/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
[modify] https://crrev.com/41b81861d982406ad5fdc69315d40e6b13d59d52/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
[modify] https://crrev.com/41b81861d982406ad5fdc69315d40e6b13d59d52/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/036e4e016357920de5af49fc8e7528d6d0257ed9

commit 036e4e016357920de5af49fc8e7528d6d0257ed9
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue Aug 07 06:52:53 2018

Revert "Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service"

This reverts commit c9cbab072a2c44b00d21f6b2a19b2699f60f8e71.

Reason for revert: Caused flakiness  https://crbug.com/871601 

Original change's description:
> Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service
> 
> The error event was not being sent when the client was reset.
> 
> Bug:  721414 
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I951422061022d50644d8453900af14be27bb9eaf
> Reviewed-on: https://chromium-review.googlesource.com/1150403
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580911}

TBR=jam@chromium.org,cduvall@chromium.org

Change-Id: If5d71d67ad54ed590408c7ef1af0c71431c788d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  721414 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1164822
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581156}
[modify] https://crrev.com/036e4e016357920de5af49fc8e7528d6d0257ed9/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
[modify] https://crrev.com/036e4e016357920de5af49fc8e7528d6d0257ed9/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
[modify] https://crrev.com/036e4e016357920de5af49fc8e7528d6d0257ed9/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b13d4396f5ad625ee44cd0d459857e2f9e97b83

commit 0b13d4396f5ad625ee44cd0d459857e2f9e97b83
Author: Clark DuVall <cduvall@chromium.org>
Date: Tue Aug 07 19:10:58 2018

Reland "Reland "Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service""

This is a reland of 41b81861d982406ad5fdc69315d40e6b13d59d52

The original change was reverted for an old build that didn't have the fix in the reland.

Original change's description:
> Reland "Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service"
>
> This is a reland of c9cbab072a2c44b00d21f6b2a19b2699f60f8e71
>
> request_completed_ was being set unnecessarily after RemoveRequest was called.
>
> Original change's description:
> > Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service
> >
> > The error event was not being sent when the client was reset.
> >
> > Bug:  721414 
> > Cq-Include-Trybots: luci.chromium.try:linux_mojo
> > Change-Id: I951422061022d50644d8453900af14be27bb9eaf
> > Reviewed-on: https://chromium-review.googlesource.com/1150403
> > Commit-Queue: Clark DuVall <cduvall@chromium.org>
> > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580911}
>
> TBR=jam@chromium.org
>
> Bug:  721414 
> Change-Id: I48769a4b86d2a18acbe5fbcedb9de3ed478e4c54
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Reviewed-on: https://chromium-review.googlesource.com/1164209
> Reviewed-by: Clark DuVall <cduvall@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581058}

TBR=jam@chromium.org

Bug:  721414 ,  871601 
Change-Id: Ia42b661e48b61a6d1cffab453710160ac0f5b8d7
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1165503
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581299}
[modify] https://crrev.com/0b13d4396f5ad625ee44cd0d459857e2f9e97b83/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
[modify] https://crrev.com/0b13d4396f5ad625ee44cd0d459857e2f9e97b83/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
[modify] https://crrev.com/0b13d4396f5ad625ee44cd0d459857e2f9e97b83/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter