New issue
Advanced search Search tips

Issue 721408 link

Starred by 5 users
Status: Fixed
Owner:
caseq@chromium.org
Closed: May 2018
Cc:
caseq@chromium.org
pfeldman@chromium.org
dgozman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-Servicification

Blocked on:
issue 757648
Blocking:
issue 598073



Sign in to add a comment

Add DevTools support when using the network service

Project Member Reported by jam@chromium.org, May 11 2017 
When the network service is in use (--enable-network-service, see also parent bug), devtools should continue to work.

I don't know all the details, but afaik devtools hooks a bunch of network code paths to allow inspection/timing etc? We have to figure out how this will work with a network service. Our goal so far has been to move as much of the functionality out of networking and towards consumers, to leave the network service with a minimal API.

This might be a lot of work, so it would be great to start sketching some designs and planning to invest time in this soon.

Thanks

Comment 1 by dgozman@chromium.org, May 12 2017

Components: -Platform>Apps>DevTools Platform>DevTools

Comment 2 by l...@chromium.org, May 15 2017

Cc: allada@chromium.org

Comment 3 by l...@chromium.org, May 23 2017

Cc: -allada@chromium.org
Owner: allada@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by yzshen@chromium.org, May 24 2017

Components: Internals>Network>Service

Comment 5 by allada@chromium.org, Jul 20 2017

Owner: caseq@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed

commit 83a6eeeb90b4acba86bc53d6dfcde7959cb890ed
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Mon Aug 14 19:20:04 2017

Add support for getting actual request headers to net::URLRequest

This introduces URLRequest::SetRequestHeadersCallback() that installs
a callback that receives actual headers sent to the remote party if
request involves an HTTP transaction. We previously got this via
NetLogObserver that we would like to remove.

Bug:  721408 
Change-Id: I1c9625730a227e6ae33cae4b16478f441f249ecd
Reviewed-on: https://chromium-review.googlesource.com/611089
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494127}
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/chrome/browser/devtools/devtools_network_transaction.cc
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/chrome/browser/devtools/devtools_network_transaction.h
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/BUILD.gn
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/http/failing_http_transaction_factory.cc
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/http/http_basic_stream.cc
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/http/http_basic_stream.h
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/http/http_cache_transaction.cc
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/http/http_cache_transaction.h
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/http/http_network_transaction.cc
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/http/http_network_transaction.h
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/http/http_network_transaction_unittest.cc
[add] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/http/http_raw_request_headers.cc
[add] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/http/http_raw_request_headers.h
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/http/http_response_body_drainer_unittest.cc
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/http/http_stream.h
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/http/http_transaction.h
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/http/http_transaction_test_util.h
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/http/proxy_connect_redirect_http_stream.h
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/quic/chromium/quic_http_stream.cc
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/spdy/chromium/multiplexed_http_stream.cc
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/spdy/chromium/multiplexed_http_stream.h
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/spdy/chromium/spdy_http_stream.cc
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/spdy/chromium/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/url_request/url_request.cc
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/url_request/url_request.h
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/url_request/url_request_http_job.cc
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/url_request/url_request_http_job.h
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/url_request/url_request_job.cc
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/url_request/url_request_job.h
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/url_request/url_request_quic_unittest.cc
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/83a6eeeb90b4acba86bc53d6dfcde7959cb890ed/net/websockets/websocket_handshake_stream_base.h
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e263d6749e71887741c2414c2c922d1c9cc4829

commit 5e263d6749e71887741c2414c2c922d1c9cc4829
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Wed Aug 16 18:10:17 2017

Remove NetLogObserver, use request headers callback instead

This switches raw headers retrieval in DevTools to use explicit URLRequest
API (SetRequestHeadersCallbac) instead of NetLogObserver.

See also: https://chromium-review.googlesource.com/c/611089

Bug:  721408 
Change-Id: Ied74bbd131847d669403cda4141a92b6d45a7274
Reviewed-on: https://chromium-review.googlesource.com/611181
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494861}
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/content/browser/BUILD.gn
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/content/browser/devtools/devtools_agent_host_impl.cc
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/content/browser/devtools/devtools_agent_host_impl.h
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/content/browser/devtools/devtools_manager.cc
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/content/browser/loader/async_resource_handler.cc
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/content/browser/loader/navigation_resource_handler.cc
[delete] https://crrev.com/64851d6549e974416f48bf85a95621076393ae16/content/browser/loader/netlog_observer.cc
[delete] https://crrev.com/64851d6549e974416f48bf85a95621076393ae16/content/browser/loader/netlog_observer.h
[delete] https://crrev.com/64851d6549e974416f48bf85a95621076393ae16/content/browser/loader/netlog_observer_unittest.cc
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/content/browser/loader/resource_loader.h
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/content/browser/loader/sync_resource_handler.cc
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/content/test/BUILD.gn
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/net/http/http_request_headers.cc
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/net/http/http_request_headers.h
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/net/http/http_request_headers_unittest.cc
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/net/http/http_response_headers.cc
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/net/http/http_response_headers.h
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/net/http/http_response_headers_unittest.cc
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/net/spdy/core/spdy_header_block.cc
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/net/spdy/core/spdy_header_block.h
[modify] https://crrev.com/5e263d6749e71887741c2414c2c922d1c9cc4829/net/spdy/core/spdy_header_block_test.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a924c8b70c3db35a9d623cd04e500da5d10f7a81

commit a924c8b70c3db35a9d623cd04e500da5d10f7a81
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Fri Aug 18 17:37:23 2017

Network Service: do not shallow-copy ResourceResponseHead

ResourceResponseHead has a bunch of non-threadsafe scoped_refptrs that,
if copied while passed between threads, trigger a DCHECK(). Having a
deep copy allows us to pass an object that has a refcount of 1, which
is ok to move between threads.

Bug: 416050,  721408 
Change-Id: I90259292aed86b449f38be819b0e72dd35c4d326
Reviewed-on: https://chromium-review.googlesource.com/619868
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495602}
[modify] https://crrev.com/a924c8b70c3db35a9d623cd04e500da5d10f7a81/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/a924c8b70c3db35a9d623cd04e500da5d10f7a81/content/browser/loader/navigation_url_loader_network_service.h
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/031e9e388bfc3cddcdc12abbf2f4d44f34fc5f1b

commit 031e9e388bfc3cddcdc12abbf2f4d44f34fc5f1b
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Fri Aug 18 21:00:35 2017

Add chrome-devtools:// to the list of Web UI URL schemes

This fixes loading of DevTools front-end when using
network service. Note that debug_devtools mode is still not
supported.

Bug:  721408 
Change-Id: I4523ea687fbe3e33a67cba63070df2b27adb7f46
Reviewed-on: https://chromium-review.googlesource.com/617598
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495679}
[modify] https://crrev.com/031e9e388bfc3cddcdc12abbf2f4d44f34fc5f1b/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/031e9e388bfc3cddcdc12abbf2f4d44f34fc5f1b/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/031e9e388bfc3cddcdc12abbf2f4d44f34fc5f1b/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/031e9e388bfc3cddcdc12abbf2f4d44f34fc5f1b/content/browser/browser_url_handler_impl.cc
[modify] https://crrev.com/031e9e388bfc3cddcdc12abbf2f4d44f34fc5f1b/content/browser/storage_partition_impl_map.cc
[modify] https://crrev.com/031e9e388bfc3cddcdc12abbf2f4d44f34fc5f1b/content/browser/webui/url_data_manager_backend.cc
[modify] https://crrev.com/031e9e388bfc3cddcdc12abbf2f4d44f34fc5f1b/content/browser/webui/url_data_manager_backend.h
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf692eb2a26d9f664fe1e7a15be29a6b799664cb

commit bf692eb2a26d9f664fe1e7a15be29a6b799664cb
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Mon Aug 21 22:36:17 2017

Revert "Revert "Fix DevTools raw headers reporting from network service""

This re-lands "Fix DevTools raw headers reporting from network service" after the main reason for test failure was fixed, while suppressing remaining test failures.

Original change's description:
> Revert "Fix DevTools raw headers reporting from network service"
>
> This reverts commit 5d03b51f59466695c6304a8990eaefd0481fd8e1.
>
> Reason for revert: per jam's comment, this caused massive layout tests failure.
>
> Change-Id: I5eaade602b667b26d57bc498448ef0b05cad9584
> Reviewed-on: https://chromium-review.googlesource.com/619706
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#495375}

TBR=jam@chromium.org,caseq@chromium.org,mmenke@chromium.org

Change-Id: I60e783041aaa4f7d2619c8b61fe28b675ee62d64
Bug:  721408 
Reviewed-on: https://chromium-review.googlesource.com/622208
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496091}
[modify] https://crrev.com/bf692eb2a26d9f664fe1e7a15be29a6b799664cb/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/bf692eb2a26d9f664fe1e7a15be29a6b799664cb/content/network/network_service_unittest.cc
[modify] https://crrev.com/bf692eb2a26d9f664fe1e7a15be29a6b799664cb/content/network/url_loader_impl.cc
[modify] https://crrev.com/bf692eb2a26d9f664fe1e7a15be29a6b799664cb/content/network/url_loader_impl.h
[modify] https://crrev.com/bf692eb2a26d9f664fe1e7a15be29a6b799664cb/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fa70190fce6b61ea4beb195a9d08c7a97c0cca2

commit 6fa70190fce6b61ea4beb195a9d08c7a97c0cca2
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Tue Aug 22 00:18:19 2017

Move BuildDevToolsInfo to loader_util so it can be reused

This is a follow-up to https://chromium-review.googlesource.com/c/617611
that removes code duplication of BuildDevToolsInfo() by moving it to a
place where it can be reused between network service and the browser
loader.

Bug:  721408 
Change-Id: I5c7446121bfc20a67e11a95d36c2fd0d3aec0649
Reviewed-on: https://chromium-review.googlesource.com/619686
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496137}
[modify] https://crrev.com/6fa70190fce6b61ea4beb195a9d08c7a97c0cca2/content/browser/loader/DEPS
[modify] https://crrev.com/6fa70190fce6b61ea4beb195a9d08c7a97c0cca2/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/6fa70190fce6b61ea4beb195a9d08c7a97c0cca2/content/common/loader_util.cc
[modify] https://crrev.com/6fa70190fce6b61ea4beb195a9d08c7a97c0cca2/content/common/loader_util.h
[modify] https://crrev.com/6fa70190fce6b61ea4beb195a9d08c7a97c0cca2/content/network/url_loader_impl.cc

Comment 13 by caseq@chromium.org, Aug 22 2017

Blockedon: 757648
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/864c0cdc8ba5a2239ec1fc4ee92fede872d3aebe

commit 864c0cdc8ba5a2239ec1fc4ee92fede872d3aebe
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Fri Aug 25 07:57:10 2017

Add a devtools test that fails with NetworkService to the filter

http/tests/devtools/console/console-uncaught-promise.html
This was renamed from http/tests/inspector/console in r497249,
but doesn't pass with NetworkService. (Will look a little further
but disabling for now)

TBR=jam@chromium.org
NOTRY=true

Bug:  721408 ,  729849 
Change-Id: I53d6474af5764844281a6eb4209884ba1b4ec776
Reviewed-on: https://chromium-review.googlesource.com/634964
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497351}
[modify] https://crrev.com/864c0cdc8ba5a2239ec1fc4ee92fede872d3aebe/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4ed0c7a4403696812e8051efe19c4c58069e166

commit d4ed0c7a4403696812e8051efe19c4c58069e166
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Wed Aug 30 21:39:14 2017

DevTools: use chrome-devtools:// instead of https:// for remote modules

This switches DevTools front-end to use chrome-devtools://devtools/remote
to access remote modules instead of fethcing them directly via https.
The fetch will thus be performed by the proxy within DevToolsDataSource.
We need this since WebUI processes can't directly fetch http(s?):// URLs
as they only get WebUI loader factories.

Bug:  721408 
Change-Id: I6ef7ae8c87063db5df9f1464694acabd2ea7a68a
Reviewed-on: https://chromium-review.googlesource.com/642457
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498620}
[modify] https://crrev.com/d4ed0c7a4403696812e8051efe19c4c58069e166/third_party/WebKit/Source/devtools/front_end/Runtime.js
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4

commit 2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Aug 31 17:00:52 2017

Get raw response headers using URLRequest::SetResponseHeadersCallback()

DevTools used to get actual response headers with NetLogObserver. Once we
removed NetLogObserver, we started using URLRequest::response_headers().
However, it returns the original cached headers in case of revalidation
requests, which is not what DevTools expect.
This adds SetResponseHeadersCallback() similar to SetRequestHeadersCallback()
to resolve the issue.

Bug:  758090 ,  721408 
Change-Id: I8d8a7a757601fe282a82b8a092148726cdab85e2
Reviewed-on: https://chromium-review.googlesource.com/631119
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498894}
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/chrome/browser/devtools/devtools_network_transaction.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/chrome/browser/devtools/devtools_network_transaction.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/content/browser/loader/resource_loader.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/content/common/loader_util.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/content/common/loader_util.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/content/network/url_loader_impl.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/content/network/url_loader_impl.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/http/failing_http_transaction_factory.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/http/http_cache_transaction.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/http/http_cache_transaction.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/http/http_network_transaction.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/http/http_network_transaction.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/http/http_response_headers.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/http/http_transaction.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/http/http_transaction_test_util.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/url_request/url_request.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/url_request/url_request.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/url_request/url_request_http_job.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/url_request/url_request_http_job.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/url_request/url_request_job.cc
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/url_request/url_request_job.h
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/net/url_request/url_request_unittest.cc
[add] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/raw-response-headers-expected.txt
[add] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/raw-response-headers.js
[modify] https://crrev.com/2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4/third_party/WebKit/Source/devtools/front_end/Tests.js
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2df69cc63747fd6d7efb3225172fa860cb0ed84

commit d2df69cc63747fd6d7efb3225172fa860cb0ed84
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Tue Sep 05 20:23:07 2017

Check child process permission for raw headers in Network Service

This introduces NetworkService::SetRawHeadersAccess(pid, bool)
and uses it in RenderFrameDevToolsAgentHost to grant this permission
to inspected renderers similarly to how we do it for the case of
browser-based resource dispatcher.

Bug:  721408 
Change-Id: Ibfdb6b09570750ab85051ed9413ec0ff23ce831a
Reviewed-on: https://chromium-review.googlesource.com/648217
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499729}
[modify] https://crrev.com/d2df69cc63747fd6d7efb3225172fa860cb0ed84/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/d2df69cc63747fd6d7efb3225172fa860cb0ed84/content/network/network_context.h
[modify] https://crrev.com/d2df69cc63747fd6d7efb3225172fa860cb0ed84/content/network/network_service_impl.cc
[modify] https://crrev.com/d2df69cc63747fd6d7efb3225172fa860cb0ed84/content/network/network_service_impl.h
[modify] https://crrev.com/d2df69cc63747fd6d7efb3225172fa860cb0ed84/content/network/network_service_unittest.cc
[modify] https://crrev.com/d2df69cc63747fd6d7efb3225172fa860cb0ed84/content/network/network_service_url_loader_factory_impl.cc
[modify] https://crrev.com/d2df69cc63747fd6d7efb3225172fa860cb0ed84/content/network/url_loader_impl.cc
[modify] https://crrev.com/d2df69cc63747fd6d7efb3225172fa860cb0ed84/content/network/url_loader_impl.h
[modify] https://crrev.com/d2df69cc63747fd6d7efb3225172fa860cb0ed84/content/network/url_loader_unittest.cc
[modify] https://crrev.com/d2df69cc63747fd6d7efb3225172fa860cb0ed84/content/public/common/network_service.mojom
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24f33167852983f3cee26b69639baa36db7b4358

commit 24f33167852983f3cee26b69639baa36db7b4358
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Sep 14 22:41:40 2017

Move DevTools network throttling to content layer

This moves the implementation of DevTools' network throttling to content.
Core of the implementation is now under content/common, so it can be reused
in the network service.
Needed drive-by changes include making DevToolsNetworkController a
singleton, which also allowed to nuke DevToolsNetworkControllerHandle and
some other simplifications.

Bug:  721408 , 752322
Change-Id: I71b84aa62f7ffad8f8df5fba7fe36dc2ba4b27e6
Reviewed-on: https://chromium-review.googlesource.com/664356
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502052}
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/android/devtools_manager_delegate_android.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/android/devtools_manager_delegate_android.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/devtools/BUILD.gn
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/devtools/chrome_devtools_manager_delegate.h
[delete] https://crrev.com/9ce9badd0fe1091096eee012b2583a755e3b85b5/chrome/browser/devtools/devtools_network_conditions.cc
[delete] https://crrev.com/9ce9badd0fe1091096eee012b2583a755e3b85b5/chrome/browser/devtools/devtools_network_controller.cc
[delete] https://crrev.com/9ce9badd0fe1091096eee012b2583a755e3b85b5/chrome/browser/devtools/devtools_network_controller.h
[delete] https://crrev.com/9ce9badd0fe1091096eee012b2583a755e3b85b5/chrome/browser/devtools/devtools_network_controller_handle.cc
[delete] https://crrev.com/9ce9badd0fe1091096eee012b2583a755e3b85b5/chrome/browser/devtools/devtools_network_controller_handle.h
[delete] https://crrev.com/9ce9badd0fe1091096eee012b2583a755e3b85b5/chrome/browser/devtools/devtools_network_protocol_handler.cc
[delete] https://crrev.com/9ce9badd0fe1091096eee012b2583a755e3b85b5/chrome/browser/devtools/devtools_network_protocol_handler.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/off_the_record_profile_impl.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/off_the_record_profile_impl.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/off_the_record_profile_io_data.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/profile.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/profile_impl.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/ui/app_list/test/fake_profile.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/browser/ui/app_list/test/fake_profile.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/test/BUILD.gn
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/chrome/test/base/testing_profile.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/browser/BUILD.gn
[add] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/browser/devtools/devtools_network_transaction_factory.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/browser/devtools/worker_devtools_agent_host.cc
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/BUILD.gn
[add] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_conditions.cc
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_conditions.h
[add] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_controller.cc
[add] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_controller.h
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_controller_unittest.cc
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_interceptor.cc
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_interceptor.h
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_transaction.cc
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_transaction.h
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_transaction_factory.cc
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_transaction_factory.h
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_upload_data_stream.cc
[rename] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/common/devtools/devtools_network_upload_data_stream.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/public/browser/BUILD.gn
[add] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/public/browser/devtools_network_transaction_factory.h
[modify] https://crrev.com/24f33167852983f3cee26b69639baa36db7b4358/content/test/BUILD.gn
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71db1a4f45ec56120650bf1025643e8f7da8f888

commit 71db1a4f45ec56120650bf1025643e8f7da8f888
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Oct 10 14:23:28 2017

Gardening: A new DevTools request interception test fails on NetworkService

request-interception-resource-types.js was recently added and is failing,
same with the other existing request-interception* tests.

Bug:  721408 
Change-Id: I4ea4219abb9c593dd7904742c9f8924d9feb72ee
TBR: kinuko
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/708456
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507661}
[modify] https://crrev.com/71db1a4f45ec56120650bf1025643e8f7da8f888/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a

commit a1d473a7968d2dbeb0895e2f6d64c6baed68b43a
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Oct 12 01:41:26 2017

DevTools: pass RenderProcessHost of target to protocol handlers

Bug:  721408 
Change-Id: Ieb3efcb08dbb3446bc18fdf60e95a63e11d78f78
Reviewed-on: https://chromium-review.googlesource.com/707680
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508211}
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/devtools_session.cc
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/devtools_session.h
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/devtools_domain_handler.cc
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/devtools_domain_handler.h
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/dom_handler.cc
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/dom_handler.h
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/emulation_handler.cc
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/emulation_handler.h
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/input_handler.cc
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/input_handler.h
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/inspector_handler.cc
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/inspector_handler.h
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/io_handler.cc
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/io_handler.h
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/security_handler.cc
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/security_handler.h
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/service_worker_handler.cc
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/service_worker_handler.h
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/storage_handler.cc
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/storage_handler.h
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/target_handler.cc
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/protocol/target_handler.h
[modify] https://crrev.com/a1d473a7968d2dbeb0895e2f6d64c6baed68b43a/content/browser/devtools/worker_devtools_agent_host.cc
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36733cc507393f96a13dc02b01e7f49d6c5040d1

commit 36733cc507393f96a13dc02b01e7f49d6c5040d1
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Mon Oct 16 19:14:50 2017

Enable throttling with network service

Bug:  721408 
Change-Id: Idae0723cefcdbd90ebcfb68b15f86690df97fbe7
Reviewed-on: https://chromium-review.googlesource.com/696713
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509133}
[modify] https://crrev.com/36733cc507393f96a13dc02b01e7f49d6c5040d1/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/36733cc507393f96a13dc02b01e7f49d6c5040d1/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/36733cc507393f96a13dc02b01e7f49d6c5040d1/content/network/DEPS
[modify] https://crrev.com/36733cc507393f96a13dc02b01e7f49d6c5040d1/content/network/network_context.cc
[modify] https://crrev.com/36733cc507393f96a13dc02b01e7f49d6c5040d1/content/network/network_context.h
[modify] https://crrev.com/36733cc507393f96a13dc02b01e7f49d6c5040d1/content/network/network_service_unittest.cc
[modify] https://crrev.com/36733cc507393f96a13dc02b01e7f49d6c5040d1/content/public/common/network_service.mojom
Project Member

Comment 22 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f7a4b73e9404f9d8e951f489045f149be62a0ec

commit 4f7a4b73e9404f9d8e951f489045f149be62a0ec
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Tue Oct 17 02:36:38 2017

Move throttling to network service

This moves the contents of content/common/devtools to content/network/throttling,
removing DevTools from the class names.

Bug:  721408 
Change-Id: I0dc5b70eceb9976af623662a21d730260e6bbba8
Reviewed-on: https://chromium-review.googlesource.com/703674
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509231}
[modify] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/browser/devtools/devtools_network_transaction_factory.cc
[modify] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/common/BUILD.gn
[delete] https://crrev.com/593ce8039382341522c0e6634c96f0c641d800da/content/common/devtools/devtools_network_conditions.cc
[delete] https://crrev.com/593ce8039382341522c0e6634c96f0c641d800da/content/common/devtools/devtools_network_conditions.h
[delete] https://crrev.com/593ce8039382341522c0e6634c96f0c641d800da/content/common/devtools/devtools_network_controller.cc
[delete] https://crrev.com/593ce8039382341522c0e6634c96f0c641d800da/content/common/devtools/devtools_network_controller.h
[delete] https://crrev.com/593ce8039382341522c0e6634c96f0c641d800da/content/common/devtools/devtools_network_transaction_factory.cc
[delete] https://crrev.com/593ce8039382341522c0e6634c96f0c641d800da/content/common/devtools/devtools_network_upload_data_stream.h
[modify] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/network/BUILD.gn
[modify] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/network/DEPS
[modify] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/network/network_context.cc
[add] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/network/throttling/network_conditions.cc
[add] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/network/throttling/network_conditions.h
[add] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/network/throttling/throttling_controller.cc
[add] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/network/throttling/throttling_controller.h
[rename] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/network/throttling/throttling_controller_unittest.cc
[rename] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/network/throttling/throttling_network_interceptor.cc
[rename] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/network/throttling/throttling_network_interceptor.h
[rename] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/network/throttling/throttling_network_transaction.cc
[rename] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/network/throttling/throttling_network_transaction.h
[add] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/network/throttling/throttling_network_transaction_factory.cc
[rename] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/network/throttling/throttling_network_transaction_factory.h
[rename] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/network/throttling/throttling_upload_data_stream.cc
[add] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/network/throttling/throttling_upload_data_stream.h
[modify] https://crrev.com/4f7a4b73e9404f9d8e951f489045f149be62a0ec/content/test/BUILD.gn
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37d8de9afbfa5223fe504881ba15350adddec9d3

commit 37d8de9afbfa5223fe504881ba15350adddec9d3
Author: Reilly Grant <reillyg@chromium.org>
Date: Tue Oct 17 15:28:00 2017

Disable DevTools test failing with Network Service

http/tests/devtools/sdk/network-interception-wildcard-pattern-matching.js
fails when run with the Network Service enabled. Broken support for
DevTools is a known issue.

TBR=caseq@chromium.org

Bug:  721408 
Change-Id: Ibd78cf00220ad1a560a0ea34559dfe9e6a6b58a3
Reviewed-on: https://chromium-review.googlesource.com/721806
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509390}
[modify] https://crrev.com/37d8de9afbfa5223fe504881ba15350adddec9d3/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
Project Member

Comment 24 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8efc9dab96dae0426d8e42f343a2ca3c9ef42d6

commit c8efc9dab96dae0426d8e42f343a2ca3c9ef42d6
Author: Reilly Grant <reillyg@chromium.org>
Date: Wed Oct 18 23:44:39 2017

Enable a lot more LayoutTests with Network Service

These tests appear to be passing and should be enabled.

TBR=jam@chromium.org

Bug:  729849 , 721408 ,611935
Change-Id: I163023024f2f94c8b6031f7f2c3a4ec85f2f2ada
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/724282
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509932}
[modify] https://crrev.com/c8efc9dab96dae0426d8e42f343a2ca3c9ef42d6/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
Project Member

Comment 25 by bugdroid1@chromium.org, Oct 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5625b2a54a34749667cb2136e9f45a27bcdb1cd1

commit 5625b2a54a34749667cb2136e9f45a27bcdb1cd1
Author: Reilly Grant <reillyg@chromium.org>
Date: Fri Oct 20 18:02:35 2017

Disable new LayoutTests failing with Network Service

These tests are new and fail or timeout.

TBR=jam@chromium.org

Bug:  729849 , 721408 
Change-Id: Id40c1e246aedb8a68ebb1fac67573f6edc7529f0
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/731108
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510487}
[modify] https://crrev.com/5625b2a54a34749667cb2136e9f45a27bcdb1cd1/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Comment 26 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Project Member

Comment 27 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3957a76a18a98311477f0e0e051ab4b34585fdf

commit d3957a76a18a98311477f0e0e051ab4b34585fdf
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Wed Jan 24 07:17:45 2018

NetworkService sherriffing: update layout tests expectations

http/tests/inspector-protocol/network/request-interception-referer.js
failing since it's added in r530961

http/tests/devtools/network/oopif-content.js
failing since it's added in r530695
because (I think) the opener frame's RenderFrameImpl could be null in OOPIF
in GetSubresourceLoaderFactories

TBR=jam@chromium.org

Bug:  721408 ,  805310 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ide50836831c7abc94d0f4f9ee98d5be6a73d9a3f
Reviewed-on: https://chromium-review.googlesource.com/882704
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531469}
[modify] https://crrev.com/d3957a76a18a98311477f0e0e051ab4b34585fdf/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Comment 28 by falken@chromium.org, Feb 22 2018

Cc: caseq@chromium.org
 Issue 814579  has been merged into this issue.
Project Member

Comment 29 by bugdroid1@chromium.org, Feb 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3d8bf0ba294a19dcd3d4ab714d7e5f40d54e565

commit c3d8bf0ba294a19dcd3d4ab714d7e5f40d54e565
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Feb 22 01:26:40 2018

Gardening: NetworkService: http/tests/inspector-protocol/network/request-interception-raw-headers.js fails

This is a new test added in r537971 that's failing, which looks expected
since DevTools support for NetworkService is still in-progress.

TBR=caseq, mmenke

Bug:  721408 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib6b05a8da77efa91056ae8d05152b7f0b604d13c
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/930341
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538298}
[modify] https://crrev.com/c3d8bf0ba294a19dcd3d4ab714d7e5f40d54e565/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
Project Member

Comment 30 by bugdroid1@chromium.org, Mar 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d49c5062f69ab4a3c1fd2391c147555fcbde62e

commit 8d49c5062f69ab4a3c1fd2391c147555fcbde62e
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Mar 15 19:50:49 2018

DevTools: implement a URLLoader-based request interception proxy

BUG= 812464 , 721408 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I39b237ba370dc65febbb52e8d31b1d01d4c35d10
Reviewed-on: https://chromium-review.googlesource.com/956685
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543475}
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/content/browser/BUILD.gn
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/content/browser/devtools/devtools_network_interceptor.cc
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/content/browser/devtools/devtools_network_interceptor.h
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/content/browser/devtools/devtools_url_interceptor_request_job.cc
[add] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/content/browser/devtools/devtools_url_loader_interceptor.cc
[add] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/content/browser/devtools/devtools_url_loader_interceptor.h
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/content/browser/devtools/devtools_url_request_interceptor.cc
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/third_party/WebKit/LayoutTests/http/tests/devtools/network/resources/resource.php
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/redirect-interception-mocked-expected.txt
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-cancel-xhr-while-responding-error-expected.txt
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-cancel-xhr-while-responding-error.js
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-with-data-url-expected.txt
[modify] https://crrev.com/8d49c5062f69ab4a3c1fd2391c147555fcbde62e/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-with-data-url.js
Project Member

Comment 31 by bugdroid1@chromium.org, Mar 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/add8371da1a41468c226f119e6a9b223931becba

commit add8371da1a41468c226f119e6a9b223931becba
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Mon Mar 19 22:09:41 2018

DevTools: add support for auth info to URLLoader-based interceptor

 - expose request id in NetworkServiceClient methods;
 - plumb host process id to DevToolsURLLoaderInterception;
 - maintain a static map from (process id, routing id, request id)
    to InterceptionJob*;
 - wire auth request callbacks from NetworkServiceClient to
    InterceptionJob.

BUG= 812464 , 721408 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I9eee7b2e9bc436376c741fcca7e2f67a2f04a32d
Reviewed-on: https://chromium-review.googlesource.com/967092
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544182}
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/content/browser/devtools/devtools_url_loader_interceptor.cc
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/content/browser/devtools/devtools_url_loader_interceptor.h
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/content/browser/network_service_client.cc
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/content/browser/network_service_client.h
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/services/network/public/mojom/url_loader_factory.mojom
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/services/network/url_loader.cc
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/services/network/url_loader.h
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/services/network/url_loader_factory.cc
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/services/network/url_loader_unittest.cc
[modify] https://crrev.com/add8371da1a41468c226f119e6a9b223931becba/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
Project Member

Comment 32 by bugdroid1@chromium.org, Mar 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c897eb808ca8cba689bcc9ca2245ecf8cd44c7c

commit 2c897eb808ca8cba689bcc9ca2245ecf8cd44c7c
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Mon Mar 19 23:54:48 2018

Remove expectation entries for devtools tests passing with --enable-features=NetworkService

TBR=jam@chromium.org, pfeldman@chromium.org

Bug:  721408 , 805310 , 778542 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Icdb98586e6e2ae53802c1e4d2f2fa3b66a6247fa
Reviewed-on: https://chromium-review.googlesource.com/969329
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544214}
[modify] https://crrev.com/2c897eb808ca8cba689bcc9ca2245ecf8cd44c7c/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
Project Member

Comment 33 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/942286d41ad2e1c5b463e302fec45cbcb92c4e32

commit 942286d41ad2e1c5b463e302fec45cbcb92c4e32
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Mar 22 02:12:38 2018

Switch DevToolsUIBindings::LoadNetworkResource to using SimpleURLLoader

... and do the same in ShellDevtoolsBindings (sigh).
Also, add a browser test to cover the implementation in DevToolsUIBindings.

Bug:  721408 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I83bd0c8160feb6a0de764bb4f6615ef421516f4b
Reviewed-on: https://chromium-review.googlesource.com/973811
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544948}
[modify] https://crrev.com/942286d41ad2e1c5b463e302fec45cbcb92c4e32/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/942286d41ad2e1c5b463e302fec45cbcb92c4e32/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/942286d41ad2e1c5b463e302fec45cbcb92c4e32/chrome/browser/devtools/devtools_ui_bindings.h
[modify] https://crrev.com/942286d41ad2e1c5b463e302fec45cbcb92c4e32/content/shell/browser/shell_devtools_bindings.cc
[modify] https://crrev.com/942286d41ad2e1c5b463e302fec45cbcb92c4e32/content/shell/browser/shell_devtools_bindings.h
[modify] https://crrev.com/942286d41ad2e1c5b463e302fec45cbcb92c4e32/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
[modify] https://crrev.com/942286d41ad2e1c5b463e302fec45cbcb92c4e32/third_party/WebKit/Source/devtools/front_end/Tests.js
Project Member

Comment 34 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2735885c65f03b9e224958576c16dd89e001d21

commit f2735885c65f03b9e224958576c16dd89e001d21
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Mar 22 16:39:08 2018

Network Service: report encoded bytes to URLLoaderClient

This fixes http/tests/inspector-protocol/network-data-length.js

Bug:  721408 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I77cda55f1e129f13f162910340f2853f3fb66d07
Reviewed-on: https://chromium-review.googlesource.com/974464
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545109}
[modify] https://crrev.com/f2735885c65f03b9e224958576c16dd89e001d21/services/network/url_loader.cc
[modify] https://crrev.com/f2735885c65f03b9e224958576c16dd89e001d21/services/network/url_loader.h
[modify] https://crrev.com/f2735885c65f03b9e224958576c16dd89e001d21/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
Project Member

Comment 35 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/019c4cf7dd223328d6884d8cea1c514c05ddb120

commit 019c4cf7dd223328d6884d8cea1c514c05ddb120
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Tue Mar 27 16:43:33 2018

Pass SSLInfo in ResourceResponseInfo instead of assorted fields

Bug:  721408 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I037a0c3e5f91b284700cddfd5c5253f01aa7fde2
Reviewed-on: https://chromium-review.googlesource.com/978623
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546134}
[modify] https://crrev.com/019c4cf7dd223328d6884d8cea1c514c05ddb120/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/019c4cf7dd223328d6884d8cea1c514c05ddb120/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/019c4cf7dd223328d6884d8cea1c514c05ddb120/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/019c4cf7dd223328d6884d8cea1c514c05ddb120/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/019c4cf7dd223328d6884d8cea1c514c05ddb120/services/network/public/cpp/network_param_ipc_traits.h
[modify] https://crrev.com/019c4cf7dd223328d6884d8cea1c514c05ddb120/services/network/public/cpp/resource_response.cc
[modify] https://crrev.com/019c4cf7dd223328d6884d8cea1c514c05ddb120/services/network/public/cpp/resource_response_info.cc
[modify] https://crrev.com/019c4cf7dd223328d6884d8cea1c514c05ddb120/services/network/public/cpp/resource_response_info.h
Project Member

Comment 36 by bugdroid1@chromium.org, Mar 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53cdcfb554fec081faaa53bce95c2a1cbfd52cf8

commit 53cdcfb554fec081faaa53bce95c2a1cbfd52cf8
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Mar 29 03:16:40 2018

DevTools: support cookies protocol methods with network service

Also added a test to detect the case when cookie CRUD protocol methods
operate on different cookie storage with regards to the network layer.

Bug:  721408 
Change-Id: If81d4b2c1e13d69289e6dc006aabf9879fa80b11
Reviewed-on: https://chromium-review.googlesource.com/985246
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546721}
[modify] https://crrev.com/53cdcfb554fec081faaa53bce95c2a1cbfd52cf8/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/53cdcfb554fec081faaa53bce95c2a1cbfd52cf8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/cookies-protocol-test-expected.txt
[modify] https://crrev.com/53cdcfb554fec081faaa53bce95c2a1cbfd52cf8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/cookies-protocol-test.js
Project Member

Comment 37 by bugdroid1@chromium.org, Apr 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d64a4bcd56d33f0d465a193176ccd762e56c9bf

commit 0d64a4bcd56d33f0d465a193176ccd762e56c9bf
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Wed Apr 04 04:01:55 2018

DevTools: fix TestRawHeadersWithRedirectAndHSTS with network service enabled

Bug:  721408 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I2470b02838678052524ab146fe3438a885e7799e
Reviewed-on: https://chromium-review.googlesource.com/994540
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547973}
[modify] https://crrev.com/0d64a4bcd56d33f0d465a193176ccd762e56c9bf/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/0d64a4bcd56d33f0d465a193176ccd762e56c9bf/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 38 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f517c0cabf110982768e47c30af2a22d11e3ad9

commit 6f517c0cabf110982768e47c30af2a22d11e3ad9
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Apr 05 17:53:57 2018

Remove 2 passing DevTools tests from mojo.fyi.network_browser_tests.filter

TBR: jam@chromium.org

Bug:  721408 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib1999e8752b1d76248eaa17aea1d12dc018d1662
Reviewed-on: https://chromium-review.googlesource.com/997020
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548479}
[modify] https://crrev.com/6f517c0cabf110982768e47c30af2a22d11e3ad9/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 40 by bugdroid1@chromium.org, Apr 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc9987c830da0701aea0311e56fadb5b104a277a

commit dc9987c830da0701aea0311e56fadb5b104a277a
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Fri Apr 13 19:09:02 2018

Revert "DevTools: fix interception for <a download='...'> downloads with network service"

This reverts commit 031b31c46bdd9be3a5b472ced41316f142370aa5.

Reason for revert: triggers an assert on in devtools download interception tests with network service.

Original change's description:
> DevTools: fix interception for <a download='...'> downloads with network service
> 
> Bug:  721408 
> 
> Change-Id: I60f0cf81a69d7826d2043aa8222d2e69ff9e406a
> Reviewed-on: https://chromium-review.googlesource.com/1006231
> Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550690}

TBR=dgozman@chromium.org,caseq@chromium.org,qinmin@chromium.org

Change-Id: I51f1a7145faa59103ff06b537380745913af2cf2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  721408 
Reviewed-on: https://chromium-review.googlesource.com/1012817
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550710}
[modify] https://crrev.com/dc9987c830da0701aea0311e56fadb5b104a277a/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/dc9987c830da0701aea0311e56fadb5b104a277a/content/browser/download/network_download_url_loader_factory_getter.cc
[modify] https://crrev.com/dc9987c830da0701aea0311e56fadb5b104a277a/content/browser/download/network_download_url_loader_factory_getter.h
[delete] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-anchor-download-expected.txt
[delete] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-anchor-download.js
Project Member

Comment 41 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/031b31c46bdd9be3a5b472ced41316f142370aa5

commit 031b31c46bdd9be3a5b472ced41316f142370aa5
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Fri Apr 13 18:30:59 2018

DevTools: fix interception for <a download='...'> downloads with network service

Bug:  721408 

Change-Id: I60f0cf81a69d7826d2043aa8222d2e69ff9e406a
Reviewed-on: https://chromium-review.googlesource.com/1006231
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550690}
[modify] https://crrev.com/031b31c46bdd9be3a5b472ced41316f142370aa5/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/031b31c46bdd9be3a5b472ced41316f142370aa5/content/browser/download/network_download_url_loader_factory_getter.cc
[modify] https://crrev.com/031b31c46bdd9be3a5b472ced41316f142370aa5/content/browser/download/network_download_url_loader_factory_getter.h
[add] https://crrev.com/031b31c46bdd9be3a5b472ced41316f142370aa5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-anchor-download-expected.txt
[add] https://crrev.com/031b31c46bdd9be3a5b472ced41316f142370aa5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-anchor-download.js
Project Member

Comment 42 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc9987c830da0701aea0311e56fadb5b104a277a

commit dc9987c830da0701aea0311e56fadb5b104a277a
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Fri Apr 13 19:09:02 2018

Revert "DevTools: fix interception for <a download='...'> downloads with network service"

This reverts commit 031b31c46bdd9be3a5b472ced41316f142370aa5.

Reason for revert: triggers an assert on in devtools download interception tests with network service.

Original change's description:
> DevTools: fix interception for <a download='...'> downloads with network service
> 
> Bug:  721408 
> 
> Change-Id: I60f0cf81a69d7826d2043aa8222d2e69ff9e406a
> Reviewed-on: https://chromium-review.googlesource.com/1006231
> Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550690}

TBR=dgozman@chromium.org,caseq@chromium.org,qinmin@chromium.org

Change-Id: I51f1a7145faa59103ff06b537380745913af2cf2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  721408 
Reviewed-on: https://chromium-review.googlesource.com/1012817
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550710}
[modify] https://crrev.com/dc9987c830da0701aea0311e56fadb5b104a277a/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/dc9987c830da0701aea0311e56fadb5b104a277a/content/browser/download/network_download_url_loader_factory_getter.cc
[modify] https://crrev.com/dc9987c830da0701aea0311e56fadb5b104a277a/content/browser/download/network_download_url_loader_factory_getter.h
[delete] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-anchor-download-expected.txt
[delete] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-anchor-download.js
Project Member

Comment 43 by bugdroid1@chromium.org, Apr 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41b2ff3a05c105a425ab09fa1d45850d6a60b4b6

commit 41b2ff3a05c105a425ab09fa1d45850d6a60b4b6
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Wed Apr 18 06:36:04 2018

Reland "DevTools: fix interception for <a download='...'> downloads with network service"

This is a reland of 031b31c46bdd9be3a5b472ced41316f142370aa5

Original change's description:
> DevTools: fix interception for <a download='...'> downloads with network service
> 
> Bug:  721408 
> 
> Change-Id: I60f0cf81a69d7826d2043aa8222d2e69ff9e406a
> Reviewed-on: https://chromium-review.googlesource.com/1006231
> Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550690}

Bug:  721408 
Change-Id: Ia02958bcecb911f288c30699e4b265574c8807e3
Reviewed-on: https://chromium-review.googlesource.com/1015852
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551597}
[modify] https://crrev.com/41b2ff3a05c105a425ab09fa1d45850d6a60b4b6/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/41b2ff3a05c105a425ab09fa1d45850d6a60b4b6/content/browser/download/network_download_url_loader_factory_getter.cc
[modify] https://crrev.com/41b2ff3a05c105a425ab09fa1d45850d6a60b4b6/content/browser/download/network_download_url_loader_factory_getter.h
[add] https://crrev.com/41b2ff3a05c105a425ab09fa1d45850d6a60b4b6/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-anchor-download-expected.txt
[add] https://crrev.com/41b2ff3a05c105a425ab09fa1d45850d6a60b4b6/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-anchor-download.js
Project Member

Comment 44 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1e370b95adc18f131fa07e2911ca88021e116a8

commit f1e370b95adc18f131fa07e2911ca88021e116a8
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Fri May 04 00:29:39 2018

Rewrite several devtools_protocol_browsertest tests as inspector-protocol layout tests

Bug:  721408 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ifd9be7ae953b43bdeca09ec7f2c8dfa51dcbe7d1
Reviewed-on: https://chromium-review.googlesource.com/1042857
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555924}
[modify] https://crrev.com/f1e370b95adc18f131fa07e2911ca88021e116a8/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[delete] https://crrev.com/c7fadd2120895397b68ae3f76dfe6661a93c694b/content/test/data/devtools/control_navigations/iframe_navigation.html
[delete] https://crrev.com/c7fadd2120895397b68ae3f76dfe6661a93c694b/content/test/data/devtools/control_navigations/meta_tag.html
[modify] https://crrev.com/f1e370b95adc18f131fa07e2911ca88021e116a8/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
[add] https://crrev.com/f1e370b95adc18f131fa07e2911ca88021e116a8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/navigation-blocking-expected.txt
[add] https://crrev.com/f1e370b95adc18f131fa07e2911ca88021e116a8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/navigation-blocking-xorigin-iframe-expected.txt
[add] https://crrev.com/f1e370b95adc18f131fa07e2911ca88021e116a8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/navigation-blocking-xorigin-iframe.js
[add] https://crrev.com/f1e370b95adc18f131fa07e2911ca88021e116a8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/navigation-blocking.js
[add] https://crrev.com/f1e370b95adc18f131fa07e2911ca88021e116a8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/page/page-stop-loading-expected.txt
[add] https://crrev.com/f1e370b95adc18f131fa07e2911ca88021e116a8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/page/page-stop-loading.js
[add] https://crrev.com/f1e370b95adc18f131fa07e2911ca88021e116a8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/iframe-navigation.html
[add] https://crrev.com/f1e370b95adc18f131fa07e2911ca88021e116a8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/meta-tag.html
Project Member

Comment 45 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72390a4295cd68d32796b9ae2e3dd44ffd71b1d2

commit 72390a4295cd68d32796b9ae2e3dd44ffd71b1d2
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Fri May 04 16:43:51 2018

DevTools: make DevToolsSanityTest.TestNetworkPushTime work with Network Service

Bug:  721408 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I22204e52a27a1431907d284fd32993d727b1435d
Reviewed-on: https://chromium-review.googlesource.com/1043528
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556088}
[modify] https://crrev.com/72390a4295cd68d32796b9ae2e3dd44ffd71b1d2/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/72390a4295cd68d32796b9ae2e3dd44ffd71b1d2/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 46 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b92b538e19106e1ad916e6f4939433001468be7

commit 6b92b538e19106e1ad916e6f4939433001468be7
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Fri May 04 23:54:13 2018

Network Service: Remove crash expectations for interception-file-url.js

Works for me now, I think the DCHECK it was hitting was removed as a
drive-by here:

https://chromium-review.googlesource.com/c/chromium/src/+/1008974/11/content/browser/devtools/devtools_url_loader_interceptor.cc#b478

TBR: dgozman@chromium.org, lushnikov@chromium.org
Bug:  721408 , 831887 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I886a1e302b94b5de685e4ef4442c10564df78539
Reviewed-on: https://chromium-review.googlesource.com/1044539
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556259}
[modify] https://crrev.com/6b92b538e19106e1ad916e6f4939433001468be7/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Comment 47 by jam@chromium.org, May 7 2018

Status: Fixed (was: Assigned)
Thanks a lot Andrey!

I believe this can now be marked fixed.

Comment 48 by caseq@chromium.org, May 7 2018 

Thanks, indeed! :-)
Project Member

Comment 49 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d

commit 1608dec4b25fae0d3ee57bfab004c3fe6140bd6d
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Fri Nov 30 17:39:00 2018

DevTools: do not expose raw headers for cross-origin requests

Same as https://chromium-review.googlesource.com/c/chromium/src/+/821410/,
but now for the network service.

Bug: 898306,  793692 ,  721408 
Change-Id: I96a2a25e66f4ff528d84baf03d600e4f1c89dd30
Reviewed-on: https://chromium-review.googlesource.com/c/1313739
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612685}
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/content/browser/loader/navigation_url_loader_impl_unittest.cc
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/content/browser/websockets/websocket_manager.cc
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/services/network/network_context.cc
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/services/network/network_service.cc
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/services/network/network_service.h
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/services/network/network_service_unittest.cc
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/services/network/public/mojom/websocket.mojom
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/services/network/url_loader.cc
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/services/network/url_loader.h
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/services/network/url_loader_factory.cc
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/services/network/url_loader_unittest.cc
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/services/network/websocket.cc
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/services/network/websocket.h
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/services/network/websocket_factory.cc
[modify] https://crrev.com/1608dec4b25fae0d3ee57bfab004c3fe6140bd6d/third_party/blink/web_tests/FlagExpectations/enable-features=NetworkService
Project Member

Comment 50 by bugdroid1@chromium.org, Dec 4

Labels: merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d6da28e05764b49866c2e5f53504e578b16d260

commit 3d6da28e05764b49866c2e5f53504e578b16d260
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Tue Dec 04 23:41:17 2018

DevTools: do not expose raw headers for cross-origin requests

Same as https://chromium-review.googlesource.com/c/chromium/src/+/821410/,
but now for the network service.

Bug: 898306,  793692 ,  721408 
Change-Id: I96a2a25e66f4ff528d84baf03d600e4f1c89dd30
Reviewed-on: https://chromium-review.googlesource.com/c/1313739
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612685}(cherry picked from commit 1608dec4b25fae0d3ee57bfab004c3fe6140bd6d)
Reviewed-on: https://chromium-review.googlesource.com/c/1361790
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#52}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/content/browser/loader/navigation_url_loader_impl_unittest.cc
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/content/browser/websockets/websocket_manager.cc
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/services/network/network_context.cc
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/services/network/network_service.cc
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/services/network/network_service.h
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/services/network/network_service_unittest.cc
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/services/network/public/mojom/websocket.mojom
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/services/network/url_loader.cc
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/services/network/url_loader.h
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/services/network/url_loader_factory.cc
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/services/network/url_loader_unittest.cc
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/services/network/websocket.cc
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/services/network/websocket.h
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/services/network/websocket_factory.cc
[modify] https://crrev.com/3d6da28e05764b49866c2e5f53504e578b16d260/third_party/blink/web_tests/FlagExpectations/enable-features=NetworkService
Project Member

Comment 51 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/3d6da28e05764b49866c2e5f53504e578b16d260

Commit: 3d6da28e05764b49866c2e5f53504e578b16d260
Author: caseq@chromium.org
Commiter: caseq@chromium.org
Date: 2018-12-04 23:41:17 +0000 UTC

DevTools: do not expose raw headers for cross-origin requests

Same as https://chromium-review.googlesource.com/c/chromium/src/+/821410/,
but now for the network service.

Bug: 898306,  793692 ,  721408 
Change-Id: I96a2a25e66f4ff528d84baf03d600e4f1c89dd30
Reviewed-on: https://chromium-review.googlesource.com/c/1313739
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612685}(cherry picked from commit 1608dec4b25fae0d3ee57bfab004c3fe6140bd6d)
Reviewed-on: https://chromium-review.googlesource.com/c/1361790
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#52}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
►

Sign in to add a comment