Empty state is confusing if Articles for You are disabled |
||||||||||
Issue descriptionSteps to reproduce: 1) Enable Chrome Home 2) Enable the suggestion settings in chrome://flags 3) Turn of content suggestions in settings Result: a) A sign-in promo claiming that signing in will show better suggestions b) When you do sign in, the "all dismissed" illustration appears, claiming that more articles will appear soon. c) Hitting the refresh button does nothing. We should probably just hide both the sign-in promo and the all-dismissed item.
,
Jun 29 2017
This isn't actually a duplicate of 707780. I agree that the right thing to do is to hide the sign in promo and the all dismissed state. There is one issue, which is that it may be hard for users to find the setting once they've turned it off. We may want to address that with new product requirements in the future. +nepper and mardini FYI
,
Jun 29 2017
,
Jul 6 2017
tschumann/bauerb: Should someone own this on the eng side ?
,
Jul 10 2017
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02481b2984dd77002228c0f1aecadb220d5143b9 commit 02481b2984dd77002228c0f1aecadb220d5143b9 Author: Nicolas Dossou-gbete <dgn@chromium.org> Date: Mon Jul 10 17:15:30 2017 [Suggestions] Surface correct AreRemoteSuggestionsEnabled value The repo contains a currently unused preferences screen for the suggestions, that is the only caller of the remote suggestion status methods. This CL marks them as appropriately unreached. The status of the remote suggestions will be used soon to update the UI state, so AreRemoteSuggestionsEnabled is updated in this patch to reflect the accurate status. Bug: 721407 , 740115 Change-Id: Ia92d85798f96064acc77c9366dafc3daee4ce025 Reviewed-on: https://chromium-review.googlesource.com/563617 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#485304} [modify] https://crrev.com/02481b2984dd77002228c0f1aecadb220d5143b9/components/ntp_snippets/content_suggestions_service.cc [modify] https://crrev.com/02481b2984dd77002228c0f1aecadb220d5143b9/components/ntp_snippets/remote/remote_suggestions_provider.h [modify] https://crrev.com/02481b2984dd77002228c0f1aecadb220d5143b9/components/ntp_snippets/remote/remote_suggestions_provider_impl.cc [modify] https://crrev.com/02481b2984dd77002228c0f1aecadb220d5143b9/components/ntp_snippets/remote/remote_suggestions_provider_impl.h [modify] https://crrev.com/02481b2984dd77002228c0f1aecadb220d5143b9/components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0dc3405be0681184ced6e44391dffbc3bd7ea89c commit 0dc3405be0681184ced6e44391dffbc3bd7ea89c Author: Nicolas Dossou-gbete <dgn@chromium.org> Date: Tue Jul 11 12:11:31 2017 [Suggestions] Use a callback for the FetchMore action Modified SuggestionsSection#fetchSuggestions to take a recieving callback as input rather than relying on notifying back the right observer for the result. This makes SuggestionsSection.Observer simpler, with only notification-style methods, opening the possibility to register multiple observers later. Bug: 721407 Change-Id: I0e735be3eaca7bdc428abd2d009d6bbfb230cbc5 Reviewed-on: https://chromium-review.googlesource.com/563410 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#485601} [modify] https://crrev.com/0dc3405be0681184ced6e44391dffbc3bd7ea89c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java [modify] https://crrev.com/0dc3405be0681184ced6e44391dffbc3bd7ea89c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java [modify] https://crrev.com/0dc3405be0681184ced6e44391dffbc3bd7ea89c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java [modify] https://crrev.com/0dc3405be0681184ced6e44391dffbc3bd7ea89c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [modify] https://crrev.com/0dc3405be0681184ced6e44391dffbc3bd7ea89c/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java [modify] https://crrev.com/0dc3405be0681184ced6e44391dffbc3bd7ea89c/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java [modify] https://crrev.com/0dc3405be0681184ced6e44391dffbc3bd7ea89c/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java [modify] https://crrev.com/0dc3405be0681184ced6e44391dffbc3bd7ea89c/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java [modify] https://crrev.com/0dc3405be0681184ced6e44391dffbc3bd7ea89c/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/0dc3405be0681184ced6e44391dffbc3bd7ea89c/chrome/browser/android/ntp/ntp_snippets_bridge.h [modify] https://crrev.com/0dc3405be0681184ced6e44391dffbc3bd7ea89c/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/FakeSuggestionsSource.java
,
Jul 12 2017
,
Jul 12 2017
As of https://crbug.com/738872#c8 we now hide the signin promo and the all dismissed item when remote suggestions are disabled. Waiting for rachelis@'s approval of the solution to close. Preview video attached.
,
Jul 13 2017
Thanks, dgn@. This LGTM but let's wait for Rachel to validate.
,
Jul 13 2017
Thanks guys! Can you bring this to the UX weekly for a review? +Finkm for scheduling
,
Jul 13 2017
Decision made in the UX sync: We remove the learn more link in case suggestions were disabled. Once we know how many users are affected by this and in case it turns out to be significant, we can revisit this and think about alternative solutions.
,
Jul 13 2017
> How many users are affected: See go/chrome-suggestions-disabled-histograms Decision: We remove the Learn More link.
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdeb2a64671284589f7c4c310e5d01839a6d7ed3 commit fdeb2a64671284589f7c4c310e5d01839a6d7ed3 Author: Nicolas Dossou-gbete <dgn@chromium.org> Date: Fri Jul 14 12:21:42 2017 [Suggestions] All dismissed state when disabled: hide everything In addition to the All Dismissed item, we now also hide the footer that holds the Learn More link and the space at the bottom of the NTP when remote suggestions are disabled. Bug: 721407 Change-Id: I660f627c0d6fb0f9370e9604437d43227a5dafae Reviewed-on: https://chromium-review.googlesource.com/570447 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#486743} [modify] https://crrev.com/fdeb2a64671284589f7c4c310e5d01839a6d7ed3/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/fdeb2a64671284589f7c4c310e5d01839a6d7ed3/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SpacingItem.java [modify] https://crrev.com/fdeb2a64671284589f7c4c310e5d01839a6d7ed3/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
,
Jul 14 2017
+rachelis@, finkm@: does this need to go through implementation or some other type of review?
,
Jul 14 2017
,
Jul 14 2017
Is this part of the feature for a setting to disable zine, and has that already gone through review?
,
Jul 17 2017
The setting for disabling Zine is already launched on Stable. And yes, that's a bugfix that I consider part of it.
,
Jul 19 2017
from Zine UX sync: Pls send an FYI to the email thread where the Zine setting was discussed.
,
Jul 19 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by dgn@chromium.org
, May 11 2017Status: Duplicate (was: Untriaged)