New issue
Advanced search Search tips

Issue 721403 link

Starred by 8 users
Status: Fixed
Owner:
cduvall@chromium.org
Closed: Nov 29
Cc:
tbansal@chromium.org
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-Servicification

Blocked on:
issue 836029
issue 879777
issue 879783
issue 879784
Blocking:
issue 598073
issue 827531
issue 841820



Sign in to add a comment

Get Data Reduction Proxy working with network service

Project Member Reported by rdsmith@chromium.org, May 11 2017 
To remove the network service from the browser process, all communication with other services needs to be switched to mojo.  This bug tracks the efforts to do this for the Chrome Data Reduction Proxy.

Comment 1 by rdsmith@chromium.org, May 11 2017

Cc: rdsmith@chromium.org
 Issue 721404  has been merged into this issue.

Comment 2 by yzshen@chromium.org, May 24 2017

Components: Internals>Network>Service

Comment 3 by dougt@chromium.org, Oct 18 2017

Owner: reillyg@chromium.org
Status: Started (was: Assigned)

Comment 4 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b414ace77d7ac38026a54b521ab5d7a56f63e688

commit b414ace77d7ac38026a54b521ab5d7a56f63e688
Author: Reilly Grant <reillyg@chromium.org>
Date: Tue Nov 14 23:03:22 2017

Remove ProxyService from ProxyDelegate interface

The ProxyService pointer passed to OnResolveProxy is only used to fetch
the ProxyRetryInfoMap so a const reference to this data can be passed in
directly.

Bug:  721403 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic79eaef9a2077b77716b6b6ff8b0fcd821a7ab32
Reviewed-on: https://chromium-review.googlesource.com/764379
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516481}
[modify] https://crrev.com/b414ace77d7ac38026a54b521ab5d7a56f63e688/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/b414ace77d7ac38026a54b521ab5d7a56f63e688/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
[modify] https://crrev.com/b414ace77d7ac38026a54b521ab5d7a56f63e688/net/base/proxy_delegate.h
[modify] https://crrev.com/b414ace77d7ac38026a54b521ab5d7a56f63e688/net/base/test_proxy_delegate.cc
[modify] https://crrev.com/b414ace77d7ac38026a54b521ab5d7a56f63e688/net/base/test_proxy_delegate.h
[modify] https://crrev.com/b414ace77d7ac38026a54b521ab5d7a56f63e688/net/proxy/proxy_service.cc
[modify] https://crrev.com/b414ace77d7ac38026a54b521ab5d7a56f63e688/net/proxy/proxy_service_unittest.cc
[modify] https://crrev.com/b414ace77d7ac38026a54b521ab5d7a56f63e688/net/websockets/websocket_end_to_end_test.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fe183738d996a50e736650af3ef778240609ab3

commit 6fe183738d996a50e736650af3ef778240609ab3
Author: Reilly Grant <reillyg@chromium.org>
Date: Wed Dec 13 01:08:02 2017

Call OnResolveProxy in DataReductionProxyDelegate tests

This change simplifies setup in these tests as we already create a
DataReductionProxyDelegate instance with the appropriate configuration.

Bug:  721403 
Change-Id: Iae6ae1364872c521f8da1b6ed5273b0af154ab25
Reviewed-on: https://chromium-review.googlesource.com/823179
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523642}
[modify] https://crrev.com/6fe183738d996a50e736650af3ef778240609ab3/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/6fe183738d996a50e736650af3ef778240609ab3/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
[modify] https://crrev.com/6fe183738d996a50e736650af3ef778240609ab3/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e8ba3ef5323b569d2a3ce0d5e16b1fcd46eb858

commit 2e8ba3ef5323b569d2a3ce0d5e16b1fcd46eb858
Author: Reilly Grant <reillyg@chromium.org>
Date: Thu Dec 14 00:34:44 2017

Remove GetAlternativeProxy from ProxyDelegate interface

Instead of calling back into the ProxyDelegate interface this patch adds
the alternate proxy server information to the ProxyInfo class so that it
can be populated by DataReductionProxyDelegate during the initial call
to OnResolveProxy.

This reduces the number of round-trips between //net and the Data
Reduction Proxy implementation which should simplify the Network Service
implementation.

Bug:  721403 
Change-Id: I8cc4280901325c39346a595fbaa41d03995102be
Reviewed-on: https://chromium-review.googlesource.com/821416
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523952}
[modify] https://crrev.com/2e8ba3ef5323b569d2a3ce0d5e16b1fcd46eb858/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/2e8ba3ef5323b569d2a3ce0d5e16b1fcd46eb858/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
[modify] https://crrev.com/2e8ba3ef5323b569d2a3ce0d5e16b1fcd46eb858/net/base/proxy_delegate.h
[modify] https://crrev.com/2e8ba3ef5323b569d2a3ce0d5e16b1fcd46eb858/net/base/test_proxy_delegate.cc
[modify] https://crrev.com/2e8ba3ef5323b569d2a3ce0d5e16b1fcd46eb858/net/base/test_proxy_delegate.h
[modify] https://crrev.com/2e8ba3ef5323b569d2a3ce0d5e16b1fcd46eb858/net/http/http_stream_factory_impl_job_controller.cc
[modify] https://crrev.com/2e8ba3ef5323b569d2a3ce0d5e16b1fcd46eb858/net/http/http_stream_factory_impl_job_controller_unittest.cc
[modify] https://crrev.com/2e8ba3ef5323b569d2a3ce0d5e16b1fcd46eb858/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/2e8ba3ef5323b569d2a3ce0d5e16b1fcd46eb858/net/proxy/proxy_info.cc
[modify] https://crrev.com/2e8ba3ef5323b569d2a3ce0d5e16b1fcd46eb858/net/proxy/proxy_info.h
[modify] https://crrev.com/2e8ba3ef5323b569d2a3ce0d5e16b1fcd46eb858/net/proxy/proxy_service_unittest.cc
[modify] https://crrev.com/2e8ba3ef5323b569d2a3ce0d5e16b1fcd46eb858/net/websockets/websocket_end_to_end_test.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/922c4671ce57d40708ed8dbc4c3897f8867a2b28

commit 922c4671ce57d40708ed8dbc4c3897f8867a2b28
Author: Reilly Grant <reillyg@chromium.org>
Date: Fri Dec 29 00:39:57 2017

Use OnResolveProxy instead of GetAlternativeProxy in tests

This change continues the work from r523952 by completely hiding
GetAlternativeProxy from tests and doing all tests through
OnResolveProxy. This required removing some test cases that covered
inputs that GetAlternativeProxy would never be called with.

This will allow the implementation to evolve further in ways that do
not break the tests.

Bug:  721403 
Change-Id: Ia025e1594ec9566858e21e397383f8f5b927248e
Reviewed-on: https://chromium-review.googlesource.com/845056
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526343}
[modify] https://crrev.com/922c4671ce57d40708ed8dbc4c3897f8867a2b28/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
[modify] https://crrev.com/922c4671ce57d40708ed8dbc4c3897f8867a2b28/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/879bd186e4eb3735b842ed44840b9b7d2da369d7

commit 879bd186e4eb3735b842ed44840b9b7d2da369d7
Author: Reilly Grant <reillyg@chromium.org>
Date: Wed Jan 03 19:04:15 2018

Remove unused proxy tunnel methods from ProxyDelegate

The only production implementations of the OnTunnelConnectCompleted,
OnBeforeTunnelRequest and OnTunnelHeadersReceived are empty. They are
used however in http_proxy_client_socket_pool_unittest.cc which has had
to have some test expectations removed.

This effectively reverts r294252 as DRP's custom HTTP headers are now
added by the DataReductionProxyNetworkDelegate instead of the
DataReductionProxyDelegate.

Bug:  721403 
Change-Id: Ifb683e7fc28e97efc7182df1a33bf46f1b74a7ec
Reviewed-on: https://chromium-review.googlesource.com/846261
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526757}
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/base/proxy_delegate.h
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/base/test_proxy_delegate.cc
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/base/test_proxy_delegate.h
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/http/http_proxy_client_socket.cc
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/http/http_proxy_client_socket.h
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/http/http_proxy_client_socket_fuzzer.cc
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/http/http_proxy_client_socket_pool.cc
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/http/http_proxy_client_socket_pool.h
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/http/http_proxy_client_socket_pool_unittest.cc
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/http/http_proxy_client_socket_unittest.cc
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/http/http_proxy_client_socket_wrapper.cc
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/http/http_proxy_client_socket_wrapper.h
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/http/http_proxy_client_socket_wrapper_unittest.cc
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/proxy/proxy_service_unittest.cc
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/socket/client_socket_pool_manager.cc
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/socket/ssl_client_socket_pool_unittest.cc
[modify] https://crrev.com/879bd186e4eb3735b842ed44840b9b7d2da369d7/net/websockets/websocket_end_to_end_test.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89a7e510ed013af01257dd8b522b9f12c1a260b6

commit 89a7e510ed013af01257dd8b522b9f12c1a260b6
Author: Reilly Grant <reillyg@chromium.org>
Date: Sat Jan 20 01:57:16 2018

Remove OnAlternativeProxyBroken from ProxyDelegate

This change removes the OnAlternativeProxyBroken method from the
ProxyDelegate interface. Instead, QUIC proxies are marked as bad by
adding them to the ProxyRetryInfoMap maintained by ProxyService.

Bug:  721403 
Change-Id: Ibfa2104b9906749ddd79c69a2a173ab1ec84af96
Reviewed-on: https://chromium-review.googlesource.com/852900
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530729}
[modify] https://crrev.com/89a7e510ed013af01257dd8b522b9f12c1a260b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/89a7e510ed013af01257dd8b522b9f12c1a260b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
[modify] https://crrev.com/89a7e510ed013af01257dd8b522b9f12c1a260b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
[modify] https://crrev.com/89a7e510ed013af01257dd8b522b9f12c1a260b6/net/base/proxy_delegate.h
[modify] https://crrev.com/89a7e510ed013af01257dd8b522b9f12c1a260b6/net/base/test_proxy_delegate.cc
[modify] https://crrev.com/89a7e510ed013af01257dd8b522b9f12c1a260b6/net/base/test_proxy_delegate.h
[modify] https://crrev.com/89a7e510ed013af01257dd8b522b9f12c1a260b6/net/http/http_stream_factory_impl_job_controller.cc
[modify] https://crrev.com/89a7e510ed013af01257dd8b522b9f12c1a260b6/net/http/http_stream_factory_impl_job_controller.h
[modify] https://crrev.com/89a7e510ed013af01257dd8b522b9f12c1a260b6/net/http/http_stream_factory_impl_job_controller_unittest.cc
[modify] https://crrev.com/89a7e510ed013af01257dd8b522b9f12c1a260b6/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/89a7e510ed013af01257dd8b522b9f12c1a260b6/net/proxy/proxy_info.cc
[modify] https://crrev.com/89a7e510ed013af01257dd8b522b9f12c1a260b6/net/proxy/proxy_service_unittest.cc
[modify] https://crrev.com/89a7e510ed013af01257dd8b522b9f12c1a260b6/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/89a7e510ed013af01257dd8b522b9f12c1a260b6/net/websockets/websocket_end_to_end_test.cc
[modify] https://crrev.com/89a7e510ed013af01257dd8b522b9f12c1a260b6/tools/metrics/histograms/histograms.xml
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d

commit f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d
Author: Reilly Grant <reillyg@chromium.org>
Date: Wed Jan 24 21:47:26 2018

Remove IsTrustedSpdyProxy from net::ProxyDelegate

This patch removes the IsTrustedSpdyProxy method from net::ProxyDelegate
and instead stores this information in the net::ProxyServer instance
itself. Only proxy configurations built by the Data Reduction Proxy
service (or in test) are marked with this flag.

Bug:  721403 
Change-Id: Iaf15263c476cdf32316f52d92d1df0c09c73a5bc
Reviewed-on: https://chromium-review.googlesource.com/882221
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531696}
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/base/proxy_delegate.h
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/base/proxy_server.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/base/proxy_server.h
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/base/test_proxy_delegate.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/base/test_proxy_delegate.h
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/http/http_network_session.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/http/http_proxy_client_socket_pool.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/http/http_proxy_client_socket_pool.h
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/http/http_proxy_client_socket_pool_unittest.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/http/http_proxy_client_socket_wrapper.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/http/http_proxy_client_socket_wrapper.h
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/http/http_proxy_client_socket_wrapper_unittest.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/proxy_resolution/proxy_service_unittest.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/socket/client_socket_pool_manager.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/socket/ssl_client_socket_pool_unittest.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/spdy/chromium/spdy_session.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/spdy/chromium/spdy_session.h
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/spdy/chromium/spdy_session_pool.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/spdy/chromium/spdy_session_pool.h
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/spdy/chromium/spdy_session_unittest.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/spdy/chromium/spdy_test_util_common.cc
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/spdy/chromium/spdy_test_util_common.h
[modify] https://crrev.com/f29015e78cb5ee6e3fdacb3eedadb90fdbe76b4d/net/websockets/websocket_end_to_end_test.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4ad1a4d0094dc4ea0023ec0e6050c677ca27058

commit c4ad1a4d0094dc4ea0023ec0e6050c677ca27058
Author: Reilly Grant <reillyg@chromium.org>
Date: Tue Jan 30 18:19:02 2018

Clean up DataReductionProxyDelegate::OnResolveProxy

This change cleans up the logic in OnResolveProxy and its two helper
functions (one of which is removed) so that it is clearer what logic is
run only when a request is eligible for the data reduction proxy or only
when the request will be made through the data reduction proxy.
Duplicate checks are removed or the later ones turned into DCHECKs to
clarify assumptions.

Bug:  721403 
Change-Id: I271a553e0c1406921c6a2a23ab21241ba3095df5
Reviewed-on: https://chromium-review.googlesource.com/887650
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532951}
[modify] https://crrev.com/c4ad1a4d0094dc4ea0023ec0e6050c677ca27058/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/c4ad1a4d0094dc4ea0023ec0e6050c677ca27058/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h

Comment 13 by rdsmith@chromium.org, Feb 16 2018

Cc: -rdsmith@chromium.org

Comment 14 by jcivelli@chromium.org, May 10 2018

Blocking: 841820

Comment 15 by dxie@chromium.org, May 22 2018

Labels: OS-Android
this is android only.

Comment 16 by reillyg@chromium.org, May 22 2018 

This isn't Android-only but Android is the primary platform for this feature.

Comment 17 by dxie@chromium.org, May 29 2018

Labels: Hotlist-KnownIssue

Comment 18 by mmenke@chromium.org, Jun 20 2018

Components: Internals>Network>DataProxy
Should this block windows canary?  This class has some hard edges that crash when we don't set up an in-process URLREquestContext.

Comment 19 by tbansal@chromium.org, Jun 21 2018

Cc: bengr@chromium.org
Discussed with bengr@ today: We do not think there is a need to block OS-Windows network servicification on canary channel behind DRP mojofication. However, we need to resolve this bug (or figure out an alternate path) before network servicification happens for other  platforms or channels where DRP user population is more significant.

Comment 20 by reillyg@chromium.org, Jun 22 2018

Labels: Proj-Servicification-Canary
I've filed  issue 855620  to track migrating DRP to network::SimpleURLLoader and  issue 855621  to track temporarily disabling DRP when the Network Service is enabled to avoid these sharp edges.

Comment 21 by reillyg@chromium.org, Jun 22 2018

Labels: -Proj-Servicification-Canary

Comment 22 by jam@chromium.org, Sep 4

Labels: -Hotlist-KnownIssue

Comment 23 by dxie@chromium.org, Sep 7

Labels: Proj-Servicification-Stable Hotlist-KnownIssue

Comment 24 by jam@chromium.org, Sep 7

Summary: Get Data Reduction Proxy working with network service (was: Switch Network<->Data Reduction Proxy communication to mojo)

Comment 25 by jam@chromium.org, Sep 7

Blocking: 827531

Comment 26 by bengr@chromium.org, Sep 7

Cc: tbansal@chromium.org
Labels: -Pri-3 M-72 Pri-2
Reilly, let us know how we can help with this. We'd like to get it done soon.

Comment 27 by reillyg@chromium.org, Sep 10

Owner: cduvall@chromium.org
cduvall@ will be taking over this work. There are two in-progress patches I have from this issue:

network_delegate_proxy_delegate_merge.patch attempts to merge ProxyDelegate into NetworkDelegate in order to allow proxy decisions to be made on a per-URLRequest level rather than through a ProxyDelegate which is assigned to a network context and doesn't get passed the URLRequest.

This patch broke the DataReductionProxyNetworkDelegate tests and so the smaller patch proxy_delegate_in_network_delegate_tests.patch just adds a DataReductionProxyDelegate to these tests in order to resolve the failures separately from the larger merge.
proxy_delegate_in_network_delegate_tests.patch
6.9 KB Download
network_delegate_proxy_delegate_merge.patch
114 KB Download

Comment 28 by cduvall@chromium.org, Sep 12 

I'll be ramping up on this in the next week or so, Ben I'll sync with you once I have my head around what needs to be done.

Comment 29 by tbansal@chromium.org, Sep 12 

There was a design doc that rdsmith@ wrote a while back: https://docs.google.com/document/d/1jS-M6apvcoesMVAikdw_hrK-CrAEDmBxqN6I7fbB4Lw/edit

Comment 32 by eroman@chromium.org, Sep 25

Blockedon: 879784

Comment 33 by cduvall@chromium.org, Sep 25

Blockedon: 879783 879777
Project Member

Comment 34 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64df410d0ca79a8522d329e75ce8c21a9db77038

commit 64df410d0ca79a8522d329e75ce8c21a9db77038
Author: Eric Roman <eroman@chromium.org>
Date: Thu Oct 04 21:29:27 2018

Remove unused ProxyResolutionService::TryResolveProxySynchronously().

Bug:  721403 
Change-Id: I126d12c56012f27a0962987b98c52f8bbd50ef92
Reviewed-on: https://chromium-review.googlesource.com/c/1260384
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596860}
[modify] https://crrev.com/64df410d0ca79a8522d329e75ce8c21a9db77038/net/proxy_resolution/proxy_resolution_service.cc
[modify] https://crrev.com/64df410d0ca79a8522d329e75ce8c21a9db77038/net/proxy_resolution/proxy_resolution_service.h
[modify] https://crrev.com/64df410d0ca79a8522d329e75ce8c21a9db77038/net/proxy_resolution/proxy_resolution_service_unittest.cc
Project Member

Comment 35 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57d6320e339d46cbf7055477cb0cfe6c5183be4b

commit 57d6320e339d46cbf7055477cb0cfe6c5183be4b
Author: Clark DuVall <cduvall@chromium.org>
Date: Fri Oct 05 17:45:09 2018

Add basic DRP browsertests

These test the basic proxy usage and headers. We can add more tests
here if necessary to help track what's not working with network
service.

Bug:  721403 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I09c0181ee4cdac97b4c532630f274f2418858d5d
Reviewed-on: https://chromium-review.googlesource.com/c/1263038
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597188}
[add] https://crrev.com/57d6320e339d46cbf7055477cb0cfe6c5183be4b/chrome/browser/net/spdyproxy/data_reduction_proxy_browsertest.cc
[modify] https://crrev.com/57d6320e339d46cbf7055477cb0cfe6c5183be4b/chrome/test/BUILD.gn
[modify] https://crrev.com/57d6320e339d46cbf7055477cb0cfe6c5183be4b/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 36 by cduvall@chromium.org, Oct 5

Blockedon: 836029
Project Member

Comment 37 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14a7b2c91746c37ec850b557ac6974fd1c94db64

commit 14a7b2c91746c37ec850b557ac6974fd1c94db64
Author: Clark DuVall <cduvall@chromium.org>
Date: Mon Oct 08 19:11:28 2018

Network service changes for custom proxy config

This CL handles network service changes needed to support DRP proxy
config. This allows setting a custom proxy config that will be used if
the request would otherwise be sent direct. Additionally, headers can be
set at the config or request level for requests sent using the proxy.
These headers can either be added pre or post cache, which allows
caching of the response to be affected by the Vary: tag for some headers.

Bug:  721403 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ie0faf02d1499e75bf27d023a3dc73efbeab6e787
Reviewed-on: https://chromium-review.googlesource.com/c/1260262
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597642}
[modify] https://crrev.com/14a7b2c91746c37ec850b557ac6974fd1c94db64/services/network/BUILD.gn
[modify] https://crrev.com/14a7b2c91746c37ec850b557ac6974fd1c94db64/services/network/network_context.cc
[modify] https://crrev.com/14a7b2c91746c37ec850b557ac6974fd1c94db64/services/network/network_context.h
[modify] https://crrev.com/14a7b2c91746c37ec850b557ac6974fd1c94db64/services/network/network_context_unittest.cc
[modify] https://crrev.com/14a7b2c91746c37ec850b557ac6974fd1c94db64/services/network/network_service_network_delegate.cc
[modify] https://crrev.com/14a7b2c91746c37ec850b557ac6974fd1c94db64/services/network/network_service_network_delegate.h
[add] https://crrev.com/14a7b2c91746c37ec850b557ac6974fd1c94db64/services/network/network_service_proxy_delegate.cc
[add] https://crrev.com/14a7b2c91746c37ec850b557ac6974fd1c94db64/services/network/network_service_proxy_delegate.h
[add] https://crrev.com/14a7b2c91746c37ec850b557ac6974fd1c94db64/services/network/network_service_proxy_delegate_unittest.cc
[modify] https://crrev.com/14a7b2c91746c37ec850b557ac6974fd1c94db64/services/network/public/cpp/network_ipc_param_traits.h
[modify] https://crrev.com/14a7b2c91746c37ec850b557ac6974fd1c94db64/services/network/public/cpp/proxy_config.typemap
[modify] https://crrev.com/14a7b2c91746c37ec850b557ac6974fd1c94db64/services/network/public/cpp/resource_request.h
[modify] https://crrev.com/14a7b2c91746c37ec850b557ac6974fd1c94db64/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/14a7b2c91746c37ec850b557ac6974fd1c94db64/services/network/url_loader.cc
[modify] https://crrev.com/14a7b2c91746c37ec850b557ac6974fd1c94db64/services/network/url_loader.h
Project Member

Comment 38 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6eee9cbbc23ff592d43320d226481121a0f55af8

commit 6eee9cbbc23ff592d43320d226481121a0f55af8
Author: Clark DuVall <cduvall@chromium.org>
Date: Tue Oct 09 22:08:12 2018

Hook up DRP config and headers to network service interface

This hooks up the chrome side of DRP to the network service interface
landed in crrev.com/c/1260262. Right now this handles the basic config
and headers.

A new feature is added to control the new DRP path separately from the
NetworkService feature, so we can start a NetworkService experiment
without DRP support if necessary.

Bug:  721403 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I6798f487751ac4741d18df711e9330903ed8770e
Reviewed-on: https://chromium-review.googlesource.com/c/1269721
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598103}
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/chrome/browser/BUILD.gn
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/chrome/browser/net/spdyproxy/data_reduction_proxy_browsertest.cc
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/chrome/renderer/BUILD.gn
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/chrome/renderer/DEPS
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/chrome/renderer/url_loader_throttle_provider_impl.cc
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/BUILD.gn
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/content/browser/BUILD.gn
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/content/browser/content_lofi_decider.cc
[add] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/content/common/BUILD.gn
[add] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle.cc
[add] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle.h
[add] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle_unittest.cc
[add] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/content/common/header_util.cc
[add] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/content/common/header_util.h
[add] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/content/common/header_util_unittest.cc
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.cc
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/core/common/data_reduction_proxy_features.cc
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/core/common/data_reduction_proxy_features.h
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/6eee9cbbc23ff592d43320d226481121a0f55af8/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 39 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0163c5145cb02a690f03b2e7fb44f1570f303043

commit 0163c5145cb02a690f03b2e7fb44f1570f303043
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Wed Oct 10 08:30:03 2018

Revert "Hook up DRP config and headers to network service interface"

This reverts commit 6eee9cbbc23ff592d43320d226481121a0f55af8.

Reason for revert: broke unit tests on Android
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933078628653060144/+/steps/unit_tests_on_Android_device_Nexus_5X/0/logs/BookmarkLastVisitUpdaterTest.IsTrackingVisits/0
../../chrome/browser/profiles/profile_io_data.cc:652:11: runtime error: control flow integrity check for type 'ProfileIOData::ResourceContext' failed during base-to-derived cast (vtable address 0xdd6f5ae8)
  0xdd6f5ae8: note: vtable is of type 'content::MockResourceContext'

Original change's description:
> Hook up DRP config and headers to network service interface
> 
> This hooks up the chrome side of DRP to the network service interface
> landed in crrev.com/c/1260262. Right now this handles the basic config
> and headers.
> 
> A new feature is added to control the new DRP path separately from the
> NetworkService feature, so we can start a NetworkService experiment
> without DRP support if necessary.
> 
> Bug:  721403 
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I6798f487751ac4741d18df711e9330903ed8770e
> Reviewed-on: https://chromium-review.googlesource.com/c/1269721
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Eric Roman <eroman@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598103}

TBR=eroman@chromium.org,jam@chromium.org,tbansal@chromium.org,cduvall@chromium.org

Change-Id: Ic0016baec17903ce6ad702f7392625a61f14631c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  721403 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/c/1273057
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598256}
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/chrome/browser/BUILD.gn
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/chrome/browser/net/spdyproxy/data_reduction_proxy_browsertest.cc
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/chrome/renderer/BUILD.gn
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/chrome/renderer/DEPS
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/chrome/renderer/url_loader_throttle_provider_impl.cc
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/components/BUILD.gn
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/components/data_reduction_proxy/content/browser/BUILD.gn
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/components/data_reduction_proxy/content/browser/content_lofi_decider.cc
[delete] https://crrev.com/e1a18fb57390e1a93f1882468723cb4fd64dd094/components/data_reduction_proxy/content/common/BUILD.gn
[delete] https://crrev.com/e1a18fb57390e1a93f1882468723cb4fd64dd094/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle.cc
[delete] https://crrev.com/e1a18fb57390e1a93f1882468723cb4fd64dd094/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle.h
[delete] https://crrev.com/e1a18fb57390e1a93f1882468723cb4fd64dd094/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle_unittest.cc
[delete] https://crrev.com/e1a18fb57390e1a93f1882468723cb4fd64dd094/components/data_reduction_proxy/content/common/header_util.cc
[delete] https://crrev.com/e1a18fb57390e1a93f1882468723cb4fd64dd094/components/data_reduction_proxy/content/common/header_util.h
[delete] https://crrev.com/e1a18fb57390e1a93f1882468723cb4fd64dd094/components/data_reduction_proxy/content/common/header_util_unittest.cc
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.cc
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/components/data_reduction_proxy/core/common/data_reduction_proxy_features.cc
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/components/data_reduction_proxy/core/common/data_reduction_proxy_features.h
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/0163c5145cb02a690f03b2e7fb44f1570f303043/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 40 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9233584d1d2ff2987e235b99a5d2260f6515d371

commit 9233584d1d2ff2987e235b99a5d2260f6515d371
Author: Clark DuVall <cduvall@chromium.org>
Date: Wed Oct 10 16:49:09 2018

Reland "Hook up DRP config and headers to network service interface"

This is a reland of 6eee9cbbc23ff592d43320d226481121a0f55af8

Previously, ProfileIOData::FromResourceContext was only called when
necessary because MockResourceContext is used in some tests. This
restores that behavior.

Original change's description:
> Hook up DRP config and headers to network service interface
>
> This hooks up the chrome side of DRP to the network service interface
> landed in crrev.com/c/1260262. Right now this handles the basic config
> and headers.
>
> A new feature is added to control the new DRP path separately from the
> NetworkService feature, so we can start a NetworkService experiment
> without DRP support if necessary.
>
> Bug:  721403 
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I6798f487751ac4741d18df711e9330903ed8770e
> Reviewed-on: https://chromium-review.googlesource.com/c/1269721
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Eric Roman <eroman@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598103}

TBR=tbansal@chromium.org,jam@chromium.org,eroman@chromium.org

Bug:  721403 
Change-Id: If4c1089359753cf5037c71faf62308b6e34cb159
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/c/1273606
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598364}
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/chrome/browser/BUILD.gn
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/chrome/browser/net/spdyproxy/data_reduction_proxy_browsertest.cc
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/chrome/renderer/BUILD.gn
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/chrome/renderer/DEPS
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/chrome/renderer/url_loader_throttle_provider_impl.cc
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/BUILD.gn
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/content/browser/BUILD.gn
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/content/browser/content_lofi_decider.cc
[add] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/content/common/BUILD.gn
[add] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle.cc
[add] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle.h
[add] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle_unittest.cc
[add] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/content/common/header_util.cc
[add] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/content/common/header_util.h
[add] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/content/common/header_util_unittest.cc
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.cc
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/core/common/data_reduction_proxy_features.cc
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/core/common/data_reduction_proxy_features.h
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/9233584d1d2ff2987e235b99a5d2260f6515d371/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 41 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aac40ceff0ef299bc26b69a23b5cdc6e500e31d5

commit aac40ceff0ef299bc26b69a23b5cdc6e500e31d5
Author: Clark DuVall <cduvall@chromium.org>
Date: Wed Oct 10 20:18:13 2018

Add more browsertest coverage for DRP

This tests:
- Using CORE proxy for media requests
- Bypass and blocking logic

Bug:  721403 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I9c3d6d28a87d9e45285acecb887098aa2d1a08e9
Reviewed-on: https://chromium-review.googlesource.com/c/1272661
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598476}
[modify] https://crrev.com/aac40ceff0ef299bc26b69a23b5cdc6e500e31d5/chrome/browser/net/spdyproxy/data_reduction_proxy_browsertest.cc
[modify] https://crrev.com/aac40ceff0ef299bc26b69a23b5cdc6e500e31d5/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 42 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c1f41d867eea98025d58c6f1272a029d71c4af4

commit 8c1f41d867eea98025d58c6f1272a029d71c4af4
Author: Eric Roman <eroman@chromium.org>
Date: Wed Oct 10 21:40:10 2018

Remove unused field trial parameter for DataReductionProxyRobustConnection.

Bug:  721403 
Change-Id: Idf20dcf0000805f74044cf56cc8cfeb8e67f0bf2
Reviewed-on: https://chromium-review.googlesource.com/c/1274000
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598520}
[modify] https://crrev.com/8c1f41d867eea98025d58c6f1272a029d71c4af4/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
Project Member

Comment 43 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/416efd393ece6198930fd4c52047d7a08cf7536f

commit 416efd393ece6198930fd4c52047d7a08cf7536f
Author: Eric Roman <eroman@chromium.org>
Date: Thu Oct 11 19:28:22 2018

Refactor DataReductionProxyBypassProtocol to remove net::URLRequest dependency.

To facilitate sharing logic between DataReductionProxyURLLoaderThrottle and DataReductionProxyInterceptor.

Bug:  721403 
Change-Id: I8dd9493346d58c1c6fb99b7887d3775645b650a3
Reviewed-on: https://chromium-review.googlesource.com/c/1273950
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598885}
[modify] https://crrev.com/416efd393ece6198930fd4c52047d7a08cf7536f/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
[modify] https://crrev.com/416efd393ece6198930fd4c52047d7a08cf7536f/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.h
[modify] https://crrev.com/416efd393ece6198930fd4c52047d7a08cf7536f/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc
[modify] https://crrev.com/416efd393ece6198930fd4c52047d7a08cf7536f/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/416efd393ece6198930fd4c52047d7a08cf7536f/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
Project Member

Comment 44 by bugdroid1@chromium.org, Oct 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b72f17d07870e04b6d2320e14df768e62fb57202

commit b72f17d07870e04b6d2320e14df768e62fb57202
Author: Eric Roman <eroman@chromium.org>
Date: Fri Oct 12 17:54:13 2018

Remove NetLog support from Data Reduction Proxy.

Bug:  721403 
Change-Id: I266cafc445813b0305b00bbae8698542505cfcfc
Reviewed-on: https://chromium-review.googlesource.com/c/1274613
Reviewed-by: Ben Greenstein <bengr@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599281}
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/chrome/browser/net/net_export_helper.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/chrome/browser/net/net_export_helper.h
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/chrome/browser/ui/webui/net_export_ui.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.h
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/common/BUILD.gn
[delete] https://crrev.com/2c379a0e7c594d15e7a84f83ebb961bc013ad317/components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc
[delete] https://crrev.com/2c379a0e7c594d15e7a84f83ebb961bc013ad317/components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.h
[delete] https://crrev.com/2c379a0e7c594d15e7a84f83ebb961bc013ad317/components/data_reduction_proxy/core/common/data_reduction_proxy_event_storage_delegate.h
[delete] https://crrev.com/2c379a0e7c594d15e7a84f83ebb961bc013ad317/components/data_reduction_proxy/core/common/data_reduction_proxy_event_storage_delegate_test_utils.cc
[delete] https://crrev.com/2c379a0e7c594d15e7a84f83ebb961bc013ad317/components/data_reduction_proxy/core/common/data_reduction_proxy_event_storage_delegate_test_utils.h
[delete] https://crrev.com/2c379a0e7c594d15e7a84f83ebb961bc013ad317/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc
[delete] https://crrev.com/2c379a0e7c594d15e7a84f83ebb961bc013ad317/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.h
[delete] https://crrev.com/2c379a0e7c594d15e7a84f83ebb961bc013ad317/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/components/net_log/chrome_net_log.cc
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/net/log/net_log_event_type_list.h
[modify] https://crrev.com/b72f17d07870e04b6d2320e14df768e62fb57202/net/log/net_log_source_type_list.h
Project Member

Comment 45 by bugdroid1@chromium.org, Oct 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f4edc62e40d82f3e7df82967eea063e9e3a7ed2

commit 1f4edc62e40d82f3e7df82967eea063e9e3a7ed2
Author: Clark DuVall <cduvall@chromium.org>
Date: Fri Oct 12 22:39:11 2018

Remove DRP deps from components/net_log BUILD.gn and DEPS

Bug:  721403 
Change-Id: If3cae7ab4e1122b98411076d3f72c6088f184c71
Reviewed-on: https://chromium-review.googlesource.com/c/1279227
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599386}
[modify] https://crrev.com/1f4edc62e40d82f3e7df82967eea063e9e3a7ed2/components/net_log/BUILD.gn
[modify] https://crrev.com/1f4edc62e40d82f3e7df82967eea063e9e3a7ed2/components/net_log/DEPS

Comment 46 by cduvall@chromium.org, Oct 17 

Issue 896462 has been merged into this issue.
Project Member

Comment 47 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bd28572e99a3af530040c3495c4c60fb8bb1746

commit 6bd28572e99a3af530040c3495c4c60fb8bb1746
Author: Clark DuVall <cduvall@chromium.org>
Date: Thu Oct 18 16:17:13 2018

Only use core DRP proxies for media requests in network service

This implements the DRP logic for only using CORE proxies when proxying
RESOURCE_TYPE_MEDIA requests. A similar approach is used to
DataReductionProxyDelegate, which uses an MRUCache to associate URLs
to resource type during proxy resolution, since the ProxyDelegate only
has access to the URL.

Bug:  721403 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ib1c50dbc1344535e46c80b2d3a900dbb6b215141
Reviewed-on: https://chromium-review.googlesource.com/c/1274526
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600786}
[modify] https://crrev.com/6bd28572e99a3af530040c3495c4c60fb8bb1746/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle.cc
[modify] https://crrev.com/6bd28572e99a3af530040c3495c4c60fb8bb1746/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle_unittest.cc
[modify] https://crrev.com/6bd28572e99a3af530040c3495c4c60fb8bb1746/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/6bd28572e99a3af530040c3495c4c60fb8bb1746/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h
[modify] https://crrev.com/6bd28572e99a3af530040c3495c4c60fb8bb1746/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/6bd28572e99a3af530040c3495c4c60fb8bb1746/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/6bd28572e99a3af530040c3495c4c60fb8bb1746/services/network/network_context_unittest.cc
[modify] https://crrev.com/6bd28572e99a3af530040c3495c4c60fb8bb1746/services/network/network_service_proxy_delegate.cc
[modify] https://crrev.com/6bd28572e99a3af530040c3495c4c60fb8bb1746/services/network/network_service_proxy_delegate.h
[modify] https://crrev.com/6bd28572e99a3af530040c3495c4c60fb8bb1746/services/network/public/cpp/network_ipc_param_traits.h
[modify] https://crrev.com/6bd28572e99a3af530040c3495c4c60fb8bb1746/services/network/public/cpp/resource_request.h
[modify] https://crrev.com/6bd28572e99a3af530040c3495c4c60fb8bb1746/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/6bd28572e99a3af530040c3495c4c60fb8bb1746/services/network/url_loader.cc
[modify] https://crrev.com/6bd28572e99a3af530040c3495c4c60fb8bb1746/services/network/url_loader.h
[modify] https://crrev.com/6bd28572e99a3af530040c3495c4c60fb8bb1746/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 48 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/206c0777170302d87809a0dd87e77a9e8901521f

commit 206c0777170302d87809a0dd87e77a9e8901521f
Author: Clark DuVall <cduvall@chromium.org>
Date: Thu Oct 18 17:57:52 2018

Add DRP browsertests for warmup URL fetches

Bug:  721403 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia1432c05c9118f9300bee7d5b6e6650d699bc58d
Reviewed-on: https://chromium-review.googlesource.com/c/1285569
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600821}
[modify] https://crrev.com/206c0777170302d87809a0dd87e77a9e8901521f/chrome/browser/net/spdyproxy/data_reduction_proxy_browsertest.cc
[modify] https://crrev.com/206c0777170302d87809a0dd87e77a9e8901521f/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 49 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/696017c74ad5d0f56e2eaed6bf2b4d6385ca45db

commit 696017c74ad5d0f56e2eaed6bf2b4d6385ca45db
Author: Clark DuVall <cduvall@chromium.org>
Date: Thu Oct 18 21:57:33 2018

Add browsertest for important DRP UMAs

Bug:  721403 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id5a6a3da80fb2e50b80e156a8c39328a8e79ba42
Reviewed-on: https://chromium-review.googlesource.com/c/1289161
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600929}
[modify] https://crrev.com/696017c74ad5d0f56e2eaed6bf2b4d6385ca45db/chrome/browser/net/spdyproxy/data_reduction_proxy_browsertest.cc
[modify] https://crrev.com/696017c74ad5d0f56e2eaed6bf2b4d6385ca45db/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 50 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2ae3b7c0de1a2516d91d1b82e1c34fa608e7c64

commit d2ae3b7c0de1a2516d91d1b82e1c34fa608e7c64
Author: Clark DuVall <cduvall@chromium.org>
Date: Mon Oct 22 20:09:20 2018

Keep previously configured DRP servers in network service

This matches the logic in http://crrev.com/c/1045025. A couple of the
most recent configs are kept around in case the config changes in the
middle of a request, which will allow the headers to be correct in that
case.

Also adds a browsertest for basic config changes.

Bug:  721403 
Change-Id: I788dcf52efa9a86031fd33cbc77d1be45022b19c
Reviewed-on: https://chromium-review.googlesource.com/c/1292510
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601701}
[modify] https://crrev.com/d2ae3b7c0de1a2516d91d1b82e1c34fa608e7c64/chrome/browser/net/spdyproxy/data_reduction_proxy_browsertest.cc
[modify] https://crrev.com/d2ae3b7c0de1a2516d91d1b82e1c34fa608e7c64/services/network/network_service_proxy_delegate.cc
[modify] https://crrev.com/d2ae3b7c0de1a2516d91d1b82e1c34fa608e7c64/services/network/network_service_proxy_delegate.h
[modify] https://crrev.com/d2ae3b7c0de1a2516d91d1b82e1c34fa608e7c64/services/network/network_service_proxy_delegate_unittest.cc
Project Member

Comment 51 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2961e58a0245ea02ac733ec3d1131153ea654bf0

commit 2961e58a0245ea02ac733ec3d1131153ea654bf0
Author: Clark DuVall <cduvall@chromium.org>
Date: Tue Oct 23 07:13:22 2018

Fix DRP warmup URLs with network service

DRP currently handles this by modifying the proxy list to only have a
specific proxy in the ProxyDelegate if the request is for a warmup
URL. This change implements equivalent functionality when using the
network service by creating a new NetworkContext with only the relevant
proxy set in the custom proxy config, and using that context when
making the warmup request.

Bug:  721403 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I10e2ae5a7493526c24ac35c6db9a4d33dbbc6c8c
Reviewed-on: https://chromium-review.googlesource.com/c/1289165
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601867}
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/components/data_reduction_proxy/core/browser/BUILD.gn
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/components/data_reduction_proxy/core/browser/DEPS
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/components/data_reduction_proxy/core/browser/warmup_url_fetcher.cc
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/components/data_reduction_proxy/core/browser/warmup_url_fetcher.h
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/components/data_reduction_proxy/core/browser/warmup_url_fetcher_unittest.cc
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/services/network/network_context.cc
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/services/network/network_service_proxy_delegate.cc
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/services/network/network_service_proxy_delegate.h
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/services/network/network_service_proxy_delegate_unittest.cc
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/2961e58a0245ea02ac733ec3d1131153ea654bf0/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 52 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c5a72cc522900a43030ea23d93edbdca06b72a1

commit 9c5a72cc522900a43030ea23d93edbdca06b72a1
Author: Clark DuVall <cduvall@chromium.org>
Date: Thu Oct 25 01:29:21 2018

Get DataReductionProxyData from NavigationHandle in network service path

DataReductionProxyData is not supported with network service since it
gets most of the data from net::URLRequest. This creates a mostly
complete version using the NavigationHandle, which should allow us to
log most of the important DRP metrics correctly. A few things which are
not yet supported:
- DataReductionProxyData in
  MetricsWebContentsObserver::ResourceLoadComplete (see TODO there)
- Some fields are not filled in
  DataReductionProxyChromeSettings::CreateDataFromNavigationHandle
- Maybe other things I missed

This required adding a couple fields to NavigationHandle and syncing
the configured DRP proxies to DRPSettings.

http://crbug.com/898326 tracks deprecating DataReductionProxyData
completely.

Bug:  721403 , 898326
Change-Id: I1210948f60a03ed7d632f1547311bbd3826323fb
Reviewed-on: https://chromium-review.googlesource.com/c/1297002
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602560}
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/chrome/browser/plugins/pdf_iframe_navigation_throttle_unittest.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/chrome/browser/previews/previews_ui_tab_helper_unittest.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/common/data_reduction_proxy_config_values.h
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/content/browser/frame_host/origin_policy_throttle_unittest.cc
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/content/public/browser/navigation_handle.h
[modify] https://crrev.com/9c5a72cc522900a43030ea23d93edbdca06b72a1/services/network/public/cpp/resource_response.cc
Project Member

Comment 53 by bugdroid1@chromium.org, Oct 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cad73214a91bc2bb7ea930b61b9707cbbe52f33

commit 8cad73214a91bc2bb7ea930b61b9707cbbe52f33
Author: Clark DuVall <cduvall@chromium.org>
Date: Fri Oct 26 17:42:57 2018

Remove unused lofi_requested field from DataReductionProxyData

This field was only being used in tests.

Bug:  721403 
Change-Id: I58d0bb526827c54a706d4bf16b42efebf9ea2f81
Reviewed-on: https://chromium-review.googlesource.com/c/1301962
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603137}
[modify] https://crrev.com/8cad73214a91bc2bb7ea930b61b9707cbbe52f33/components/data_reduction_proxy/content/browser/content_lofi_decider.cc
[modify] https://crrev.com/8cad73214a91bc2bb7ea930b61b9707cbbe52f33/components/data_reduction_proxy/content/browser/content_lofi_decider.h
[modify] https://crrev.com/8cad73214a91bc2bb7ea930b61b9707cbbe52f33/components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc
[modify] https://crrev.com/8cad73214a91bc2bb7ea930b61b9707cbbe52f33/components/data_reduction_proxy/core/browser/data_reduction_proxy_data.cc
[modify] https://crrev.com/8cad73214a91bc2bb7ea930b61b9707cbbe52f33/components/data_reduction_proxy/core/browser/data_reduction_proxy_data.h
[modify] https://crrev.com/8cad73214a91bc2bb7ea930b61b9707cbbe52f33/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_unittest.cc
[modify] https://crrev.com/8cad73214a91bc2bb7ea930b61b9707cbbe52f33/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
[modify] https://crrev.com/8cad73214a91bc2bb7ea930b61b9707cbbe52f33/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/8cad73214a91bc2bb7ea930b61b9707cbbe52f33/components/data_reduction_proxy/core/common/lofi_decider.h
Project Member

Comment 54 by bugdroid1@chromium.org, Oct 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05faba13cd28021efa0499ae1eab3986d92bf96b

commit 05faba13cd28021efa0499ae1eab3986d92bf96b
Author: Clark DuVall <cduvall@chromium.org>
Date: Mon Oct 29 19:34:48 2018

Make sure DRP is disabled when incognito

Creating an incognito window was crashing when DRP was enabled with
network service.

Bug:  721403 
Change-Id: I7c97fec3e6dd4b15358c73eb442f441caa45f5af
Reviewed-on: https://chromium-review.googlesource.com/c/1305515
Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603588}
[modify] https://crrev.com/05faba13cd28021efa0499ae1eab3986d92bf96b/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/05faba13cd28021efa0499ae1eab3986d92bf96b/chrome/browser/net/spdyproxy/data_reduction_proxy_browsertest.cc
Project Member

Comment 56 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a00cf68a551aae618a610c27bda146d84288c206

commit a00cf68a551aae618a610c27bda146d84288c206
Author: Eric Roman <eroman@chromium.org>
Date: Thu Nov 01 20:09:11 2018

Add support for proxy bypass and retry to network servicified version of Data Reduction Proxy.

The overall design is to decide on the proxies to mark as bad, and when to restart a request as part of the DRP's URLLoaderThrottle.

This CL is complete enough to pass fallback browser_tests, however it hacks around one piece of unimplemented functionality: the DRP configuration is not yet synchronized to throttle, so it guesses it. This needs to be addressed in a follow-up.

Bug:  721403 
Change-Id: If95e52aad825d6e2c3b73fd12fdfeb9e53ae6cc6
Reviewed-on: https://chromium-review.googlesource.com/c/1297238
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604687}
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/chrome/renderer/url_loader_throttle_provider_impl.cc
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/chrome/renderer/url_loader_throttle_provider_impl.h
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle.cc
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle.h
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle_unittest.cc
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/core/browser/BUILD.gn
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/core/browser/DEPS
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.h
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/core/common/BUILD.gn
[add] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/core/common/OWNERS
[add] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/core/common/data_reduction_proxy.mojom
[rename] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/core/common/data_reduction_proxy_bypass_protocol.cc
[rename] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/components/data_reduction_proxy/core/common/data_reduction_proxy_bypass_protocol.h
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/content/common/throttling_url_loader.cc
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/content/common/throttling_url_loader.h
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/content/common/throttling_url_loader_unittest.cc
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/content/public/common/url_loader_throttle.cc
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/content/public/common/url_loader_throttle.h
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/services/network/network_context.cc
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/services/network/network_service_proxy_delegate.cc
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/services/network/network_service_proxy_delegate.h
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/a00cf68a551aae618a610c27bda146d84288c206/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 57 by dxie@google.com, Nov 8

Labels: -Proj-Servicification-Stable Proj-Servicification-Canary
Project Member

Comment 58 by bugdroid1@chromium.org, Nov 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79340d0c403809b15a3f40f732452e6ddf0e4908

commit 79340d0c403809b15a3f40f732452e6ddf0e4908
Author: Clark DuVall <cduvall@chromium.org>
Date: Tue Nov 20 23:25:53 2018

Clear DRP bad proxy cache when DRP is turned off

This adds a test for clearing the bad proxy cache when DRP is turned
off, and implements that functionality with network service.

Bug:  721403 
Change-Id: I12f441191de6dfb890c7a042b72a5a87f72e41aa
Reviewed-on: https://chromium-review.googlesource.com/c/1343352
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609846}
[modify] https://crrev.com/79340d0c403809b15a3f40f732452e6ddf0e4908/chrome/browser/net/spdyproxy/data_reduction_proxy_browsertest.cc
[modify] https://crrev.com/79340d0c403809b15a3f40f732452e6ddf0e4908/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/79340d0c403809b15a3f40f732452e6ddf0e4908/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/79340d0c403809b15a3f40f732452e6ddf0e4908/services/network/network_service_proxy_delegate.cc
[modify] https://crrev.com/79340d0c403809b15a3f40f732452e6ddf0e4908/services/network/network_service_proxy_delegate.h
[modify] https://crrev.com/79340d0c403809b15a3f40f732452e6ddf0e4908/services/network/public/mojom/network_context.mojom
Project Member

Comment 59 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8e3546cab3818f9ca4ff9b917165e3136f49b56

commit c8e3546cab3818f9ca4ff9b917165e3136f49b56
Author: Clark DuVall <cduvall@chromium.org>
Date: Wed Nov 28 01:39:42 2018

Make sure custom proxy config is always a valid pointer

This was part of the reason one of the Android tests is failing.

Bug:  721403 
Change-Id: I58493a24c32aaac2e568ade3541dea36ff87b88c
Reviewed-on: https://chromium-review.googlesource.com/c/1352325
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611496}
[modify] https://crrev.com/c8e3546cab3818f9ca4ff9b917165e3136f49b56/services/network/network_service_proxy_delegate.cc
[modify] https://crrev.com/c8e3546cab3818f9ca4ff9b917165e3136f49b56/services/network/network_service_proxy_delegate_unittest.cc
Project Member

Comment 60 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e5952f309b13c3b4535c48a0863b3556424a501

commit 0e5952f309b13c3b4535c48a0863b3556424a501
Author: Eric Roman <eroman@chromium.org>
Date: Thu Nov 29 00:48:29 2018

Observe the current configuration from DataReductionProxyURLLoaderThrottle.

Bug:  721403 

Change-Id: I6f23e6ba1099666be58014efa840829a072b097c
Reviewed-on: https://chromium-review.googlesource.com/c/1347432
Reviewed-by: rajendrant <rajendrant@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611968}
[modify] https://crrev.com/0e5952f309b13c3b4535c48a0863b3556424a501/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/0e5952f309b13c3b4535c48a0863b3556424a501/chrome/browser/net/spdyproxy/data_reduction_proxy_browsertest.cc
[modify] https://crrev.com/0e5952f309b13c3b4535c48a0863b3556424a501/chrome/renderer/url_loader_throttle_provider_impl.cc
[modify] https://crrev.com/0e5952f309b13c3b4535c48a0863b3556424a501/chrome/renderer/url_loader_throttle_provider_impl.h
[modify] https://crrev.com/0e5952f309b13c3b4535c48a0863b3556424a501/components/data_reduction_proxy/DEPS
[modify] https://crrev.com/0e5952f309b13c3b4535c48a0863b3556424a501/components/data_reduction_proxy/content/common/BUILD.gn
[modify] https://crrev.com/0e5952f309b13c3b4535c48a0863b3556424a501/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle.cc
[modify] https://crrev.com/0e5952f309b13c3b4535c48a0863b3556424a501/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle.h
[modify] https://crrev.com/0e5952f309b13c3b4535c48a0863b3556424a501/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle_unittest.cc
[modify] https://crrev.com/0e5952f309b13c3b4535c48a0863b3556424a501/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/0e5952f309b13c3b4535c48a0863b3556424a501/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/0e5952f309b13c3b4535c48a0863b3556424a501/components/data_reduction_proxy/core/common/BUILD.gn
[modify] https://crrev.com/0e5952f309b13c3b4535c48a0863b3556424a501/components/data_reduction_proxy/core/common/data_reduction_proxy.mojom
[add] https://crrev.com/0e5952f309b13c3b4535c48a0863b3556424a501/components/data_reduction_proxy/core/common/data_reduction_proxy_throttle_manager.cc
[add] https://crrev.com/0e5952f309b13c3b4535c48a0863b3556424a501/components/data_reduction_proxy/core/common/data_reduction_proxy_throttle_manager.h
[modify] https://crrev.com/0e5952f309b13c3b4535c48a0863b3556424a501/services/network/network_service_proxy_delegate.cc
Project Member

Comment 61 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bef77dfa608bd576776c4b4a2738d07980c6d787

commit bef77dfa608bd576776c4b4a2738d07980c6d787
Author: Clark DuVall <cduvall@chromium.org>
Date: Thu Nov 29 19:28:19 2018

Log DRP UMAs for successful requests in network service

This fixes the last DRP browser test. Factors the code to a common
location so it can be used in the DRP throttle.

Bug:  721403 
Change-Id: I47330f7e9cad75861787caa843d55147a42fb8a4
Reviewed-on: https://chromium-review.googlesource.com/c/1354653
Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612312}
[modify] https://crrev.com/bef77dfa608bd576776c4b4a2738d07980c6d787/chrome/browser/net/spdyproxy/data_reduction_proxy_browsertest.cc
[modify] https://crrev.com/bef77dfa608bd576776c4b4a2738d07980c6d787/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle.cc
[modify] https://crrev.com/bef77dfa608bd576776c4b4a2738d07980c6d787/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle.h
[modify] https://crrev.com/bef77dfa608bd576776c4b4a2738d07980c6d787/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
[modify] https://crrev.com/bef77dfa608bd576776c4b4a2738d07980c6d787/components/data_reduction_proxy/core/browser/data_reduction_proxy_util.cc
[modify] https://crrev.com/bef77dfa608bd576776c4b4a2738d07980c6d787/components/data_reduction_proxy/core/browser/data_reduction_proxy_util.h
[modify] https://crrev.com/bef77dfa608bd576776c4b4a2738d07980c6d787/components/data_reduction_proxy/core/browser/warmup_url_fetcher.cc
[modify] https://crrev.com/bef77dfa608bd576776c4b4a2738d07980c6d787/components/data_reduction_proxy/core/browser/warmup_url_fetcher_unittest.cc
[modify] https://crrev.com/bef77dfa608bd576776c4b4a2738d07980c6d787/components/data_reduction_proxy/core/common/BUILD.gn
[add] https://crrev.com/bef77dfa608bd576776c4b4a2738d07980c6d787/components/data_reduction_proxy/core/common/uma_util.cc
[add] https://crrev.com/bef77dfa608bd576776c4b4a2738d07980c6d787/components/data_reduction_proxy/core/common/uma_util.h
[modify] https://crrev.com/bef77dfa608bd576776c4b4a2738d07980c6d787/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 62 by cduvall@chromium.org, Nov 29

Status: Fixed (was: Started)
I'm marking this tracking bug as fixed, since all browser tests are passing for DRP in network service. We can create more targeted bugs for any remaining network service DRP functionality/metrics that are remaining.
Project Member

Comment 63 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/203bcc58ed663b1039bdcae6abe99740a7099811

commit 203bcc58ed663b1039bdcae6abe99740a7099811
Author: Clark DuVall <cduvall@chromium.org>
Date: Thu Nov 29 22:11:29 2018

Add NS DRP flag for data saver browser test

This fixes the last DRP related browser test in the filter file.

Bug:  721403 
Change-Id: Id535fb2fea2636770ba567e601b10b3a273fd1fe
Reviewed-on: https://chromium-review.googlesource.com/c/1355769
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612399}
[modify] https://crrev.com/203bcc58ed663b1039bdcae6abe99740a7099811/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
[modify] https://crrev.com/203bcc58ed663b1039bdcae6abe99740a7099811/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 64 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66378d752a90529c00e9ffde76a0e9b8a95aacc2

commit 66378d752a90529c00e9ffde76a0e9b8a95aacc2
Author: Eric Roman <eroman@chromium.org>
Date: Fri Nov 30 01:51:41 2018

Do sanity checks in MarkProxiesAsBad().

Bug:  721403 
Change-Id: I879f2d2eb8a903bd59b459cb3267c890308da60d
Reviewed-on: https://chromium-review.googlesource.com/c/1356220
Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612499}
[modify] https://crrev.com/66378d752a90529c00e9ffde76a0e9b8a95aacc2/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
Project Member

Comment 65 by bugdroid1@chromium.org, Dec 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7e021ec71e7eaaeb9ec1ed685c68fd210c0823d

commit f7e021ec71e7eaaeb9ec1ed685c68fd210c0823d
Author: Eric Roman <eroman@chromium.org>
Date: Sat Dec 01 01:20:22 2018

Add a unit-test verifying that the DRP throttle doesn't respect Chrome-Proxy headers received from non-DRP proxies.

Bug:  721403 
Change-Id: I16192adf4460f1ee84861567f370c6433510705c
Reviewed-on: https://chromium-review.googlesource.com/c/1357350
Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612888}
[modify] https://crrev.com/f7e021ec71e7eaaeb9ec1ed685c68fd210c0823d/components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle_unittest.cc
Project Member

Comment 66 by bugdroid1@chromium.org, Dec 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d97f646b8993fffeb6e908a2fa7781763d0d662

commit 9d97f646b8993fffeb6e908a2fa7781763d0d662
Author: Eric Roman <eroman@chromium.org>
Date: Sat Dec 01 01:35:41 2018

Test that DataReductionProxy can still fallback to DIRECT after a config change.

Bug:  721403 
Change-Id: I0fc428e46078950bd4261c9228453d5517c4e320
Reviewed-on: https://chromium-review.googlesource.com/c/1357603
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612895}
[modify] https://crrev.com/9d97f646b8993fffeb6e908a2fa7781763d0d662/chrome/browser/net/spdyproxy/data_reduction_proxy_browsertest.cc
Project Member

Comment 68 by bugdroid1@chromium.org, Dec 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fb48e55f7fefdb003dd093324a148f53bb5568c

commit 2fb48e55f7fefdb003dd093324a148f53bb5568c
Author: Clark DuVall <cduvall@chromium.org>
Date: Sat Dec 01 18:35:57 2018

Add DRP network service flag to tests that need it

This flag is necessary to enable DRP with network service. Adding the
flag to DRP tests allows them to pass when run with network service on
the Android mojo bot.

Also updates the changed files to use @EnableFeatures/@DisableFeatures.

Bug:  721403 
Change-Id: Ibf75db48c4ab64ac47bd493e1a5e04f899ac19e9
Reviewed-on: https://chromium-review.googlesource.com/c/1352476
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612927}
[modify] https://crrev.com/2fb48e55f7fefdb003dd093324a148f53bb5568c/chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java
[modify] https://crrev.com/2fb48e55f7fefdb003dd093324a148f53bb5568c/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/DataSaverAppMenuTest.java
[modify] https://crrev.com/2fb48e55f7fefdb003dd093324a148f53bb5568c/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/2fb48e55f7fefdb003dd093324a148f53bb5568c/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java
[modify] https://crrev.com/2fb48e55f7fefdb003dd093324a148f53bb5568c/testing/buildbot/filters/mojo.fyi.network_chrome_public_test_apk.filter
►

Sign in to add a comment