New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 721401 link

Starred by 3 users
Status: Fixed
Owner:
█ xunji...@chromium.org
Last visit > 30 days ago
Closed: Jul 24
Cc:
tommi@chromium.org
guidou@chromium.org
emir...@chromium.org
mcasas@chromium.org
█ pthatcher@chromium.org
█ deadbeef@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Feature
Proj-Servicification

Blocked on:
issue 806817
issue 793066
issue 793071
issue 793076
issue 801321
issue 811497
issue 816634
issue 817094
issue 840797
issue 848073
issue 848075
issue 848078
issue 848079
issue 862608
Blocking:
issue 598073



Sign in to add a comment

Add support for TCP, TLS & UDP sockets in the network service

Project Member Reported by jam@chromium.org, May 11 2017 
When the network service is in use (--enable-network-service, see also parent bug), sockets should be used through the service.

We had an implementation of this in the old mandoline network service, see https://codereview.chromium.org/1873463003/ for inspiration.

WebRTC is one consumer, there are probably others. WebRTC team: can you help with this? Thanks

Comment 1 by guidou@chromium.org, May 11 2017

Cc: pthatcher@chromium.org deadbeef@chromium.org
Components: -Blink>WebRTC Blink>WebRTC>Network

Comment 2 by yzshen@chromium.org, May 24 2017

Components: Internals>Network>Service

Comment 3 by anatolid@chromium.org, Jun 20 2017

Labels: -Type-Bug Type-Feature

Comment 4 by rdsmith@chromium.org, Jul 24 2017

Cc: rdsmith@chromium.org
The consumer list I have for this feature is:

WebRTC
Chromoting
Jingle (Used by Sync, Chromoting (?), WebRTC (?).
Extension sockets API.  rsleevi@ specifically warns that this consumers ownership model is a mis-fit with //net’s, which may mean there are extra dragons here.
Certificate Reporting and Transparency (datagram interface).

No guarantees of accuracy, just including more pointers to chase down.

Comment 5 by xunji...@chromium.org, Sep 26 2017

Owner: xunji...@chromium.org
Status: Assigned (was: Untriaged)
Assigning myself to work on a design in Q4.

Comment 6 by xunji...@chromium.org, Oct 11 2017 

John, is this bug targeted to TCP & UDP but not TLS socket?
The madoline CL that you linked to only has TCP and UDP mojo interfaces.  I looked at the usage of //net raw sockets. TLS socket's case is more hairy, which involves //net entities like socket pools, cert verifier and ssl config service (an example: https://cs.chromium.org/chromium/src/extensions/browser/api/socket/tls_socket.cc?rcl=625eff0aca7fd386555696d437c8c2adbb90a7e0&l=253).

Are we starting with TCP and UDP first? or do we want a design that include all raw socket types and their current use cases? The latter seems rather unattainable for Q4 given that the servicification plan for things like cert verifier is not yet decided.

Comment 7 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 8 by xunji...@chromium.org, Dec 7 2017

Blockedon: 793066

Comment 9 by xunji...@chromium.org, Dec 7 2017

Blockedon: 793071

Comment 10 by xunji...@chromium.org, Dec 7 2017

Blockedon: 793076
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/648cc30cf5debbb5f0412b2da50e6abbb0aee1d7

commit 648cc30cf5debbb5f0412b2da50e6abbb0aee1d7
Author: Helen Li <xunjieli@chromium.org>
Date: Fri Dec 15 01:04:52 2017

Make AddressFamily into its own mojom file

AddressFamily is defined in host resolver mojom file. This CL makes it into
its own mojom file.

Bug:  721401 
Change-Id: I29585ea8c35a63d543c4280b43d7f3fc70073eef
Reviewed-on: https://chromium-review.googlesource.com/826006
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524270}
[modify] https://crrev.com/648cc30cf5debbb5f0412b2da50e6abbb0aee1d7/net/dns/mojo_host_struct_traits.cc
[modify] https://crrev.com/648cc30cf5debbb5f0412b2da50e6abbb0aee1d7/net/dns/mojo_host_struct_traits.h
[modify] https://crrev.com/648cc30cf5debbb5f0412b2da50e6abbb0aee1d7/net/interfaces/BUILD.gn
[add] https://crrev.com/648cc30cf5debbb5f0412b2da50e6abbb0aee1d7/net/interfaces/address_family.mojom
[add] https://crrev.com/648cc30cf5debbb5f0412b2da50e6abbb0aee1d7/net/interfaces/address_family.typemap
[add] https://crrev.com/648cc30cf5debbb5f0412b2da50e6abbb0aee1d7/net/interfaces/address_family_traits.cc
[add] https://crrev.com/648cc30cf5debbb5f0412b2da50e6abbb0aee1d7/net/interfaces/address_family_traits.h
[modify] https://crrev.com/648cc30cf5debbb5f0412b2da50e6abbb0aee1d7/net/interfaces/host_resolver.typemap
[modify] https://crrev.com/648cc30cf5debbb5f0412b2da50e6abbb0aee1d7/net/interfaces/host_resolver_service.mojom
[modify] https://crrev.com/648cc30cf5debbb5f0412b2da50e6abbb0aee1d7/net/interfaces/typemaps.gni
[modify] https://crrev.com/648cc30cf5debbb5f0412b2da50e6abbb0aee1d7/services/proxy_resolver/public/interfaces/proxy_resolver.mojom
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/558a66f7e36b9639e5991a80cc5a89817a94231f

commit 558a66f7e36b9639e5991a80cc5a89817a94231f
Author: Helen Li <xunjieli@chromium.org>
Date: Tue Jan 02 18:47:22 2018

Moves Jingle ProxyResolvingClientSocket to services/network/

ProxyResolvingClientSocket accesses socket pools, http auth cache,
client certs cache directly.  As a part of the network servicification
effort, all interactions with //net need to be done using mojo APIs.
Socket usage will also be through mojo APIs. This CL moves this class to
services/network so the API surface that we need to export is smaller.

This CL:
- Moves ProxyResolvingClientSocket to services/network.
- Adds a few additional unit tests.

See design doc:  https://docs.google.com/document/d/1iQl_Y2o7vykiPXpZiNbKov-WZbUb4RprmXIk311tTso/edit?usp=sharing.

Bug:  721401 

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idbc0cb2e3a9713ef111ddd8b5845f27b1445574e
Reviewed-on: https://chromium-review.googlesource.com/763651
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526510}
[modify] https://crrev.com/558a66f7e36b9639e5991a80cc5a89817a94231f/content/browser/renderer_host/p2p/socket_host_tcp.cc
[modify] https://crrev.com/558a66f7e36b9639e5991a80cc5a89817a94231f/jingle/BUILD.gn
[modify] https://crrev.com/558a66f7e36b9639e5991a80cc5a89817a94231f/jingle/glue/DEPS
[delete] https://crrev.com/6b6aa45dcb13039f230fa7414aef463d0ecf8c25/jingle/glue/proxy_resolving_client_socket_unittest.cc
[modify] https://crrev.com/558a66f7e36b9639e5991a80cc5a89817a94231f/jingle/glue/xmpp_client_socket_factory.cc
[modify] https://crrev.com/558a66f7e36b9639e5991a80cc5a89817a94231f/remoting/signaling/DEPS
[modify] https://crrev.com/558a66f7e36b9639e5991a80cc5a89817a94231f/remoting/signaling/xmpp_signal_strategy.cc
[modify] https://crrev.com/558a66f7e36b9639e5991a80cc5a89817a94231f/services/network/public/cpp/BUILD.gn
[rename] https://crrev.com/558a66f7e36b9639e5991a80cc5a89817a94231f/services/network/public/cpp/proxy_resolving_client_socket.cc
[rename] https://crrev.com/558a66f7e36b9639e5991a80cc5a89817a94231f/services/network/public/cpp/proxy_resolving_client_socket.h
[add] https://crrev.com/558a66f7e36b9639e5991a80cc5a89817a94231f/services/network/public/cpp/proxy_resolving_client_socket_unittest.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89a75d2786705d9679d3a49667baef5b98f0f1de

commit 89a75d2786705d9679d3a49667baef5b98f0f1de
Author: Helen Li <xunjieli@chromium.org>
Date: Wed Jan 03 15:56:12 2018

Reorder methods in proxy_resolving_client_socket.cc to match header file

This CL reorders methods in proxy_resolving_client_socket.cc to match that in
the header file.

Bug:  721401 
Change-Id: Id9fb467c335e88f2437ce649d1f969109731d22d
Reviewed-on: https://chromium-review.googlesource.com/847286
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526703}
[modify] https://crrev.com/89a75d2786705d9679d3a49667baef5b98f0f1de/services/network/public/cpp/proxy_resolving_client_socket.cc

Comment 14 by xunji...@chromium.org, Jan 11 2018

Blockedon: 801321
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac

commit 8dd1fbe0653f65b714b335559f9f4bbdc06e01ac
Author: Helen Li <xunjieli@chromium.org>
Date: Mon Jan 22 21:48:08 2018

Add UDP socket mojo interface and implementation

This CL patched over Mandoline's UDP part
(https://codereview.chromium.org/1873463003) and made modifications.

Interface definition:
- udp_socket.mojom, which is modeled after udp_socket_posix/win.h
- udp_socket_impl.h/cc, the concrete implementation. It uses a
  net::UDPSocket as the underlying //net socket implementation.

Network Service:
- network_service.mojom is modified to bind a UDPSocketRequest and
  a UDPSocketReceiverPtr with a udp_socket_impl.

Design doc:
https://docs.google.com/document/d/1iQl_Y2o7vykiPXpZiNbKov-WZbUb4RprmXIk311tTso/edit?usp=sharing

Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ibad5ec0e64e5e50ec7ff05305ffd35e1b48878d4
Reviewed-on: https://chromium-review.googlesource.com/796933
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531009}
[modify] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/content/network/BUILD.gn
[modify] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/content/network/network_context.cc
[modify] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/content/network/network_context.h
[modify] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/content/network/network_context_unittest.cc
[modify] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/content/test/BUILD.gn
[modify] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/services/BUILD.gn
[modify] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/services/network/BUILD.gn
[modify] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/services/network/public/interfaces/BUILD.gn
[modify] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/services/network/public/interfaces/network_service.mojom
[add] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/services/network/public/interfaces/udp_socket.mojom
[add] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/services/network/udp_socket.cc
[add] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/services/network/udp_socket.h
[add] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/services/network/udp_socket_factory.cc
[add] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/services/network/udp_socket_factory.h
[add] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/services/network/udp_socket_factory_unittest.cc
[add] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/services/network/udp_socket_test_util.cc
[add] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/services/network/udp_socket_test_util.h
[add] https://crrev.com/8dd1fbe0653f65b714b335559f9f4bbdc06e01ac/services/network/udp_socket_unittest.cc

Comment 16 by xunji...@chromium.org, Jan 29 2018

Blockedon: 806817
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7efd1522e7660cbaf56131689df2007914315f4

commit e7efd1522e7660cbaf56131689df2007914315f4
Author: Helen Li <xunjieli@chromium.org>
Date: Mon Jan 29 19:04:26 2018

Pass through network traffic annotation tag for UDP sockets

All socket writes need to be annotated with traffic annotation tag.
This CL adds this requirement to the API.

Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iee211a7812ba074f2788c879d0bc4b715e178fde
Reviewed-on: https://chromium-review.googlesource.com/881425
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532526}
[modify] https://crrev.com/e7efd1522e7660cbaf56131689df2007914315f4/services/network/BUILD.gn
[modify] https://crrev.com/e7efd1522e7660cbaf56131689df2007914315f4/services/network/public/interfaces/BUILD.gn
[modify] https://crrev.com/e7efd1522e7660cbaf56131689df2007914315f4/services/network/public/interfaces/udp_socket.mojom
[modify] https://crrev.com/e7efd1522e7660cbaf56131689df2007914315f4/services/network/udp_socket.cc
[modify] https://crrev.com/e7efd1522e7660cbaf56131689df2007914315f4/services/network/udp_socket.h
[modify] https://crrev.com/e7efd1522e7660cbaf56131689df2007914315f4/services/network/udp_socket_test_util.cc
[modify] https://crrev.com/e7efd1522e7660cbaf56131689df2007914315f4/services/network/udp_socket_unittest.cc
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6badda9c5437b3f122d30f16bed23c520467ff7

commit a6badda9c5437b3f122d30f16bed23c520467ff7
Author: Helen Li <xunjieli@chromium.org>
Date: Tue Jan 30 18:36:46 2018

Rename address_family_traits.h to address_family_mojom_traits.h

The file is not named correctly. This CL uses the correct name suffix.

Bug:  721401 
Change-Id: I9c0976bc802cee9f3c13141e6edb0b4ba81de97a
Reviewed-on: https://chromium-review.googlesource.com/891440
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532960}
[modify] https://crrev.com/a6badda9c5437b3f122d30f16bed23c520467ff7/net/dns/mojo_host_struct_traits.cc
[modify] https://crrev.com/a6badda9c5437b3f122d30f16bed23c520467ff7/net/interfaces/OWNERS
[modify] https://crrev.com/a6badda9c5437b3f122d30f16bed23c520467ff7/net/interfaces/address_family.typemap
[rename] https://crrev.com/a6badda9c5437b3f122d30f16bed23c520467ff7/net/interfaces/address_family_mojom_traits.cc
[rename] https://crrev.com/a6badda9c5437b3f122d30f16bed23c520467ff7/net/interfaces/address_family_mojom_traits.h
Project Member

Comment 19 by bugdroid1@chromium.org, Feb 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54c9412b35670636de910412ff1df62a4471e984

commit 54c9412b35670636de910412ff1df62a4471e984
Author: Helen Li <xunjieli@chromium.org>
Date: Tue Feb 06 03:54:43 2018

Add Multicast options and setters to udp_socket.mojom

This CL adds Multicast options and setters to udp_socket.mojom.

Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I3d6fd2a1c491caea7ed004a47a2b254e84d2f2c5
Reviewed-on: https://chromium-review.googlesource.com/891447
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534618}
[modify] https://crrev.com/54c9412b35670636de910412ff1df62a4471e984/services/network/network_context_unittest.cc
[modify] https://crrev.com/54c9412b35670636de910412ff1df62a4471e984/services/network/public/interfaces/udp_socket.mojom
[modify] https://crrev.com/54c9412b35670636de910412ff1df62a4471e984/services/network/udp_socket.cc
[modify] https://crrev.com/54c9412b35670636de910412ff1df62a4471e984/services/network/udp_socket.h
[modify] https://crrev.com/54c9412b35670636de910412ff1df62a4471e984/services/network/udp_socket_test_util.cc
[modify] https://crrev.com/54c9412b35670636de910412ff1df62a4471e984/services/network/udp_socket_test_util.h
[modify] https://crrev.com/54c9412b35670636de910412ff1df62a4471e984/services/network/udp_socket_unittest.cc
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67e5bb34a5108ac8c8f05082f69cfba4c2a26e2c

commit 67e5bb34a5108ac8c8f05082f69cfba4c2a26e2c
Author: Helen Li <xunjieli@chromium.org>
Date: Thu Feb 08 22:26:40 2018

Remove UDPSocket::Open() from udp_socket.mojom

To simplify the interface, this CL gets rid of Open().
Additionally:
- SetReceiveBufferSize() and SetSendBufferSize() are moved to UDPSocketOptions.
  No current embedder of net::UDPSocket sets these options after Connect/Bind.
- SetBroadcast() is modified to be only legal after Bind(). Extensions currently
  exposes this functionality in its async API.

Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I333880c5f84bfe88e631ab6384e0d1af3222fd57
Reviewed-on: https://chromium-review.googlesource.com/902122
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535546}
[modify] https://crrev.com/67e5bb34a5108ac8c8f05082f69cfba4c2a26e2c/services/network/network_context_unittest.cc
[modify] https://crrev.com/67e5bb34a5108ac8c8f05082f69cfba4c2a26e2c/services/network/public/interfaces/udp_socket.mojom
[modify] https://crrev.com/67e5bb34a5108ac8c8f05082f69cfba4c2a26e2c/services/network/udp_socket.cc
[modify] https://crrev.com/67e5bb34a5108ac8c8f05082f69cfba4c2a26e2c/services/network/udp_socket.h
[modify] https://crrev.com/67e5bb34a5108ac8c8f05082f69cfba4c2a26e2c/services/network/udp_socket_test_util.cc
[modify] https://crrev.com/67e5bb34a5108ac8c8f05082f69cfba4c2a26e2c/services/network/udp_socket_test_util.h
[modify] https://crrev.com/67e5bb34a5108ac8c8f05082f69cfba4c2a26e2c/services/network/udp_socket_unittest.cc
Project Member

Comment 21 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85d46dae96017abd0c1a8282f4ce1ffe814da2b3

commit 85d46dae96017abd0c1a8282f4ce1ffe814da2b3
Author: Helen Li <xunjieli@chromium.org>
Date: Thu Feb 08 23:39:44 2018

Migrate extensions to using udp_socket.mojom

This CL:
- Migrates extensions' chrome.socket and chrome.sockets.udp APIs from
using net::UDPSocket to using udp_socket.mojom. These involves changing
several extension async function to use AsyncStartWork() and
AsyncWorkComplete() because mojo APIs are async.

- Adds a Close() method on udp_socket.mojom
because chrome.socket API depends on the ability to re-connect a socket
after disconnecting it. See testPendingCallback in
chrome/test/data/extensions/api_test/socket/api/background.js

Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I13c4c902ff05d4596a6657f5872fdf41cdec7a7c
Reviewed-on: https://chromium-review.googlesource.com/904266
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535576}
[modify] https://crrev.com/85d46dae96017abd0c1a8282f4ce1ffe814da2b3/chrome/browser/extensions/api/DEPS
[modify] https://crrev.com/85d46dae96017abd0c1a8282f4ce1ffe814da2b3/chrome/browser/extensions/api/socket/udp_socket_unittest.cc
[modify] https://crrev.com/85d46dae96017abd0c1a8282f4ce1ffe814da2b3/extensions/browser/api/socket/socket.h
[modify] https://crrev.com/85d46dae96017abd0c1a8282f4ce1ffe814da2b3/extensions/browser/api/socket/socket_api.cc
[modify] https://crrev.com/85d46dae96017abd0c1a8282f4ce1ffe814da2b3/extensions/browser/api/socket/socket_api.h
[modify] https://crrev.com/85d46dae96017abd0c1a8282f4ce1ffe814da2b3/extensions/browser/api/socket/tcp_socket.cc
[modify] https://crrev.com/85d46dae96017abd0c1a8282f4ce1ffe814da2b3/extensions/browser/api/socket/tcp_socket.h
[modify] https://crrev.com/85d46dae96017abd0c1a8282f4ce1ffe814da2b3/extensions/browser/api/socket/udp_socket.cc
[modify] https://crrev.com/85d46dae96017abd0c1a8282f4ce1ffe814da2b3/extensions/browser/api/socket/udp_socket.h
[modify] https://crrev.com/85d46dae96017abd0c1a8282f4ce1ffe814da2b3/extensions/browser/api/sockets_udp/sockets_udp_api.cc
[modify] https://crrev.com/85d46dae96017abd0c1a8282f4ce1ffe814da2b3/extensions/browser/api/sockets_udp/sockets_udp_api.h
[modify] https://crrev.com/85d46dae96017abd0c1a8282f4ce1ffe814da2b3/services/network/public/interfaces/udp_socket.mojom
[modify] https://crrev.com/85d46dae96017abd0c1a8282f4ce1ffe814da2b3/services/network/udp_socket.cc
[modify] https://crrev.com/85d46dae96017abd0c1a8282f4ce1ffe814da2b3/services/network/udp_socket.h
[modify] https://crrev.com/85d46dae96017abd0c1a8282f4ce1ffe814da2b3/services/network/udp_socket_unittest.cc
Project Member

Comment 22 by bugdroid1@chromium.org, Feb 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fcad09d4a17b65c16ac2c0b71b3b0b29132935f

commit 6fcad09d4a17b65c16ac2c0b71b3b0b29132935f
Author: Helen Li <xunjieli@chromium.org>
Date: Fri Feb 09 00:44:16 2018

Move net.interfaces.AddressList into its own file

This CL moves net.interfaces.AddressList into its own file so it can be used
by the new TCP socket mojo interface.

Bug:  721401 
Change-Id: I71d0a33e85b403a434eff455cb4cc76e668396ea
Reviewed-on: https://chromium-review.googlesource.com/908970
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535596}
[modify] https://crrev.com/6fcad09d4a17b65c16ac2c0b71b3b0b29132935f/net/dns/mojo_host_struct_traits.cc
[modify] https://crrev.com/6fcad09d4a17b65c16ac2c0b71b3b0b29132935f/net/dns/mojo_host_struct_traits.h
[modify] https://crrev.com/6fcad09d4a17b65c16ac2c0b71b3b0b29132935f/net/interfaces/BUILD.gn
[add] https://crrev.com/6fcad09d4a17b65c16ac2c0b71b3b0b29132935f/net/interfaces/address_list.mojom
[add] https://crrev.com/6fcad09d4a17b65c16ac2c0b71b3b0b29132935f/net/interfaces/address_list.typemap
[add] https://crrev.com/6fcad09d4a17b65c16ac2c0b71b3b0b29132935f/net/interfaces/address_list_mojom_traits.cc
[add] https://crrev.com/6fcad09d4a17b65c16ac2c0b71b3b0b29132935f/net/interfaces/address_list_mojom_traits.h
[modify] https://crrev.com/6fcad09d4a17b65c16ac2c0b71b3b0b29132935f/net/interfaces/host_resolver.typemap
[modify] https://crrev.com/6fcad09d4a17b65c16ac2c0b71b3b0b29132935f/net/interfaces/host_resolver_service.mojom
[modify] https://crrev.com/6fcad09d4a17b65c16ac2c0b71b3b0b29132935f/net/interfaces/typemaps.gni

Comment 23 by xunji...@chromium.org, Feb 12 2018

Blockedon: 811497

Comment 24 by rdsmith@chromium.org, Feb 16 2018

Cc: -rdsmith@chromium.org

Comment 25 by xunji...@chromium.org, Feb 26 2018

Blockedon: 816634

Comment 26 by xunji...@chromium.org, Feb 27 2018

Blockedon: 817094
Project Member

Comment 27 by bugdroid1@chromium.org, Mar 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589

commit f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589
Author: Helen Li <xunjieli@chromium.org>
Date: Mon Mar 12 21:32:55 2018

Add TCP socket API to network service

This CL adds TCP socket API to network service.
This is partly based on mandoline implementation
(https://codereview.chromium.org/1873463003/)

Two TCP socket interfaces are added.
- TCPConnectedSocket
- TCPServerSocket

TBR=miu@chromium.org

Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I56e2702c02b9c86a72eba68c85391c3b017a4d64
Reviewed-on: https://chromium-review.googlesource.com/868711
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542606}
[modify] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/media/cast/net/udp_socket_client_unittest.cc
[modify] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/services/network/BUILD.gn
[modify] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/services/network/network_context.cc
[modify] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/services/network/network_context.h
[modify] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/services/network/public/mojom/BUILD.gn
[modify] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/services/network/public/mojom/network_service.mojom
[add] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/services/network/public/mojom/tcp_socket.mojom
[add] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/services/network/socket_factory.cc
[add] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/services/network/socket_factory.h
[add] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/services/network/tcp_connected_socket.cc
[add] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/services/network/tcp_connected_socket.h
[add] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/services/network/tcp_server_socket.cc
[add] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/services/network/tcp_server_socket.h
[add] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/services/network/udp_socket.cc
[modify] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/services/network/udp_socket.h
[delete] https://crrev.com/ffc26d979f5e1b236278ab23f5f9e9c32a0ae9bb/services/network/udp_socket_factory.cc
[delete] https://crrev.com/ffc26d979f5e1b236278ab23f5f9e9c32a0ae9bb/services/network/udp_socket_factory.h
[delete] https://crrev.com/ffc26d979f5e1b236278ab23f5f9e9c32a0ae9bb/services/network/udp_socket_factory_unittest.cc
[modify] https://crrev.com/f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589/services/network/udp_socket_unittest.cc
Project Member

Comment 28 by bugdroid1@chromium.org, Mar 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc

commit 32c4f747a52a8dc6e91ca384f15c640d6fabbbcc
Author: Trent Apted <tapted@chromium.org>
Date: Tue Mar 13 02:17:04 2018

Revert "Add TCP socket API to network service"

This reverts commit f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589.

Reason for revert: causes TCPSocketTest.ReadAndWriteMultiple to flake (timeout)

Bug:  821232 

Original change's description:
> Add TCP socket API to network service
> 
> This CL adds TCP socket API to network service.
> This is partly based on mandoline implementation
> (https://codereview.chromium.org/1873463003/)
> 
> Two TCP socket interfaces are added.
> - TCPConnectedSocket
> - TCPServerSocket
> 
> TBR=miu@chromium.org
> 
> Bug:  721401 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I56e2702c02b9c86a72eba68c85391c3b017a4d64
> Reviewed-on: https://chromium-review.googlesource.com/868711
> Reviewed-by: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542606}

TBR=miu@chromium.org,mmenke@chromium.org,tsepez@chromium.org,xunjieli@chromium.org,rhalavati@chromium.org

Change-Id: Id31caa2f5cc54993735586555e68bd3c345600bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/958943
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542696}
[modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/media/cast/net/udp_socket_client_unittest.cc
[modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/BUILD.gn
[modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/network_context.cc
[modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/network_context.h
[modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/public/mojom/BUILD.gn
[modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/public/mojom/network_service.mojom
[delete] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/services/network/public/mojom/tcp_socket.mojom
[delete] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/services/network/socket_factory.cc
[delete] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/services/network/socket_factory.h
[delete] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/services/network/tcp_connected_socket.cc
[delete] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/services/network/tcp_connected_socket.h
[delete] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/services/network/tcp_server_socket.cc
[delete] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/services/network/tcp_server_socket.h
[delete] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/udp_socket.cc
[modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/udp_socket.h
[add] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/udp_socket_factory.cc
[add] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/udp_socket_factory.h
[add] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/udp_socket_factory_unittest.cc
[modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/udp_socket_unittest.cc
Project Member

Comment 29 by bugdroid1@chromium.org, Mar 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8cf1a861b668acb63e6616a136268b3aa907d6d

commit a8cf1a861b668acb63e6616a136268b3aa907d6d
Author: Helen Li <xunjieli@chromium.org>
Date: Wed Mar 14 13:27:42 2018

Reland: Add TCP socket API to network service

This CL adds TCP socket API to network service.
This is partly based on mandoline implementation
(https://codereview.chromium.org/1873463003/)

Two TCP socket interfaces are added.
- TCPConnectedSocket
- TCPServerSocket

Change in reland:
- adds logging to TCPSocketTest.ReadAndWriteMultiple to investigate
  the test timeout observed in  crbug.com/821232 
- Modifies TestServer slightly to own all client connections instead
  of only the latest one.

R=mmenke@chromium.org
TBR=miu@chromium.org
TBR=tsepez@chromium.org

Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I0426a7aeda30cce7a2a1e84afae5208958dc4a10
Reviewed-on: https://chromium-review.googlesource.com/960250
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543064}
[modify] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/media/cast/net/udp_socket_client_unittest.cc
[modify] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/services/network/BUILD.gn
[modify] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/services/network/network_context.cc
[modify] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/services/network/network_context.h
[modify] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/services/network/public/mojom/BUILD.gn
[modify] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/services/network/public/mojom/network_service.mojom
[add] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/services/network/public/mojom/tcp_socket.mojom
[add] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/services/network/socket_factory.cc
[add] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/services/network/socket_factory.h
[add] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/services/network/tcp_connected_socket.cc
[add] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/services/network/tcp_connected_socket.h
[add] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/services/network/tcp_server_socket.cc
[add] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/services/network/tcp_server_socket.h
[add] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/services/network/udp_socket.cc
[modify] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/services/network/udp_socket.h
[delete] https://crrev.com/c38b35ae6888784582324d3f2860377f1068ca18/services/network/udp_socket_factory.cc
[delete] https://crrev.com/c38b35ae6888784582324d3f2860377f1068ca18/services/network/udp_socket_factory.h
[delete] https://crrev.com/c38b35ae6888784582324d3f2860377f1068ca18/services/network/udp_socket_factory_unittest.cc
[modify] https://crrev.com/a8cf1a861b668acb63e6616a136268b3aa907d6d/services/network/udp_socket_unittest.cc
Project Member

Comment 30 by bugdroid1@chromium.org, Mar 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94

commit d27e71f2fea189d519f1b24dda0aa55d1c1b3c94
Author: Caleb Rouleau <crouleau@chromium.org>
Date: Wed Mar 14 23:45:51 2018

Revert "Reland: Add TCP socket API to network service"

This reverts commit a8cf1a861b668acb63e6616a136268b3aa907d6d.

Reason for revert: added faking test case TCPSocketTest.ReadAndWriteMultiple

BUG:  822058 

Original change's description:
> Reland: Add TCP socket API to network service
> 
> This CL adds TCP socket API to network service.
> This is partly based on mandoline implementation
> (https://codereview.chromium.org/1873463003/)
> 
> Two TCP socket interfaces are added.
> - TCPConnectedSocket
> - TCPServerSocket
> 
> Change in reland:
> - adds logging to TCPSocketTest.ReadAndWriteMultiple to investigate
>   the test timeout observed in  crbug.com/821232 
> - Modifies TestServer slightly to own all client connections instead
>   of only the latest one.
> 
> R=​mmenke@chromium.org
> TBR=miu@chromium.org
> TBR=tsepez@chromium.org
> 
> Bug:  721401 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I0426a7aeda30cce7a2a1e84afae5208958dc4a10
> Reviewed-on: https://chromium-review.googlesource.com/960250
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543064}

TBR=miu@chromium.org,mmenke@chromium.org,tsepez@chromium.org,xunjieli@chromium.org

Change-Id: I078642396307e5eb20853a12596d931e0bb30d88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/963667
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543239}
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/media/cast/net/udp_socket_client_unittest.cc
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/BUILD.gn
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/network_context.cc
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/network_context.h
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/public/mojom/BUILD.gn
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/public/mojom/network_service.mojom
[delete] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/services/network/public/mojom/tcp_socket.mojom
[delete] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/services/network/socket_factory.cc
[delete] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/services/network/socket_factory.h
[delete] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/services/network/tcp_connected_socket.cc
[delete] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/services/network/tcp_connected_socket.h
[delete] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/services/network/tcp_server_socket.cc
[delete] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/services/network/tcp_server_socket.h
[delete] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/udp_socket.cc
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/udp_socket.h
[add] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/udp_socket_factory.cc
[add] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/udp_socket_factory.h
[add] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/udp_socket_factory_unittest.cc
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/udp_socket_unittest.cc
Project Member

Comment 31 by bugdroid1@chromium.org, Mar 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d867246f9c673d3ee39130eac6c7a5fe0dab6575

commit d867246f9c673d3ee39130eac6c7a5fe0dab6575
Author: Helen Li <xunjieli@chromium.org>
Date: Thu Mar 15 16:10:12 2018

Reland: Add TCP socket API to network service

This CL adds TCP socket API to network service.
This is partly based on mandoline implementation
(https://codereview.chromium.org/1873463003/)

Two TCP socket interfaces are added.
- TCPConnectedSocket
- TCPServerSocket

Change in reland:
- Removes TCPSocketTest.ReadAndWriteMultiple because
  base::RunLoop().RunUntilIdle(), when used in conjunction with the rest of the
  test logic, times out sometimes on iOS bot. We have a better
  version of this test (ReadAndWriteMultipleWithMockClientSocket) written using
  mock sockets. See  crbug.com/822058 

R=mmenke@chromium.org
TBR=miu@chromium.org
TBR=tsepez@chromium.org

Bug:  721401 ,  822058 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I71cde7f2a16d022e888d62a6fec3d4fd5917b6e9
Reviewed-on: https://chromium-review.googlesource.com/964250
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543381}
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/media/cast/net/udp_socket_client_unittest.cc
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/BUILD.gn
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/network_context.cc
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/network_context.h
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/public/mojom/BUILD.gn
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/public/mojom/network_service.mojom
[add] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/public/mojom/tcp_socket.mojom
[add] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/socket_factory.cc
[add] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/socket_factory.h
[add] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/tcp_connected_socket.cc
[add] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/tcp_connected_socket.h
[add] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/tcp_server_socket.cc
[add] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/tcp_server_socket.h
[add] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/udp_socket.cc
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/udp_socket.h
[delete] https://crrev.com/ef8a99cba301276aa64d628cd683be9c142e6335/services/network/udp_socket_factory.cc
[delete] https://crrev.com/ef8a99cba301276aa64d628cd683be9c142e6335/services/network/udp_socket_factory.h
[delete] https://crrev.com/ef8a99cba301276aa64d628cd683be9c142e6335/services/network/udp_socket_factory_unittest.cc
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/udp_socket_unittest.cc
Project Member

Comment 32 by bugdroid1@chromium.org, Mar 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/117666127deaca48d669a03ad3ed65a2e746a99e

commit 117666127deaca48d669a03ad3ed65a2e746a99e
Author: Helen Li <xunjieli@chromium.org>
Date: Fri Mar 16 20:32:15 2018

Move a few mojo types out of url_loader.mojom so they can be shared.

This CL moves a few mojo types out of url_loader.mojom so they can be shared
(e.g. with the new tls socket APIs).

Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ie613dc08b32eb0541ef43137dee1ac4f515cc078
Reviewed-on: https://chromium-review.googlesource.com/962991
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543810}
[modify] https://crrev.com/117666127deaca48d669a03ad3ed65a2e746a99e/services/network/public/cpp/network_param.typemap
[modify] https://crrev.com/117666127deaca48d669a03ad3ed65a2e746a99e/services/network/public/mojom/BUILD.gn
[add] https://crrev.com/117666127deaca48d669a03ad3ed65a2e746a99e/services/network/public/mojom/network_param.mojom
[modify] https://crrev.com/117666127deaca48d669a03ad3ed65a2e746a99e/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/117666127deaca48d669a03ad3ed65a2e746a99e/services/network/public/mojom/network_service_test.mojom
[modify] https://crrev.com/117666127deaca48d669a03ad3ed65a2e746a99e/services/network/public/mojom/url_loader.mojom
Project Member

Comment 33 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f021980c40ac8a5e912654dd4560d667be1c66ef

commit f021980c40ac8a5e912654dd4560d667be1c66ef
Author: Helen Li <xunjieli@chromium.org>
Date: Tue Mar 27 13:30:37 2018

Make TCPConnectedSocketObserver an optional param

There are users of TCP socket APIs who do not care about the specific read/write
errors. One example is net::HttpServer.
This CL makes the observer param optional.

Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I028a01b6b8e3dea87a3865b704cc15347a3f2793
Reviewed-on: https://chromium-review.googlesource.com/978033
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546095}
[modify] https://crrev.com/f021980c40ac8a5e912654dd4560d667be1c66ef/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/f021980c40ac8a5e912654dd4560d667be1c66ef/services/network/public/mojom/tcp_socket.mojom
[modify] https://crrev.com/f021980c40ac8a5e912654dd4560d667be1c66ef/services/network/tcp_connected_socket.cc
[modify] https://crrev.com/f021980c40ac8a5e912654dd4560d667be1c66ef/services/network/tcp_socket_unittest.cc
Project Member

Comment 34 by bugdroid1@chromium.org, Apr 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53553a99d99fc81127faf1783dde1d63197da78b

commit 53553a99d99fc81127faf1783dde1d63197da78b
Author: Helen Li <xunjieli@chromium.org>
Date: Wed Apr 11 02:16:59 2018

Add a net::TransportClientSocket class

This CL adds a net::TransportClientSocket so that we can have an interface
to expose socket Bind() method.

This CL changes the following:
- socket_test_util.cc
  Changes MockClientSocket to subclass this new net::TransportClientSocket
  class instead of net::SSLClientSocket. This new class hierarchy is more
  intuitive because not all client sockets are ssl socket.
- client_socket_factory.cc
  Makes CreateTransportClientSocket() returns a net::TransportClientSocket
  instead of a StreamSocket.
- services/network/*
  Makes network::SocketFactory take in a net::ClientSocketFactory.
- cast_socket.cc/h and cast_socket_unittest.cc.


Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ie258114565e76529555e244364be421e66637960
Reviewed-on: https://chromium-review.googlesource.com/995554
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549731}
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/components/cast_channel/cast_socket.cc
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/components/cast_channel/cast_socket.h
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/components/cast_channel/cast_socket_unittest.cc
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/net/BUILD.gn
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/net/dns/address_sorter_posix_unittest.cc
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/net/dns/dns_session_unittest.cc
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/net/socket/client_socket_factory.cc
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/net/socket/client_socket_factory.h
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/net/socket/client_socket_pool_base_unittest.cc
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/net/socket/fuzzed_socket.cc
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/net/socket/fuzzed_socket.h
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/net/socket/fuzzed_socket_factory.cc
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/net/socket/fuzzed_socket_factory.h
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/net/socket/socket_test_util.cc
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/net/socket/socket_test_util.h
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/net/socket/tcp_client_socket.h
[add] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/net/socket/transport_client_socket.h
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/net/socket/transport_client_socket_pool_test_util.cc
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/net/socket/transport_client_socket_pool_test_util.h
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/services/network/network_context.cc
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/services/network/network_context.h
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/services/network/socket_factory.cc
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/services/network/socket_factory.h
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/services/network/tcp_connected_socket.cc
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/services/network/tcp_connected_socket.h
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/53553a99d99fc81127faf1783dde1d63197da78b/services/network/udp_socket_unittest.cc
Project Member

Comment 35 by bugdroid1@chromium.org, Apr 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3292d8d82fc7638f83d0d694e5b332220857a3d5

commit 3292d8d82fc7638f83d0d694e5b332220857a3d5
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Wed Apr 11 06:00:01 2018

Revert "Add a net::TransportClientSocket class"

This reverts commit 53553a99d99fc81127faf1783dde1d63197da78b.

Reason for revert: This makes unit_tests failed on many bots.

Original change's description:
> Add a net::TransportClientSocket class
> 
> This CL adds a net::TransportClientSocket so that we can have an interface
> to expose socket Bind() method.
> 
> This CL changes the following:
> - socket_test_util.cc
>   Changes MockClientSocket to subclass this new net::TransportClientSocket
>   class instead of net::SSLClientSocket. This new class hierarchy is more
>   intuitive because not all client sockets are ssl socket.
> - client_socket_factory.cc
>   Makes CreateTransportClientSocket() returns a net::TransportClientSocket
>   instead of a StreamSocket.
> - services/network/*
>   Makes network::SocketFactory take in a net::ClientSocketFactory.
> - cast_socket.cc/h and cast_socket_unittest.cc.
> 
> 
> Bug:  721401 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Ie258114565e76529555e244364be421e66637960
> Reviewed-on: https://chromium-review.googlesource.com/995554
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Derek Cheng <imcheng@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549731}

TBR=mmenke@chromium.org,xunjieli@chromium.org,imcheng@chromium.org

Change-Id: If5aea44dc8671f126baf23fab2d4768cc2458fd9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  831477 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1006298
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549789}
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/components/cast_channel/cast_socket.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/components/cast_channel/cast_socket.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/components/cast_channel/cast_socket_unittest.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/BUILD.gn
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/dns/address_sorter_posix_unittest.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/dns/dns_session_unittest.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/client_socket_factory.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/client_socket_factory.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/client_socket_pool_base_unittest.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/fuzzed_socket.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/fuzzed_socket.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/fuzzed_socket_factory.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/fuzzed_socket_factory.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/socket_test_util.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/socket_test_util.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/tcp_client_socket.h
[delete] https://crrev.com/8d2045c2dcc6e89ba3aaa7c70d0662a06d1191e1/net/socket/transport_client_socket.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/transport_client_socket_pool_test_util.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/transport_client_socket_pool_test_util.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/services/network/network_context.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/services/network/network_context.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/services/network/socket_factory.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/services/network/socket_factory.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/services/network/tcp_connected_socket.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/services/network/tcp_connected_socket.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/services/network/udp_socket_unittest.cc
Project Member

Comment 36 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5bb9221e75948e1527179b9629c633d5925fd96

commit d5bb9221e75948e1527179b9629c633d5925fd96
Author: Helen Li <xunjieli@chromium.org>
Date: Thu Apr 12 15:33:09 2018

Reland "Add a net::TransportClientSocket class"

This is a reland of 53553a99d99fc81127faf1783dde1d63197da78b

Original change's description:
> Add a net::TransportClientSocket class
>
> This CL adds a net::TransportClientSocket so that we can have an interface
> to expose socket Bind() method.
>
> This CL changes the following:
> - socket_test_util.cc
>   Changes MockClientSocket to subclass this new net::TransportClientSocket
>   class instead of net::SSLClientSocket. This new class hierarchy is more
>   intuitive because not all client sockets are ssl socket.
> - client_socket_factory.cc
>   Makes CreateTransportClientSocket() returns a net::TransportClientSocket
>   instead of a StreamSocket.
> - services/network/*
>   Makes network::SocketFactory take in a net::ClientSocketFactory.
> - cast_socket.cc/h and cast_socket_unittest.cc.
>
>
> Bug:  721401 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Ie258114565e76529555e244364be421e66637960
> Reviewed-on: https://chromium-review.googlesource.com/995554
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Derek Cheng <imcheng@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549731}

TBR=imcheng@chromium.org

Bug:  721401 
Change-Id: I93fb736881be6554bdaf17359b881370be1d7fea
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1007034
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550210}
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/components/cast_channel/cast_socket.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/components/cast_channel/cast_socket.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/components/cast_channel/cast_socket_unittest.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/BUILD.gn
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/dns/address_sorter_posix_unittest.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/dns/dns_session_unittest.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/client_socket_factory.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/client_socket_factory.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/client_socket_pool_base_unittest.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/fuzzed_socket.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/fuzzed_socket.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/fuzzed_socket_factory.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/fuzzed_socket_factory.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/socket_test_util.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/socket_test_util.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/tcp_client_socket.h
[add] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/transport_client_socket.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/transport_client_socket_pool_test_util.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/transport_client_socket_pool_test_util.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/services/network/network_context.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/services/network/network_context.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/services/network/socket_factory.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/services/network/socket_factory.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/services/network/tcp_connected_socket.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/services/network/tcp_connected_socket.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/services/network/udp_socket_unittest.cc
Project Member

Comment 37 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5bb9221e75948e1527179b9629c633d5925fd96

commit d5bb9221e75948e1527179b9629c633d5925fd96
Author: Helen Li <xunjieli@chromium.org>
Date: Thu Apr 12 15:33:09 2018

Reland "Add a net::TransportClientSocket class"

This is a reland of 53553a99d99fc81127faf1783dde1d63197da78b

Original change's description:
> Add a net::TransportClientSocket class
>
> This CL adds a net::TransportClientSocket so that we can have an interface
> to expose socket Bind() method.
>
> This CL changes the following:
> - socket_test_util.cc
>   Changes MockClientSocket to subclass this new net::TransportClientSocket
>   class instead of net::SSLClientSocket. This new class hierarchy is more
>   intuitive because not all client sockets are ssl socket.
> - client_socket_factory.cc
>   Makes CreateTransportClientSocket() returns a net::TransportClientSocket
>   instead of a StreamSocket.
> - services/network/*
>   Makes network::SocketFactory take in a net::ClientSocketFactory.
> - cast_socket.cc/h and cast_socket_unittest.cc.
>
>
> Bug:  721401 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Ie258114565e76529555e244364be421e66637960
> Reviewed-on: https://chromium-review.googlesource.com/995554
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Derek Cheng <imcheng@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549731}

TBR=imcheng@chromium.org

Bug:  721401 
Change-Id: I93fb736881be6554bdaf17359b881370be1d7fea
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1007034
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550210}
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/components/cast_channel/cast_socket.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/components/cast_channel/cast_socket.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/components/cast_channel/cast_socket_unittest.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/BUILD.gn
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/dns/address_sorter_posix_unittest.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/dns/dns_session_unittest.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/client_socket_factory.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/client_socket_factory.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/client_socket_pool_base_unittest.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/fuzzed_socket.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/fuzzed_socket.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/fuzzed_socket_factory.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/fuzzed_socket_factory.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/socket_test_util.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/socket_test_util.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/tcp_client_socket.h
[add] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/transport_client_socket.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/transport_client_socket_pool_test_util.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/net/socket/transport_client_socket_pool_test_util.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/services/network/network_context.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/services/network/network_context.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/services/network/socket_factory.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/services/network/socket_factory.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/services/network/tcp_connected_socket.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/services/network/tcp_connected_socket.h
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/d5bb9221e75948e1527179b9629c633d5925fd96/services/network/udp_socket_unittest.cc
Project Member

Comment 38 by bugdroid1@chromium.org, Apr 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17c77ccb593beabff75d207213d1b31b7e369f56

commit 17c77ccb593beabff75d207213d1b31b7e369f56
Author: Helen Li <xunjieli@chromium.org>
Date: Thu Apr 19 21:29:18 2018

Move writing/reading logic out of tcp_connected_socket.cc into a separate class

This CL moves writing/reading logic out of tcp_connected_socket.cc into a
separate class, socket_data_pump.h/cc. This separate class will be re-used by
tls socket implementation.

Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5d5b723d52c10a653f06b0f6e8eed9fb5b895899
Reviewed-on: https://chromium-review.googlesource.com/1005535
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552163}
[modify] https://crrev.com/17c77ccb593beabff75d207213d1b31b7e369f56/services/network/BUILD.gn
[add] https://crrev.com/17c77ccb593beabff75d207213d1b31b7e369f56/services/network/socket_data_pump.cc
[add] https://crrev.com/17c77ccb593beabff75d207213d1b31b7e369f56/services/network/socket_data_pump.h
[add] https://crrev.com/17c77ccb593beabff75d207213d1b31b7e369f56/services/network/socket_data_pump_unittest.cc
[modify] https://crrev.com/17c77ccb593beabff75d207213d1b31b7e369f56/services/network/tcp_connected_socket.cc
[modify] https://crrev.com/17c77ccb593beabff75d207213d1b31b7e369f56/services/network/tcp_connected_socket.h
Project Member

Comment 39 by bugdroid1@chromium.org, May 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60

commit 2f1216f9f52fbca0bc8bc941e81ebd12321d2b60
Author: Helen Li <xunjieli@chromium.org>
Date: Mon May 07 23:20:38 2018

[network service] Add an API to upgrade a TCP socket to a TLS socket

This CL:
- Adds an UpgradeToTLS() API to mojom::TCPConnectedSocket, so consumers of
  mojom::TCPConnectedSocket can perform TLS connect on top of an already
  connected tcp client socket.
- Adds a tls_socket.mojom file which includes the interface definition of
  TLSClientSocket.

Other changes to support implementing UpgradeToTLS():
- Uses net::StreamSocket::ReadIfReady() instead of net::StreamSocket::Read() in
  socket_data_pump.h/cc. Using ReadIfReady() allows us to cancel the receive
  side in preparation for UpgradeToTLS() without worrying that data might be
  buffered by the tcp socket.
- Adds a net::Socket::CancelReadIfReady(), so we can tell the underlying tcp
  socket to cancel a pending ReadIfReady() and unregister their event watchers.

Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic23fc782f6e701e6b7a9f60ac2ddfeccc6031744
Reviewed-on: https://chromium-review.googlesource.com/1034080
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556605}
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/net/socket/socket.cc
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/net/socket/socket.h
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/net/socket/socket_posix.cc
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/net/socket/socket_posix.h
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/net/socket/socket_test_util.cc
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/net/socket/socket_test_util.h
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/net/socket/tcp_client_socket.cc
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/net/socket/tcp_client_socket.h
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/net/socket/tcp_socket_posix.cc
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/net/socket/tcp_socket_posix.h
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/net/socket/tcp_socket_unittest.cc
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/net/socket/tcp_socket_win.cc
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/net/socket/tcp_socket_win.h
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/BUILD.gn
[add] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/mojo_socket_test_util.cc
[add] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/mojo_socket_test_util.h
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/network_context.cc
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/network_context.h
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/public/mojom/BUILD.gn
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/public/mojom/tcp_socket.mojom
[add] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/public/mojom/tls_socket.mojom
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/socket_data_pump.cc
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/socket_data_pump.h
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/socket_data_pump_unittest.cc
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/socket_factory.cc
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/socket_factory.h
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/tcp_connected_socket.cc
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/tcp_connected_socket.h
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/tcp_server_socket.cc
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/tcp_server_socket.h
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/test/test_network_context.h
[add] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/tls_client_socket.cc
[add] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/tls_client_socket.h
[add] https://crrev.com/2f1216f9f52fbca0bc8bc941e81ebd12321d2b60/services/network/tls_client_socket_unittest.cc
Project Member

Comment 40 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7d6c93d3852fd261369392eb1e8898725a050b5

commit e7d6c93d3852fd261369392eb1e8898725a050b5
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue May 08 05:48:26 2018

Revert "[network service] Add an API to upgrade a TCP socket to a TLS socket"

This reverts commit 2f1216f9f52fbca0bc8bc941e81ebd12321d2b60.

Reason for revert: Caused use-of-uninitialized-value in Linux MSan Tests bot.
https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20MSan%20Tests/9657

Looks like client_socket_factory_ is not initialized?

Original change's description:
> [network service] Add an API to upgrade a TCP socket to a TLS socket
> 
> This CL:
> - Adds an UpgradeToTLS() API to mojom::TCPConnectedSocket, so consumers of
>   mojom::TCPConnectedSocket can perform TLS connect on top of an already
>   connected tcp client socket.
> - Adds a tls_socket.mojom file which includes the interface definition of
>   TLSClientSocket.
> 
> Other changes to support implementing UpgradeToTLS():
> - Uses net::StreamSocket::ReadIfReady() instead of net::StreamSocket::Read() in
>   socket_data_pump.h/cc. Using ReadIfReady() allows us to cancel the receive
>   side in preparation for UpgradeToTLS() without worrying that data might be
>   buffered by the tcp socket.
> - Adds a net::Socket::CancelReadIfReady(), so we can tell the underlying tcp
>   socket to cancel a pending ReadIfReady() and unregister their event watchers.
> 
> Bug:  721401 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Ic23fc782f6e701e6b7a9f60ac2ddfeccc6031744
> Reviewed-on: https://chromium-review.googlesource.com/1034080
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556605}

TBR=mmenke@chromium.org,tsepez@chromium.org,xunjieli@chromium.org

Change-Id: Iaa5ad743e7cdf90239675cef6f34457ea8b5be8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1049206
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556702}
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/net/socket/socket.cc
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/net/socket/socket.h
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/net/socket/socket_posix.cc
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/net/socket/socket_posix.h
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/net/socket/socket_test_util.cc
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/net/socket/socket_test_util.h
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/net/socket/tcp_client_socket.cc
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/net/socket/tcp_client_socket.h
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/net/socket/tcp_socket_posix.cc
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/net/socket/tcp_socket_posix.h
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/net/socket/tcp_socket_unittest.cc
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/net/socket/tcp_socket_win.cc
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/net/socket/tcp_socket_win.h
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/BUILD.gn
[delete] https://crrev.com/44e5e78d3c1393bc3d2caaefa0e7653d09804103/services/network/mojo_socket_test_util.cc
[delete] https://crrev.com/44e5e78d3c1393bc3d2caaefa0e7653d09804103/services/network/mojo_socket_test_util.h
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/network_context.cc
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/network_context.h
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/public/mojom/BUILD.gn
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/public/mojom/tcp_socket.mojom
[delete] https://crrev.com/44e5e78d3c1393bc3d2caaefa0e7653d09804103/services/network/public/mojom/tls_socket.mojom
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/socket_data_pump.cc
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/socket_data_pump.h
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/socket_data_pump_unittest.cc
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/socket_factory.cc
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/socket_factory.h
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/tcp_connected_socket.cc
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/tcp_connected_socket.h
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/tcp_server_socket.cc
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/tcp_server_socket.h
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/e7d6c93d3852fd261369392eb1e8898725a050b5/services/network/test/test_network_context.h
[delete] https://crrev.com/44e5e78d3c1393bc3d2caaefa0e7653d09804103/services/network/tls_client_socket.cc
[delete] https://crrev.com/44e5e78d3c1393bc3d2caaefa0e7653d09804103/services/network/tls_client_socket.h
[delete] https://crrev.com/44e5e78d3c1393bc3d2caaefa0e7653d09804103/services/network/tls_client_socket_unittest.cc
Project Member

Comment 41 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3

commit a6d3b2c20dd8ab040c9a002b50511171ad74a8d3
Author: Helen Li <xunjieli@chromium.org>
Date: Tue May 08 16:09:07 2018

Reland "[network service] Add an API to upgrade a TCP socket to a TLS socket"

This is a reland of 2f1216f9f52fbca0bc8bc941e81ebd12321d2b60

The previous patch is reverted because of an use-before-initialize member.
Diff between PS#1 and PS#2 is the fix.

TBR=mmenke@chromium.org
TBR=tsepez@chromium.org

Original change's description:
> [network service] Add an API to upgrade a TCP socket to a TLS socket
>
> This CL:
> - Adds an UpgradeToTLS() API to mojom::TCPConnectedSocket, so consumers of
>   mojom::TCPConnectedSocket can perform TLS connect on top of an already
>   connected tcp client socket.
> - Adds a tls_socket.mojom file which includes the interface definition of
>   TLSClientSocket.
>
> Other changes to support implementing UpgradeToTLS():
> - Uses net::StreamSocket::ReadIfReady() instead of net::StreamSocket::Read() in
>   socket_data_pump.h/cc. Using ReadIfReady() allows us to cancel the receive
>   side in preparation for UpgradeToTLS() without worrying that data might be
>   buffered by the tcp socket.
> - Adds a net::Socket::CancelReadIfReady(), so we can tell the underlying tcp
>   socket to cancel a pending ReadIfReady() and unregister their event watchers.
>
> Bug:  721401 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Ic23fc782f6e701e6b7a9f60ac2ddfeccc6031744
> Reviewed-on: https://chromium-review.googlesource.com/1034080
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556605}

Bug:  721401 
Change-Id: Ifcde7839e0a64e4ae055be51a98ed1f75a662771
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1050025
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556813}
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/net/socket/socket.cc
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/net/socket/socket.h
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/net/socket/socket_posix.cc
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/net/socket/socket_posix.h
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/net/socket/socket_test_util.cc
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/net/socket/socket_test_util.h
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/net/socket/tcp_client_socket.cc
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/net/socket/tcp_client_socket.h
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/net/socket/tcp_socket_posix.cc
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/net/socket/tcp_socket_posix.h
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/net/socket/tcp_socket_unittest.cc
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/net/socket/tcp_socket_win.cc
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/net/socket/tcp_socket_win.h
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/BUILD.gn
[add] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/mojo_socket_test_util.cc
[add] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/mojo_socket_test_util.h
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/network_context.cc
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/network_context.h
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/public/mojom/BUILD.gn
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/public/mojom/tcp_socket.mojom
[add] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/public/mojom/tls_socket.mojom
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/socket_data_pump.cc
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/socket_data_pump.h
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/socket_data_pump_unittest.cc
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/socket_factory.cc
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/socket_factory.h
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/tcp_connected_socket.cc
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/tcp_connected_socket.h
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/tcp_server_socket.cc
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/tcp_server_socket.h
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/test/test_network_context.h
[add] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/tls_client_socket.cc
[add] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/tls_client_socket.h
[add] https://crrev.com/a6d3b2c20dd8ab040c9a002b50511171ad74a8d3/services/network/tls_client_socket_unittest.cc

Comment 42 by xunji...@chromium.org, May 9 2018

Blockedon: 840797
Project Member

Comment 43 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7fe4743e85827cbab53f1e3f4556c23f61826ad

commit a7fe4743e85827cbab53f1e3f4556c23f61826ad
Author: Helen Li <xunjieli@chromium.org>
Date: Fri May 11 14:29:10 2018

Fix network::TCPServerSocket to error out when GetLocalAddress() fails

This CL fixes the case where network::TCPServerSocket::Listen() fails to catch
the error from net::ServerSocket::GetLocalAddress().

Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I16916e1ddfd717715ab08ad56c06d1b38e220471
Reviewed-on: https://chromium-review.googlesource.com/1054588
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557871}
[modify] https://crrev.com/a7fe4743e85827cbab53f1e3f4556c23f61826ad/services/network/tcp_server_socket.cc
[modify] https://crrev.com/a7fe4743e85827cbab53f1e3f4556c23f61826ad/services/network/tcp_socket_unittest.cc
Project Member

Comment 44 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d062165a955b6e2a6b24eeeec8932bb5dee7292e

commit d062165a955b6e2a6b24eeeec8932bb5dee7292e
Author: Helen Li <xunjieli@chromium.org>
Date: Fri May 11 14:43:12 2018

Use base::BindLambdaForTesting in two test files

Use capturing lambda to make test logic more concise.

Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic48af0c91ddc9574fa793540df4059247df005d9
Reviewed-on: https://chromium-review.googlesource.com/1048207
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557876}
[modify] https://crrev.com/d062165a955b6e2a6b24eeeec8932bb5dee7292e/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/d062165a955b6e2a6b24eeeec8932bb5dee7292e/services/network/udp_socket_test_util.cc
Project Member

Comment 45 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c191a2d56c811aeb117515bb6070328ae73d5ae1

commit c191a2d56c811aeb117515bb6070328ae73d5ae1
Author: Helen Li <xunjieli@chromium.org>
Date: Mon May 14 14:42:58 2018

ProxyResolvingClientSocket now supports tls, switch P2PSocketHostTcp to use that

network::ProxyResolvingClientSocket supports connecting using tls. This CL
switches P2PSocketHostTcp to using that.

Bug:  721401 
Change-Id: I7cbdafb92268e54104d22288baadeda528b4a95d
Reviewed-on: https://chromium-review.googlesource.com/1053833
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558299}
[modify] https://crrev.com/c191a2d56c811aeb117515bb6070328ae73d5ae1/content/browser/renderer_host/p2p/socket_host.h
[modify] https://crrev.com/c191a2d56c811aeb117515bb6070328ae73d5ae1/content/browser/renderer_host/p2p/socket_host_tcp.cc
[modify] https://crrev.com/c191a2d56c811aeb117515bb6070328ae73d5ae1/content/browser/renderer_host/p2p/socket_host_tcp.h
[modify] https://crrev.com/c191a2d56c811aeb117515bb6070328ae73d5ae1/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc

Comment 46 by xunji...@chromium.org, May 22 2018

Components: -Blink>WebRTC>Network
Labels: -merge-merged-testbranch Proj-Servicification-Canary
Project Member

Comment 47 by bugdroid1@chromium.org, May 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48f117eff39bb0894064f67c5d9ff68f3a31c12e

commit 48f117eff39bb0894064f67c5d9ff68f3a31c12e
Author: Helen Li <xunjieli@chromium.org>
Date: Tue May 29 20:38:40 2018

Modify network service socket apis to in preparation to convert consumers

- Add extra return values to NetworkContext::CreateTCPConnectedSocket, because
//extensions depends on the ability to get local address and peer address
synchronously.
- Add a network::mojom::SSLConfig to UpgradeToTLS() because //extensions depends
on the ability to configure max and min tls version.
- Add two non-pure virtual methods (SetNoDelay and SetKeepAlive) to
net/socket/transport_client_socket.h, so I can mock out those in tests using
mock socket data (net::MockClientSocket is a subclass of
net::TransportClientSocket).

Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I2019d783b29ff0d68dbea95fb7a0f2d5e81a70fd
Reviewed-on: https://chromium-review.googlesource.com/1073191
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562575}
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/net/BUILD.gn
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/net/socket/socket_test_util.cc
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/net/socket/socket_test_util.h
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/net/socket/tcp_client_socket.h
[add] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/net/socket/transport_client_socket.cc
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/net/socket/transport_client_socket.h
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/services/network/public/cpp/server/http_server_unittest.cc
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/services/network/public/mojom/tcp_socket.mojom
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/services/network/public/mojom/tls_socket.mojom
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/services/network/socket_factory.cc
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/services/network/socket_factory.h
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/services/network/ssl_config_type_converter.cc
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/services/network/ssl_config_type_converter.h
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/services/network/tcp_connected_socket.cc
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/services/network/tcp_connected_socket.h
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/services/network/tcp_server_socket.cc
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/48f117eff39bb0894064f67c5d9ff68f3a31c12e/services/network/tls_client_socket_unittest.cc

Comment 48 by xunji...@chromium.org, May 30 2018

Blockedon: 848073

Comment 49 by xunji...@chromium.org, May 30 2018

Summary: Add support for TCP, TLS & UDP sockets in the network service and convert consumers (was: Add support for TCP & UDP sockets in the network service and convert consumers)

Comment 50 by xunji...@chromium.org, May 30 2018

Blockedon: 848075

Comment 51 by xunji...@chromium.org, May 30 2018

Blockedon: 848078

Comment 52 by xunji...@chromium.org, May 30 2018

Blockedon: 848079
Project Member

Comment 53 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41066e83216ea19036dcf33cfbf35e18f77da9fe

commit 41066e83216ea19036dcf33cfbf35e18f77da9fe
Author: Helen Li <xunjieli@chromium.org>
Date: Thu May 31 22:05:17 2018

Convert Extensions TCP & TLS Socket APIs to mojo sockets

This CL converts extensions TCP and TLS socket apis to network service's mojo
socket.

- Remove combined_socket_unittest.cc because the test cases no longer apply. I
tried to write equivalent ones in tcp_socket_unittest.cc and
tls_socket_unittest.cc
- Add a ContentUtilityClient implementation for extensions_browsertests, so we
can inject a NetworkServiceTestHelper to the utility process in which network
service runs.

Bug:  721401 
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_mojo
Change-Id: I333a3021a5c66eb94618be6830ba0ff68c442eba
Reviewed-on: https://chromium-review.googlesource.com/1070434
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563390}
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/build/check_gn_headers_whitelist.txt
[delete] https://crrev.com/9cd04c45abe239d5ed7cd260ec69ecdfb4f76edd/chrome/browser/extensions/api/socket/combined_socket_unittest.cc
[delete] https://crrev.com/9cd04c45abe239d5ed7cd260ec69ecdfb4f76edd/chrome/browser/extensions/api/socket/mock_tcp_client_socket.h
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/chrome/browser/extensions/api/socket/tls_socket_unittest.cc
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/chrome/test/BUILD.gn
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/chrome/test/data/extensions/api_test/socket/api/background.js
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/socket/BUILD.gn
[add] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/socket/mojo_data_pump.cc
[add] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/socket/mojo_data_pump.h
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/socket/socket.cc
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/socket/socket.h
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/socket/socket_api.cc
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/socket/socket_api.h
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/socket/tcp_socket.cc
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/socket/tcp_socket.h
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/socket/tls_socket.cc
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/socket/tls_socket.h
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/socket/udp_socket.cc
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/socket/udp_socket.h
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/sockets_tcp/sockets_tcp_api.cc
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/sockets_tcp/sockets_tcp_api.h
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/shell/BUILD.gn
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/shell/test/DEPS
[modify] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/shell/test/shell_test_launcher_delegate.cc
[add] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/shell/test/test_shell_main_delegate.cc
[add] https://crrev.com/41066e83216ea19036dcf33cfbf35e18f77da9fe/extensions/shell/test/test_shell_main_delegate.h
Project Member

Comment 54 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68147c8d632e66d625953b4432899a9c5bb4e56f

commit 68147c8d632e66d625953b4432899a9c5bb4e56f
Author: Helen Li <xunjieli@chromium.org>
Date: Thu May 31 23:34:53 2018

Remove unused methods in tcp_socket.mojom

The GetLocalAddress() method is deprecated now that
NetworkContext::CreateTCPConnectedSocket and
NetworkContext::CreateTCPServerSocket both surface the local address
upon successful completion.

TBR=tsepez@chromium.org
for a trivial removal from tcp_socket.mojom

Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I279736d00608e7326abe63314ce587a67374c30a
Reviewed-on: https://chromium-review.googlesource.com/1081018
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563429}
[modify] https://crrev.com/68147c8d632e66d625953b4432899a9c5bb4e56f/services/network/public/cpp/server/http_server.cc
[modify] https://crrev.com/68147c8d632e66d625953b4432899a9c5bb4e56f/services/network/public/cpp/server/http_server.h
[modify] https://crrev.com/68147c8d632e66d625953b4432899a9c5bb4e56f/services/network/public/cpp/server/http_server_unittest.cc
[modify] https://crrev.com/68147c8d632e66d625953b4432899a9c5bb4e56f/services/network/public/mojom/tcp_socket.mojom
[modify] https://crrev.com/68147c8d632e66d625953b4432899a9c5bb4e56f/services/network/tcp_connected_socket.cc
[modify] https://crrev.com/68147c8d632e66d625953b4432899a9c5bb4e56f/services/network/tcp_connected_socket.h
[modify] https://crrev.com/68147c8d632e66d625953b4432899a9c5bb4e56f/services/network/tcp_server_socket.cc
[modify] https://crrev.com/68147c8d632e66d625953b4432899a9c5bb4e56f/services/network/tcp_server_socket.h
Project Member

Comment 55 by bugdroid1@chromium.org, Jun 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa36ad64441d1e485ceb49eb28ae443b3b1846f0

commit fa36ad64441d1e485ceb49eb28ae443b3b1846f0
Author: Helen Li <xunjieli@chromium.org>
Date: Fri Jun 01 19:52:59 2018

Remove test-only check in SafeBrowsingURLRequestContextGetter

SafeBrowsingURLRequestContextGetter depends on a non-null
g_browser_process->system_request_context(). The request context can be null
in tests.

This CL removes the test-only check and fixes the affected tests so they
have an valid system request context.

With network service, I am adding a code path which DCHECKs on
net::URLRequestContext members. SafeBrowsingURLRequestContextGetter is giving
a net::URLRequestContext with many invalid fields (e.g. |cert_verifier_|) in
tests when g_browser_process->system_request_context() is not initialized.

Bug:  721401 
Change-Id: I5fd7d65646729b4d96276e0110790a14bbe3b0a9
Reviewed-on: https://chromium-review.googlesource.com/1082572
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563765}
[modify] https://crrev.com/fa36ad64441d1e485ceb49eb28ae443b3b1846f0/chrome/browser/net/trial_comparison_cert_verifier_unittest.cc
[modify] https://crrev.com/fa36ad64441d1e485ceb49eb28ae443b3b1846f0/chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc
[modify] https://crrev.com/fa36ad64441d1e485ceb49eb28ae443b3b1846f0/chrome/browser/safe_browsing/notification_image_reporter_unittest.cc
[modify] https://crrev.com/fa36ad64441d1e485ceb49eb28ae443b3b1846f0/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
[modify] https://crrev.com/fa36ad64441d1e485ceb49eb28ae443b3b1846f0/chrome/browser/safe_browsing/ui_manager_unittest.cc
[modify] https://crrev.com/fa36ad64441d1e485ceb49eb28ae443b3b1846f0/chrome/browser/subresource_filter/subresource_filter_test_harness.cc
[modify] https://crrev.com/fa36ad64441d1e485ceb49eb28ae443b3b1846f0/chrome/browser/subresource_filter/subresource_filter_test_harness.h
[modify] https://crrev.com/fa36ad64441d1e485ceb49eb28ae443b3b1846f0/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_unittest.cc
[modify] https://crrev.com/fa36ad64441d1e485ceb49eb28ae443b3b1846f0/components/safe_browsing/browser/safe_browsing_url_request_context_getter.cc

Comment 56 by dxie@chromium.org, Jun 8 2018

Labels: OS-Chrome OS-Windows OS-Mac OS-Linux
Project Member

Comment 57 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c51db4c0ba899a80f578bc60e0c64677d3067d9d

commit c51db4c0ba899a80f578bc60e0c64677d3067d9d
Author: Helen Li <xunjieli@chromium.org>
Date: Thu Jun 14 22:05:04 2018

Put net/server/* into a separate BUILD.gn file

net::HttpServer is being deprecated. This CL puts them into a separate target
with limited visibility and adds comments.

TBR=dgozman@chromium.org

Bug:  721401 

Change-Id: Id2a5be800ec0ceccb94d3a9987adc96d14e7f8b7
Reviewed-on: https://chromium-review.googlesource.com/1076498
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567438}
[modify] https://crrev.com/c51db4c0ba899a80f578bc60e0c64677d3067d9d/chrome/browser/devtools/BUILD.gn
[modify] https://crrev.com/c51db4c0ba899a80f578bc60e0c64677d3067d9d/chrome/test/chromedriver/BUILD.gn
[modify] https://crrev.com/c51db4c0ba899a80f578bc60e0c64677d3067d9d/content/browser/BUILD.gn
[modify] https://crrev.com/c51db4c0ba899a80f578bc60e0c64677d3067d9d/net/BUILD.gn
[add] https://crrev.com/c51db4c0ba899a80f578bc60e0c64677d3067d9d/net/server/BUILD.gn

Comment 58 by xunji...@chromium.org, Jul 11

Blockedon: 862608

Comment 59 by dxie@chromium.org, Jul 12

Labels: -Pri-2 Pri-1
Project Member

Comment 60 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/494108abe23d689c0a311025d464edc7453d368b

commit 494108abe23d689c0a311025d464edc7453d368b
Author: Helen Li <xunjieli@chromium.org>
Date: Fri Jul 20 21:00:31 2018

Revert "Convert Extensions TCP & TLS Socket APIs to mojo sockets"

This reverts commit 41066e83216ea19036dcf33cfbf35e18f77da9fe.

Reason for revert: This CL broke an internal app.  See  crbug.com/865958 

Original change's description:
> Convert Extensions TCP & TLS Socket APIs to mojo sockets
>
> This CL converts extensions TCP and TLS socket apis to network service's mojo
> socket.
>
> - Remove combined_socket_unittest.cc because the test cases no longer apply. I
> tried to write equivalent ones in tcp_socket_unittest.cc and
> tls_socket_unittest.cc
> - Add a ContentUtilityClient implementation for extensions_browsertests, so we
> can inject a NetworkServiceTestHelper to the utility process in which network
> service runs.
>
> Bug:  721401 
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_mojo
> Change-Id: I333a3021a5c66eb94618be6830ba0ff68c442eba
> Reviewed-on: https://chromium-review.googlesource.com/1070434
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563390}

TBR=jam@chromium.org,reillyg@chromium.org,xunjieli@chromium.org,morlovich@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  721401 ,  865958 
Change-Id: I9e9408f31887ab45d0bd967e2f17f91c465836c6
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1145340
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576982}
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/build/check_gn_headers_whitelist.txt
[add] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/chrome/browser/extensions/api/socket/combined_socket_unittest.cc
[add] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/chrome/browser/extensions/api/socket/mock_tcp_client_socket.h
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/chrome/browser/extensions/api/socket/tls_socket_unittest.cc
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/chrome/test/BUILD.gn
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/chrome/test/data/extensions/api_test/socket/api/background.js
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/socket/BUILD.gn
[delete] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/extensions/browser/api/socket/mojo_data_pump.cc
[delete] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/extensions/browser/api/socket/mojo_data_pump.h
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/socket/socket.cc
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/socket/socket.h
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/socket/socket_api.cc
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/socket/socket_api.h
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/socket/tcp_socket.cc
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/socket/tcp_socket.h
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/socket/tls_socket.cc
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/socket/tls_socket.h
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/socket/udp_socket.cc
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/socket/udp_socket.h
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/sockets_tcp/sockets_tcp_api.cc
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/sockets_tcp/sockets_tcp_api.h
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc
[modify] https://crrev.com/494108abe23d689c0a311025d464edc7453d368b/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h
Project Member

Comment 61 by bugdroid1@chromium.org, Jul 23

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/414ca59262e3866e8ad28cd4d00f37536ff5868b

commit 414ca59262e3866e8ad28cd4d00f37536ff5868b
Author: Helen Li <xunjieli@chromium.org>
Date: Mon Jul 23 19:49:41 2018

Revert "Convert Extensions TCP & TLS Socket APIs to mojo sockets"

This reverts commit 41066e83216ea19036dcf33cfbf35e18f77da9fe.

Reason for revert: This CL broke an internal app.  See  crbug.com/865958 

Original change's description:
> Convert Extensions TCP & TLS Socket APIs to mojo sockets
>
> This CL converts extensions TCP and TLS socket apis to network service's mojo
> socket.
>
> - Remove combined_socket_unittest.cc because the test cases no longer apply. I
> tried to write equivalent ones in tcp_socket_unittest.cc and
> tls_socket_unittest.cc
> - Add a ContentUtilityClient implementation for extensions_browsertests, so we
> can inject a NetworkServiceTestHelper to the utility process in which network
> service runs.
>
> Bug:  721401 
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_mojo
> Change-Id: I333a3021a5c66eb94618be6830ba0ff68c442eba
> Reviewed-on: https://chromium-review.googlesource.com/1070434
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563390}

TBR=jam@chromium.org,reillyg@chromium.org,xunjieli@chromium.org,morlovich@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  721401 ,  865958 
Change-Id: I9e9408f31887ab45d0bd967e2f17f91c465836c6
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1145340
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#576982}(cherry picked from commit 494108abe23d689c0a311025d464edc7453d368b)
Reviewed-on: https://chromium-review.googlesource.com/1147182
Cr-Commit-Position: refs/branch-heads/3497@{#23}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/build/check_gn_headers_whitelist.txt
[add] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/chrome/browser/extensions/api/socket/combined_socket_unittest.cc
[add] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/chrome/browser/extensions/api/socket/mock_tcp_client_socket.h
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/chrome/browser/extensions/api/socket/tls_socket_unittest.cc
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/chrome/test/BUILD.gn
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/chrome/test/data/extensions/api_test/socket/api/background.js
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/socket/BUILD.gn
[delete] https://crrev.com/1b5dd7ce82f97dfd81f07649fff0c7dc76c8e6d6/extensions/browser/api/socket/mojo_data_pump.cc
[delete] https://crrev.com/1b5dd7ce82f97dfd81f07649fff0c7dc76c8e6d6/extensions/browser/api/socket/mojo_data_pump.h
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/socket/socket.cc
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/socket/socket.h
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/socket/socket_api.cc
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/socket/socket_api.h
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/socket/tcp_socket.cc
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/socket/tcp_socket.h
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/socket/tls_socket.cc
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/socket/tls_socket.h
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/socket/udp_socket.cc
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/socket/udp_socket.h
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/sockets_tcp/sockets_tcp_api.cc
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/sockets_tcp/sockets_tcp_api.h
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc
[modify] https://crrev.com/414ca59262e3866e8ad28cd4d00f37536ff5868b/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h
Project Member

Comment 62 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9

commit bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9
Author: Helen Li <xunjieli@chromium.org>
Date: Tue Jul 24 16:06:56 2018

Reland "Convert Extensions TCP & TLS Socket APIs to mojo sockets"

This reverts commit 494108abe23d689c0a311025d464edc7453d368b.

Reason for revert: Reland it in M70.

Original change's description:
> Revert "Convert Extensions TCP & TLS Socket APIs to mojo sockets"
> 
> This reverts commit 41066e83216ea19036dcf33cfbf35e18f77da9fe.
> 
> Reason for revert: This CL broke an internal app.  See  crbug.com/865958 
> 
> Original change's description:
> > Convert Extensions TCP & TLS Socket APIs to mojo sockets
> >
> > This CL converts extensions TCP and TLS socket apis to network service's mojo
> > socket.
> >
> > - Remove combined_socket_unittest.cc because the test cases no longer apply. I
> > tried to write equivalent ones in tcp_socket_unittest.cc and
> > tls_socket_unittest.cc
> > - Add a ContentUtilityClient implementation for extensions_browsertests, so we
> > can inject a NetworkServiceTestHelper to the utility process in which network
> > service runs.
> >
> > Bug:  721401 
> > Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_mojo
> > Change-Id: I333a3021a5c66eb94618be6830ba0ff68c442eba
> > Reviewed-on: https://chromium-review.googlesource.com/1070434
> > Commit-Queue: Helen Li <xunjieli@chromium.org>
> > Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#563390}
> 
> TBR=jam@chromium.org,reillyg@chromium.org,xunjieli@chromium.org,morlovich@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug:  721401 ,  865958 
> Change-Id: I9e9408f31887ab45d0bd967e2f17f91c465836c6
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_mojo
> Reviewed-on: https://chromium-review.googlesource.com/1145340
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Helen Li <xunjieli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576982}

TBR=jam@chromium.org,reillyg@chromium.org,xunjieli@chromium.org,morlovich@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  721401 ,  865958 
Change-Id: I9748ea1d6c04f26429508da9358ca16ff01ff90d
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1148480
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577565}
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/build/check_gn_headers_whitelist.txt
[delete] https://crrev.com/cdd345c5e180e46e21ef64e4ac87d22b4eb8332f/chrome/browser/extensions/api/socket/combined_socket_unittest.cc
[delete] https://crrev.com/cdd345c5e180e46e21ef64e4ac87d22b4eb8332f/chrome/browser/extensions/api/socket/mock_tcp_client_socket.h
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/chrome/browser/extensions/api/socket/tls_socket_unittest.cc
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/chrome/test/BUILD.gn
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/chrome/test/data/extensions/api_test/socket/api/background.js
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/socket/BUILD.gn
[add] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/socket/mojo_data_pump.cc
[add] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/socket/mojo_data_pump.h
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/socket/socket.cc
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/socket/socket.h
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/socket/socket_api.cc
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/socket/socket_api.h
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/socket/tcp_socket.cc
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/socket/tcp_socket.h
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/socket/tls_socket.cc
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/socket/tls_socket.h
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/socket/udp_socket.cc
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/socket/udp_socket.h
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/sockets_tcp/sockets_tcp_api.cc
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/sockets_tcp/sockets_tcp_api.h
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc
[modify] https://crrev.com/bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h

Comment 63 by xunji...@chromium.org, Jul 24

Status: Fixed (was: Assigned)
Summary: Add support for TCP, TLS & UDP sockets in the network service (was: Add support for TCP, TLS & UDP sockets in the network service and convert consumers)
Closing this meta bug. All socket APIs have been added. 
Separate bugs should be filed to track embedder conversion.
Project Member

Comment 64 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ba3af4e057bbbefa6eb3b2d7b806972b53b251c

commit 5ba3af4e057bbbefa6eb3b2d7b806972b53b251c
Author: Helen Li <xunjieli@chromium.org>
Date: Fri Jul 27 11:21:03 2018

Rearrange extensions MojoDataPump::ReceiveMore and SendMore

Rearrange ReceiveMore and SendMore, so that we check MOJO_RESULT_SHOULD_WAIT
before !MOJO_RESULT_OK. This CL adds three unit tests that pass
with or without the change.

Bug:  721401 
Change-Id: I6b132b2399f9091374d037d890d7ca98ba358445
Reviewed-on: https://chromium-review.googlesource.com/1150428
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578597}
[modify] https://crrev.com/5ba3af4e057bbbefa6eb3b2d7b806972b53b251c/extensions/browser/BUILD.gn
[modify] https://crrev.com/5ba3af4e057bbbefa6eb3b2d7b806972b53b251c/extensions/browser/api/socket/mojo_data_pump.cc
[add] https://crrev.com/5ba3af4e057bbbefa6eb3b2d7b806972b53b251c/extensions/browser/api/socket/mojo_data_pump_unittest.cc
►

Sign in to add a comment