Yep, sorry, meant to do this.  I'll do it for DRP as well.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e64af8eed07578f01b933d654180659c0fe962c

commit 1e64af8eed07578f01b933d654180659c0fe962c
Author: rdsmith <rdsmith@chromium.org>
Date: Sat Jun 17 00:25:28 2017

Implement and test CanonicalCookie::IsCanonical()

This is done for data validation including but not limited to the
cookies servicification effort.

BUG= 721395 ,  723734 
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2898953008
Cr-Commit-Position: refs/heads/master@{#480238}

[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/android_webview/browser/net/aw_cookie_store_wrapper_unittest.cc
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/ios/net/cookies/cookie_store_ios_persistent_unittest.mm
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/ios/net/cookies/cookie_store_ios_unittest.mm
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/net/cookies/canonical_cookie.cc
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/net/cookies/canonical_cookie.h
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/net/cookies/canonical_cookie_unittest.cc
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/net/cookies/cookie_store_unittest.h
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/net/cookies/parsed_cookie.cc
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/net/cookies/parsed_cookie.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e64af8eed07578f01b933d654180659c0fe962c

commit 1e64af8eed07578f01b933d654180659c0fe962c
Author: rdsmith <rdsmith@chromium.org>
Date: Sat Jun 17 00:25:28 2017

Implement and test CanonicalCookie::IsCanonical()

This is done for data validation including but not limited to the
cookies servicification effort.

BUG= 721395 ,  723734 
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2898953008
Cr-Commit-Position: refs/heads/master@{#480238}

[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/android_webview/browser/net/aw_cookie_store_wrapper_unittest.cc
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/ios/net/cookies/cookie_store_ios_persistent_unittest.mm
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/ios/net/cookies/cookie_store_ios_unittest.mm
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/net/cookies/canonical_cookie.cc
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/net/cookies/canonical_cookie.h
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/net/cookies/canonical_cookie_unittest.cc
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/net/cookies/cookie_store_unittest.h
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/net/cookies/parsed_cookie.cc
[modify] https://crrev.com/1e64af8eed07578f01b933d654180659c0fe962c/net/cookies/parsed_cookie.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2709eee26ac162dc961a19bed779a584bb49da02

commit 2709eee26ac162dc961a19bed779a584bb49da02
Author: rdsmith <rdsmith@chromium.org>
Date: Tue Jun 20 22:43:27 2017

Refactor transmission of security of source and http_only mods in cookie_monster.cc.

Prep CL for https://codereview.chromium.org/2882063002

BUG= 721395 
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2903213004
Cr-Commit-Position: refs/heads/master@{#481002}

[modify] https://crrev.com/2709eee26ac162dc961a19bed779a584bb49da02/net/cookies/cookie_monster.cc
[modify] https://crrev.com/2709eee26ac162dc961a19bed779a584bb49da02/net/cookies/cookie_monster.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6ce44474ee162592d04a31cf0b243c31a53f57d

commit a6ce44474ee162592d04a31cf0b243c31a53f57d
Author: rdsmith <rdsmith@chromium.org>
Date: Wed Jun 21 17:11:05 2017

Add a SetCanonicalCookie method for CookieMonster.

This includes some refactoring of creation time defaulting, as well
as a histogram revision bump because the information about whether a
cookie is being set based on a null URL is no longer available at
the point of histogram creation.

BUG= 721395 ,  723734 
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2882063002
Cr-Commit-Position: refs/heads/master@{#481227}

[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/android_webview/browser/net/aw_cookie_store_wrapper.cc
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/android_webview/browser/net/aw_cookie_store_wrapper.h
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/chrome/browser/extensions/api/cookies/cookies_unittest.cc
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/headless/public/util/testing/generic_url_request_mocks.cc
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/headless/public/util/testing/generic_url_request_mocks.h
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/ios/net/cookies/cookie_store_ios.h
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/ios/net/cookies/cookie_store_ios.mm
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/ios/net/cookies/cookie_store_ios_persistent.h
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/ios/net/cookies/cookie_store_ios_persistent.mm
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/net/cookies/canonical_cookie.cc
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/net/cookies/canonical_cookie.h
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/net/cookies/canonical_cookie_unittest.cc
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/net/cookies/cookie_monster.cc
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/net/cookies/cookie_monster.h
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/net/cookies/cookie_store.h
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/net/cookies/cookie_store_test_helpers.cc
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/net/cookies/cookie_store_test_helpers.h
[modify] https://crrev.com/a6ce44474ee162592d04a31cf0b243c31a53f57d/net/cookies/cookie_store_unittest.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ac8171e75097750531a69f5eadf32b03f481f96

commit 7ac8171e75097750531a69f5eadf32b03f481f96
Author: rdsmith <rdsmith@chromium.org>
Date: Thu Jun 22 17:09:54 2017

Shift cookie system callbacks to OnceCallback to match mojo.

Mojo provides OnceCallbacks to services for notification of
completion of operations (which makes sense--operations
can't conceptually complete multiple times). Unfortunately,
CookieStore, while asynchronous, uses the default repeating
callbacks.  This CL shifts the CookieStore over to using
OnceCallbacks, so that a cookie service may be layered on
top of it.  This change is made simpler and smaller by the
fact that there is an automatic cast from a repeated Callback
to a OnceCallback, so consumers of the CookieStore
interface do not need to be converted.  However, all
subclasses of CookieStore do.

See https://docs.google.com/document/d/1jsaJAT-WbFS2ZwLEPkAgGcMTQ6MQLIQlyQfd1JeEupg/edit#heading=h.5ztx0u98smg8
for details on OnceCallback and conversions.  A couple of
things to note about conversions:
* OnceCallbacks can't be copied, they need to be moved
  (std::move).
* Bind produces Callbacks, BindOnce produces
  OnceCallbacks.
* If you Bind a OnceCallback, that's similar to binding a
  unique_ptr<>; you have to use Passed() and it's not clear
  what happens if you call the result multiple times.
  BindOnce() Just Works, and correctly expresses the
  semantics (since if a repeating Callback actually used a
  OnceCallback, it's not clear what the repeating Callback
  would do on the next call).

BUG= 721395 

Review-Url: https://codereview.chromium.org/2937963003
Cr-Commit-Position: refs/heads/master@{#481573}

[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/android_webview/browser/net/aw_cookie_store_wrapper.cc
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/android_webview/browser/net/aw_cookie_store_wrapper.h
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/chrome/browser/browsing_data/browsing_data_cookie_helper.cc
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/chrome/browser/browsing_data/browsing_data_cookie_helper.h
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/chrome/browser/browsing_data/mock_browsing_data_cookie_helper.cc
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/chrome/browser/browsing_data/mock_browsing_data_cookie_helper.h
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/chrome/browser/extensions/api/cookies/cookies_helpers.cc
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/chrome/browser/extensions/api/cookies/cookies_helpers.h
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/content/browser/net/quota_policy_cookie_store.cc
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/content/browser/net/quota_policy_cookie_store.h
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/headless/public/util/testing/generic_url_request_mocks.cc
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/headless/public/util/testing/generic_url_request_mocks.h
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/ios/net/cookies/cookie_store_ios.h
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/ios/net/cookies/cookie_store_ios.mm
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/ios/net/cookies/cookie_store_ios_persistent.h
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/ios/net/cookies/cookie_store_ios_persistent.mm
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/ios/net/cookies/cookie_store_ios_persistent_unittest.mm
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/ios/net/cookies/cookie_store_ios_test_util.h
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/ios/net/cookies/cookie_store_ios_test_util.mm
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/ios/net/cookies/cookie_store_ios_unittest.mm
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/net/cookies/cookie_monster.cc
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/net/cookies/cookie_monster.h
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/net/cookies/cookie_monster_store_test.cc
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/net/cookies/cookie_monster_store_test.h
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/net/cookies/cookie_store.cc
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/net/cookies/cookie_store.h
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/net/cookies/cookie_store_test_helpers.cc
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/net/cookies/cookie_store_test_helpers.h
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/net/extras/sqlite/sqlite_persistent_cookie_store.cc
[modify] https://crrev.com/7ac8171e75097750531a69f5eadf32b03f481f96/net/extras/sqlite/sqlite_persistent_cookie_store.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5beda16555c10b32becc695dd03481ea61b9b98

commit a5beda16555c10b32becc695dd03481ea61b9b98
Author: rdsmith <rdsmith@chromium.org>
Date: Sat Jul 08 13:55:42 2017

Change CookieStore::DeleteCallback to take uint32_t.

The number of cookies deleted will always be zero or a positive number,
so should be represented by an unsigned.  This is being done to bring
the CookieStore interface into alignment with the Mojo cookie service.

BUG= 721395 
R=mmenke@chromium.org
TBR=sgurun@chromium.org
TBR=mkwst@chromium.org
TBR=sky@chromium.org
TBR=jam@chromium.org
TBR=rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2971733002
Cr-Commit-Position: refs/heads/master@{#485148}

[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/android_webview/browser/cookie_manager.cc
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/android_webview/browser/net/aw_cookie_store_wrapper.cc
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/android_webview/browser/net/aw_cookie_store_wrapper_unittest.cc
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/chrome/browser/sessions/session_data_deleter.cc
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/ios/chrome/browser/net/cookie_util.mm
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/ios/chrome/browser/ui/chrome_web_view_factory.mm
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/ios/net/cookies/cookie_store_ios.h
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/ios/net/cookies/cookie_store_ios.mm
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/net/cookies/cookie_monster.cc
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/net/cookies/cookie_monster.h
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/net/cookies/cookie_store.h
[modify] https://crrev.com/a5beda16555c10b32becc695dd03481ea61b9b98/net/cookies/cookie_store_unittest.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2675a47a1c288ab4536067e8569ef52d279d21c7

commit 2675a47a1c288ab4536067e8569ef52d279d21c7
Author: Randy Smith <rdsmith@chromium.org>
Date: Thu Jul 13 18:15:49 2017

Add defaults in default constructor for undefined CanonicalCookie data members.

BUG= 721395 
R=mmenke@chromium.org

Change-Id: I608c01810d2ccf47366614ea35bdf28e819d920f
Reviewed-on: https://chromium-review.googlesource.com/568688
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486441}
[modify] https://crrev.com/2675a47a1c288ab4536067e8569ef52d279d21c7/net/cookies/canonical_cookie.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10400077f54ae9977d9ff9165801a39642de0e53

commit 10400077f54ae9977d9ff9165801a39642de0e53
Author: Randy Smith <rdsmith@chromium.org>
Date: Thu Aug 03 04:08:31 2017

Enforce existing requirements for setting httponly cookies on the
SetCanonicalCookie pathway (used to just be enforced via
SetCookieWithOptions()).

Discovered in writing tests for the cookie service, so using that bug.

Bug:  721395 
Change-Id: I6d8b0e44e99063200de6f5983d0049af4efd2bc6
Reviewed-on: https://chromium-review.googlesource.com/581797
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491643}
[modify] https://crrev.com/10400077f54ae9977d9ff9165801a39642de0e53/net/cookies/cookie_monster.cc
[modify] https://crrev.com/10400077f54ae9977d9ff9165801a39642de0e53/net/cookies/cookie_store_unittest.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69722f400b9def82e76a88597a425a951104cf01

commit 69722f400b9def82e76a88597a425a951104cf01
Author: Randy Smith <rdsmith@chromium.org>
Date: Thu Aug 03 21:22:38 2017

Formatting/comment changes in cookie store unit tests.

I missed a couple of comments in
https://chromium-review.googlesource.com/c/581797, so executing on
them in a separate CL.

TBR=mmenke@chromium.org

Bug:  721395 
Change-Id: Ica4c496ff28cd202026406f1ebcf4194045c969c
Reviewed-on: https://chromium-review.googlesource.com/600632
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491848}
[modify] https://crrev.com/69722f400b9def82e76a88597a425a951104cf01/net/cookies/cookie_store_unittest.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/323ea0ec5ba764f3ac449760eb423a3cac1c5c22

commit 323ea0ec5ba764f3ac449760eb423a3cac1c5c22
Author: Randy Smith <rdsmith@chromium.org>
Date: Fri Aug 11 01:29:58 2017

Implement Mojo service for cookie access.

This CL implements the Mojo interface to cookies described in 
https://docs.google.com/document/d/1s1vL8hNDPvOhssgsp8HjgL9yKZMzwo50yY5Hy8X6iE4/edit.  
The intent is that all cookie accesses from chrome/, content/, and renderers will be 
switched to use this interface.

Bug:  721395 
Change-Id: I4b476d3629b276916f1842a9ac267bd5693aa9e5
Reviewed-on: https://chromium-review.googlesource.com/588074
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493634}
[modify] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/content/network/BUILD.gn
[modify] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/content/network/DEPS
[add] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/content/network/cookie_manager_impl.cc
[add] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/content/network/cookie_manager_impl.h
[add] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/content/network/cookie_manager_impl_unittest.cc
[modify] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/content/public/common/BUILD.gn
[add] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/content/public/common/cookie_manager.mojom
[add] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/content/public/common/cookie_manager.typemap
[add] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/content/public/common/cookie_manager_traits.cc
[add] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/content/public/common/cookie_manager_traits.h
[modify] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/content/public/common/typemaps.gni
[modify] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/content/test/BUILD.gn
[modify] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/net/cookies/canonical_cookie.cc
[modify] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/net/cookies/cookie_constants.h
[modify] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/net/cookies/cookie_options.cc
[modify] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/net/cookies/cookie_options.h
[modify] https://crrev.com/323ea0ec5ba764f3ac449760eb423a3cac1c5c22/net/cookies/cookie_store.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1265f60241107682eb20f71ba297855c71bd311f

commit 1265f60241107682eb20f71ba297855c71bd311f
Author: Randy Smith <rdsmith@chromium.org>
Date: Fri Aug 18 16:26:54 2017

Added CookieManager interface to NetworkContext.

Note that the pipe created is not associated with any other
Mojo pipe, and hence does not have ordering guarantees with
any other Mojo pipe.

Bug:  721395 
Change-Id: I12a72d3764427f2622222c2777276cd07c6aa592
Reviewed-on: https://chromium-review.googlesource.com/612823
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495568}
[modify] https://crrev.com/1265f60241107682eb20f71ba297855c71bd311f/content/network/network_context.cc
[modify] https://crrev.com/1265f60241107682eb20f71ba297855c71bd311f/content/network/network_context.h
[modify] https://crrev.com/1265f60241107682eb20f71ba297855c71bd311f/content/network/network_context_unittest.cc
[modify] https://crrev.com/1265f60241107682eb20f71ba297855c71bd311f/content/public/common/network_service.mojom

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d32dc8cfa3dc462524189c555ba1e35fc04d5679

commit d32dc8cfa3dc462524189c555ba1e35fc04d5679
Author: Randy Smith <rdsmith@chromium.org>
Date: Wed Aug 30 18:03:40 2017

Add ability to track all cookie changes by registration.

Currently, the ability to track all cookie changes is implemented by
a delegate to the CookieMonster.  This CL implements a registration
method on the CookieStore which may be used instead of the delegate.  
This makes the usage of the global tracker more general and more 
easily wrapped by Mojo.  It is not currently implemented on
non-CookieMonster CookieStores, but can be when needed on those
platforms.

Bug:  721395 
Change-Id: I6b253b3a2caed7f6c58caf81c9de9f7bacc74b96
Reviewed-on: https://chromium-review.googlesource.com/602775
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498533}
[modify] https://crrev.com/d32dc8cfa3dc462524189c555ba1e35fc04d5679/android_webview/browser/net/aw_cookie_store_wrapper.cc
[modify] https://crrev.com/d32dc8cfa3dc462524189c555ba1e35fc04d5679/android_webview/browser/net/aw_cookie_store_wrapper.h
[modify] https://crrev.com/d32dc8cfa3dc462524189c555ba1e35fc04d5679/android_webview/browser/net/aw_cookie_store_wrapper_unittest.cc
[modify] https://crrev.com/d32dc8cfa3dc462524189c555ba1e35fc04d5679/headless/public/util/testing/generic_url_request_mocks.cc
[modify] https://crrev.com/d32dc8cfa3dc462524189c555ba1e35fc04d5679/headless/public/util/testing/generic_url_request_mocks.h
[modify] https://crrev.com/d32dc8cfa3dc462524189c555ba1e35fc04d5679/ios/net/cookies/cookie_store_ios.h
[modify] https://crrev.com/d32dc8cfa3dc462524189c555ba1e35fc04d5679/ios/net/cookies/cookie_store_ios.mm
[modify] https://crrev.com/d32dc8cfa3dc462524189c555ba1e35fc04d5679/ios/net/cookies/cookie_store_ios_persistent_unittest.mm
[modify] https://crrev.com/d32dc8cfa3dc462524189c555ba1e35fc04d5679/ios/net/cookies/cookie_store_ios_unittest.mm
[modify] https://crrev.com/d32dc8cfa3dc462524189c555ba1e35fc04d5679/net/cookies/cookie_monster.cc
[modify] https://crrev.com/d32dc8cfa3dc462524189c555ba1e35fc04d5679/net/cookies/cookie_monster.h
[modify] https://crrev.com/d32dc8cfa3dc462524189c555ba1e35fc04d5679/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/d32dc8cfa3dc462524189c555ba1e35fc04d5679/net/cookies/cookie_store.h
[modify] https://crrev.com/d32dc8cfa3dc462524189c555ba1e35fc04d5679/net/cookies/cookie_store_test_helpers.cc
[modify] https://crrev.com/d32dc8cfa3dc462524189c555ba1e35fc04d5679/net/cookies/cookie_store_test_helpers.h
[modify] https://crrev.com/d32dc8cfa3dc462524189c555ba1e35fc04d5679/net/cookies/cookie_store_unittest.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a522662173fc007dbc20aaadcef85abbee012f7

commit 0a522662173fc007dbc20aaadcef85abbee012f7
Author: Randy Smith <rdsmith@chromium.org>
Date: Wed Aug 30 19:35:34 2017

Remove CookieMonsterDelegate usage for tracking cookie changes, switching
to registration interface.  This will allow cleaner conversion of cookie 
stores to Mojo.

R=mmenke@chromium.org

Bug:  721395 
Change-Id: Iaa4e13316a06781d9f37dad56e482ebec4921266
Reviewed-on: https://chromium-review.googlesource.com/604547
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498570}
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/android_webview/browser/cookie_manager.cc
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/chrome/browser/extensions/BUILD.gn
[delete] https://crrev.com/64f230ebf325b59013d388667e25631f5ef0d50c/chrome/browser/extensions/extension_cookie_monster_delegate.cc
[delete] https://crrev.com/64f230ebf325b59013d388667e25631f5ef0d50c/chrome/browser/extensions/extension_cookie_monster_delegate.h
[add] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/chrome/browser/extensions/extension_cookie_notifier.cc
[add] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/chrome/browser/extensions/extension_cookie_notifier.h
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/chrome/test/data/extensions/api_test/cookies/events_spanning/test.js
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/chromecast/browser/url_request_context_factory.cc
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/components/safe_browsing/browser/safe_browsing_url_request_context_getter.cc
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/content/browser/net/quota_policy_cookie_store.cc
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/content/public/browser/cookie_store_factory.h
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/ios/chrome/browser/browser_state/chrome_browser_state_io_data.h
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/ios/chrome/browser/net/cookie_util.mm
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/ios/components/io_thread/ios_io_thread.mm
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/ios/net/cookies/cookie_store_ios.mm
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/net/cookies/cookie_monster.cc
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/net/cookies/cookie_monster.h
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/net/cookies/cookie_monster_perftest.cc
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/net/cookies/cookie_monster_store_test.cc
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/net/cookies/cookie_monster_store_test.h
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/0a522662173fc007dbc20aaadcef85abbee012f7/net/url_request/url_request_test_util.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbf177b285203e25d99f35837921a74203f6d122

commit cbf177b285203e25d99f35837921a74203f6d122
Author: Randy Smith <rdsmith@chromium.org>
Date: Thu Oct 05 22:26:44 2017

Invert the implementation of "{including,excluding}_domains" to match comment.

Both test and implementation were inverted from the comment in the Mojo
interface for CookieManagerImpl deletion functionality.  This CL fixes that.

Bug:  721395 
Change-Id: I39274d5fc91a27ab988dcc6de61ded25dfe874e0
Reviewed-on: https://chromium-review.googlesource.com/701138
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506886}
[modify] https://crrev.com/cbf177b285203e25d99f35837921a74203f6d122/content/network/cookie_manager_impl.cc
[modify] https://crrev.com/cbf177b285203e25d99f35837921a74203f6d122/content/network/cookie_manager_impl_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93d0cb01bb0c645e43d81ac5e303a50d7799ffe7

commit 93d0cb01bb0c645e43d81ac5e303a50d7799ffe7
Author: Randy Smith <rdsmith@chromium.org>
Date: Tue Oct 17 18:38:24 2017

Shift CookieManagerImpl tests over to specifying cookies separately in each
test.

Bug:  721395 
Change-Id: Iafc5c8ab00b70e87b3c27a5f30003c89004c138c
Reviewed-on: https://chromium-review.googlesource.com/721141
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509441}
[modify] https://crrev.com/93d0cb01bb0c645e43d81ac5e303a50d7799ffe7/content/network/cookie_manager_impl_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/549408c99d7fb92f3313e4da984458a6d66afb78

commit 549408c99d7fb92f3313e4da984458a6d66afb78
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Oct 23 23:51:32 2017

Add user counter stats to get/set cookie JavaScript APIs.

BUG= 721395 

Change-Id: Id96366128e67baaa6b21475032a2c35c709b9001
Reviewed-on: https://chromium-review.googlesource.com/733663
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510964}
[modify] https://crrev.com/549408c99d7fb92f3313e4da984458a6d66afb78/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/549408c99d7fb92f3313e4da984458a6d66afb78/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/549408c99d7fb92f3313e4da984458a6d66afb78/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da71322ac54dfd10eed8ef4a8e3bb9af1eb3f0a9

commit da71322ac54dfd10eed8ef4a8e3bb9af1eb3f0a9
Author: Randy Smith <rdsmith@chromium.org>
Date: Tue Oct 24 18:53:56 2017

Refine specification of CookieManager interface deletion semantics.

It turns out that a) the CookieManager deletion functionality has
effectively only a single consumer (BrowsingDataFilterBuilder
consumers), and b) that consumer has very specific and slightly non-obvious
requirements for deletion.  This CL brings the deletion semantics exported
into alignment with the consumer requirements.

The tests added for this change include tests copied from 
BrowsingDataFilterBuilderImplTest.RegistrableDomainMatchesCookiesWhitelist
adapted to the new interface.

Bug:  721395 
Change-Id: Ib95f8be196b83c631a91a6f573d24953888e435f
Reviewed-on: https://chromium-review.googlesource.com/703756
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511220}
[modify] https://crrev.com/da71322ac54dfd10eed8ef4a8e3bb9af1eb3f0a9/content/network/cookie_manager_impl.cc
[modify] https://crrev.com/da71322ac54dfd10eed8ef4a8e3bb9af1eb3f0a9/content/network/cookie_manager_impl_unittest.cc
[modify] https://crrev.com/da71322ac54dfd10eed8ef4a8e3bb9af1eb3f0a9/services/network/public/interfaces/cookie_manager.mojom

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5f10a9aa1ce4c81d26a6f53c6b533f8bae266c5

commit b5f10a9aa1ce4c81d26a6f53c6b533f8bae266c5
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Nov 01 14:50:33 2017

Change document.cookie setter to use a sync IPC call.

This is needed to avoid race conditions with setting a cookie and making a request right away.
Currently it works when cookies and request handling are dispatched on the same thread and
associated mojo interfaces are used. However this will stop working if non-associated interfaces
are used, which will be the case when the cookie and loading interfaces live in different processes.
More background here:
https://docs.google.com/a/chromium.org/document/d/1eg1ohplfFGrlz5gFNgbJflRdIljPqCj58p4Zfb81QGM

We don't anticipate this having a perceptible perf impact, but added UMA stats to confirm. Cookie
getters are already sync, and this new sync call replies right when the IPC is dispatched (as
opposed to when the cookie database is updated).

BUG= 721395 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Icb7afe358a9fa969cd6fed1c2c5730fa9a18a2ec
Reviewed-on: https://chromium-review.googlesource.com/742345
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513123}
[modify] https://crrev.com/b5f10a9aa1ce4c81d26a6f53c6b533f8bae266c5/content/browser/frame_host/render_frame_message_filter.cc
[modify] https://crrev.com/b5f10a9aa1ce4c81d26a6f53c6b533f8bae266c5/content/browser/frame_host/render_frame_message_filter.h
[modify] https://crrev.com/b5f10a9aa1ce4c81d26a6f53c6b533f8bae266c5/content/browser/frame_host/render_frame_message_filter_browsertest.cc
[modify] https://crrev.com/b5f10a9aa1ce4c81d26a6f53c6b533f8bae266c5/content/common/render_frame_message_filter.mojom
[modify] https://crrev.com/b5f10a9aa1ce4c81d26a6f53c6b533f8bae266c5/content/renderer/renderer_webcookiejar_impl.cc
[modify] https://crrev.com/b5f10a9aa1ce4c81d26a6f53c6b533f8bae266c5/third_party/WebKit/Source/core/loader/CookieJar.cpp
[modify] https://crrev.com/b5f10a9aa1ce4c81d26a6f53c6b533f8bae266c5/tools/metrics/histograms/histograms.xml

Apologies, applied the wrong component in bulk.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58eab19b66fb85590854e5704163943ba4a6cb80

commit 58eab19b66fb85590854e5704163943ba4a6cb80
Author: Randy Smith <rdsmith@chromium.org>
Date: Mon Nov 13 21:44:25 2017

Shift profile_resetter over to CookieManager mojo interface.

Bug:  721395 
Change-Id: I0d4c7152dededabbc37d11a0f799837d87930958
Reviewed-on: https://chromium-review.googlesource.com/759696
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516064}
[modify] https://crrev.com/58eab19b66fb85590854e5704163943ba4a6cb80/chrome/browser/DEPS
[modify] https://crrev.com/58eab19b66fb85590854e5704163943ba4a6cb80/chrome/browser/profile_resetter/profile_resetter_browsertest.cc
[modify] https://crrev.com/58eab19b66fb85590854e5704163943ba4a6cb80/chrome/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e23356c2bd4d56b57f7da3fb39aa771a4e588d82

commit e23356c2bd4d56b57f7da3fb39aa771a4e588d82
Author: Randy Smith <rdsmith@chromium.org>
Date: Tue Nov 14 01:41:50 2017

Small cookie interface conversions away from net::CookieStore.

Specifically:
* Removed unused cookie_store.h include from chrome/browser/net
  and chrome/browser/safe_browsing.
* Switched content/public/test/browser_test_utils.cc over to Mojo accesses
  to cookies.
* The above required making the static CookieStore::BuildCookieLine
  available instead on CanonicalCookie (which is visible to Mojo clients
  when CookieStore is not).

Bug:  721395 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8565fa795a48996774bd2d1aca21763dc31af3e8
Reviewed-on: https://chromium-review.googlesource.com/764944
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516139}
[modify] https://crrev.com/e23356c2bd4d56b57f7da3fb39aa771a4e588d82/chrome/browser/android/download/intercept_download_resource_throttle.cc
[modify] https://crrev.com/e23356c2bd4d56b57f7da3fb39aa771a4e588d82/chrome/browser/net/chrome_url_request_context_getter.cc
[modify] https://crrev.com/e23356c2bd4d56b57f7da3fb39aa771a4e588d82/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify] https://crrev.com/e23356c2bd4d56b57f7da3fb39aa771a4e588d82/content/browser/frame_host/render_frame_message_filter.cc
[modify] https://crrev.com/e23356c2bd4d56b57f7da3fb39aa771a4e588d82/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/e23356c2bd4d56b57f7da3fb39aa771a4e588d82/headless/public/util/generic_url_request_job.cc
[modify] https://crrev.com/e23356c2bd4d56b57f7da3fb39aa771a4e588d82/net/cookies/canonical_cookie.cc
[modify] https://crrev.com/e23356c2bd4d56b57f7da3fb39aa771a4e588d82/net/cookies/canonical_cookie.h
[modify] https://crrev.com/e23356c2bd4d56b57f7da3fb39aa771a4e588d82/net/cookies/canonical_cookie_unittest.cc
[modify] https://crrev.com/e23356c2bd4d56b57f7da3fb39aa771a4e588d82/net/cookies/cookie_store.cc
[modify] https://crrev.com/e23356c2bd4d56b57f7da3fb39aa771a4e588d82/net/cookies/cookie_store.h
[modify] https://crrev.com/e23356c2bd4d56b57f7da3fb39aa771a4e588d82/net/cookies/cookie_store_unittest.cc
[modify] https://crrev.com/e23356c2bd4d56b57f7da3fb39aa771a4e588d82/net/cookies/cookie_store_unittest.h
[modify] https://crrev.com/e23356c2bd4d56b57f7da3fb39aa771a4e588d82/net/url_request/url_request_http_job.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2789e7e496c904eeb6a0fe6684357ccec39c4fe

commit c2789e7e496c904eeb6a0fe6684357ccec39c4fe
Author: Randy Smith <rdsmith@chromium.org>
Date: Tue Nov 14 17:16:56 2017

Switch SessionDataDeleter cookie access over to Mojo.

Bug:  721395 
Change-Id: I06b833910c11c345b0995c0ff3f7de5f64c56b82
Reviewed-on: https://chromium-review.googlesource.com/760037
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516337}
[modify] https://crrev.com/c2789e7e496c904eeb6a0fe6684357ccec39c4fe/chrome/browser/sessions/session_data_deleter.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9

commit 218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Tue Nov 21 21:41:31 2017

[Extensions] Remove callback from ExtensionService::UninstallExtension

ExtensionService::UninstallExtension takes a callback to call when the
data is removed for the extension's origin. Of the 60+ callers to this
method, the vast majority passed in base::Bind(&base::DoNothing), with
a handful more passing in an empty base::Closure. Only a single caller
(WebstoreReinstaller) passed in a "real" callback, and it appears to
be unnecessary. Additionally, the callback is already misleading - it
corresponds to removing storage partition data, but not chrome.storage
data.

This callback is also making a refactor on the cookies interface more
complicated, and may not be possible to maintain.

Remove the callback from the method interface.

Bug:  721395 ,  787563 
TBR=benwells@chromium.org (c/b/apps)
TBR=atwilson@chromium.org (c/b/background, c/b/policy)
TBR=derat@chromium.org (c/b/chromeos)
TBR=treib@chromium.org (c/b/search)
TBR=estade@chromium.org (c/b/themes)
TBR=tapted@chromium.org (c/b/ui)

Change-Id: I1cbffd781fb90a40ff597e20ae80812b8646c5ef
Reviewed-on: https://chromium-review.googlesource.com/778040
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518402}
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/apps/drive/drive_app_provider.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/background/background_application_list_model_unittest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/chromeos/extensions/gfx_utils_unittest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/chromeos/lock_screen_apps/app_manager_impl.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/chromeos/note_taking_helper_unittest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/api/management/chrome_management_api_delegate.h
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/extension_browsertest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/extension_service.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/extension_service.h
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/extension_service_test_with_install.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/extension_uninstall_dialog.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/external_install_error.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/service_worker_apitest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/shared_module_service.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/shared_module_service_unittest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/webstore_inline_installer_browsertest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/webstore_reinstaller.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/extensions/webstore_reinstaller.h
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/search/hotword_service.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/themes/theme_service.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/themes/theme_service_unittest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/ui/app_list/search/app_search_provider_unittest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/extensions/browser/api/management/management_api.cc
[modify] https://crrev.com/218df7fcaf5c9ebe6bf15dfd4110ded91792f8e9/extensions/browser/api/management/management_api_delegate.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a68c2a85cd2e3a033eaf35918db17a04379ea3f9

commit a68c2a85cd2e3a033eaf35918db17a04379ea3f9
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Wed Nov 29 19:11:26 2017

[Extensions + Storage] Remove callback from ClearDataForOrigin

DataDeleter::StartDeleting takes a callback to be fired when the
deletion is done or scheduled, but no callers use this. Additionally,
the callback is making life difficult for a cookies interface refactor.

Remove the callback from DataDeleter::StartDeleting(). Since this was
the only use of the callback in StoragePartition::ClearDataForOrigin(),
remove the callback from that interface as well.

Bug:  721395 ,  787563 
TBR=michaelbai@chromium.org (android_webview)

Change-Id: I6e90a4275703d4e356beee11f445ee4c9deaa720
Reviewed-on: https://chromium-review.googlesource.com/790754
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520185}
[modify] https://crrev.com/a68c2a85cd2e3a033eaf35918db17a04379ea3f9/android_webview/browser/aw_quota_manager_bridge.cc
[modify] https://crrev.com/a68c2a85cd2e3a033eaf35918db17a04379ea3f9/chrome/browser/extensions/data_deleter.cc
[modify] https://crrev.com/a68c2a85cd2e3a033eaf35918db17a04379ea3f9/chrome/browser/extensions/data_deleter.h
[modify] https://crrev.com/a68c2a85cd2e3a033eaf35918db17a04379ea3f9/chrome/browser/extensions/extension_service.cc
[modify] https://crrev.com/a68c2a85cd2e3a033eaf35918db17a04379ea3f9/content/browser/browsing_data/browsing_data_remover_impl_unittest.cc
[modify] https://crrev.com/a68c2a85cd2e3a033eaf35918db17a04379ea3f9/content/browser/devtools/protocol/storage_handler.cc
[modify] https://crrev.com/a68c2a85cd2e3a033eaf35918db17a04379ea3f9/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/a68c2a85cd2e3a033eaf35918db17a04379ea3f9/content/browser/storage_partition_impl.h
[modify] https://crrev.com/a68c2a85cd2e3a033eaf35918db17a04379ea3f9/content/public/browser/storage_partition.h
[modify] https://crrev.com/a68c2a85cd2e3a033eaf35918db17a04379ea3f9/content/public/test/test_storage_partition.cc
[modify] https://crrev.com/a68c2a85cd2e3a033eaf35918db17a04379ea3f9/content/public/test/test_storage_partition.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8f419888f05c537edb3e00596349d11c8c8f015

commit b8f419888f05c537edb3e00596349d11c8c8f015
Author: Randy Smith <rdsmith@chromium.org>
Date: Wed Nov 29 22:22:52 2017

Remove SetCookieWithDetailsAsync API in favor of SetCanonicalCookieAsync.

This also included writing a "CanonicalCookie::CreateSanitizedCookie()" function
for the sanitization SetCookieWithDetailsAsync used to do.

TBR=ellyjones@chromium.org
TBR=alexclarke@chromium.org
TBR=boliu@chromium.org

Bug:  721395 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idf1aa3da5206c8a188ae734b7a927da1d7c6c8bb
Reviewed-on: https://chromium-review.googlesource.com/777954
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520271}
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/android_webview/browser/net/aw_cookie_store_wrapper.cc
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/android_webview/browser/net/aw_cookie_store_wrapper.h
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/chrome/browser/android/cookies/cookies_fetcher.cc
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/chrome/browser/browsing_data/site_data_counting_helper_unittest.cc
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/chrome/browser/chromeos/login/profile_auth_data.cc
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/chrome/browser/chromeos/login/profile_auth_data_unittest.cc
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/chrome/browser/extensions/api/cookies/cookies_api.cc
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/headless/public/util/testing/generic_url_request_mocks.cc
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/headless/public/util/testing/generic_url_request_mocks.h
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/ios/net/cookies/cookie_store_ios.h
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/ios/net/cookies/cookie_store_ios.mm
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/ios/net/cookies/cookie_store_ios_persistent.h
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/ios/net/cookies/cookie_store_ios_persistent.mm
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/net/cookies/canonical_cookie.cc
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/net/cookies/canonical_cookie.h
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/net/cookies/canonical_cookie_unittest.cc
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/net/cookies/cookie_monster.cc
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/net/cookies/cookie_monster.h
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/net/cookies/cookie_store.h
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/net/cookies/cookie_store_test_helpers.cc
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/net/cookies/cookie_store_test_helpers.h
[modify] https://crrev.com/b8f419888f05c537edb3e00596349d11c8c8f015/net/cookies/cookie_store_unittest.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d227f185d493be64cfe642f248d197f8fc3fe9f8

commit d227f185d493be64cfe642f248d197f8fc3fe9f8
Author: Randy Smith <rdsmith@chromium.org>
Date: Tue Dec 05 20:16:27 2017

Add a CookieManager interface for monitoring all cookie changes.

Bug:  721395 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I8a2cd64bc04c33fa984af3ebff7d053738f5ccd4
Reviewed-on: https://chromium-review.googlesource.com/806355
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521801}
[modify] https://crrev.com/d227f185d493be64cfe642f248d197f8fc3fe9f8/content/network/cookie_manager.cc
[modify] https://crrev.com/d227f185d493be64cfe642f248d197f8fc3fe9f8/content/network/cookie_manager.h
[modify] https://crrev.com/d227f185d493be64cfe642f248d197f8fc3fe9f8/content/network/cookie_manager_unittest.cc
[modify] https://crrev.com/d227f185d493be64cfe642f248d197f8fc3fe9f8/services/network/public/interfaces/cookie_manager.mojom

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9512b33d81ec3b425f82012581f178b1d445e42a

commit 9512b33d81ec3b425f82012581f178b1d445e42a
Author: Randy Smith <rdsmith@chromium.org>
Date: Tue Dec 12 19:57:55 2017

Refactor use of StoragePartition::ClearData* methods.

This refactor is to remove the passed URLRequestContextGetter as an
argument, preperatory to shifting cookie deletion in StoragePartitionImpl
over to Mojo interfaces.

Bug:  721395 
Change-Id: I4568cb5ffd98591605a7c5d8b3850c5d8cd5d9b7
Reviewed-on: https://chromium-review.googlesource.com/754518
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523520}
[modify] https://crrev.com/9512b33d81ec3b425f82012581f178b1d445e42a/android_webview/browser/aw_quota_manager_bridge.cc
[modify] https://crrev.com/9512b33d81ec3b425f82012581f178b1d445e42a/chrome/browser/extensions/data_deleter.cc
[modify] https://crrev.com/9512b33d81ec3b425f82012581f178b1d445e42a/content/browser/browsing_data/browsing_data_remover_impl_unittest.cc
[modify] https://crrev.com/9512b33d81ec3b425f82012581f178b1d445e42a/content/browser/devtools/protocol/storage_handler.cc
[modify] https://crrev.com/9512b33d81ec3b425f82012581f178b1d445e42a/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/9512b33d81ec3b425f82012581f178b1d445e42a/content/browser/storage_partition_impl.h
[modify] https://crrev.com/9512b33d81ec3b425f82012581f178b1d445e42a/content/public/browser/storage_partition.h
[modify] https://crrev.com/9512b33d81ec3b425f82012581f178b1d445e42a/content/public/test/test_storage_partition.cc
[modify] https://crrev.com/9512b33d81ec3b425f82012581f178b1d445e42a/content/public/test/test_storage_partition.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64399d625c3f98974e4033e5ff572b41d46dc677

commit 64399d625c3f98974e4033e5ff572b41d46dc677
Author: Randy Smith <rdsmith@chromium.org>
Date: Wed Dec 20 04:33:40 2017

Shift ExtensionCookieNotifier over to Mojo.

This also allows its removal from the ProfileIOData pathway as it is no
longer associated with the IO thread.

Bug:  721395 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib58633ce6b8a597c9f4900d0bc3de2096e3d1bff
Reviewed-on: https://chromium-review.googlesource.com/806594
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525261}
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/extensions/api/cookies/cookies_api.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/extensions/extension_cookie_notifier.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/extensions/extension_cookie_notifier.h
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/extensions/extension_system_impl.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/extensions/extension_system_impl.h
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/extensions/test_extension_system.h
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/net/chrome_cookie_notification_details.h
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/profiles/off_the_record_profile_impl.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/sync/glue/extension_data_type_controller.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/sync/glue/extension_setting_data_type_controller.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/sync/glue/theme_data_type_controller.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/sync/test/integration/sync_app_helper.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/sync/test/integration/sync_app_list_helper.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/sync/test/integration/sync_extension_helper.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/extensions/browser/extension_system.h
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/extensions/browser/mock_extension_system.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/extensions/browser/mock_extension_system.h
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/extensions/shell/browser/default_shell_browser_main_delegate.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/extensions/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/extensions/shell/browser/shell_extension_system.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/extensions/shell/browser/shell_extension_system.h
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/extensions/shell/test/shell_test.cc
[modify] https://crrev.com/64399d625c3f98974e4033e5ff572b41d46dc677/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45a4b06922a58692cd9d5800219b9928e4c232f8

commit 45a4b06922a58692cd9d5800219b9928e4c232f8
Author: Randy Smith <rdsmith@chromium.org>
Date: Fri Dec 22 00:06:55 2017

Add GetCookieManagerForBrowserProcess() to StoragePartition.

This allows StoragePartition consumers who don't need their own CookieManager
interface pointer, or who need FIFO ordering for cookie requests across
multiple not-easily-sharable uses of the CookieManager to use a central
location.

Bug:  721395 
Change-Id: I6a1ae96e0ceccf59744e1b363d703b68860e65b3
Reviewed-on: https://chromium-review.googlesource.com/836750
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525867}
[modify] https://crrev.com/45a4b06922a58692cd9d5800219b9928e4c232f8/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/45a4b06922a58692cd9d5800219b9928e4c232f8/content/browser/storage_partition_impl.h
[modify] https://crrev.com/45a4b06922a58692cd9d5800219b9928e4c232f8/content/public/browser/storage_partition.h
[modify] https://crrev.com/45a4b06922a58692cd9d5800219b9928e4c232f8/content/public/test/test_storage_partition.cc
[modify] https://crrev.com/45a4b06922a58692cd9d5800219b9928e4c232f8/content/public/test/test_storage_partition.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e93faff1da7b32ad86b9402ae20289921d622d24

commit e93faff1da7b32ad86b9402ae20289921d622d24
Author: Randy Smith <rdsmith@chromium.org>
Date: Fri Dec 22 14:36:06 2017

Shift extension API code to using Mojo CookieManager interface.

This CL includes the shift of one unit test over to CookieManager as well.
The other can't be changed yet, because it targets the extensions
URLRequestContext, which doesn't have a NetworkContext wrapper yet.

Bug:  721395 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I87590f3d3fa8d98fdb90935ac5e9b1540e4d4359
Reviewed-on: https://chromium-review.googlesource.com/776017
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525989}
[modify] https://crrev.com/e93faff1da7b32ad86b9402ae20289921d622d24/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/e93faff1da7b32ad86b9402ae20289921d622d24/chrome/browser/extensions/DEPS
[modify] https://crrev.com/e93faff1da7b32ad86b9402ae20289921d622d24/chrome/browser/extensions/api/DEPS
[modify] https://crrev.com/e93faff1da7b32ad86b9402ae20289921d622d24/chrome/browser/extensions/api/cookies/cookies_api.cc
[modify] https://crrev.com/e93faff1da7b32ad86b9402ae20289921d622d24/chrome/browser/extensions/api/cookies/cookies_api.h
[modify] https://crrev.com/e93faff1da7b32ad86b9402ae20289921d622d24/chrome/browser/extensions/api/cookies/cookies_helpers.cc
[modify] https://crrev.com/e93faff1da7b32ad86b9402ae20289921d622d24/chrome/browser/extensions/api/cookies/cookies_helpers.h
[modify] https://crrev.com/e93faff1da7b32ad86b9402ae20289921d622d24/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/e93faff1da7b32ad86b9402ae20289921d622d24/content/network/cookie_manager.cc
[modify] https://crrev.com/e93faff1da7b32ad86b9402ae20289921d622d24/content/network/cookie_manager_unittest.cc
[modify] https://crrev.com/e93faff1da7b32ad86b9402ae20289921d622d24/services/network/public/interfaces/cookie_manager.mojom
[modify] https://crrev.com/e93faff1da7b32ad86b9402ae20289921d622d24/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9240dadb49ddf8727b5bb23536c39745c657097e

commit 9240dadb49ddf8727b5bb23536c39745c657097e
Author: Randy Smith <rdsmith@chromium.org>
Date: Fri Dec 22 16:46:35 2017

Shift CookieManager deletion implementation over to early return.

Bug:  721395 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I1a304a73965a57bc9dae35004f1ae1e84d61456a
Reviewed-on: https://chromium-review.googlesource.com/798190
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526008}
[modify] https://crrev.com/9240dadb49ddf8727b5bb23536c39745c657097e/content/network/cookie_manager.cc

reillyg@, is this done?

This is not done yet. In terms of our Windows canary launch  issue 792660  and  issue 792663  appear to be the most important blockers. The later one dovetails nicely after I finish my other active DICE-related Network Service work.

Removing Windows flag as all Windows canary-blocking issues have been resolved.

i would assume Mac and Linux are also fixed.

 Issue 792676 , which tracks CookieManager migration for Chrome Headless still applies to Linux, macOS and Windows.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91ea2c1a48f86fa5d5b4eb7e4fefdc13b1953706

commit 91ea2c1a48f86fa5d5b4eb7e4fefdc13b1953706
Author: Reilly Grant <reillyg@google.com>
Date: Mon Sep 17 22:34:45 2018

Reconnect ExtensionCookieNotifier on Network Service restart

This change adds a connection error handler to ExtensionCookieNotifier
so that if the Mojo connection it is using to listen for cookie change
events it closed it will attempt to open a new one.

An unnecessary check for Profile validity has been removed since this
code now runs on the UI thread and the object is owned by a
KeyedService.

Bug:  721395 
Change-Id: I433250c7671fd16031c8507c2287e033414ab204
Reviewed-on: https://chromium-review.googlesource.com/1228955
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591848}
[modify] https://crrev.com/91ea2c1a48f86fa5d5b4eb7e4fefdc13b1953706/chrome/browser/extensions/extension_cookie_notifier.cc
[modify] https://crrev.com/91ea2c1a48f86fa5d5b4eb7e4fefdc13b1953706/chrome/browser/extensions/extension_cookie_notifier.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e53c8ceda9d0db1e186656abd1297ef0203f8344

commit e53c8ceda9d0db1e186656abd1297ef0203f8344
Author: Reilly Grant <reillyg@google.com>
Date: Fri Sep 21 16:58:11 2018

Remove TestingProfile::GetCookieStore()

This method was only used by the BrowsingDataCookieHelper unit tests,
which this change converts to using the network::mojom::CookieManager
interface.

Bug:  721395 
Change-Id: Ia4f5a54221d0ce902a42e8f910230ad0d732b7ee
Reviewed-on: https://chromium-review.googlesource.com/1236289
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593231}
[modify] https://crrev.com/e53c8ceda9d0db1e186656abd1297ef0203f8344/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc
[modify] https://crrev.com/e53c8ceda9d0db1e186656abd1297ef0203f8344/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/e53c8ceda9d0db1e186656abd1297ef0203f8344/chrome/test/base/testing_profile.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0aa1d243f6df50e26930493492164a1550ff63d1

commit 0aa1d243f6df50e26930493492164a1550ff63d1
Author: Reilly Grant <reillyg@google.com>
Date: Wed Oct 03 19:41:11 2018

Use network::mojom::CookieManager in RemoveSafeBrowsingCookieTester

This change updates RemoveSafeBrowsingCookieTester and its base class
RemoveCookieTester to use the CookieManager Mojo interface instead of
the net::CookieStore interface directly.

These tests now pass however I am leaving them marked as disabled until
issue 812589 is investigated more thoroughly.

Bug:  721395 ,812589
Change-Id: Iaadf98b31969bd159dfda5f5ff0802b8c8dd3239
Reviewed-on: https://chromium-review.googlesource.com/c/1257785
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596328}
[modify] https://crrev.com/0aa1d243f6df50e26930493492164a1550ff63d1/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc