Peek content of InfoBar that appears behind existing one |
|||
Issue descriptionIf an infobar appears while another one is already showing, the new infobar should peek it's content to more clearly indicate to the user that it is there. - The content peek amount will be 48dp (the min infobar height). - The peeking infobar will not be interactive. - After peeking, the infobar will animate down to only show the very top of the infobar.
,
May 16 2017
The peeking animation curve and timing looks good to me
,
May 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58394da4f0c15dce8e8dbe2da801dd34e7e9f95c commit 58394da4f0c15dce8e8dbe2da801dd34e7e9f95c Author: mdjones <mdjones@chromium.org> Date: Mon May 22 22:03:20 2017 Peek new infobars behind existing ones This change extends the peeking behavior when there are multiple infobars attempting to show simultaneously. When a new infobar is added, it will peek above the existing ones giving a brief view of it's contents and bringing more attention to it. BUG= 721389 Review-Url: https://codereview.chromium.org/2846663002 Cr-Commit-Position: refs/heads/master@{#473719} [modify] https://crrev.com/58394da4f0c15dce8e8dbe2da801dd34e7e9f95c/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainerLayout.java [modify] https://crrev.com/58394da4f0c15dce8e8dbe2da801dd34e7e9f95c/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarWrapper.java
,
May 22 2017
,
Jul 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b35707030c0d21c8bd64b4290c64116e54f539b commit 4b35707030c0d21c8bd64b4290c64116e54f539b Author: Matthew Jones <mdjones@chromium.org> Date: Sat Jul 08 00:25:32 2017 Revert "Peek new infobars behind existing ones" This reverts commit 58394da4f0c15dce8e8dbe2da801dd34e7e9f95c as it causes a crash and undesirable behavior in the existing infractructure. BUG=729575, 729611, 721389 Change-Id: I029fcc2c6d63b849bf511e57bd2737acb0b6325f Reviewed-on: https://chromium-review.googlesource.com/564081 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#485112} [modify] https://crrev.com/4b35707030c0d21c8bd64b4290c64116e54f539b/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainerLayout.java [modify] https://crrev.com/4b35707030c0d21c8bd64b4290c64116e54f539b/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarWrapper.java
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc36fe03f544265b13057ec92cde9d2d1df3b23f commit fc36fe03f544265b13057ec92cde9d2d1df3b23f Author: Megan Jablonski <megjablon@google.com> Date: Tue Jul 11 18:14:55 2017 Revert "Peek new infobars behind existing ones" This reverts commit 58394da4f0c15dce8e8dbe2da801dd34e7e9f95c as it causes a crash and undesirable behavior in the existing infractructure. BUG=729575, 729611, 721389 TBR=mdjones@chromium.org (cherry picked from commit 4b35707030c0d21c8bd64b4290c64116e54f539b) Change-Id: I029fcc2c6d63b849bf511e57bd2737acb0b6325f Reviewed-on: https://chromium-review.googlesource.com/564081 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#485112} Reviewed-on: https://chromium-review.googlesource.com/567232 Reviewed-by: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#583} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/fc36fe03f544265b13057ec92cde9d2d1df3b23f/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainerLayout.java [modify] https://crrev.com/fc36fe03f544265b13057ec92cde9d2d1df3b23f/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarWrapper.java |
|||
►
Sign in to add a comment |
|||
Comment 1 by mdjones@chromium.org
, May 11 2017