New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 721383 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: May 2017
Cc:
█ vpalatin@chromium.org
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Add dedicated (non-type-c) charger

Project Member Reported by dnojiri@chromium.org, May 11 2017 
Charge manager (common/charge_manager.c) assumes all power suppliers are USB PD ports. This prevents a different type of charger (e.g. barrel jack) from working.
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/bb1b65a17754e7e38d52720db3ad68e95e5d905e

commit bb1b65a17754e7e38d52720db3ad68e95e5d905e
Author: Daisuke Nojiri <dnojiri@chromium.org>
Date: Fri May 12 00:15:47 2017

charger: Add dedicated (non-type-c) charger

This patch adds a dedicated charge port. The number of such ports
is specified by CONFIG_DEDICATED_CHARGE_PORT_COUNT. It works as a
sink only. The total number of charge ports is represented by
CHARGE_PORT_COUNT.

BUG= chromium:721383 
BRANCH=none
TEST=make buildall. Boot Fizz off of barrel jack.

Change-Id: Ibbb11f3e1c66e35b5abe190e49161eeaa2009994
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/501468
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>

[modify] https://crrev.com/bb1b65a17754e7e38d52720db3ad68e95e5d905e/include/charge_manager.h
[modify] https://crrev.com/bb1b65a17754e7e38d52720db3ad68e95e5d905e/board/kevin/board.h
[modify] https://crrev.com/bb1b65a17754e7e38d52720db3ad68e95e5d905e/common/charge_manager.c
[modify] https://crrev.com/bb1b65a17754e7e38d52720db3ad68e95e5d905e/include/config.h

Comment 2 by dnojiri@chromium.org, May 12 2017

Status: Fixed (was: Untriaged)

Comment 3 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment