Issue metadata
Sign in to add a comment
|
Lines left behind on page when moving scaled divs
Reported by
vpberr...@gmail.com,
May 11 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 Example URL: https://jsfiddle.net/x92p1jts/ Steps to reproduce the problem: 1. Go to the JSFiddle URL provided 2. Drag the box around slowly with the mouse 3. If no artifacts left behind, adjust the scale with the mousewheel and scroll again What is the expected behavior? The box moves around cleanly What went wrong? When the box is moved around it leaves behind lines on the page Does it occur on multiple sites: Yes Is it a problem with a plugin? N/A Did this work before? Yes Does this work in other browsers? Yes Chrome version: 58.0.3029.110 Channel: stable OS Version: 10.0 Flash Version: 25.0.0.171 I previously had a bug open for this ( Issue 622232 ) and it seemed fixed for a while. I think that this is a regression (Unsure of the last version it was working on though)
,
May 11 2017
,
May 11 2017
Reported as regression and updating priority.
,
May 11 2017
Reproduces on Win 10 with Version 58.0.3029.81 beta (64-bit). Does not reproduce in Version 60.0.3083.0 (Official Build) canary (64-bit). Bisect please. Although we're unlikely to fix M-58, we do want to be sure the fix makes it into M-59.
,
May 11 2017
Reproduced on Mac Retina on 58.0.3029.110 and 60.0.3083.0, but not on 57.0.2987.133 and 60.0.3096.0. However I couldn't reproduce in bisect.
,
May 11 2017
Managed to bisect. Regressed range: https://chromium.googlesource.com/chromium/src/+log/0bd994d15c644515a66f1ddd081122894e314e3b..b4dde882f6c2b2be84035b53f60ec286d347bc50 Fixed range: https://chromium.googlesource.com/chromium/src/+log/c1036c002f34914a521b631d57b8c7bdd01f4ce3..f8e03c0c5adc572d5e1f51e4093cecb0e661f05e In the first range we disabled SlimmingPaintInvalidation and in the second range we enabled it. Though SlimmingPaintInvalidation is enabled by default in M59, we will launch 1% reverse experiment of SlimmingPaintInvalidation so we still need to fix it. Bisected with --disable-slimming-paint-invalidation and found the following regression range: https://chromium.googlesource.com/chromium/src/+log/a9e7f034a9aa1353d418d8ac3c745a0450763c05..ed71ca7437db67890fdc2848ff4edea9aa2b0cca Suspecting https://chromium.googlesource.com/chromium/src/+/3a2c4663e5be244f263af1a7824bae449a927524. r469772 should have fixed this for non-SPInvalidation. Request merge of the LayoutBox.cpp part of r469772.
,
May 12 2017
removing the bisect label as already updated the bisect in comment #6.
,
May 12 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ffe68d4df63647d3f30a2bd88aecec16634aec4 commit 6ffe68d4df63647d3f30a2bd88aecec16634aec4 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Sat May 13 20:47:38 2017 Expand to pixels before transform in LayoutBox::MapVisualRectToContainer This merges the LayoutBox.cpp part of https://crrev.com/469772. It ensures the paint invalidation rect covers non-translation transformed contents no matter if the contents are pixel snapped. BUG= 721370 NOTRY=true NOPRESUBMIT=true TBR=wangxianzhu@chromium.org Review-Url: https://codereview.chromium.org/2883753002 Cr-Commit-Position: refs/branch-heads/3071@{#545} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/6ffe68d4df63647d3f30a2bd88aecec16634aec4/third_party/WebKit/Source/core/layout/LayoutBox.cpp
,
May 13 2017
,
May 17 2017
Verified this issue on Mac OS 10.12 and Windows-10 using chrome latest beta M59-59.0.3071.61 by following steps mentioned in the original comment, Observed no artifacts left behind while moving the box around. Hence adding TE-Verified label. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, May 11 2017