New issue
Advanced search Search tips

Issue 721363 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task
Team-Security-UX



Sign in to add a comment

Missing an end-to-end test for navigation with DevTools security panel

Project Member Reported by est...@chromium.org, May 11 2017

Issue description

We should add a test for  issue 713203 , where a navigation was failing to display properly in the security panel. In particular, the security info for the main resource request was not showing up in DevTools.
 

Comment 1 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 2 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt
Cc: est...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Some more detail about this bug.


First, this bug is about a specific test case, but I think in general it would be useful to have end-to-end tests that the security panel is functioning properly, not necessarily this test case specifically. The security panel has layout tests, which simulate messages from the browser to the renderer and then check that the security panel displays properly. We should also have end-to-end browser tests that don't simulate messages from the browser to the renderer but instead do the real thing. (https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/http/tests/devtools/security/origin-view-ct-compliance.js is an example of a layout test, and the other tests in that directory. They construct devtools messages in the test rather than testing the messages that the browser actually sends in real life.)

End-to-end security panel tests could live in chrome/browser/ssl/ssl_browsertest.cc, or in a new file in that directory. So an example of an end-to-end test might be:
1.) Navigate to an https page.
2.) Open DevTools using the helpers in chrome/browser/devtools/devtools_window_testing.h (DevToolsWindowTesting::OpenDevToolsWindowSync).
3.) Switch to the security panel and execute Javascript that checks that the correct information is shown. https://cs.chromium.org/chromium/src/chrome/browser/devtools/devtools_sanity_browsertest.cc?dr=CSs&g=0&l=187 looks like it is an example of how to switch to a particular panel, and https://cs.chromium.org/chromium/src/chrome/browser/devtools/devtools_sanity_browsertest.cc?dr=CSs&g=0&l=1328 an example of how to execute JS in the devtools window.

I can help dig into any of these steps more if needed!
Owner: est...@chromium.org
Status: Assigned (was: Available)
Making sure this is not lost.
Components: Tests>Missing
Components: -Test>Missing
 Issue 558184  has been merged into this issue.

Sign in to add a comment