Observer properties should be "weak" (as opposed to "assign"). |
|||||
Issue descriptionObservableBoolean should have a weak reference to its observer. This is to prevent |observer| from ever being a dangling pointer, thus making our code less crash-prone. In addition this would allow us to remove nearly all occurrences of "setObserver:nil" in the codebase, and thus remove a bunch of deallocs.
,
May 11 2017
,
May 17 2017
,
Aug 25 2017
ObservableBoolean is from settings code
,
Sep 27
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jif@chromium.org
, May 11 2017