New issue
Advanced search Search tips

Issue 721338 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

voice_icon_keyboard_accessory not found upstream

Project Member Reported by gambard@chromium.org, May 11 2017

Issue description

voice_icon_keyboard_accessory image is not available upstream. It is displayed above the keyboard for example.
 
I think the icon should be accessed through the provider too.
Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91763e4b9dcc698868d3140d83db15e3a59498f8

commit 91763e4b9dcc698868d3140d83db15e3a59498f8
Author: gambard <gambard@chromium.org>
Date: Thu May 11 13:08:25 2017

Whitelist voice_icon_keyboard_accessory as not found image

voice_icon_keyboard_accessory is not available upstream but it is used in the
code. This CL adds it as an exception.

BUG= 721338 

Review-Url: https://codereview.chromium.org/2871173007
Cr-Commit-Position: refs/heads/master@{#470936}

[modify] https://crrev.com/91763e4b9dcc698868d3140d83db15e3a59498f8/ios/chrome/app/startup/setup_debugging.mm

Project Member

Comment 3 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c485baf2b38d83473ebf49c40c81b95115d8d383

commit c485baf2b38d83473ebf49c40c81b95115d8d383
Author: gambard <gambard@chromium.org>
Date: Thu May 11 14:49:03 2017

Whitelist voice_icon as not found image

voice_icon is not available upstream but it is used in thecode. This CL adds it
as an exception.

BUG= 721338 
TBR=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2877703004
Cr-Commit-Position: refs/heads/master@{#470955}

[modify] https://crrev.com/c485baf2b38d83473ebf49c40c81b95115d8d383/ios/chrome/app/startup/setup_debugging.mm

Comment 4 by jif@chromium.org, Jul 6 2017

Owner: jif@chromium.org
Should be fixed once the old keyboard accessory view is deleted.
Owner: ----
Status: Untriaged (was: Assigned)
jif@ is no longer on the team. Releasing his bugs for triage.

Comment 6 by sczs@chromium.org, Jun 27 2018

Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)
gambard@ has this issue been fixed now? Can we close it?
Status: Fixed (was: Assigned)

Sign in to add a comment