New issue
Advanced search Search tips

Issue 721331 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature
Team-Blink-Paint



Sign in to add a comment

Implement cloning of geometry interfaces

Reported by sim...@opera.com, May 11 2017

Issue description

See
https://github.com/w3c/fxtf-drafts/pull/147
https://github.com/w3c/web-platform-tests/pull/5888

Chromium and Gecko do not yet support cloning of these.

The use case is sending a copy of an instance to a worker with postMessage() (without having to unwrap them in author code to avoid DataCloneError).

https://lists.w3.org/Archives/Public/public-fx/2014OctDec/0007.html for earlier email thread when cloning was first specified.

I think this is not a showstopper for shipping, but I think it makes sense to have.
 

Comment 1 by fs...@chromium.org, May 11 2017

Cc: -fs...@chromium.org
Components: Blink>Geometry
Labels: -Type-Bug Type-Feature
Owner: fs...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by fs...@chromium.org, May 12 2017

Status: Started (was: Assigned)

Comment 3 by fs...@chromium.org, May 12 2017

A initial CL for this is up. Will wait for the WPT pull request to merge before closing this.

Comment 4 by sim...@opera.com, May 15 2017

I've now landed the spec change and WPT PR.

Comment 5 by fs...@chromium.org, May 16 2017

awesome! :) thanks.
Project Member

Comment 6 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e8060a43d58b5e94f8c88518283376242e286b5

commit 9e8060a43d58b5e94f8c88518283376242e286b5
Author: fserb <fserb@chromium.org>
Date: Mon May 29 19:25:34 2017

Implement serialization/deserialization of geometry interfaces

The WPT tests are in good shape but not submitted yet:
https://github.com/w3c/web-platform-tests/pull/5888

BUG= 721331 

Review-Url: https://codereview.chromium.org/2874203003
Cr-Commit-Position: refs/heads/master@{#475371}

[delete] https://crrev.com/168dc2f3cb966091dcca1abb798b5c4ebd7c5437/third_party/WebKit/LayoutTests/external/wpt/css/geometry-1/structured-serialization-expected.txt
[modify] https://crrev.com/9e8060a43d58b5e94f8c88518283376242e286b5/third_party/WebKit/Source/bindings/core/v8/serialization/SerializationTag.h
[modify] https://crrev.com/9e8060a43d58b5e94f8c88518283376242e286b5/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp
[modify] https://crrev.com/9e8060a43d58b5e94f8c88518283376242e286b5/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp
[modify] https://crrev.com/9e8060a43d58b5e94f8c88518283376242e286b5/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
[modify] https://crrev.com/9e8060a43d58b5e94f8c88518283376242e286b5/third_party/WebKit/Source/core/geometry/DOMMatrix.cpp
[modify] https://crrev.com/9e8060a43d58b5e94f8c88518283376242e286b5/third_party/WebKit/Source/core/geometry/DOMMatrix.h
[modify] https://crrev.com/9e8060a43d58b5e94f8c88518283376242e286b5/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp
[modify] https://crrev.com/9e8060a43d58b5e94f8c88518283376242e286b5/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h

Comment 7 by fs...@chromium.org, May 29 2017

Status: Fixed (was: Started)
donerine.

Sign in to add a comment