New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 721304 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
█ rsgav...@chromium.org
█ ppolise...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Stylus Text selection does not work from M os onwards

Reported by mahesh...@samsung.com, May 11 2017 
Steps to reproduce the problem:
1. Open google.com->Click on Privacy
2. Try Stylus selection pressing Stylus button on text
3. Page is scrolling instead of selecting text

What is the expected behavior?
Text should be selected.

What went wrong?
From M os onwards , the motion event for Stylus button pressed has changed.

Did this work before? N/A 

Chrome version: 57.0.2987.133  Channel: stable
OS Version: M os onwards
Flash Version:

Comment 1 by ppolise...@chromium.org, May 12 2017

Labels: Needs-Feedback
Hello

Thanks for reporting the issue. However, we were unable to repro this issue on Galaxy Note5(SM-N920I)/MMB29K. Can you please provide additional info like name, model of your device, bugreport/logcat for the issue? Also, can you please provide a video for the issue, if possible?

Comment 2 by mahesh...@samsung.com, May 15 2017 

Stylus selection needs to be done with the stylus button pressed.
Press the stylus button and drag on any text. Selection is not happening.

App version - Chrome 58.0.3029.83
Android 7.0.0 SM-N920L Build/NRD90M
20170515_101718.mp4
5.9 MB View Download
Project Member

Comment 3 by sheriffbot@chromium.org, May 15 2017

Cc: ppolise...@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "ppolisetty@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by mahesh...@samsung.com, May 15 2017 

I think I have found a fix. 
https://codereview.chromium.org/2874183002/
Project Member

Comment 5 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/529c2f2c71f13edbfd34df3c8c1129f39edaeb3f

commit 529c2f2c71f13edbfd34df3c8c1129f39edaeb3f
Author: mahesh.ma <mahesh.ma@samsung.com>
Date: Wed May 24 03:01:47 2017

[Android] Fix Text selection with Stylus button pressed from Android M

Stylus text selection with stylus button pressed does not work from
Android M as the button state for stylus event has been changed. Add
code to support new button state - MotionEvent::BUTTON_STYLUS_PRIMARY.

BUG= 721304 

Review-Url: https://codereview.chromium.org/2874183002
Cr-Commit-Position: refs/heads/master@{#474141}

[modify] https://crrev.com/529c2f2c71f13edbfd34df3c8c1129f39edaeb3f/content/browser/renderer_host/input/stylus_text_selector.cc
[modify] https://crrev.com/529c2f2c71f13edbfd34df3c8c1129f39edaeb3f/content/browser/renderer_host/input/stylus_text_selector_unittest.cc

Comment 6 by rsgav...@chromium.org, May 24 2017

Labels: Needs-Feedback
Can this issue be closed?

Comment 7 by mahesh...@samsung.com, May 26 2017 

Yes.
Project Member

Comment 8 by sheriffbot@chromium.org, May 26 2017

Cc: rsgav...@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "rsgavara@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by candr...@chromium.org, Sep 16 2017

Status: Fixed (was: Unconfirmed)
Thanks.  Closing as per C#7.
►

Sign in to add a comment