Regression : Ripple effect on 'RELAUNCH' button does not have proper spacing on left & right side.
Reported by
avsha...@etouch.net,
May 11 2017
|
||||
Issue descriptionChrome Version : 60.0.3096.0 (Official Build) c714b929856634f69e66588db294ccb8b785ad25-refs/heads/master@{#470759} 32/64 bit OS : Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://md-settings, scroll down the page and expand 'Advanced' section. 2. Under 'Privacy & security' section, Enable/Disable "Automatically send usage statistics and crash.." option. 3. Click and hold on 'RELAUNCH' button and observe the ripple effect. Actual : Ripple effect on 'RELAUNCH' button does not have proper spacing on left & right side (i.e Ripple effect appears to be chopped from either side). Expected : Ripple effect should have proper spacing on both the sides. This is a regression issue broken in ‘M-60’, below is the Manual Regression range and will soon update other info. Good build : 60.0.3095.5 Bad build : 60.0.3096.0
,
May 16 2017
,
May 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c8d005df63e8ef30df1ed4f0afe469cca335b2c commit 2c8d005df63e8ef30df1ed4f0afe469cca335b2c Author: dschuyler <dschuyler@chromium.org> Date: Wed May 17 03:18:39 2017 [MD settings] removing secondary-button class This CL removes the global .secondary-button class. At one point we had several types of buttons, but we eventually narrowed down to two buttons: .primary-button and .secondary-button; though some buttons were not specified as either. That meant we effectively had three button classes. Rather than add .secondary-button to each paper-button that isn't explicitly secondary already, I've removed that class. Now there are .primary-buttons and normal buttons; i.e. any non-primary-button is a secondary button (aka normal) button. Note: The references to .secondary-button are still in place (based on Steven's review comment below) and there are a couple places where a .secondary-button is used locally within a dom-module; those have been left unchanged. BUG= 721268 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2889493002 Cr-Commit-Position: refs/heads/master@{#472301} [modify] https://crrev.com/2c8d005df63e8ef30df1ed4f0afe469cca335b2c/chrome/browser/resources/settings/settings_shared_css.html
,
May 17 2017
,
May 23 2017
Tested the issue on windows 7, Mac 10.12.4 and Linux Ubuntu 14.04 using chrome version#60.0.3107.4 with the steps mentioned in comment #0. Observed that the fix is working as expected.Hence adding TE-Verified labels. Please find the attached screen cast for the same. Thanks!! |
||||
►
Sign in to add a comment |
||||
Comment 1 by avsha...@etouch.net
, May 11 2017Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)