With those complications, I really wonder if we can change the code to not have the service know about all these details. IMO, that's a sign that the service should not decide whether or not to use the Google server. It should simply forward the favicon request to the provider (either directly or through the some abstraction like the ContentSuggestion itself) and the provider can do what needs to be done.

Note: The provider starts accumulating a lot of "pull functionality" where it's original purpose is to push information. I wonder if we can move such "pull functionality" from the provider and make it available through suggestion-specific classes.

Favicon fetching is code that should get removed if we switch to jardin on both Android and iOS. Keeping only for reference.

Some clean-up might be beneficial if some parts of the code survive longer (e.g. iOS, Android tablets, ...)

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Can we close this?

The question should go to jardin team. From my point of view, yes.

twellington: See comment 6.
Removing iOS bit.

Issue 708479 has been merged into this issue.

+fgorski@ recently made some changes around favicon fetching for Jardin. Filip, please see comment 6.

This is no longer an issue.

With Simplified NTP launched we only present Remote Suggestions.