New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 721256 link

Starred by 1 user
Status: Fixed
Owner:
tommycli@chromium.org
Closed: May 2017
Cc:
nyerramilli@chromium.org
kkaluri@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Empty passphrase is not allowed' error message is seen after opening 'reset sync' link via tab focus

Reported by sans...@etouch.net, May 11 2017 
Chrome Version : 60.0.3095.5 (Official Build) 72e83b35450360b17a9d1f70e30c86d7a881ec34-refs/branch-heads/3095@{#5} 32/64-bit
OS: Windows(7,8,10), Linux (14.04 LTS), Mac (10.11.6, 10.12.3)

Steps:
1. Launch Chrome and sign in to Chrome with valid credential
2. Navigate to chrome://settings/syncSetup and click on 'Encrypt synced data with your own sync passphrase'
3. Press tab key till focus is on 'reset sync' link and hit Enter key(link opens in new tab) 
4. Switch back to previous tab (chrome://settings/syncSetup)and observe at Passphrase field 

Actual: 'Empty passphrase is not allowed' error message is seen after opening 'reset sync' link via tab focus

Expected: 'Empty passphrase is not allowed' error message should not be seen after opening 'reset sync' link via tab focus

This is a regression issue broken in ‘M-58’ and will soon update other info.

Good build :58.0.2990.0
Bad build :58.0.2991.0
Actual_video.mp4
446 KB View Download
Expected_video.mp4
369 KB View Download

Comment 1 by kkaluri@chromium.org, May 11 2017

Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build : 58.0.2990.0 ,  Revision Range - 445313
Bad build  : 58.0.2991.0 ,  Revision Range - 445609

After executing the per-revision bisect script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/8e6835872476554e6ccc30565424434faee1a6e3..c2f23d8d70cf93aef29ee64a957ab6a8714798b7


The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/c2f23d8d70cf93aef29ee64a957ab6a8714798b7


Review-Url: https://codereview.chromium.org/2632783003

tommycli@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.
Project Member

Comment 2 by bugdroid1@chromium.org, May 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7527494451ef6967ba4f39c657782b4babccbc7e

commit 7527494451ef6967ba4f39c657782b4babccbc7e
Author: tommycli <tommycli@chromium.org>
Date: Tue May 16 18:18:27 2017

MD Settings: Improve Sync Page Enter key handling.

Removes problematic usage of iron-a11y-keys and replaces it with a
simpler on-keypress handler.

Also fixes a bug.

BUG= 721256 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TEST=MANUAL

Review-Url: https://codereview.chromium.org/2882143003
Cr-Commit-Position: refs/heads/master@{#472163}

[modify] https://crrev.com/7527494451ef6967ba4f39c657782b4babccbc7e/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/7527494451ef6967ba4f39c657782b4babccbc7e/chrome/browser/resources/settings/people_page/sync_page.js

Comment 3 by tommycli@chromium.org, May 16 2017

Status: Fixed (was: Assigned)

Comment 4 by sureshkumari@chromium.org, May 23 2017

Labels: TE-Verified-60.0.3107.4 TE-Verified-M60
Tested the issue on windows 7, Mac 10.12.4, Linux Ubuntu 14.04 using chrome version#60.0.3107.4 with the steps mentioned in comment #0.
Observed that the fix is working as expected.Hence adding TE-Verified labels.
Please find the attached screen cast for the same.

Thanks!!
721256.mov
3.8 MB Download
►

Sign in to add a comment