New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721252 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocked on:
issue 722788



Sign in to add a comment

"Add Person" UX has some inconsistencies and confusing elements (anecdote).

Project Member Reported by d...@chromium.org, May 11 2017

Issue description

Chrome Version: 58.0.3029
OS: Windows 10

What steps will reproduce the problem?
(1) Click profile tab in title bar.
(2) Select "Manage People"
(3) Click "Add Person"

What is the expected result?
The most intuitive user experience possible :)

What happens instead?
I am reporting an anecdote based on observation of my significant other attempting to register a second account in Chrome. Take it with a grain of salt.

1) The "Add person" title looks like an input field. They clicked it multiple times expecting something to happen. When I asked why afterwards, they noted the similar font, the fact that it was in the same plane as other UI elements, and the underline suggesting text entry, which it does in the "Name" element immediately below.

2) It is not obvious when an avatar was selected. The thin blue border was not immediately observed, and they clicked their desired avatar multiple times before recognizing it.

3) They hesitated to click the "Save" button. When I asked why, they responded that they thought they might have the wrong dialog, and that "Save" implied that existing data would be overwritten. I would suggest naming the button after the appropriate verb, "Add".

FWIW I agree with all of these points, and think that they have merit. Notably, I recall encountering (2), taking a few for me to realize that the avatar that I clicked was, in fact, selected.

Please use labels and text to provide additional information.

(See attached screenshot for annotations)

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
 
LF6xocjXYNd.png
120 KB View Download
Owner: ew...@chromium.org
Status: Assigned (was: Untriaged)
Sounds reasonable. Eli, is this something we should improve?

Comment 2 by ew...@chromium.org, May 15 2017

Cc: srahim@chromium.org ew...@chromium.org bsazonov@chromium.org
Labels: OS-Linux OS-Mac OS-Windows
Owner: bettes@chromium.org
All sound like reasonable pieces of feedback to me!

+Alan and Shimi for UX input on each of these three points. The first two are visual design questions (for Alan) and the last one is a string question (for Shimi).

Comment 3 by srahim@chromium.org, May 15 2017

re: the third comment, we try to align the title and button text when it makes sense. I agree that it makes sense here to use "Add" as the CTA.

The rest of the feedback sounds reasonable to me as well, especially the comment about the horizontal rule under the title "Add person."

I would also add that, rather than auto-populating a name like "Person 1", it would be better UX to use proper hint text. Either something simple like "Enter a name" or more detailed, like "Enter a name to differentiate this profile, like "Work" or "Personal"" --- if that is in fact the kind of guidance we want to give. 

"Person 1/2/3" as hint text seems like exactly the opposite of what would be useful for managing different profiles.

Comment 4 by ew...@chromium.org, May 16 2017

Blockedon: 722788

Comment 5 by ew...@chromium.org, May 16 2017

OK, so let's definitely update the action button to "ADD" instead of "SAVE." I filed  Issue 722788  to track that.

Updating the logic for the default names will be trickier for other reasons, so I'd like to separate out that feedback for now.

Alan - still curious to hear your feedback on (1) and (2). I can file bugs for those once we figure out exactly what updates (if any) we want to make.

Comment 6 by bettes@chromium.org, May 19 2017

Cc: -ew...@chromium.org
Owner: ew...@chromium.org
1. The rule line was used to bring some hierarchy, but probably can be removed if it's causing confusion. I've attached some instructions for the bug. 

2. Let's just add an additional pixel:

Actual: 1px solid Google Blue 500
Expected: 2px solid Google Blue 500
rule-line.png
387 KB View Download

Comment 7 by ew...@chromium.org, May 19 2017

Cc: msarda@chromium.org ew...@chromium.org
Owner: jlebel@chromium.org
Over to Jerome to make the UI tweaks described above (removing rule line, squishing the content together vertically, removing the supervised user icon, and adding a pixel to the blue border for the selected avatar).
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 19 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: jlebel@chromium.org
Owner: scottchen@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f693ed6ba49ae613b04f641b1ebf252af0167ef4

commit f693ed6ba49ae613b04f641b1ebf252af0167ef4
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Nov 07 15:21:48 2017

[signin] user manager ui updates.

- removed rule-lines under title
- bring title closer to content
- content centers vertically in the window
- supervisor icons removed

Bug:  721252 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I72c6c035efb5911d2360d32abe7b9bb06ee98038
Reviewed-on: https://chromium-review.googlesource.com/753364
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514472}
[modify] https://crrev.com/f693ed6ba49ae613b04f641b1ebf252af0167ef4/chrome/browser/browser_resources.grd
[modify] https://crrev.com/f693ed6ba49ae613b04f641b1ebf252af0167ef4/chrome/browser/resources/md_user_manager/create_profile.html
[delete] https://crrev.com/bd7ae2fdffcad95add12407ca671f3e1f4657c9b/chrome/browser/resources/md_user_manager/icons.html
[modify] https://crrev.com/f693ed6ba49ae613b04f641b1ebf252af0167ef4/chrome/browser/resources/md_user_manager/supervised_user_create_confirm.html
[modify] https://crrev.com/f693ed6ba49ae613b04f641b1ebf252af0167ef4/chrome/browser/resources/md_user_manager/supervised_user_learn_more.html
[modify] https://crrev.com/f693ed6ba49ae613b04f641b1ebf252af0167ef4/chrome/browser/ui/webui/signin/md_user_manager_ui.cc

Status: Fixed (was: Started)
Labels: TE-Verified-M64 TE-Verified-64.0.3262.0
Tested the issue on Windows 7, Mac OS 10.12.6 and Ubuntu 14.04 using chrome version 64.0.3262.0 by following the steps mentioned in the original comment and issue seems to be fixed.

Observed that when a avatar is selected, the blue border looks more clear and instead of 'Save', the 'Add' button is seen. Also there is no line under Add Person.
Attached screen shot for reference.

Hence adding TE-Verified Labels.

Thanks!

721252.png
103 KB View Download

Comment 14 by d...@chromium.org, Nov 8 2017

Looks great - thanks for taking my report seriously and acting on it!

Sign in to add a comment