New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721249 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

<select> with white-space, the selected <option>'s label is not displayed

Reported by ham...@gmail.com, May 11 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36

Example URL:

Steps to reproduce the problem:
1. Display <select> with white-space, first <option>'s label is blank.
2. Select other <option>.

sample html
========
<html>

<style type="text/css">
select {
  white-space: normal;
}
</style>

<body>
<form>
<select>
    <option value="0"></option>
    <option value="1">bar</option>
    <option value="2">foo</option>
</select>
</form>
</body>
</html>
========

What is the expected behavior?
Display other <option>'s label(bar or foo).

What went wrong?
It does not change from the blank.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? Yes 57.0.2987.133

Does this work in other browsers? Yes

Chrome version: 59.0.3071.47  Channel: beta
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version:
 
sample.png
11.6 KB View Download
Labels: Needs-Triage-M59
Cc: brajkumar@chromium.org
Components: Blink
Labels: -Pri-2 -Type-Compat -Needs-Triage-M59 hasbisect-per-revision ReleaseBlock-Stable M-59 OS-Linux Pri-1 Type-Bug-Regression
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce on Windows-10 and Ubuntu 14.04 using chrome Beta M59-59.0.3071.47. Unable to reproduce this issue on Mac OS 10.12.4. Since this is a recent regression on chrome M58 marking it as RB-Stable for M-59, please feel free to remove or edit if this is not the case.

Bisect Information:
=====================
Good build: 58.0.3028.0
Bad Build : 58.0.3029.0

You are probably looking for a change made after 454347 (known good), but no later than 454348 (first known bad).

Change Log URL: https://chromium.googlesource.com/chromium/src/+log/5e4b87b7f3fc1dcd8a56774b7c597d12792a3694..666abc33c97400adfa53065f50364d8cbeadd89a

From the above change log suspecting below change
Review URL: https://codereview.chromium.org/2729683002

wangxianzhu@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Components: -Blink Blink>Paint
This is a SPInvalidation bug and is not applicable to M-58. I guess the above bisecting is done with SPInvalidation forced enabled somehow.

Re-bisected with the default SPInvalidation settings and got a range containing the CL enabling SPInvalidation.
Labels: BugSource-User PaintTeamTriaged-20170511
Project Member

Comment 5 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/727b9633cf8e84b3d79be12f6284248a9e129227

commit 727b9633cf8e84b3d79be12f6284248a9e129227
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Mon May 15 18:11:55 2017

LayoutMenuList::ControlClipRect may depend on size of children

Add NeedsPaintPropertyUpdate().

BUG= 721249 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2874413003
Cr-Commit-Position: refs/heads/master@{#471828}

[modify] https://crrev.com/727b9633cf8e84b3d79be12f6284248a9e129227/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
[modify] https://crrev.com/727b9633cf8e84b3d79be12f6284248a9e129227/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp
[modify] https://crrev.com/727b9633cf8e84b3d79be12f6284248a9e129227/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp

Labels: Merge-Request-59
Project Member

Comment 7 by sheriffbot@chromium.org, May 16 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, May 17 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29d64645baf8815aa1d709165bf2586b8f4ad0eb

commit 29d64645baf8815aa1d709165bf2586b8f4ad0eb
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Wed May 17 16:27:45 2017

LayoutMenuList::ControlClipRect may depend on size of children

Add NeedsPaintPropertyUpdate().

BUG= 721249 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=wangxianzhu
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2874413003
Cr-Original-Commit-Position: refs/heads/master@{#471828}
Review-Url: https://codereview.chromium.org/2890013002
Cr-Commit-Position: refs/branch-heads/3071@{#600}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/29d64645baf8815aa1d709165bf2586b8f4ad0eb/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
[modify] https://crrev.com/29d64645baf8815aa1d709165bf2586b8f4ad0eb/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp
[modify] https://crrev.com/29d64645baf8815aa1d709165bf2586b8f4ad0eb/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp

Comment 10 by ajha@chromium.org, May 23 2017

Labels: TE-Verified-60.0.3107.4 TE-Verified-M60
Just to update, this is working as intended on Windows-10, Linux Ubuntu 14.04 on chrome version: 60.0.3071.4 when 'slimming-paint-invalidation' flag is enabled/disabled/default.

Adding the verified label therefore. 
Labels: TE-Verified-M59 TE-Verified-59.0.3071.71
Verified this issue on Windows-10 and Ubuntu 14.04 using chrome latest beta M59-59.0.3071.71 as per the test case provided in the original comment. Observed no white space while selecting the option from drop down after enabling the chrome flag #slimming-paint-invalidation. Hence adding TE-Verified label.
721249.jpg
90.9 KB View Download

Sign in to add a comment