New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 721230 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
█ hdodda@chromium.org
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary extra space is seen between checkbox and its text of More Actions overlay under language section.

Reported by abom...@etouch.net, May 11 2017 
Chrome Version:60.0.3095.5 72e83b35450360b17a9d1f70e30c86d7a881ec34-refs/branch-heads/3095@{#5}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://settings/languages
2. Click on ‘More Actions’ icon such that overlay gets open and observe.

Actual:Unnecessary extra space is seen between checkbox and its text of More Actions overlay
Expected: Extra space should not be seen.

This is regression issue, broken in ‘M 60’ and below is manual bisect info:
Good build:60.0.3094.0
Bad build:60.0.3095.0

Note: Issue is also seen for chrome://settings/clearBrowserData
Actual:Expected.png
53.9 KB View Download

Comment 1 by hdodda@chromium.org, May 11 2017

Cc: hdodda@chromium.org
Labels: hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,

Good build: 60.0.3094.0(Revision: 470111).
Bad build: 60.0.3095.0 (Revision: 470437).

You are probably looking for a change made after 470400 (known good), but no later than 470410 (first known bad).

CHANGELOG URL:

 https://chromium.googlesource.com/chromium/src/+log/013bc2a066a0d595098ad4b0a502b5732261b951..20407a59ca3f29bfe7ca6a0cdea8fe95a7482ab5

From the CL's above, assigning the issue to the concern owner 

Suspect CL : https://chromium.googlesource.com/chromium/src/+/dfef613f078ed5cddcff6ff82037aac8f0473036

@dschuyler- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2829373003

Thanks!

Comment 2 by ranjitkan@chromium.org, May 11 2017

Labels: -hasbisect-per-revision hasbisect

Comment 3 by dschuyler@chromium.org, May 16 2017

Status: Started (was: Assigned)
CL at https://codereview.chromium.org/2886603002/
Project Member

Comment 4 by bugdroid1@chromium.org, May 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38438a522f398efbc70717d69c8999fc13574640

commit 38438a522f398efbc70717d69c8999fc13574640
Author: dschuyler <dschuyler@chromium.org>
Date: Tue May 16 18:49:33 2017

[MD settings] separate spacing of controlled-by icon and control-label

This CL replaces the use of the --cr-control-spacing with two variables
--cr--control-label-spacing and --cr-controlled-by-spacing. Those two
distances are now required (by UI) to be different values (20px and 24px
respectively). Removing the old variable and using more explicitly named
variables should help avoid confusion about where each should be used.

BUG= 721230 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2886603002
Cr-Commit-Position: refs/heads/master@{#472177}

[modify] https://crrev.com/38438a522f398efbc70717d69c8999fc13574640/chrome/browser/resources/settings/controls/controlled_button.html
[modify] https://crrev.com/38438a522f398efbc70717d69c8999fc13574640/chrome/browser/resources/settings/controls/controlled_radio_button.html
[modify] https://crrev.com/38438a522f398efbc70717d69c8999fc13574640/chrome/browser/resources/settings/controls/settings_checkbox.html
[modify] https://crrev.com/38438a522f398efbc70717d69c8999fc13574640/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
[modify] https://crrev.com/38438a522f398efbc70717d69c8999fc13574640/chrome/browser/resources/settings/controls/settings_slider.html
[modify] https://crrev.com/38438a522f398efbc70717d69c8999fc13574640/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/38438a522f398efbc70717d69c8999fc13574640/chrome/browser/resources/settings/date_time_page/date_time_page.html
[modify] https://crrev.com/38438a522f398efbc70717d69c8999fc13574640/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/38438a522f398efbc70717d69c8999fc13574640/chrome/browser/resources/settings/internet_page/internet_subpage.html
[modify] https://crrev.com/38438a522f398efbc70717d69c8999fc13574640/chrome/browser/resources/settings/internet_page/network_property_list.html
[modify] https://crrev.com/38438a522f398efbc70717d69c8999fc13574640/chrome/browser/resources/settings/internet_page/network_siminfo.html
[modify] https://crrev.com/38438a522f398efbc70717d69c8999fc13574640/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/38438a522f398efbc70717d69c8999fc13574640/chrome/browser/resources/settings/settings_vars_css.html
[modify] https://crrev.com/38438a522f398efbc70717d69c8999fc13574640/ui/webui/resources/cr_elements/network/cr_network_list_item.html
[modify] https://crrev.com/38438a522f398efbc70717d69c8999fc13574640/ui/webui/resources/cr_elements/shared_vars_css.html

Comment 5 by dschuyler@chromium.org, May 16 2017

Status: Fixed (was: Started)

Comment 6 by sureshkumari@chromium.org, May 23 2017

Labels: TE-Verified-60.0.3107.4 TE-Verified-M60
Tested the issue on windows 7, Mac 10.12.4 and Linux Ubuntu 14.04 using chrome version#60.0.3107.4 with the steps mentioned in comment #0.
Observed that the fix is working as expected.Hence adding TE-Verified labels.
Please find the attached screen cast for the same.

Thanks!!
721230.mov
2.2 MB Download
►

Sign in to add a comment