New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 721228 link

Starred by 1 user
Status: Fixed
Owner:
█ mgiuca@chromium.org
Long OOO (go/where-is-mgiuca)
Closed: May 2017
Cc:
█ mariakho...@chromium.org
thildebr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature



Sign in to add a comment

Move Android InstalledAppProviderImpl from content/ to chrome/

Project Member Reported by mgiuca@chromium.org, May 11 2017 
org.chromium.chrome.browser.installedapp.InstalledAppProvider is currently located in:
content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderImpl.java

This module will need to use Android Play services which apparently cannot be accessed from content. The simplest way to achieve this is to move the entire implementation to chrome.

(An alternative design is to create a delegate interface in content, subclass it in chrome, and hook it up somehow. thildebr@ tried this and found it too ugly.)

Let's move it into:
chrome/android/java/src/org/chromium/chrome/browser/installedapp/InstalledAppProviderImpl.java

The dummy implementation (on non-Android platforms) can remain in content.

NB: Architecture diagram:
https://docs.google.com/drawings/d/1D9zDpCXe3GWVYO2XS4w0mIDY21CHbGhjQVOOJtcWWQw/edit
Project Member

Comment 2 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83689098f7e7bb61de20e9c74335c20121f8a9e5

commit 83689098f7e7bb61de20e9c74335c20121f8a9e5
Author: mgiuca <mgiuca@chromium.org>
Date: Fri May 12 19:44:16 2017

Moved InstalledAppProvider Android impl from content into chrome.

This is necessary to allow the implementation to use Android Play
services.

BUG= 721228 

Review-Url: https://codereview.chromium.org/2876783002
Cr-Commit-Position: refs/heads/master@{#471413}

[rename] https://crrev.com/83689098f7e7bb61de20e9c74335c20121f8a9e5/chrome/android/java/src/org/chromium/chrome/browser/installedapp/InstalledAppProviderFactory.java
[rename] https://crrev.com/83689098f7e7bb61de20e9c74335c20121f8a9e5/chrome/android/java/src/org/chromium/chrome/browser/installedapp/InstalledAppProviderImpl.java
[rename] https://crrev.com/83689098f7e7bb61de20e9c74335c20121f8a9e5/chrome/android/java/src/org/chromium/chrome/browser/installedapp/PackageHash.java
[modify] https://crrev.com/83689098f7e7bb61de20e9c74335c20121f8a9e5/chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java
[modify] https://crrev.com/83689098f7e7bb61de20e9c74335c20121f8a9e5/chrome/android/java_sources.gni
[rename] https://crrev.com/83689098f7e7bb61de20e9c74335c20121f8a9e5/chrome/android/junit/src/org/chromium/chrome/browser/installedapp/InstalledAppProviderTest.java
[rename] https://crrev.com/83689098f7e7bb61de20e9c74335c20121f8a9e5/chrome/android/junit/src/org/chromium/chrome/browser/installedapp/PackageHashTest.java
[modify] https://crrev.com/83689098f7e7bb61de20e9c74335c20121f8a9e5/content/public/android/BUILD.gn
[modify] https://crrev.com/83689098f7e7bb61de20e9c74335c20121f8a9e5/content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java

Comment 3 by mgiuca@chromium.org, May 15 2017

Status: Fixed (was: Started)
►

Sign in to add a comment