Issue metadata
Sign in to add a comment
|
Regression: 'Show original' button on translate bubble is misplaced while translating page.
Reported by
db...@etouch.net,
May 11 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3095.5 Revision 72e83b35450360b17a9d1f70e30c86d7a881ec34-refs/branch-heads/3095@{#5} OS: Windows(7,8,10) Pre-condition: Enabled 'Material Design in the rest of the browser's native UI' flag from chrome://flags What steps will reproduce the problem? (1) Launch chrome, open non-english page(e.g.https://www.google.com.mx/intl/es-419/chrome/browser/welcome.html) (2) Click on 'Translate' button on translate bubble, observe Show original button on bubble while translating page Actual: 'Show original' button on translate bubble is misplaced while translating page. Expected: 'Show original' button on translate bubble should not misplaced while translating page. This is a regression issue, broken in 'M-60', will soon update the other info: Good Build: 60.0.3079.0 Bad Build: 60.0.3080.0 Note: Issue is not seen on Mac OS.
,
May 11 2017
,
May 11 2017
Using the per-revision bisect providing the bisect results, Good build: 60.0.3077.0 (Revision: 466199). Bad build : 60.0.3078.0 (Revision: 466494). You are probably looking for a change made after 466210 (known good), but no later than 466211 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/190b7dd412a2f782a2b7c0b671778e1c00a48563..480f457f6939eade256dc987fd740452ef5912de @tapted: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Adding RB Label as this is a recent Regression. Please remove if not required. Thank You.
,
May 12 2017
weird. For some reason the dialog is getting a bogus layout when it transitions into its third, "page has been translated" state. Doesn't happen when re-showing the dialog in that third state - just when it transitions into it. I'll need to investigate. Removing release block since this flag isn't on by default.
,
May 23 2017
Note this also needs chrome://flags/#translate-2016q2-ui Disabled.
,
May 23 2017
,
May 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb91c5093e7b44830872d79d95d4c391c82776b8 commit bb91c5093e7b44830872d79d95d4c391c82776b8 Author: tapted <tapted@chromium.org> Date: Thu May 25 01:31:45 2017 Layout the translate bubble after changing child view visibility. BoxLayout only manipulates visible subviews, so making a subview newly visible may require a layout. A SizeToContents() call can also trigger Layout() but only if the size of the Widget actually changes. r466211 removed some unnecessary insets such that this was no longer likely for a particular translate bubble UI transition. BUG= 721213 , 658854 TEST=(see bug) On Windows, set flags: - chrome://flags/#translate-2016q2-ui Disabled. - chrome://flags/#secondary-ui-md Enabled. Go to a page that needs translating and translate it. Ensure the "Show original" button is positioned in the bottom-right and clickable. Review-Url: https://codereview.chromium.org/2898633004 Cr-Commit-Position: refs/heads/master@{#474511} [modify] https://crrev.com/bb91c5093e7b44830872d79d95d4c391c82776b8/chrome/browser/ui/views/translate/translate_bubble_view.cc
,
May 25 2017
,
May 30 2017
Tested the issue on Ubuntu-14.04 & windows-7 using chrome dev version#60.0.3112.7 with the steps mentioned in comment #0.Observed that the fix is working as expected. Hence adding TE-Verified labels. Please find the attached screen cast for the same. Thanks!! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, May 11 2017Status: Untriaged (was: Unconfirmed)