New issue
Advanced search Search tips

Issue 721201 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 618368



Sign in to add a comment

Allow AVDA to talk to AndroidOverlayProviderImpl mojo service

Project Member Reported by liber...@chromium.org, May 11 2017

Issue description

To create an overlay, AVDA has to use mojo.  However, media/ doesn't have direct access to any of the mojo stuff in content/.

We can send a callback that does the actual mojo work from GpuChildThread to AVDA via MediaGpuChannelManager.

There's another path that creates GpuService (MUS?) that i don't know how to get working.  however, presumably, something in that chain has a Connector that we could use to do something similar.
 
Blockedon: -61 618368
Project Member

Comment 2 by bugdroid1@chromium.org, May 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/441ca70d0885c3cefafce97b8f72922ee05111e7

commit 441ca70d0885c3cefafce97b8f72922ee05111e7
Author: liberato <liberato@chromium.org>
Date: Sat May 13 16:50:38 2017

Provide callback to create mojo AndroidOverlays to AVDA.

In order to create an overlay, AVDA must be able to talk to the
AndroidOverlayProviderImpl mojo service in the browser.  However,
media/ doesn't have access to much that would let it look up the
service by itself.

This CL plumbs a callback for creating these overlays to AVDA from
GpuChildThread.  GpuChildThread has access to the mojo Connector
object, which allows it to look up services in the browser process.

The callback takes as input the routing token and a configuration
struct, and returns the overlay.

BUG= 721201 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2864603002
Cr-Commit-Position: refs/heads/master@{#471589}

[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/content/gpu/BUILD.gn
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/content/gpu/gpu_child_thread.cc
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/content/gpu/gpu_child_thread.h
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/media/base/android_overlay_mojo_factory.h
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/media/gpu/android_video_decode_accelerator.h
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/media/gpu/android_video_decode_accelerator_unittest.cc
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/media/gpu/gpu_video_decode_accelerator_factory.cc
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/media/gpu/gpu_video_decode_accelerator_factory.h
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/media/gpu/ipc/service/gpu_video_decode_accelerator.h
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/media/gpu/ipc/service/media_gpu_channel.cc
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/media/gpu/ipc/service/media_gpu_channel.h
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/media/gpu/ipc/service/media_gpu_channel_manager.cc
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/media/gpu/ipc/service/media_gpu_channel_manager.h
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/media/mojo/clients/BUILD.gn
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/media/mojo/clients/mojo_android_overlay.cc
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/media/mojo/clients/mojo_android_overlay.h
[modify] https://crrev.com/441ca70d0885c3cefafce97b8f72922ee05111e7/media/mojo/clients/mojo_android_overlay_unittest.cc

Labels: -OS-Android
Status: Fixed (was: Started)

Sign in to add a comment