New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721192 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

CodeSearch grok is broken

Project Member Reported by nainar@chromium.org, May 11 2017

Issue description

CodeSearch grok seems to be broken: 

This file is in grok-able: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/style/BorderColorAndStyle.h

It's a new file but it is C++ and in the Chromium repo
 

Comment 1 by nainar@chromium.org, May 11 2017

Components: Infra>Codesearch

Comment 2 by emso@chromium.org, May 11 2017

Labels: -Pri-3 Stability Xrefs Pri-1
Owner: emso@chromium.org
Status: Assigned (was: Untriaged)
Sorry about this. We were broken by a clang tooling change. We know what the problem is and we're working on a fix.
Project Member

Comment 3 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/bdb9d6cb87b77bf04acc1165cfe581a508e1d40e

commit bdb9d6cb87b77bf04acc1165cfe581a508e1d40e
Author: Emma Soederberg <emso@chromium.org>
Date: Thu May 11 07:50:51 2017

Adjusting run_tool.py command line to account for recent changes

The command line interface to run_tool.py was changed in
https://chromium-review.googlesource.com/c/494946/, to enforce use of flags which were earlier implicit.
The change caused code search bots run of the clang translation_unit to fail, the result being no generation of Xrefs.

Bug:721192
Change-Id: Iff5662f602adf9947f11a4680e1e72c7f1cc5cb0
Reviewed-on: https://chromium-review.googlesource.com/503088
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Emma Söderberg <emso@chromium.org>

[modify] https://crrev.com/bdb9d6cb87b77bf04acc1165cfe581a508e1d40e/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux.json
[modify] https://crrev.com/bdb9d6cb87b77bf04acc1165cfe581a508e1d40e/scripts/slave/recipes/chromium_codesearch.py
[modify] https://crrev.com/bdb9d6cb87b77bf04acc1165cfe581a508e1d40e/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos_fail.json
[modify] https://crrev.com/bdb9d6cb87b77bf04acc1165cfe581a508e1d40e/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_android.json
[modify] https://crrev.com/bdb9d6cb87b77bf04acc1165cfe581a508e1d40e/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos.json

Comment 4 by emso@chromium.org, May 12 2017

Status: Verified (was: Assigned)
This issue should be fixed now. I see Xrefs on https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/style/BorderStyle.h which is the above linked file (renamed in https://chromium.googlesource.com/chromium/src/+/7201468ffddd08c6893769c4a0616df7e9bedcad).

Closing the issue but please reopen if you still the problem. Sorry for the inconvenience.

Sign in to add a comment