New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721186 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

instrumented-libraries-for-dynamic-tools prebuilt instructions don't work

Project Member Reported by p...@chromium.org, May 11 2017

Issue description

What steps will reproduce the problem?
(1) Go to https://www.chromium.org/developers/testing/instrumented-libraries-for-dynamic-tools
(2) Try to follow instructions under "Using pre-built binaries"

What is the expected result?

Instructions work

What happens instead?

$ cat args.gn
is_component_build = false
is_debug = false
is_msan = true
msan_track_origins = 2
target_os = "chromeos"
use_ozone = false
use_prebuilt_instrumented_libraries = true
$ ninja aura_unittests
[...]/third_party/instrumented_libraries/binaries/msan-chained-origins-trusty.tgz: Cannot open: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now
Traceback (most recent call last):
  File "../../third_party/instrumented_libraries/scripts/unpack_binaries.py", line 42, in <module>
    sys.exit(main(*sys.argv[1:]))
  File "../../third_party/instrumented_libraries/scripts/unpack_binaries.py", line 29, in main
    target_dir])
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)

I needed to do this to get the prebuilts to download:

$ GYP_DEFINES='use_prebuilt_instrumented_libraries=1 msan=1 msan_track_origins=2' src/third_party/instrumented_libraries/scripts/download_binaries.py

But I shouldn't have had to figure that out, there should be an easier way to download the prebuilts.
 

Comment 1 Deleted

Cc: thomasanderson@chromium.org
On the other hand, the MSan instructions are correct:
http://dev.chromium.org/developers/testing/memorysanitizer


Thomas tried to simplify this process, but AFAIK the change had to be reverted. What's the current status? Should we update the instructions at instrumented-libraries-for-dynamic-tools? Btw, how did you even find that page?

Comment 3 by p...@chromium.org, May 11 2017

> Should we update the instructions at instrumented-libraries-for-dynamic-tools?

We probably should either do that or just add a link from that page to 
http://dev.chromium.org/developers/testing/memorysanitizer

> Btw, how did you even find that page?

I think I googled for use_prebuilt_instrumented_libraries (for me the memorysanitizer page was the first result and  instrumented-libraries-for-dynamic-tools was the second, but it looked more relevant at the time).
> We probably should either do that or just add a link from that page to 
http://dev.chromium.org/developers/testing/memorysanitizer

+1 to adding the link.  That way we don't need to maintain 2 documents for the same thing.
Owner: euge...@chromium.org
Status: Fixed (was: Untriaged)
I've updated the page with a link to MemorySanitizer.

Comment 6 by p...@chromium.org, Jun 14 2017

Thanks!

Sign in to add a comment