New issue
Advanced search Search tips

Issue 721180 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4%-5.1% regression in memory.top_10_mobile_stress at 470518:470521

Project Member Reported by sullivan@chromium.org, May 11 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 11 2017

Cc: dominickn@chromium.org
Owner: dominickn@chromium.org

=== Auto-CCing suspected CL author dominickn@chromium.org ===

Hi dominickn@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : dominickn
  Commit : faace60759ac73ae60b5d4ef84fb85c65c937b4a
  Date   : Wed May 10 08:45:47 2017
  Subject: Add blocking permission prompts to the field trial testing config.

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : memory.top_10_mobile_stress
  Metric       : memory:chrome:all_processes:reported_by_os:gpu_memory:proportional_resident_size_avg/background/after_https_mobile_twitter_com_justinbieber_skip_interstitial_true
  Change       : 4.20% | 25410218.6667 -> 26477909.3333

Revision             Result                   N
chromium@470517      25410219 +- 18918.6      6      good
chromium@470519      25410219 +- 18918.6      6      good
chromium@470520      25404757 +- 18918.6      6      good
chromium@470521      26477909 +- 18918.6      6      bad       <--

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile_stress

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979926225112673632

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5820400451190784


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
My CL updated the Finch testing config JSON file. Is this report a sign that the new config increases memory usage? I'm bemused at how it could, because the effect of the experiment is to do less work (we don't start anything at different times, we just terminate earlier and print a console message when we block a permission prompt request).
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, May 12 2017

 Issue 721076  has been merged into this issue.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, May 13 2017

 Issue 721076  has been merged into this issue.
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
Status: WontFix (was: Assigned)
I'm guessing the reason for this is that my CL (a Finch testing config change) enabled modal permission prompts on the bot, and switching from an in-Chrome infobar to a Android native modal dialog changed the peak consumption.... that being said, these reports are a little difficult to action. :(

Sign in to add a comment