Limit max depth of the layout tree |
||||||||||||||
Issue descriptionMany layout algorithms are recursive, so when the DOM tree is nested too deeply, this causes stack overflow crashes like issue 718307 . We should consider restricting the maximum depth of the layout tree: Firefox appears to do this.
,
May 12 2017
Should we implement a depth limit for NG?
,
May 12 2017
We should seriously consider it - Verified that FF == 200, I tried with Edge and on my VM they capped out at ~500, they probably don't have a firm limit and might be stack heavy. We are initially going to be very stack heavy so we'll probably have a lower limit than we do today - we may want to bring this up at the next CSSWG and try to standardize on a reasonable upper limit.
,
May 12 2017
Additional context with NG we'll be able to produce a fragment tree which we can use which will keep the page still interactive if we want even if folks go over this limit. Alternatively we may want to just jump somewhere sane and crash.
,
May 16 2017
,
Aug 31 2017
,
Aug 31 2017
,
Sep 17 2017
,
Oct 1 2017
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.
,
Oct 1 2017
,
Oct 11 2017
,
Oct 12 2017
ClusterFuzz testcase 5614405902663680 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Oct 12 2017
,
Nov 7 2017
,
Dec 18 2017
Issue 795739 has been merged into this issue.
,
Dec 27 2017
Issue 797537 has been merged into this issue.
,
Jan 22 2018
,
Mar 7 2018
,
Apr 2 2018
,
May 15 2018
Issue 842889 has been merged into this issue.
,
Jun 27 2018
,
Jul 3
Issue 857184 has been merged into this issue.
,
Sep 4
Issue 879946 has been merged into this issue.
,
Sep 25
Issue 888605 has been merged into this issue.
,
Dec 14
,
Dec 14
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/27d732d9364e1f139dafdbacc813318b5a9a852f (Reland Devirtualize LayoutBoxModelObject logical orientation border/margin/padding accessors). If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
,
Dec 14
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by dcheng@chromium.org
, May 11 2017463 bytes
463 bytes View Download