New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721175 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome , Mac
Pri: 3
Type: Feature

Blocking:
issue 718307
issue 762363



Sign in to add a comment

Limit max depth of the layout tree

Project Member Reported by dcheng@chromium.org, May 11 2017

Issue description

Many layout algorithms are recursive, so when the DOM tree is nested too deeply, this causes stack overflow crashes like  issue 718307 . We should consider restricting the maximum depth of the layout tree: Firefox appears to do this.
 

Comment 1 by dcheng@chromium.org, May 11 2017

Firefox appears to limit it to a max depth of 200.
layout_tree.html
463 bytes View Download

Comment 2 by e...@chromium.org, May 12 2017

Owner: ikilpatrick@chromium.org
Status: Assigned (was: Untriaged)
Should we implement a depth limit for NG? 
We should seriously consider it - 

Verified that FF == 200, I tried with Edge and on my VM they capped out at ~500, they probably don't have a firm limit and might be stack heavy.

We are initially going to be very stack heavy so we'll probably have a lower limit than we do today - we may want to bring this up at the next CSSWG and try to standardize on a reasonable upper limit. 


Additional context with NG we'll be able to produce a fragment tree which we can use which will keep the page still interactive if we want even if folks go over this limit. Alternatively we may want to just jump somewhere sane and crash.

Comment 5 by dcheng@chromium.org, May 16 2017

Blocking: 718307
Cc: msrchandra@chromium.org
 Issue 760796  has been merged into this issue.
Project Member

Comment 7 by ClusterFuzz, Aug 31 2017

Labels: OS-Linux
Project Member

Comment 8 by ClusterFuzz, Sep 17 2017

Labels: OS-Mac
Project Member

Comment 9 by ClusterFuzz, Oct 1 2017

Labels: Test-Predator-AutoComponents
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.
Blocking: 762363
Cc: pnangunoori@chromium.org
 Issue 773574  has been merged into this issue.
Project Member

Comment 12 by ClusterFuzz, Oct 12 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5614405902663680 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: ClusterFuzz-Wrong
Status: Assigned (was: Verified)
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
 Issue 795739  has been merged into this issue.
 Issue 797537  has been merged into this issue.
Cc: brajkumar@chromium.org
 Issue 804089  has been merged into this issue.
Project Member

Comment 18 by ClusterFuzz, Mar 7 2018

Labels: OS-Chrome
Cc: dcheng@chromium.org
 Issue 827877  has been merged into this issue.
 Issue 842889  has been merged into this issue.

Comment 21 by kojii@chromium.org, Jun 27 2018

Cc: kkaluri@chromium.org
 Issue 855837  has been merged into this issue.
 Issue 857184  has been merged into this issue.
 Issue 879946  has been merged into this issue.
 Issue 888605  has been merged into this issue.
Labels: -Type-Bug -Pri-2 Pri-3 Type-Feature
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 26 by ClusterFuzz, Dec 14

Labels: Test-Predator-Auto-Owner
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Available)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/27d732d9364e1f139dafdbacc813318b5a9a852f (Reland Devirtualize LayoutBoxModelObject logical orientation border/margin/padding accessors).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment