New issue
Advanced search Search tips

Issue 721139 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Separate Android DownloadManger and OMA related functions from DownloadManagerService

Project Member Reported by shaktisahu@chromium.org, May 11 2017

Issue description

OMADownloadHandler should handle all the OMA related functions.
DownloadMangerDelegate can contain all non-OMA and Android related functionalities
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8eb8e12559dcda966f159d8f0912a0ef863ae105

commit 8eb8e12559dcda966f159d8f0912a0ef863ae105
Author: shaktisahu <shaktisahu@chromium.org>
Date: Fri May 12 09:58:40 2017

Moved OMA downloads out of DownloadManagerService

This CL moves most of the interactions with the android DownloadManager
from DownloadManagerService to DownloadManagerDelegate. OMA downloads
use android DownloadManager, so OMA related code and shared prefs were
moved to OMADownloadHandler. The broadcast receiver for DownloadManager
was also moved to DownloadManagerDelegate.

BUG= 721139 

Review-Url: https://codereview.chromium.org/2851023003
Cr-Commit-Position: refs/heads/master@{#471264}

[modify] https://crrev.com/8eb8e12559dcda966f159d8f0912a0ef863ae105/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java
[modify] https://crrev.com/8eb8e12559dcda966f159d8f0912a0ef863ae105/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/8eb8e12559dcda966f159d8f0912a0ef863ae105/chrome/android/java/src/org/chromium/chrome/browser/download/OMADownloadHandler.java
[modify] https://crrev.com/8eb8e12559dcda966f159d8f0912a0ef863ae105/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
[modify] https://crrev.com/8eb8e12559dcda966f159d8f0912a0ef863ae105/chrome/android/javatests/src/org/chromium/chrome/browser/download/OMADownloadHandlerTest.java

Status: Fixed (was: Started)

Sign in to add a comment