New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721131 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
not on Chrome anymore
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Flicker when leaving fullscreen with overlays enabled.

Project Member Reported by jbau...@chromium.org, May 11 2017

Issue description

This seems to be an issue where SetDrawRectangle is failing because the first frame on a new surface doesn't draw the entire thing. Maybe because the alpha change caused the reshape.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f1f8dd5a7f7d15da2c24fc2ffa27ef48c7441a1

commit 2f1f8dd5a7f7d15da2c24fc2ffa27ef48c7441a1
Author: jbauman <jbauman@chromium.org>
Date: Fri May 12 07:48:16 2017

Always set damage rect to output rect if 3D context was reshaped.

The first draw after a reshape needs to draw the entire contents of the
window, so ensure the overlay processor doesn't accidentally shrink the
damage rect.

BUG= 721131 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2881483002
Cr-Commit-Position: refs/heads/master@{#471244}

[modify] https://crrev.com/2f1f8dd5a7f7d15da2c24fc2ffa27ef48c7441a1/cc/output/direct_renderer.cc
[modify] https://crrev.com/2f1f8dd5a7f7d15da2c24fc2ffa27ef48c7441a1/cc/output/gl_renderer_unittest.cc

Status: Fixed (was: Started)
Labels: Merge-Request-59
Project Member

Comment 4 by sheriffbot@chromium.org, May 17 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, May 17 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c77aad0ad268e10e2494f292d44c67d695a5514

commit 2c77aad0ad268e10e2494f292d44c67d695a5514
Author: John Bauman <jbauman@chromium.org>
Date: Wed May 17 19:50:41 2017

Always set damage rect to output rect if 3D context was reshaped.

The first draw after a reshape needs to draw the entire contents of the
window, so ensure the overlay processor doesn't accidentally shrink the
damage rect.

BUG= 721131 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2881483002
Cr-Commit-Position: refs/heads/master@{#471244}
(cherry picked from commit 2f1f8dd5a7f7d15da2c24fc2ffa27ef48c7441a1)

Review-Url: https://codereview.chromium.org/2890053002 .
Cr-Commit-Position: refs/branch-heads/3071@{#604}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/2c77aad0ad268e10e2494f292d44c67d695a5514/cc/output/direct_renderer.cc
[modify] https://crrev.com/2c77aad0ad268e10e2494f292d44c67d695a5514/cc/output/gl_renderer_unittest.cc

Sign in to add a comment