New issue
Advanced search Search tips

Issue 721127 link

Starred by 1 user
Status: Fixed
Owner:
ma...@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Payments] Desktop: shipping addresses start in error state

Project Member Reported by ma...@chromium.org, May 11 2017 
On ToT

(1) https://rsolomakhin.github.io/pr/multi/
(2) Go to address selection

There should be no errors ("unsupported address..."), because no address has been selected yet.
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b77b873b4678bafcab1c97ea39882ec9b43ee14d

commit b77b873b4678bafcab1c97ea39882ec9b43ee14d
Author: mathp <mathp@chromium.org>
Date: Thu May 11 15:26:42 2017

[Payments] Do not show error on initial load of address screen

Previously would show an error if no shipping option was
selected.

Also no longer having an error if no entries are selected but some are
available, which is a valid state to be in.

BUG= 721127 
TEST=browser_tests, components_unittests

Review-Url: https://codereview.chromium.org/2872033007
Cr-Commit-Position: refs/heads/master@{#470962}

[modify] https://crrev.com/b77b873b4678bafcab1c97ea39882ec9b43ee14d/chrome/browser/ui/views/payments/shipping_option_view_controller_browsertest.cc
[modify] https://crrev.com/b77b873b4678bafcab1c97ea39882ec9b43ee14d/components/payments/content/BUILD.gn
[modify] https://crrev.com/b77b873b4678bafcab1c97ea39882ec9b43ee14d/components/payments/content/payment_request_spec.cc
[modify] https://crrev.com/b77b873b4678bafcab1c97ea39882ec9b43ee14d/components/payments/content/payment_request_spec.h
[modify] https://crrev.com/b77b873b4678bafcab1c97ea39882ec9b43ee14d/components/payments/content/payment_request_spec_unittest.cc

Comment 2 by ma...@chromium.org, May 11 2017

Status: Fixed (was: Started)

Comment 3 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment