New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721099 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Instrumentation events are shown with wrong JS stack under them sometimes.

Project Member Reported by alph@chromium.org, May 10 2017

Issue description

Instrumentation events are shown with wrong JS stack under them sometimes.

This happens when the JS sample preceding the event differs from the stack that in fact caused the instrumentation event.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/295c9cc643a2a5e410207fd1f4634ad9c8c83405

commit 295c9cc643a2a5e410207fd1f4634ad9c8c83405
Author: Alexei Filippov <alph@chromium.org>
Date: Wed Nov 08 19:48:40 2017

[cpu-profiler] Add static CollectSample method to the CpuProfiler API.

The method forces all running profilers attached to the provided isolate
to collect a sample with the current stack.

It is going to be used to synchronize trace events generated by embedder with the samples
collected by the profiler.

Also it will finally allow us to break dependency of isolate on CPU profiler.

BUG= chromium:721099 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I81a0f8a463f837b5201bc8edaf2eb4f3761e3ff8
Reviewed-on: https://chromium-review.googlesource.com/750264
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49236}
[modify] https://crrev.com/295c9cc643a2a5e410207fd1f4634ad9c8c83405/include/v8-profiler.h
[modify] https://crrev.com/295c9cc643a2a5e410207fd1f4634ad9c8c83405/src/api.cc
[modify] https://crrev.com/295c9cc643a2a5e410207fd1f4634ad9c8c83405/src/profiler/cpu-profiler.cc
[modify] https://crrev.com/295c9cc643a2a5e410207fd1f4634ad9c8c83405/src/profiler/cpu-profiler.h
[modify] https://crrev.com/295c9cc643a2a5e410207fd1f4634ad9c8c83405/test/cctest/test-cpu-profiler.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48567a53b6a0ce0e29073fcf8edac6c0829eec56

commit 48567a53b6a0ce0e29073fcf8edac6c0829eec56
Author: Alexei Filippov <alph@chromium.org>
Date: Fri Nov 10 23:44:35 2017

DevTools: Use new static CpuProfiler::CollectSample API.

It allows collect the sample in all the running CPU profilers.

BUG= 721099 

Change-Id: I8c80c9543bb826b67b8f7ddf6b2984cb54d61fbb
Reviewed-on: https://chromium-review.googlesource.com/764793
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515746}
[modify] https://crrev.com/48567a53b6a0ce0e29073fcf8edac6c0829eec56/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/354c09953bfe89406f0cfbacf80183babb06ed8c

commit 354c09953bfe89406f0cfbacf80183babb06ed8c
Author: Michael Hablich <hablich@chromium.org>
Date: Sat Nov 11 19:21:35 2017

Revert "DevTools: Use new static CpuProfiler::CollectSample API."

This reverts commit 48567a53b6a0ce0e29073fcf8edac6c0829eec56.

Reason for revert: Needed for the rollback of V8 in https://chromium-review.googlesource.com/c/chromium/src/+/765329

Original change's description:
> DevTools: Use new static CpuProfiler::CollectSample API.
> 
> It allows collect the sample in all the running CPU profilers.
> 
> BUG= 721099 
> 
> Change-Id: I8c80c9543bb826b67b8f7ddf6b2984cb54d61fbb
> Reviewed-on: https://chromium-review.googlesource.com/764793
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515746}

TBR=alph@chromium.org,caseq@chromium.org,yangguo@chromium.org

Change-Id: I4341a4410f28d8fbb93b35a5e2eb2c447c4296bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  721099 
Reviewed-on: https://chromium-review.googlesource.com/765448
Reviewed-by: Michael Hablich <hablich@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515850}
[modify] https://crrev.com/354c09953bfe89406f0cfbacf80183babb06ed8c/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfef6451996bdd6e99c288047d3067e4b051f3e3

commit cfef6451996bdd6e99c288047d3067e4b051f3e3
Author: Alexei Filippov <alph@chromium.org>
Date: Tue Nov 14 23:04:33 2017

Reland "DevTools: Use new static CpuProfiler::CollectSample API."

This is a reland of 48567a53b6a0ce0e29073fcf8edac6c0829eec56
Original change's description:
> DevTools: Use new static CpuProfiler::CollectSample API.
>
> It allows collect the sample in all the running CPU profilers.
>
> BUG= 721099 
>
> Change-Id: I8c80c9543bb826b67b8f7ddf6b2984cb54d61fbb
> Reviewed-on: https://chromium-review.googlesource.com/764793
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515746}

TBR=caseq@chromium.org

Bug:  721099 
Change-Id: I334ee00241099ee9a3191a02178baacf16ed2f43
Reviewed-on: https://chromium-review.googlesource.com/767190
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516483}
[modify] https://crrev.com/cfef6451996bdd6e99c288047d3067e4b051f3e3/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

Comment 6 by alph@chromium.org, Nov 14 2017

Status: Fixed (was: Assigned)

Comment 7 by alph@chromium.org, Dec 6 2017

Cc: alph@chromium.org samccone@google.com
 Issue 777218  has been merged into this issue.

Sign in to add a comment