Instrumentation events are shown with wrong JS stack under them sometimes. |
||
Issue descriptionInstrumentation events are shown with wrong JS stack under them sometimes. This happens when the JS sample preceding the event differs from the stack that in fact caused the instrumentation event.
,
Nov 10 2017
The design doc is here https://docs.google.com/document/d/1InAhRZI1kFRojqS35KKs5Cy9m00lFHxJ4Mq7QfDx5ZI/edit#
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48567a53b6a0ce0e29073fcf8edac6c0829eec56 commit 48567a53b6a0ce0e29073fcf8edac6c0829eec56 Author: Alexei Filippov <alph@chromium.org> Date: Fri Nov 10 23:44:35 2017 DevTools: Use new static CpuProfiler::CollectSample API. It allows collect the sample in all the running CPU profilers. BUG= 721099 Change-Id: I8c80c9543bb826b67b8f7ddf6b2984cb54d61fbb Reviewed-on: https://chromium-review.googlesource.com/764793 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#515746} [modify] https://crrev.com/48567a53b6a0ce0e29073fcf8edac6c0829eec56/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
,
Nov 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/354c09953bfe89406f0cfbacf80183babb06ed8c commit 354c09953bfe89406f0cfbacf80183babb06ed8c Author: Michael Hablich <hablich@chromium.org> Date: Sat Nov 11 19:21:35 2017 Revert "DevTools: Use new static CpuProfiler::CollectSample API." This reverts commit 48567a53b6a0ce0e29073fcf8edac6c0829eec56. Reason for revert: Needed for the rollback of V8 in https://chromium-review.googlesource.com/c/chromium/src/+/765329 Original change's description: > DevTools: Use new static CpuProfiler::CollectSample API. > > It allows collect the sample in all the running CPU profilers. > > BUG= 721099 > > Change-Id: I8c80c9543bb826b67b8f7ddf6b2984cb54d61fbb > Reviewed-on: https://chromium-review.googlesource.com/764793 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515746} TBR=alph@chromium.org,caseq@chromium.org,yangguo@chromium.org Change-Id: I4341a4410f28d8fbb93b35a5e2eb2c447c4296bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721099 Reviewed-on: https://chromium-review.googlesource.com/765448 Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#515850} [modify] https://crrev.com/354c09953bfe89406f0cfbacf80183babb06ed8c/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfef6451996bdd6e99c288047d3067e4b051f3e3 commit cfef6451996bdd6e99c288047d3067e4b051f3e3 Author: Alexei Filippov <alph@chromium.org> Date: Tue Nov 14 23:04:33 2017 Reland "DevTools: Use new static CpuProfiler::CollectSample API." This is a reland of 48567a53b6a0ce0e29073fcf8edac6c0829eec56 Original change's description: > DevTools: Use new static CpuProfiler::CollectSample API. > > It allows collect the sample in all the running CPU profilers. > > BUG= 721099 > > Change-Id: I8c80c9543bb826b67b8f7ddf6b2984cb54d61fbb > Reviewed-on: https://chromium-review.googlesource.com/764793 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515746} TBR=caseq@chromium.org Bug: 721099 Change-Id: I334ee00241099ee9a3191a02178baacf16ed2f43 Reviewed-on: https://chromium-review.googlesource.com/767190 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#516483} [modify] https://crrev.com/cfef6451996bdd6e99c288047d3067e4b051f3e3/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
,
Nov 14 2017
,
Dec 6 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Nov 8 2017