New issue
Advanced search Search tips

Issue 721088 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[IPH] UI - Menu icon highlight in the footer row

Project Member Reported by shaktisahu@chromium.org, May 10 2017

Issue description

This should fix -
1 - Highlighting of menu icons in Chrome home mode
2 - Highlighting of data saver footer in the normal mode app menu.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60e4c6d33956a93ca6dcb7c78c913e84445dcfce

commit 60e4c6d33956a93ca6dcb7c78c913e84445dcfce
Author: shaktisahu <shaktisahu@chromium.org>
Date: Thu May 11 19:18:36 2017

IPH : Highlight for the menu icons in the chrome home footer

This CL fixes :
1 - Highlighting of menu icons in the footer in chrome home mode
2 - Highlighting of data saver footer
3 - Y inset of the text bubble in the chrome home mode

BUG= 721088 

Review-Url: https://codereview.chromium.org/2872023004
Cr-Commit-Position: refs/heads/master@{#471038}

[modify] https://crrev.com/60e4c6d33956a93ca6dcb7c78c913e84445dcfce/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/60e4c6d33956a93ca6dcb7c78c913e84445dcfce/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
[modify] https://crrev.com/60e4c6d33956a93ca6dcb7c78c913e84445dcfce/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Status: Fixed (was: Started)

Sign in to add a comment