New issue
Advanced search Search tips

Issue 721081 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

11.1%-12.5% regression in blink_perf.layout at 470255:470270

Project Member Reported by sullivan@chromium.org, May 10 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 12 2017


=== BISECT JOB RESULTS ===
Bisect was unable to run to completion

Error: TIMEOUT

The bisect was able to narrow the range, you can try running with:
  good_revision: e75a641b5b0324948fc4743813bd53d1a2bb661e
  bad_revision : b94383086bbb49474afd397fa447a8b940c84684

If failures persist contact the team (see below) and report the error.


Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : blink_perf.layout
  Metric       : large-table-with-collapsed-borders-and-colspans-wider-than-table/large-table-with-collapsed-borders-and-colspans-wider-than-table
  Change       : 10.90% | 1385.595 -> 1536.6145

Revision             Result                  N
chromium@470254      1385.6 +- 12.8094       6      good
chromium@470262      1376.05 +- 22.3648      6      good
chromium@470270      1536.61 +- 26.0858      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.layout

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979944916913459008

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5821768666710016


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, May 14 2017

Cc: wangxianzhu@chromium.org
Owner: wangxianzhu@chromium.org

=== Auto-CCing suspected CL author wangxianzhu@chromium.org ===

Hi wangxianzhu@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : wangxianzhu
  Commit : dba4d1702934a03d833c91f2c025faf2106b9c76
  Date   : Tue May 09 09:00:11 2017
  Subject: Let table row and section's self visual overflow cover whole collapsed borders

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : blink_perf.layout
  Metric       : large-table-with-collapsed-borders-and-colspans-wider-than-table/large-table-with-collapsed-borders-and-colspans-wider-than-table
  Change       : 11.75% | 1388.94083333 -> 1552.15966667

Revision             Result                  N
chromium@470254      1388.94 +- 18.3224      6      good
chromium@470262      1393.6 +- 17.4669       6      good
chromium@470266      1390.73 +- 33.4343      6      good
chromium@470267      1397.41 +- 11.143       6      good
chromium@470268      1546.2 +- 18.0571       6      bad       <--
chromium@470270      1552.16 +- 22.199       6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.layout

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979759994674994640

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5821768666710016


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: WontFix (was: Untriaged)
This is a change about correctness. Also together with an optimization https://codereview.chromium.org/2846563002, the combined result is still a progression.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, May 17 2017

Cc: lanwei@google.com
 Issue 723020  has been merged into this issue.

Sign in to add a comment