New issue
Advanced search Search tips

Issue 721078 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

12.3%-12.6% regression in blink_perf.bindings at 470449:470490

Project Member Reported by sullivan@chromium.org, May 10 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=721078

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgyqHvvgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgyt755wsM


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 12 2017


=== BISECT JOB RESULTS ===
Bisect was unable to run to completion

Please try rerunning the bisect.


If failures persist contact the team (see below) and report the error.


Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : blink_perf.bindings
  Metric       : first-child/first-child
  Change       : 11.77% | 247.942455038 -> 218.770181717

Revision                           Result                  N
chromium@470448                    247.942 +- 1.95836      6      good
chromium@470469                    245.291 +- 7.64999      6      good
chromium@470480                    247.541 +- 1.41747      6      good
chromium@470483                    248.065 +- 1.32874      6      good
chromium@470484                    246.292 +- 6.52952      6      good
chromium@470484,v8@fd749344bf      216.752 +- 16.7046      6      bad
chromium@470484,v8@02595c60a3      220.632 +- 1.3927       6      bad
chromium@470484,v8@dd9dbf4dd7      220.377 +- 1.03576      6      bad
chromium@470484,v8@5f98a061ca      220.353 +- 3.08347      6      bad
chromium@470485                    220.488 +- 1.67296      6      bad
chromium@470490                    218.77 +- 9.34745       6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979945053284262976

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5341497169281024


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, May 13 2017

Cc: rmcilroy@chromium.org
Owner: rmcilroy@chromium.org

=== Auto-CCing suspected CL author rmcilroy@chromium.org ===

Hi rmcilroy@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Ross McIlroy
  Commit : fd749344bf8b49edc4b1b31a489ff2eb843af54f
  Date   : Mon May 08 20:57:30 2017
  Subject: Revert "Reland: [TypeFeedbackVector] Store optimized code in the vector"

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : blink_perf.bindings
  Metric       : first-child/first-child
  Change       : 11.14% | 246.221543343 -> 218.784612815

Revision                           Result                   N
chromium@470448                    246.222 +- 6.52751       6      good
chromium@470469                    246.578 +- 5.77508       6      good
chromium@470480                    247.961 +- 1.35728       6      good
chromium@470483                    248.259 +- 1.01508       6      good
chromium@470484                    246.569 +- 6.08681       5      good
chromium@470484,v8@4f82f1d948      246.058 +- 6.41751       6      good
chromium@470484,v8@fd749344bf      220.43 +- 0.953989       6      bad       <--
chromium@470484,v8@02595c60a3      220.673 +- 1.35905       6      bad
chromium@470484,v8@dd9dbf4dd7      220.541 +- 2.19202       6      bad
chromium@470484,v8@5f98a061ca      220.989 +- 0.619653      6      bad
chromium@470485                    220.28 +- 0.62477        6      bad
chromium@470490                    218.785 +- 5.35032       6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979763771206993952

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5341497169281024


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Started (was: Untriaged)
I think I know the reason for this, will upload a fix shortly.
Status: Fixed (was: Started)
Fixed after the roll at r471865

Sign in to add a comment