New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721070 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

<script type=module> should work inside HTML Imports

Project Member Reported by adamk@chromium.org, May 10 2017

Issue description

Report from bicknellr@ (CCed) is that it doesn't work right now.
 
```
<link rel="import" href="import-with-module.html">
```

import-with-module.html:
```
<script type="module">
console.log('module in import');
</script>
```

This should be enough to crash 60.0.3096.0 + "Experimental Web Platform features". However, it doesn't crash if you remove *all* of the text from the inline module.

Comment 2 by neis@chromium.org, May 12 2017

Cc: hirosh...@chromium.org kouhei@chromium.org
This doesn't read like a blocker, is it?

If it is then it should be bumped to P1, M61 and in someone's queue.

If it's not then it should be removed from  issue 594639 's blockers (possibly added to a different meta bug for follow-up work).

Comment 4 by kouhei@chromium.org, May 26 2017

Blocking: -594639
No, we don't think this is a blocker. Would you create a meta-bug?

Comment 5 by adamk@chromium.org, May 26 2017

When I was working on the intent-to-ship a year ago, the conversation with the Polymer team and esprehn@ suggested that this should be a blocker (I don't have documentation of that, this is from memory). I can understand that things may well have changed in a year, but I think it would be good to check with some Blink API owners for their thoughts on this question (dglazkov in particular).

Comment 6 by kochi@chromium.org, May 30 2017

Cc: kochi@chromium.org

Comment 7 by kouhei@chromium.org, May 30 2017

Labels: -Pri-3 Pri-1
Owner: kochi@chromium.org
kochi@ to provide layout test
Project Member

Comment 8 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b19c80ec1d10fa885d2174ad432bc00c472d4344

commit b19c80ec1d10fa885d2174ad432bc00c472d4344
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Wed May 31 13:32:48 2017

Add layout tests for module script used from HTML imports

These tests currently crash, and TestExpectations includes
[ Crash ] lines.

BUG= 721070 

Change-Id: I7a7ab16cd6395d4448271fd4cd46eb9d3e0a4c37
Reviewed-on: https://chromium-review.googlesource.com/517849
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475895}
[modify] https://crrev.com/b19c80ec1d10fa885d2174ad432bc00c472d4344/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/b19c80ec1d10fa885d2174ad432bc00c472d4344/third_party/WebKit/LayoutTests/http/tests/htmlimports/import-and-script-module-external.html
[add] https://crrev.com/b19c80ec1d10fa885d2174ad432bc00c472d4344/third_party/WebKit/LayoutTests/http/tests/htmlimports/import-and-script-module-inline.html
[add] https://crrev.com/b19c80ec1d10fa885d2174ad432bc00c472d4344/third_party/WebKit/LayoutTests/http/tests/htmlimports/resources/module-script-external.html
[add] https://crrev.com/b19c80ec1d10fa885d2174ad432bc00c472d4344/third_party/WebKit/LayoutTests/http/tests/htmlimports/resources/module-script-inline.html
[add] https://crrev.com/b19c80ec1d10fa885d2174ad432bc00c472d4344/third_party/WebKit/LayoutTests/http/tests/htmlimports/resources/module.js

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e7fec99ee093143c897b019b270886edb0f24cb

commit 8e7fec99ee093143c897b019b270886edb0f24cb
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Thu Jun 01 06:07:58 2017

Support module scripts in imported HTMLs

This CL makes ScriptLoader use the Modulator of the context document
instead of the element document.
This is consistent with classic scripts for which we use context
document's ScriptController for execution.

BUG= 721070 

Change-Id: Ib5388e28e91d16b196bb579ee171ac8e0f48ddcc
Reviewed-on: https://chromium-review.googlesource.com/517766
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476206}
[modify] https://crrev.com/8e7fec99ee093143c897b019b270886edb0f24cb/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8e7fec99ee093143c897b019b270886edb0f24cb/third_party/WebKit/Source/core/dom/ScriptLoader.cpp

Status: Fixed (was: Available)

Sign in to add a comment