<script type=module> should work inside HTML Imports |
|||||
Issue descriptionReport from bicknellr@ (CCed) is that it doesn't work right now.
,
May 12 2017
,
May 26 2017
This doesn't read like a blocker, is it? If it is then it should be bumped to P1, M61 and in someone's queue. If it's not then it should be removed from issue 594639 's blockers (possibly added to a different meta bug for follow-up work).
,
May 26 2017
,
May 26 2017
When I was working on the intent-to-ship a year ago, the conversation with the Polymer team and esprehn@ suggested that this should be a blocker (I don't have documentation of that, this is from memory). I can understand that things may well have changed in a year, but I think it would be good to check with some Blink API owners for their thoughts on this question (dglazkov in particular).
,
May 30 2017
,
May 30 2017
kochi@ to provide layout test
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b19c80ec1d10fa885d2174ad432bc00c472d4344 commit b19c80ec1d10fa885d2174ad432bc00c472d4344 Author: Takayoshi Kochi <kochi@chromium.org> Date: Wed May 31 13:32:48 2017 Add layout tests for module script used from HTML imports These tests currently crash, and TestExpectations includes [ Crash ] lines. BUG= 721070 Change-Id: I7a7ab16cd6395d4448271fd4cd46eb9d3e0a4c37 Reviewed-on: https://chromium-review.googlesource.com/517849 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#475895} [modify] https://crrev.com/b19c80ec1d10fa885d2174ad432bc00c472d4344/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/b19c80ec1d10fa885d2174ad432bc00c472d4344/third_party/WebKit/LayoutTests/http/tests/htmlimports/import-and-script-module-external.html [add] https://crrev.com/b19c80ec1d10fa885d2174ad432bc00c472d4344/third_party/WebKit/LayoutTests/http/tests/htmlimports/import-and-script-module-inline.html [add] https://crrev.com/b19c80ec1d10fa885d2174ad432bc00c472d4344/third_party/WebKit/LayoutTests/http/tests/htmlimports/resources/module-script-external.html [add] https://crrev.com/b19c80ec1d10fa885d2174ad432bc00c472d4344/third_party/WebKit/LayoutTests/http/tests/htmlimports/resources/module-script-inline.html [add] https://crrev.com/b19c80ec1d10fa885d2174ad432bc00c472d4344/third_party/WebKit/LayoutTests/http/tests/htmlimports/resources/module.js
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e7fec99ee093143c897b019b270886edb0f24cb commit 8e7fec99ee093143c897b019b270886edb0f24cb Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Thu Jun 01 06:07:58 2017 Support module scripts in imported HTMLs This CL makes ScriptLoader use the Modulator of the context document instead of the element document. This is consistent with classic scripts for which we use context document's ScriptController for execution. BUG= 721070 Change-Id: Ib5388e28e91d16b196bb579ee171ac8e0f48ddcc Reviewed-on: https://chromium-review.googlesource.com/517766 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#476206} [modify] https://crrev.com/8e7fec99ee093143c897b019b270886edb0f24cb/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/8e7fec99ee093143c897b019b270886edb0f24cb/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
,
Jun 1 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bickne...@google.com
, May 11 2017``` <link rel="import" href="import-with-module.html"> ``` import-with-module.html: ``` <script type="module"> console.log('module in import'); </script> ``` This should be enough to crash 60.0.3096.0 + "Experimental Web Platform features". However, it doesn't crash if you remove *all* of the text from the inline module.