New issue
Advanced search Search tips

Issue 721066 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

FastFree link warning

Project Member Reported by a...@chromium.org, May 10 2017

Issue description

A ToT build at 5fa8d94b7460 has the following link warning:

[5905/117/30060] SOLINK libblink_platform.dylib libblink_platform.dylib.TOC
ld: warning: direct access in function 'blink::HarfBuzzSkiaGetTable(hb_face_t*, unsigned int, void*)' from file 'obj/third_party/WebKit/Source/platform/platform/HarfBuzzFace.o' to global weak symbol 'WTF::Partitions::FastFree(void*)' from file 'obj/third_party/WebKit/Source/platform/platform/FontCacheMac.o' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.

This is new.
 

Comment 1 by vivekg@chromium.org, May 11 2017

Yeah I also observed exact same error on mac

Comment 2 by a...@chromium.org, May 11 2017

Cc: a...@chromium.org thakis@chromium.org
There's been no recent change to this code. Maybe Nico knows about possible build changes that might have been done?

Comment 3 by mark@chromium.org, Jun 15 2017

Cc: jochen@chromium.org kerrnel@chromium.org mark@chromium.org rsesek@chromium.org
Components: Blink>Internals>WTF
Labels: OS-Mac
Owner: jochen@chromium.org
Status: Assigned (was: Untriaged)
This was probably caused by 7475d0c2ee929ce0c2fe346fd7ebb6937f89d9e3, just like  bug 731751 . The date that this was filed aligns with that theory. Additional reading is https://groups.google.com/a/google.com/d/topic/chrome-mac-dev/PODn7JZAMJM.

Comment 4 by jochen@chromium.org, Jun 20 2017

Avi, what are your gn args?

Comment 5 by a...@chromium.org, Jun 20 2017

is_component_build = true
is_debug = true
use_goma = true
enable_nacl = false

When I build all:

> ninja -C out/debug all -j 500 -l 23 -k 100
ninja: Entering directory `out/debug'
[0/1/1] Regenerating ninja files
[10546/500/33306] SOLINK libblink_platform.dylib libblink_platform.dylib.TOC
ld: warning: direct access in function 'blink::HarfBuzzSkiaGetTable(hb_face_t*, unsigned int, void*)' from file 'obj/third_party/WebKit/Source/platform/platform/HarfBuzzFace.o' to global weak symbol 'WTF::Partitions::FastFree(void*)' from file 'obj/third_party/WebKit/Source/platform/platform/FontCacheMac.o' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.
[0/1/44351] STAMP obj/All.stamp

Using the 10.12 SDK.

Comment 6 by jochen@chromium.org, Jun 20 2017

Status: Fixed (was: Assigned)

Sign in to add a comment