New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 720927 link

Starred by 2 users
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
mahmadi@chromium.org
ew...@chromium.org
rdevlin....@chromium.org
nyerramilli@chromium.org
msarda@chromium.org
dbeam@chromium.org
█ tkonch...@chromium.org
jlebel@chromium.org
bettes@chromium.org
michae...@chromium.org
█ ranjitkan@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

WebUI: Replace remaining usages of paper-dropdown-menu with md-select

Project Member Reported by dpa...@chromium.org, May 10 2017 
At [1] paper-dropdown-menu usage was replaced with a native <select> styled to look MD as much as possible [2], which is currently used by MD Settings and OOBE. Unfortunately there are still some usages of paper-dropdown-menu laying around in other WebUI pages. Specifically the following files still use it:

chromeos/emulator/battery_settings.html
md_extensions/keyboard_shortcuts.html
md_user_manager/create_profile.html

We should migrate those to md-select and eventually remove paper-dropdown-menu from third_party/polymer.


[1] https://bugs.chromium.org/p/chromium/issues/detail?id=651513
[2] https://cs.chromium.org/chromium/src/ui/webui/resources/html/md_select_css.html
[3] https://cs.chromium.org/search/?q=paper-dropdown-menu+file:%5Esrc/chrome/browser/resources/+package:%5Echromium$&type=cs

Comment 1 by dpa...@chromium.org, Jun 10 2017

Cc: steve...@chromium.org
FYI removing paper-dropdown-menu will allow us to also delete paper-menu-button, since it is the only user of it, see https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/bower.json?l=32.

@michaelpg, @stevenjb: Do you know if device-emulator is still being used? Visiting chrome://device-emulator is not returning a WebUI page, and the corresponding C++ WebUI controller does not seem to be referenced by anyone (https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/emulator/device_emulator_ui.h).

Comment 2 by dpa...@chromium.org, Jun 10 2017 

I think I found the answer about device-emulator. It is used on non-official ChromeOS builds, if I am interpreting correctly the following code https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc?type=cs&q=kChromeUIDeviceEmulatorHost&sq=package:chromium&l=494.

Comment 3 by scottchen@chromium.org, Jun 10 2017

Owner: scottchen@chromium.org
Status: Assigned (was: Available)

Comment 4 by michae...@chromium.org, Jun 10 2017 

We should keep chrome://device-emulator around. Although feel free to make it uglier if it's the only user of some particular eye candy.

It works only on Chrome-OS-on-Linux and is compiled out of official builds. It's intended to emulate device settings when you're not on a device, letting us test features like power supplies, pointer settings, etc.

Comment 5 by dpa...@chromium.org, Jun 10 2017 

Thanks. I was able to run it locally, looks suprisingly MD-ified for a developer only page).
emulator.png
49.7 KB View Download

Comment 6 by dpa...@chromium.org, Jun 10 2017

Cc: ew...@chromium.org bettes@chromium.org mahmadi@chromium.org ranjitkan@chromium.org jlebel@chromium.org msarda@chromium.org nyerramilli@chromium.org tkonch...@chromium.org
 Issue 652576  has been merged into this issue.

Comment 7 by scottchen@chromium.org, Jun 14 2017

Status: Started (was: Assigned)

Comment 8 by scottchen@chromium.org, Jun 20 2017

Status: Fixed (was: Started)

Comment 9 by dpa...@chromium.org, Jun 20 2017 

Are you planning to remove all the unused Polymer elements (paper-dropdown-menu, paper-menu-button, see comment #1)? Maybe let's keep this bug open to track the removal too, or file a separate one. FWIW, I am happy to delete the unused stuff if you are busy with other issues.

Comment 10 by dpa...@chromium.org, Jun 21 2017 

FYI, filed  issue 735585  to track remaining work.
►

Sign in to add a comment