New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720924 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Race condition in checking memory pressure

Project Member Reported by shrike@chromium.org, May 10 2017

Issue description

OS: macOS

The change in https://codereview.chromium.org/2743253006 stops the Mac memory pressure monitor from checking the current pressure level directly on each call to GetCurrentPressureLevel(). However, if the OS sends a pressure change notification, callers of GetCurrentPressureLevel() may receive the old pressure level.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb11bbe1e11b29ad870bdf5a940847dda841f542

commit fb11bbe1e11b29ad870bdf5a940847dda841f542
Author: shrike <shrike@chromium.org>
Date: Tue May 16 18:30:30 2017

[Mac] Fix race condition in memory pressure level reporting.

The change in https://codereview.chromium.org/2743253006 stops the Mac
memory pressure monitor from checking the current pressure level
directly on each call to GetCurrentPressureLevel(). However, if the OS
sends a pressure change notification, callers of
GetCurrentPressureLevel() may receive the old pressure level. This cl
fixes the race condition by forcing an internal pressure level update
upon receiving a pressure level change notification from the OS.

R=brettw@chromium.org,mark@chromium.org
BUG= 720924 

Review-Url: https://codereview.chromium.org/2877573002
Cr-Commit-Position: refs/heads/master@{#472171}

[modify] https://crrev.com/fb11bbe1e11b29ad870bdf5a940847dda841f542/base/memory/memory_pressure_monitor_mac.cc

Comment 2 by shrike@chromium.org, May 16 2017

Status: Fixed (was: Started)

Sign in to add a comment