New issue
Advanced search Search tips

Issue 720917 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 731255



Sign in to add a comment

Access to DisplayManager & DisplayConfigurationController from Chrome

Project Member Reported by felixe@chromium.org, May 10 2017

Issue description

During OOBE we might need to redirect output to other displays, see  http://crbug.com/668449 , similarly to the needs described in  http://crbug.com/686848 .

I need access to DisplayManager & DisplayConfigurationController to iterate displays and change which one is the primary one.
 

Comment 1 by felixe@chromium.org, May 10 2017

Description: Show this description

Comment 2 by sky@chromium.org, Aug 11 2017

Blocking: 731255
Owner: sky@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6ab7cbf77702812b690d7ea835afb51e63de4f7

commit e6ab7cbf77702812b690d7ea835afb51e63de4f7
Author: Scott Violet <sky@chromium.org>
Date: Tue Aug 15 22:10:56 2017

chromeos: move TouchDeviceTransform to ui/events/devices

And makes the public API of DeviceDataManager have a single setter for
configuring touch devices. I'm doing this so changes can be applied
atomically and observers are notified with a single notification for
all the changes.

BUG= 720917 
TEST=covered by test

Change-Id: Id10eff2b79f79f4b8c33f6a9237594def9a0a769
Reviewed-on: https://chromium-review.googlesource.com/615582
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494570}
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ash/DEPS
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ash/mus/BUILD.gn
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ash/mus/touch_transform_setter_mus.cc
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ash/mus/touch_transform_setter_mus.h
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/services/ui/input_devices/BUILD.gn
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/services/ui/input_devices/touch_device_server.cc
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/services/ui/input_devices/touch_device_server.h
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/services/ui/public/interfaces/input_devices/BUILD.gn
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/services/ui/public/interfaces/input_devices/touch_device_server.mojom
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/display/BUILD.gn
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/display/manager/BUILD.gn
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/display/manager/chromeos/DEPS
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/display/manager/chromeos/default_touch_transform_setter.cc
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/display/manager/chromeos/default_touch_transform_setter.h
[delete] https://crrev.com/c4e3ee09dcc196db3fa28a8018c14e4bd6390dbb/ui/display/manager/chromeos/mojo/BUILD.gn
[delete] https://crrev.com/c4e3ee09dcc196db3fa28a8018c14e4bd6390dbb/ui/display/manager/chromeos/mojo/OWNERS
[delete] https://crrev.com/c4e3ee09dcc196db3fa28a8018c14e4bd6390dbb/ui/display/manager/chromeos/mojo/touch_device_transform.typemap
[delete] https://crrev.com/c4e3ee09dcc196db3fa28a8018c14e4bd6390dbb/ui/display/manager/chromeos/mojo/touch_device_transform_struct_traits.h
[delete] https://crrev.com/c4e3ee09dcc196db3fa28a8018c14e4bd6390dbb/ui/display/manager/chromeos/mojo/typemaps.gni
[delete] https://crrev.com/c4e3ee09dcc196db3fa28a8018c14e4bd6390dbb/ui/display/manager/chromeos/touch_device_transform.h
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/display/manager/chromeos/touch_transform_controller.cc
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/display/manager/chromeos/touch_transform_controller.h
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/display/manager/chromeos/touch_transform_controller_unittest.cc
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/display/manager/chromeos/touch_transform_setter.h
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/BUILD.gn
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/devices/BUILD.gn
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/devices/device_data_manager.cc
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/devices/device_data_manager.h
[add] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/devices/device_data_manager_unittest.cc
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/devices/mojo/BUILD.gn
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/devices/mojo/OWNERS
[rename] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/devices/mojo/touch_device_transform.mojom
[add] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/devices/mojo/touch_device_transform.typemap
[add] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/devices/mojo/touch_device_transform_struct_traits.h
[rename] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/devices/mojo/touch_device_transform_struct_traits_unittest.cc
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/devices/mojo/typemaps.gni
[rename] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/devices/touch_device_transform.cc
[add] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/devices/touch_device_transform.h
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/devices/touchscreen_device.cc
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/devices/touchscreen_device.h
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/test/device_data_manager_test_api.h
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/test/device_data_manager_test_api_impl.cc
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/events/test/device_data_manager_test_api_stub.cc
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/gfx/mojo/BUILD.gn
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/gfx/mojo/selection_bound.typemap
[modify] https://crrev.com/e6ab7cbf77702812b690d7ea835afb51e63de4f7/ui/gfx/mojo/transform.typemap

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb8c49b7bec158d189f4ffc213c39004d93efc3f

commit cb8c49b7bec158d189f4ffc213c39004d93efc3f
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 16 14:44:20 2017

Move radius_scale into TouchDeviceTransform

This avoids having to have a separate map on the side for the scale.

BUG= 720917 
TEST=covered by test

Change-Id: I62e6f2f3c06729dca824949d90f57a7511b17bfb
Reviewed-on: https://chromium-review.googlesource.com/616065
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494775}
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/ash/mus/touch_transform_setter_mus.cc
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/ash/mus/touch_transform_setter_mus.h
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/services/ui/input_devices/touch_device_server.cc
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/services/ui/input_devices/touch_device_server.h
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/services/ui/public/interfaces/input_devices/touch_device_server.mojom
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/ui/display/manager/chromeos/default_touch_transform_setter.cc
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/ui/display/manager/chromeos/default_touch_transform_setter.h
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/ui/display/manager/chromeos/touch_transform_controller.cc
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/ui/display/manager/chromeos/touch_transform_controller_unittest.cc
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/ui/display/manager/chromeos/touch_transform_setter.h
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/ui/events/devices/device_data_manager.cc
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/ui/events/devices/device_data_manager.h
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/ui/events/devices/device_data_manager_unittest.cc
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/ui/events/devices/mojo/touch_device_transform.mojom
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/ui/events/devices/mojo/touch_device_transform_struct_traits.h
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/ui/events/devices/mojo/touch_device_transform_struct_traits_unittest.cc
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/ui/events/devices/touch_device_transform.h
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/ui/events/test/device_data_manager_test_api_impl.cc
[modify] https://crrev.com/cb8c49b7bec158d189f4ffc213c39004d93efc3f/ui/events/test/device_data_manager_test_api_stub.cc

Comment 5 by sky@chromium.org, Aug 16 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d57ca2127f6a46d8e4521d176327048061a333a

commit 6d57ca2127f6a46d8e4521d176327048061a333a
Author: Scott Violet <sky@chromium.org>
Date: Thu Aug 17 19:46:24 2017

chromeos: Converts OobeDisplayChooser to use InputDeviceManager

As part of this I'm adding AreTouchscreenTargetDisplaysValid(), which
lets client now whether TouchscreenDevice::target_display_id is valid.

BUG= 720917 
TEST=covered by test

Change-Id: I672b33c6239b8acb9e42b7d038f902b87776ebd8
Reviewed-on: https://chromium-review.googlesource.com/617589
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495286}
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/chrome/browser/DEPS
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/chrome/browser/ui/webui/chromeos/login/DEPS
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/chrome/browser/ui/webui/chromeos/login/oobe_display_chooser.cc
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/chrome/browser/ui/webui/chromeos/login/oobe_display_chooser.h
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/chrome/browser/ui/webui/chromeos/login/oobe_display_chooser_unittest.cc
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/services/ui/input_devices/input_device_server.cc
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/services/ui/input_devices/input_device_server.h
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/services/ui/public/cpp/input_devices/input_device_client.cc
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/services/ui/public/cpp/input_devices/input_device_client.h
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/services/ui/public/interfaces/input_devices/input_device_server.mojom
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/ui/events/BUILD.gn
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/ui/events/devices/device_data_manager.cc
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/ui/events/devices/device_data_manager.h
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/ui/events/devices/device_data_manager_unittest.cc
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/ui/events/devices/input_device_event_observer.h
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/ui/events/devices/input_device_manager.h
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/ui/events/devices/touchscreen_device.h
[modify] https://crrev.com/6d57ca2127f6a46d8e4521d176327048061a333a/ui/events/devices/x11/device_data_manager_x11.cc

Comment 7 by sky@chromium.org, Aug 17 2017

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/803b9e7e154c0a9cf1f03f7d464a342afce5604b

commit 803b9e7e154c0a9cf1f03f7d464a342afce5604b
Author: Scott Violet <sky@chromium.org>
Date: Thu Aug 17 23:00:21 2017

Revert "chromeos: Converts OobeDisplayChooser to use InputDeviceManager"

This reverts commit 6d57ca2127f6a46d8e4521d176327048061a333a.

Reason for revert: This makes Chrome not draw anything.

Original change's description:
> chromeos: Converts OobeDisplayChooser to use InputDeviceManager
> 
> As part of this I'm adding AreTouchscreenTargetDisplaysValid(), which
> lets client now whether TouchscreenDevice::target_display_id is valid.
> 
> BUG= 720917 
> TEST=covered by test
> 
> Change-Id: I672b33c6239b8acb9e42b7d038f902b87776ebd8
> Reviewed-on: https://chromium-review.googlesource.com/617589
> Reviewed-by: kylechar <kylechar@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#495286}

TBR=sky@chromium.org,tsepez@chromium.org,kylechar@chromium.org

Change-Id: I1cb6cb071048f3e69fe3b6e27738afdcf4a51dc3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  720917 
Reviewed-on: https://chromium-review.googlesource.com/619629
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495367}
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/chrome/browser/DEPS
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/chrome/browser/ui/webui/chromeos/login/DEPS
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/chrome/browser/ui/webui/chromeos/login/oobe_display_chooser.cc
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/chrome/browser/ui/webui/chromeos/login/oobe_display_chooser.h
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/chrome/browser/ui/webui/chromeos/login/oobe_display_chooser_unittest.cc
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/services/ui/input_devices/input_device_server.cc
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/services/ui/input_devices/input_device_server.h
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/services/ui/public/cpp/input_devices/input_device_client.cc
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/services/ui/public/cpp/input_devices/input_device_client.h
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/services/ui/public/interfaces/input_devices/input_device_server.mojom
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/ui/events/BUILD.gn
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/ui/events/devices/device_data_manager.cc
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/ui/events/devices/device_data_manager.h
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/ui/events/devices/device_data_manager_unittest.cc
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/ui/events/devices/input_device_event_observer.h
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/ui/events/devices/input_device_manager.h
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/ui/events/devices/touchscreen_device.h
[modify] https://crrev.com/803b9e7e154c0a9cf1f03f7d464a342afce5604b/ui/events/devices/x11/device_data_manager_x11.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cbe20155ed41a985dcc7a99fd32492a72d54101

commit 7cbe20155ed41a985dcc7a99fd32492a72d54101
Author: Scott Violet <sky@chromium.org>
Date: Sat Aug 19 00:54:30 2017

[reland] chromeos: Converts OobeDisplayChooser to use InputDeviceManager

Original patch was here: https://chromium-review.googlesource.com/c/617589

This differs from the original in that the original triggered a never ending
cycle. Specifically when the client modified ConfigureTouchDevices() it
notify the touch-devices changed, which triggered another call to
ConfigureTouchDevices ... To fix this I made it so that ConfigureTouchDevices
only sends OnTouchDeviceAssociationChanged. I also changed the meaning
of the mojom slightly to deal with this. Patchset 1 is the original patchset,
2 the fix.

As part of this I'm adding AreTouchscreenTargetDisplaysValid(), which
lets client now whether TouchscreenDevice::target_display_id is valid.

BUG= 720917 
TEST=covered by test

Change-Id: Iedc7e1ff7816d6c85e10d60f77b79bc392676861
Reviewed-on: https://chromium-review.googlesource.com/620203
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495770}
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/chrome/browser/DEPS
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/chrome/browser/ui/webui/chromeos/login/DEPS
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/chrome/browser/ui/webui/chromeos/login/oobe_display_chooser.cc
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/chrome/browser/ui/webui/chromeos/login/oobe_display_chooser.h
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/chrome/browser/ui/webui/chromeos/login/oobe_display_chooser_unittest.cc
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/services/ui/input_devices/input_device_server.cc
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/services/ui/input_devices/input_device_server.h
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/services/ui/public/cpp/input_devices/input_device_client.cc
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/services/ui/public/cpp/input_devices/input_device_client.h
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/services/ui/public/interfaces/input_devices/input_device_server.mojom
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/ui/events/BUILD.gn
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/ui/events/devices/device_data_manager.cc
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/ui/events/devices/device_data_manager.h
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/ui/events/devices/device_data_manager_unittest.cc
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/ui/events/devices/input_device_event_observer.h
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/ui/events/devices/input_device_manager.h
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/ui/events/devices/touchscreen_device.h
[modify] https://crrev.com/7cbe20155ed41a985dcc7a99fd32492a72d54101/ui/events/devices/x11/device_data_manager_x11.cc

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment