New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 720783 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Jun 2017
Cc:
█ pmeenan@chromium.org
█ rdsmith@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Add UMA to better understand the behavior of resource scheduler

Project Member Reported by tbansal@chromium.org, May 10 2017 
We should add UMA to better understand the behavior of resource scheduler. Particularly around how many requests go in-flight, how frequently high priority requests are in-flight at the same time as the low priority.

This UMA may be analyzed based on network quality (ECT, RTT or bandwidth) to get a sense of how scheduler behaves on different types of networks. This would also be useful to analyze performance of different resource scheduling algorithms.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29fc63386af102f88a5373b8b83ee94ac6b4ec45

commit 29fc63386af102f88a5373b8b83ee94ac6b4ec45
Author: tbansal <tbansal@chromium.org>
Date: Tue Jun 06 22:50:23 2017

Record resource scheduler UMA

Record UMA on how many requests are in-flight. UMA is recorded only when
the set of in-flight requests changes.

Also, record UMA on highest number of delayable requests in-flight when
a delayable or layout blocking request is in flight. This UMA is
recorded per-request (on select requests).

BUG= 720783 

Review-Url: https://codereview.chromium.org/2873223002
Cr-Commit-Position: refs/heads/master@{#477447}

[modify] https://crrev.com/29fc63386af102f88a5373b8b83ee94ac6b4ec45/content/browser/loader/resource_scheduler.cc
[modify] https://crrev.com/29fc63386af102f88a5373b8b83ee94ac6b4ec45/content/browser/loader/resource_scheduler_unittest.cc
[modify] https://crrev.com/29fc63386af102f88a5373b8b83ee94ac6b4ec45/tools/metrics/histograms/histograms.xml

Comment 2 by tbansal@chromium.org, Jun 6 2017

Components: Internals>Network>NetworkQuality
Labels: -Type-Bug M-61 Type-Task
Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/887fe771735c3af244a4ffeef75a3682865275e7

commit 887fe771735c3af244a4ffeef75a3682865275e7
Author: tbansal <tbansal@chromium.org>
Date: Wed Jun 07 16:05:14 2017

Add separator to the resource scheduler histograms

These somehow got missed in https://codereview.chromium.org/2873223002/

BUG= 720783 
TBR=rkaplow@chromium.org

Review-Url: https://codereview.chromium.org/2927773002
Cr-Commit-Position: refs/heads/master@{#477667}

[modify] https://crrev.com/887fe771735c3af244a4ffeef75a3682865275e7/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment