New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720781 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

WebUI: Replace remaining usage of paper-dialog with cr-dialog

Project Member Reported by dpa...@chromium.org, May 10 2017

Issue description

Previously [1] we created a cr-dialog element that is based on native <dialog> and not paper-dialog which had multiple problems. cr-dialog is already used across multiple UI pages (MD History, MD Settings, MD Bookmarks). Unfortunately there are still some usages of paper-dialog laying around, see [2]. We should migrate those to cr-dialog and eventually remove paper-dialog from our third_party/polymer folder.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=625332
[2] https://cs.chromium.org/search/?q=paper-dialog+file:%5Esrc/chrome/browser/resources/+package:%5Echromium$&type=cs
 

Comment 1 by dpa...@chromium.org, May 10 2017

Cc: alemate@chromium.org achuith@chromium.org dsinclair@chromium.org
List of files still using paper-dialog

chromeos/emulator/bluetooth_settings.html
chromeos/emulator/audio_settings.html
chromeos/login/saml_confirm_password.html
chromeos/login/offline_gaia.html
pdf/elements/viewer-error-screen/viewer-error-screen.html
pdf/elements/viewer-password-screen/viewer-password-screen.html
md_user_manager/user_manager_dialog.html

cc'ing corresponding OWNERS




Comment 2 by dpa...@chromium.org, May 10 2017

Summary: WebUI: Replace remaining usage of paper-dialog with cr-dialog (was: WebUI: Replace usage of paper-dialog with cr-dialog)

Comment 3 by dpa...@chromium.org, Jun 27 2017

FYI started work on md_user_manager/ at https://codereview.chromium.org/2957943003 (still WIP).

Comment 4 by dpa...@chromium.org, Jun 28 2017

Also chromeos/emulator/ migration is at https://codereview.chromium.org/2958193002.

Comment 5 by dpa...@chromium.org, Jun 28 2017

Cc: tsergeant@chromium.org
I noticed that pdf/elements was migrated already at https://chromium.googlesource.com/chromium/src/+/292816a57aa7292dd5057419ca5d6f7f091752ba, which means that after the above mentioned CL land, the only remaining usage will be chromeos/login.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9546a7a38d574646e91e92c12d9247378b5bb11

commit b9546a7a38d574646e91e92c12d9247378b5bb11
Author: dpapad <dpapad@chromium.org>
Date: Wed Jun 28 20:45:14 2017

Polymer: Make paper-dialog resources ChromeOS only.

The only remaining usages of paper-dialog are in ChromeOS. Until they are
removed (in favor of cr-dialog), there is no reason to include them in other platfrorms.

BUG= 720781 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2956003004
Cr-Commit-Position: refs/heads/master@{#483126}

[modify] https://crrev.com/b9546a7a38d574646e91e92c12d9247378b5bb11/ui/webui/resources/polymer_resources.grdp

Comment 8 by dpa...@chromium.org, Jun 28 2017

Cc: steve...@chromium.org
@stevenjb: The only remaining usages of paper-dialog are in 
chromeos/login/saml_confirm_password.html
chromeos/login/offline_gaia.html

Do you know if these are part of the new or old login UI?
So, saml_confirm_password is included in custom_elements_oobe.html which
appears to always be included:
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc?q=custom_elements_oobe.html&dr=C&l=143

(see code further down for where the code differentiates between MD and non
MD)

offline_gaia.html is included in both custom_elements_oobe.html and
custom_elements_login.html

So yeah, we'll need to migrate these.
Status: Started (was: Available)
Thanks for verifying, I started looking into these, hopefully should be a trivial migration.
FYI, last two usages of paper-dialog removed at https://codereview.chromium.org/2961103003.
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a140b8e1f361cdaf3a13e3c620a6bbe84ca7882

commit 4a140b8e1f361cdaf3a13e3c620a6bbe84ca7882
Author: dpapad <dpapad@chromium.org>
Date: Fri Jun 30 00:09:27 2017

Polymer: Remove unused paper-dialog and paper-dialog-behavior.

BUG= 720781 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2963213002
Cr-Commit-Position: refs/heads/master@{#483554}

[modify] https://crrev.com/4a140b8e1f361cdaf3a13e3c620a6bbe84ca7882/third_party/polymer/v1_0/bower.json
[delete] https://crrev.com/e44498c3ea4925a4868cad26fcee8fb91cd139cd/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/bower.json
[delete] https://crrev.com/e44498c3ea4925a4868cad26fcee8fb91cd139cd/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/compiled_resources2.gyp
[delete] https://crrev.com/e44498c3ea4925a4868cad26fcee8fb91cd139cd/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior-extracted.js
[delete] https://crrev.com/e44498c3ea4925a4868cad26fcee8fb91cd139cd/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior.html
[delete] https://crrev.com/e44498c3ea4925a4868cad26fcee8fb91cd139cd/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-common.css
[delete] https://crrev.com/e44498c3ea4925a4868cad26fcee8fb91cd139cd/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-shared-styles.html
[delete] https://crrev.com/e44498c3ea4925a4868cad26fcee8fb91cd139cd/third_party/polymer/v1_0/components-chromium/paper-dialog/bower.json
[delete] https://crrev.com/e44498c3ea4925a4868cad26fcee8fb91cd139cd/third_party/polymer/v1_0/components-chromium/paper-dialog/compiled_resources2.gyp
[delete] https://crrev.com/e44498c3ea4925a4868cad26fcee8fb91cd139cd/third_party/polymer/v1_0/components-chromium/paper-dialog/paper-dialog-extracted.js
[delete] https://crrev.com/e44498c3ea4925a4868cad26fcee8fb91cd139cd/third_party/polymer/v1_0/components-chromium/paper-dialog/paper-dialog.html
[modify] https://crrev.com/4a140b8e1f361cdaf3a13e3c620a6bbe84ca7882/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/4a140b8e1f361cdaf3a13e3c620a6bbe84ca7882/ui/webui/resources/polymer_resources.grdp

Status: Fixed (was: Started)

Comment 15 by oka@chromium.org, Jul 4 2017

Labels: OS-Chrome
Owner: dpa...@chromium.org
Status: Assigned (was: Fixed)
Files app uses paper-dialog, and #13 caused 738826.
Let me revert #13.
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b449e1b8f24470071fc6d07df3f42e0d914a484

commit 7b449e1b8f24470071fc6d07df3f42e0d914a484
Author: oka <oka@chromium.org>
Date: Tue Jul 04 09:03:04 2017

Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior. (patchset #1 id:1 of https://codereview.chromium.org/2963213002/ )

Reason for revert:
It caused  http://crbug.com/738826 

BUG= 738826 , 720781 

Original issue's description:
> Polymer: Remove unused paper-dialog and paper-dialog-behavior.
>
> BUG= 720781 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2963213002
> Cr-Commit-Position: refs/heads/master@{#483554}
> Committed: https://chromium.googlesource.com/chromium/src/+/4a140b8e1f361cdaf3a13e3c620a6bbe84ca7882

TBR=michaelpg@chromium.org,dpapad@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 720781 

Review-Url: https://codereview.chromium.org/2969003002
Cr-Commit-Position: refs/heads/master@{#484071}

[modify] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/bower.json
[add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/bower.json
[add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/compiled_resources2.gyp
[add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior-extracted.js
[add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior.html
[add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-common.css
[add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-shared-styles.html
[add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog/bower.json
[add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog/compiled_resources2.gyp
[add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog/paper-dialog-extracted.js
[add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog/paper-dialog.html
[modify] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/ui/webui/resources/polymer_resources.grdp

Cc: tetsui@chromium.org fukino@chromium.org oka@chromium.org
Components: Platform>Apps>FileManager
Apparently file manager still uses paper-dialog.

@tetsui, @fukino: Can you point me to the code that still uses it? I searched, but could not find any references to paper-dialog or PaperDialogBehavior. I would like to migrate the usage to cr-dilaog and remove paper-dialog. 
Found it at [1]. Perhaps cr-dialog is not the right element for this usage, instead a plain <dialog> element might be more appropriate. Looking into this.

[1] https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/elements/files_quick_view.html?s&l=20
FYI, sent CL https://codereview.chromium.org/2966163003 to migrate files app to not use paper-dialog.
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76c95498153b952fa28fd3a1d7759f7c006529f3

commit 76c95498153b952fa28fd3a1d7759f7c006529f3
Author: dpapad <dpapad@chromium.org>
Date: Thu Jul 06 18:25:25 2017

Revert "Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior."

This reverts commit 7b449e1b8f24470071fc6d07df3f42e0d914a484. Effectively this
is a relanding of crrev.com/2963213002.

The last usage of paper-dialog has been removed at crrev.com/2966163003.

TBR=michaelpg@chromium.org
BUG= 720781 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2974473002
Cr-Commit-Position: refs/heads/master@{#484679}

[modify] https://crrev.com/76c95498153b952fa28fd3a1d7759f7c006529f3/third_party/polymer/v1_0/bower.json
[delete] https://crrev.com/799b4a3caeaaa5b99fea35d3ce3a96f7553b8f56/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/bower.json
[delete] https://crrev.com/799b4a3caeaaa5b99fea35d3ce3a96f7553b8f56/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/compiled_resources2.gyp
[delete] https://crrev.com/799b4a3caeaaa5b99fea35d3ce3a96f7553b8f56/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior-extracted.js
[delete] https://crrev.com/799b4a3caeaaa5b99fea35d3ce3a96f7553b8f56/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior.html
[delete] https://crrev.com/799b4a3caeaaa5b99fea35d3ce3a96f7553b8f56/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-common.css
[delete] https://crrev.com/799b4a3caeaaa5b99fea35d3ce3a96f7553b8f56/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-shared-styles.html
[delete] https://crrev.com/799b4a3caeaaa5b99fea35d3ce3a96f7553b8f56/third_party/polymer/v1_0/components-chromium/paper-dialog/bower.json
[delete] https://crrev.com/799b4a3caeaaa5b99fea35d3ce3a96f7553b8f56/third_party/polymer/v1_0/components-chromium/paper-dialog/compiled_resources2.gyp
[delete] https://crrev.com/799b4a3caeaaa5b99fea35d3ce3a96f7553b8f56/third_party/polymer/v1_0/components-chromium/paper-dialog/paper-dialog-extracted.js
[delete] https://crrev.com/799b4a3caeaaa5b99fea35d3ce3a96f7553b8f56/third_party/polymer/v1_0/components-chromium/paper-dialog/paper-dialog.html
[modify] https://crrev.com/76c95498153b952fa28fd3a1d7759f7c006529f3/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/76c95498153b952fa28fd3a1d7759f7c006529f3/ui/webui/resources/polymer_resources.grdp

Status: Fixed (was: Assigned)
Removed again. Hopefully it sticks this time.

Comment 23 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment