Native notifications badged with the wrong icon when multiple Chrome versions installed |
||||
Issue descriptionChrome Version : 60.0.3088.3 (Official Build) dev (64-bit) and 60.0.3095.0 (Official Build) canary (64-bit) OS version : 10.12.4 What steps will reproduce the problem? (1) Install Chrome Dev and Chrome Canary builds. Note the difference in app icons (2) Allow a site, say calendar.google.com, to display notifications (3) While running Chrome Dev receive a notification What is the expected result? Notification is badged with the icon of the sending app, Chrome Dev What happens instead? Notification is badged with the icon of another app, Chrome Canary
,
May 10 2017
,
May 11 2017
,
May 11 2017
I think this is because both Chrome and Chrome Canary's AlertNotificationService.xpc share the same CFBundleIdentifier. XPCServices are supposed to be scoped to the application's bundle, but I'd guess that the notification center collates them globally. miguelg@ did try and give canary a different bundle identifier in the past on https://chromereviews.googleplex.com/573857014/, but it turned out we cannot change the identifier in the canary generation process because the XPC service is already signed by that time.
,
May 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44554d6a63cde5ea96c5d315176d7cf45222e1d6 commit 44554d6a63cde5ea96c5d315176d7cf45222e1d6 Author: miguelg <miguelg@chromium.org> Date: Mon May 22 10:11:51 2017 Rename the XPC identifier to use the outer bundle This is essentially a manual revert of https://codereview.chromium.org/2727003002 to provide XPC servers from different channels with a unique name. BUG= 720776 Review-Url: https://codereview.chromium.org/2884693002 Cr-Commit-Position: refs/heads/master@{#473538} [modify] https://crrev.com/44554d6a63cde5ea96c5d315176d7cf45222e1d6/chrome/browser/notifications/notification_platform_bridge_mac.mm [modify] https://crrev.com/44554d6a63cde5ea96c5d315176d7cf45222e1d6/chrome/browser/ui/cocoa/notifications/notification_constants_mac.mm
,
May 26 2017
,
May 30 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/src-internal.git/+/daec0b7fd62450a9e71776fa8f1bad83dc53ac41 commit daec0b7fd62450a9e71776fa8f1bad83dc53ac41 Author: Miguel Garcia <miguelg@chromium.org> Date: Tue May 30 08:54:07 2017
,
May 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/src-internal.git/+/2866d5e534b88fa9e19669b2fd8d975057837774 commit 2866d5e534b88fa9e19669b2fd8d975057837774 Author: Mark Mentovai <mark@chromium.org> Date: Wed May 31 21:02:29 2017
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9e38c66b645acd86e626d4dfcd6712203ac293b commit c9e38c66b645acd86e626d4dfcd6712203ac293b Author: miguelg <miguelg@chromium.org> Date: Fri Jun 02 12:55:59 2017 Supply a valid Alert XPC identifier to the canary build BUG= 720776 Review-Url: https://codereview.chromium.org/2917043002 Cr-Commit-Position: refs/heads/master@{#476624} [modify] https://crrev.com/c9e38c66b645acd86e626d4dfcd6712203ac293b/chrome/installer/mac/sign_versioned_dir.sh.in
,
Jun 2 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/src-internal.git/+/429904dcd466ec7a351175816b1de84d08a94d45 commit 429904dcd466ec7a351175816b1de84d08a94d45 Author: Miguel Garcia <miguelg@chromium.org> Date: Fri Jun 02 13:15:06 2017
,
Jun 5 2017
Canary 61.0.3119.0 has the renamed XPC service. Things seem to be working fine now. |
||||
►
Sign in to add a comment |
||||
Comment 1 by rpop@chromium.org
, May 10 2017Status: Available (was: Unconfirmed)