New issue
Advanced search Search tips

Issue 720774 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Bootstrapping: Distinguishing between device that are discoverable but not in OOBE

Project Member Reported by x...@chromium.org, May 10 2017

Issue description

Chrome Version: (copy from chrome://version)
OS: Chrome

If a CrOS device is not in OOBE, it should not be discovered by the Android Enrollment App. We should figure out a way to determine if there is a way to inform the Android Enrollment App whether the device is in OOBE.
 

Comment 1 by x...@chromium.org, May 11 2017

Cc: zork@chromium.org
Owner: minch@chromium.org

Comment 2 by x...@chromium.org, May 11 2017

Cc: -omrilio@chromium.org x...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/617dcc23c266b0b3c50fdb58052fdc6818e6b06b

commit 617dcc23c266b0b3c50fdb58052fdc6818e6b06b
Author: minch <minch@chromium.org>
Date: Thu May 25 00:19:56 2017

Bootstrapping: Reboot on enrollment failure

Add MESSAGE_REBOOT to ProtoDecoder. If host (slave device) enrollment
status received by the controller (master device) is
ENROLLMENT_STATUS_FAILURE. The controller can send MESSAGE_REBOOT to
the host to notify the host to reboot. The host would be re-discovered
by the controller after the reboot to restart the enrollment process.
So that the host device can be enrolled successfully without user
interaction.

BUG= 720774 

Review-Url: https://codereview.chromium.org/2901653002
Cr-Commit-Position: refs/heads/master@{#474486}

[modify] https://crrev.com/617dcc23c266b0b3c50fdb58052fdc6818e6b06b/chrome/browser/chromeos/login/screens/host_pairing_screen.cc
[modify] https://crrev.com/617dcc23c266b0b3c50fdb58052fdc6818e6b06b/chrome/browser/chromeos/login/screens/host_pairing_screen.h
[modify] https://crrev.com/617dcc23c266b0b3c50fdb58052fdc6818e6b06b/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/617dcc23c266b0b3c50fdb58052fdc6818e6b06b/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/617dcc23c266b0b3c50fdb58052fdc6818e6b06b/components/pairing/bluetooth_controller_pairing_controller.cc
[modify] https://crrev.com/617dcc23c266b0b3c50fdb58052fdc6818e6b06b/components/pairing/bluetooth_controller_pairing_controller.h
[modify] https://crrev.com/617dcc23c266b0b3c50fdb58052fdc6818e6b06b/components/pairing/bluetooth_host_pairing_controller.cc
[modify] https://crrev.com/617dcc23c266b0b3c50fdb58052fdc6818e6b06b/components/pairing/bluetooth_host_pairing_controller.h
[modify] https://crrev.com/617dcc23c266b0b3c50fdb58052fdc6818e6b06b/components/pairing/host_pairing_controller.h
[modify] https://crrev.com/617dcc23c266b0b3c50fdb58052fdc6818e6b06b/components/pairing/pairing_api.proto
[modify] https://crrev.com/617dcc23c266b0b3c50fdb58052fdc6818e6b06b/components/pairing/proto_decoder.cc
[modify] https://crrev.com/617dcc23c266b0b3c50fdb58052fdc6818e6b06b/components/pairing/proto_decoder.h

Project Member

Comment 4 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6872d3f67f6b70462aedcd20417c8ab31455f12c

commit 6872d3f67f6b70462aedcd20417c8ab31455f12c
Author: minch <minch@chromium.org>
Date: Thu May 25 00:20:32 2017

Devices shoule not be found by Android enrollment app after successful enrollment.

Changes in this cl,
1. Remove SetName() in BluetoothHostPairingController. The name of the
Apapter has been set in BluetoothAdapterBlueZ::Init().
2. Add UUID filter for device discovery when automatically
enrollment. This will make sure the device can only be found during OOBE.
It will not be found by the Android enrollment app after login if the
user set the device as discover-able manually.

BUG= 720774 

Review-Url: https://codereview.chromium.org/2888033002
Cr-Commit-Position: refs/heads/master@{#474487}

[modify] https://crrev.com/6872d3f67f6b70462aedcd20417c8ab31455f12c/components/pairing/bluetooth_controller_pairing_controller.cc
[modify] https://crrev.com/6872d3f67f6b70462aedcd20417c8ab31455f12c/components/pairing/bluetooth_host_pairing_controller.cc
[modify] https://crrev.com/6872d3f67f6b70462aedcd20417c8ab31455f12c/components/pairing/bluetooth_host_pairing_controller.h

Comment 5 by minch@chromium.org, May 25 2017

Status: Fixed (was: Assigned)

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment