New issue
Advanced search Search tips

Issue 720772 link

Starred by 1 user
Status: Fixed
Owner:
nedngu...@google.com
Closed: May 2017
Cc:
wangxianzhu@chromium.org
charliea@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Provide a command line script for running arbitrary blink_perf test path through Telemetry

Project Member Reported by nedngu...@google.com, May 10 2017 
Today, if a developer create new tests in a new directory in WebKit/PerformanceTests/foo, they will need to add some code in tools/perf/blink_perf.py to create s.t like a blink_perf.foo benchmark just to be able to run tests in foo/ directory through Telemetry.

This is inconvenient for users who just want to iterate on new WebKit perf tests & don't bother to add a new blink_perf benchmark to be run on the waterfall.

Proposal:
We will create a blink_perf benchmark that allows user to run against any test path in WebKit/PerformanceTests/ with the following command:
./tools/perf/run_benchmark blink_perf --test-path=<path to test>
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42e64aa07b0c14272ec351517ef75acc9a946a38

commit 42e64aa07b0c14272ec351517ef75acc9a946a38
Author: nednguyen <nednguyen@google.com>
Date: Thu May 11 17:36:39 2017

Add tools/perf/blink_perf_cmdline/OWNERS

This directory is for creating a new blink_perf benchmark that allows users
to run arbitrary blink_perf test paths through Telemetry

BUG= chromium:720772 

Review-Url: https://codereview.chromium.org/2875783002
Cr-Commit-Position: refs/heads/master@{#470999}

[add] https://crrev.com/42e64aa07b0c14272ec351517ef75acc9a946a38/tools/perf/contrib/blink_perf_cmdline/OWNERS
Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d449e8c4d349c0e4540a1d804920190ca76377c

commit 3d449e8c4d349c0e4540a1d804920190ca76377c
Author: nednguyen <nednguyen@google.com>
Date: Thu May 11 19:06:09 2017

Add the local blink_perf benchmark that supports running any subdir of WebKit/PerformanceTest

This tries to mimic the current commandline opion of
./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run
test case in WebKit/PerformanceTests/.. directory using the command:

./tools/perf/run_benchmark blink_perf --test-path=<path to test cases>

For examples, after this CL, users can invoke:
* './tools/perf/run_benchmark blink_perf --test-path=third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html'
command to run only color-changes-measure-frame-time.html test.

* './tools/perf/run_benchmark blink_perf --test-path=TestData/'
command to run all the tests in WebKit/PerformanceTests/TestData/ directory.

This is a lot more convenient for users who are wanting to add new test cases in
directories that aren't already covered by existing blink_perf.* benchmarks.

This benchmark is added to tools/perf/contrib/ directory because it isn't meant
to be scheduled on the perf waterfall.

BUG= 720772 

Review-Url: https://codereview.chromium.org/2874653002
Cr-Commit-Position: refs/heads/master@{#471028}

[add] https://crrev.com/3d449e8c4d349c0e4540a1d804920190ca76377c/tools/perf/contrib/blink_perf_cmdline/__init__.py
[add] https://crrev.com/3d449e8c4d349c0e4540a1d804920190ca76377c/tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py

Comment 3 by nedngu...@google.com, May 11 2017

Status: Fixed (was: Started)
►

Sign in to add a comment