New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720638 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Bootstrapping: Display Bluetooth name of Cros devices on OOBE screen

Project Member Reported by x...@chromium.org, May 10 2017

Issue description

Chrome Version: 
OS: Chrome OS

Right now the name shows up during pairing and user can't determine which device is which before attempting connection. Showing the name on OOBE screen would be a huge improvement.  

Omri, could you help provide a mock please? 
 
Cc: zalcorn@chromium.org mcirimele@chromium.org elizabethchiu@chromium.org
+Elizabeth - OOBE visual designer, could you help in providing a visual design on how to show device name in OOBE when user initiated enrollment?


+Maria,Zach FYI

Comment 2 by x...@chromium.org, May 11 2017

Cc: zork@chromium.org
Omri, Elizabeth, does this look good to you? See the right top corner of the screen. It's just one possible way to put the string. I'm open to other options too.

For those who might not know when the string should show up, the bluetooth name string will only be displayed if:
1) In OOBE
2) The CrOS device is in bluetooth discoverable mode (For ChromeBooks, it has to be enabled by the user pressing the keycombo Ctrl+Shift+Alt+S during OOBE. For other types of Chrome devices, the device will be in bluetooth discoverable mode automatically during OOBE)
after.png
672 KB View Download
I think we can put the string on the right top corner, but I want to make sure most users won't see the text on the right like the attached screen right now.

Also would you provide me an example of string for that, so that I can try to mock it up? 

Comment 4 by x...@chromium.org, May 12 2017

Elizabeth: For Chrome devices with sufficient input devices (like Chromebooks), user has to press the keycombo (Ctrl+Shift+Alt+S) to see the text (the keycombo put the device into Bluetooth discoverable mode, so that it can be connected and set up by an Android App via Bluetooth). This is not a normal user flow, so most of ChromeBook users won't see the text. For Chrome devices without sufficient input devices, the text is always visible during OOBE (because the device is Bluetooth discoverable automatically during OOBE). 

For the example of string, see https://docs.google.com/document/d/13z7k-nv3AAuSBbvwm4QN-tDsEwZwuOcw-d_EDNKJOlE/edit#heading=h.iuqffh6qhnd2.
Thanks for clarifying. If "{{Device_Type}}_{{Hash(Bluetooth_Mac)[-4:]}}" is the way we will display the message, I prefer show just "Bluetooth device detected: Macbook Pro". It seems to be easier to understand. 

Comment 6 by x...@chromium.org, May 12 2017

Re#5: I don't quite get it. For example, if the text is Chromebook_12AE, do you prefer show "Bluetooth device detected: Chromebook_12AE" string on the top right corner of the screen? The string "Bluetooth device detected" seems confusing if displayed on Chrome OS device, since it's the Android App to discover and detect the Chrome OS device, not the other way around. 
How about this? 
bluetooth_device-name.png
410 KB View Download

Comment 8 by x...@chromium.org, May 12 2017

Re#7: Looks good. But the name is the Bluetooth adapter's name. Not sure if it's fine to describe as the device name. Do we want to display the string exactly like in the mock? If so, what is the background color for the string? 

Comment 9 by x...@chromium.org, May 16 2017

Elizabeth: could you help clarify the questions in comment #8 please? Thanks!
What would you recommend for the name then? Should it be bluetooth device name, or bluetooth adapter's name?

Text: Roboto Mono regular 12
Background color: #FFF 17% 
Radius of the rounded corners: 4
Padding of both sides: 12
Height of the box: 28

Comment 11 by x...@chromium.org, May 16 2017

Re#10: How about "Bluetooth device name"? 

Comment 12 by x...@chromium.org, May 16 2017

Please see attached screenshot. Does this look good?
Screenshot 2017-05-16 at 2.39.22 PM.png
687 KB View Download
Project Member

Comment 13 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9102badab31062609acf65f4ddf9c3a332e85705

commit 9102badab31062609acf65f4ddf9c3a332e85705
Author: xdai <xdai@chromium.org>
Date: Thu May 18 17:16:49 2017

Bootstrapping: Display Bluetooth name of CrOS device on OOBE screen.

BUG= 720638 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2876753003
Cr-Commit-Position: refs/heads/master@{#472854}

[modify] https://crrev.com/9102badab31062609acf65f4ddf9c3a332e85705/chrome/browser/chromeos/login/version_info_updater.cc
[modify] https://crrev.com/9102badab31062609acf65f4ddf9c3a332e85705/chrome/browser/chromeos/login/version_info_updater.h
[modify] https://crrev.com/9102badab31062609acf65f4ddf9c3a332e85705/chrome/browser/resources/chromeos/login/login_shared.js
[modify] https://crrev.com/9102badab31062609acf65f4ddf9c3a332e85705/chrome/browser/resources/chromeos/login/md_login_shared.js
[modify] https://crrev.com/9102badab31062609acf65f4ddf9c3a332e85705/chrome/browser/resources/chromeos/login/version.html
[modify] https://crrev.com/9102badab31062609acf65f4ddf9c3a332e85705/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/9102badab31062609acf65f4ddf9c3a332e85705/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h
[modify] https://crrev.com/9102badab31062609acf65f4ddf9c3a332e85705/ui/login/display_manager.js
[modify] https://crrev.com/9102badab31062609acf65f4ddf9c3a332e85705/ui/login/oobe.css

Comment 14 by x...@chromium.org, May 18 2017

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
9574.0.0, 60.0.3105.0

Sign in to add a comment