New issue
Advanced search Search tips

Issue 720623 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
machenb...@chromium.org
dpranke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 524758


Sign in to add a comment

CQ doesn't run webkit_layout_tests on v8 rolls

Project Member Reported by thakis@chromium.org, May 10 2017 
https://codereview.chromium.org/2868373002/ reverts a v8 roll. Its tryjob did not run webkit_layout_tests: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450510

We currently believe that v8 roll broke webkit_layout_tests. If those don't run on v8 roll CLs, that'd explain why the cq didn't catch that.

Comment 1 by machenb...@chromium.org, May 11 2017 

V8 rolls have blink trybots added by CL description. See the roll:
https://codereview.chromium.org/2869723005/

It ran https://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/builds/9096 which was green.

The revert CL didn't include the same extra trybots.

It is another long-standing analyze bug that deps changes don't trigger layout tests. I think we could add that, but it'd trigger layout tests on all deps changes. That's why it wasn't done I think. AFAIK there was no logic to make a more refined decision and e.g. trigger layout tests on skia/v8 rolls only.

Comment 2 by tandrii@chromium.org, May 11 2017

Components: -Infra>CQ Infra>Client>Chrome

Comment 3 by machenb...@chromium.org, May 12 2017

Blocking: 720511

Comment 4 by bokan@chromium.org, May 16 2017

Components: -Blink Blink>Infra

Comment 5 by dpranke@chromium.org, May 16 2017

Blockedon: 524758
We do actually want the layout tests to be run on every change as appropriate, and are getting close to doing that. You can track  bug 524758  for progress; once that bug is fixed, you will not need to append the extra trybots to your CLs.

Comment 6 by qyears...@chromium.org, Sep 12 2017

Blocking: -720511
Status: Available (was: Untriaged)
Summary: CQ doesn't run webkit_layout_tests on v8 rolls (was: cq doesn't run webkit_layout_tests on v8 rolls)

Comment 7 by foolip@chromium.org, Jan 2 2018 

dpranke@, it looks like the important work in  issue 524758  is done now, did it also fix this issue or is there something left?

(Doing Blink>Infra triage of P2 issues older than 60 days.)

Comment 8 by dpranke@chromium.org, Jan 2 2018

Status: Fixed (was: Available)
You're correct, I think this is fixed now.

Comment 9 by machenb...@chromium.org, Jan 4 2018 

So, does that mean we can remove the extra blink trybot from our roll CLs now?

Comment 10 by dpranke@chromium.org, Jan 4 2018 

Yes.
►

Sign in to add a comment