New issue
Advanced search Search tips

Issue 720604 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Add support for accelerated Jpeg decoding to video capture service

Project Member Reported by chfremer@chromium.org, May 10 2017

Issue description

The video capture Mojo service currently does not support accelerated Jpeg decoding. To achieve feature parity with the legacy video capture stack, this needs to be added. 

Accelerated Jpeg decode for video capture is currently only in use on ChromeOS.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef15ddc5beec583e0d3554d06c359061c5dafc22

commit ef15ddc5beec583e0d3554d06c359061c5dafc22
Author: Christian Fremerey <chfremer@chromium.org>
Date: Fri May 04 21:16:26 2018

[Video Capture Service] Support accelerated jpeg decoding

* Move/rename class content::VideoCaptureGpuJpegDecoder to
  media::VideoCaptureJpegDecoderImpl and break dependencies to |content| in order
  to make it reusable for the video capture service. (I was unable to convince
  Gerrit that this is a move/rename. Sorry for this making it harder to review.)
* Split Gpu memory buffer factory methods from interface ui.mojom.Gpu to new interface
  ui.mojom.GpuMemoryBufferFactory
* Update class ui::ClientGpuMemoryBufferManager to depend on only the new interface
  ui.mojom.GpuMemoryBufferFactory.
* Inject dependencies on ui.mojom.GpuMemoryBufferFactory and viz.mojom.GpuService
  from Browser into video capture service when starting up the service.
* Enable the existing-but-disabled test cases for accelerated jpeg decoding in
  combination with video capture service

Design Doc: https://docs.google.com/document/d/169LS3U0DD7hHpqZSli0gpCaCqE1eWN4QXFSIGoruPwQ/edit?usp=sharing

Bug: 820608, 720604
Test: content_browsertests --gtest_filter=VideoCaptureBrowserTest.*
Change-Id: Ic9860e4f846dc0abfc85fec673b1d9c15b99c7d1
Reviewed-on: https://chromium-review.googlesource.com/971302
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556197}
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/content/browser/BUILD.gn
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/content/browser/gpu/gpu_client_impl.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/content/browser/gpu/gpu_client_impl.h
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/content/browser/renderer_host/media/in_process_video_capture_device_launcher.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/content/browser/renderer_host/media/service_video_capture_provider.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/content/browser/renderer_host/media/service_video_capture_provider.h
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/content/browser/renderer_host/media/service_video_capture_provider_unittest.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/content/browser/renderer_host/media/video_capture_browsertest.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/content/browser/renderer_host/media/video_capture_controller_unittest.cc
[add] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/content/browser/renderer_host/media/video_capture_dependencies.cc
[add] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/content/browser/renderer_host/media/video_capture_dependencies.h
[delete] https://crrev.com/dc62670454cc8c1d7ada88138a72e569ddd898cb/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/content/browser/utility_process_host.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/content/public/common/content_switches.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/content/public/common/content_switches.h
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/media/base/media_switches.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/media/base/media_switches.h
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/media/capture/BUILD.gn
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/media/capture/video/video_capture_device_client.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/media/capture/video/video_capture_device_client.h
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/media/capture/video/video_capture_jpeg_decoder.h
[add] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/media/capture/video/video_capture_jpeg_decoder_impl.cc
[rename] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/media/capture/video/video_capture_jpeg_decoder_impl.h
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/media/mojo/clients/BUILD.gn
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.h
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/ui/public/cpp/gpu/gpu.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/ui/public/cpp/tests/gpu_unittest.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/ui/public/interfaces/gpu.mojom
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/ui/ws/gpu_client.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/ui/ws/gpu_client.h
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/video_capture/BUILD.gn
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/video_capture/DEPS
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/video_capture/device_factory_media_to_mojo_adapter.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/video_capture/device_factory_media_to_mojo_adapter.h
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/video_capture/device_factory_provider_impl.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/video_capture/device_factory_provider_impl.h
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/video_capture/device_media_to_mojo_adapter.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/video_capture/device_media_to_mojo_adapter.h
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/video_capture/device_media_to_mojo_adapter_unittest.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/video_capture/public/mojom/BUILD.gn
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/video_capture/public/mojom/device_factory_provider.mojom
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/video_capture/receiver_mojo_to_media_adapter.cc
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/video_capture/receiver_mojo_to_media_adapter.h
[modify] https://crrev.com/ef15ddc5beec583e0d3554d06c359061c5dafc22/services/video_capture/test/mock_device_test.cc

Project Member

Comment 2 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e42999fc84a8ee08f8dacda8cb8471d14dd596b1

commit e42999fc84a8ee08f8dacda8cb8471d14dd596b1
Author: Max Morin <maxmorin@chromium.org>
Date: Mon May 07 09:47:14 2018

Revert "[Video Capture Service] Support accelerated jpeg decoding"

This reverts commit ef15ddc5beec583e0d3554d06c359061c5dafc22.

Reason for revert: Crashing on WebRTC bot: https://build.chromium.org/deprecated/chromium.webrtc/builders/Win10%20Tester/builds/28286
Stack trace:
	base::debug::StackTrace::StackTrace [0x02F08F00+32]
	base::debug::StackTrace::StackTrace [0x02EDEACD+13]
	logging::LogMessage::~LogMessage [0x02E9DD40+80]
	base::ThreadTaskRunnerHandle::Get [0x02EA23ED+189]
	std::make_unique<media::VideoCaptureDeviceClient,std::unique_ptr<media::VideoFrameReceiverOnTaskRunner,std::default_delete<media::VideoFrameReceiverOnTaskRunner> >,scoped_refptr<media::VideoCaptureBufferPool> &,base::RepeatingCallback<std::unique_ptr<medi [0x024D0D18+178]
	base::internal::FunctorTraits<std::unique_ptr<media::VideoCaptureJpegDecoder,std::default_delete<media::VideoCaptureJpegDecoder> > (__cdecl*)(base::RepeatingCallback<void __cdecl(mojo::InterfaceRequest<media::mojom::JpegDecodeAccelerator>)>,base::Repeatin [0x024D1330+70]
	base::internal::Invoker<base::internal::BindState<std::unique_ptr<media::VideoCaptureJpegDecoder,std::default_delete<media::VideoCaptureJpegDecoder> > (__cdecl*)(base::RepeatingCallback<void __cdecl(mojo::InterfaceRequest<media::mojom::JpegDecodeAccelerat [0x024D12E1+33]
	media::VideoCaptureDeviceClient::OnIncomingCapturedData [0x03F23016+246]
	media::VideoCaptureDeviceWin::FrameReceived [0x03F2B124+228]
	media::SinkInputPin::Receive [0x03F2BF05+181]
	(No symbol) [0x6EB233FB]
	(No symbol) [0x6EB232F7]
	(No symbol) [0x6EB401BA]
	(No symbol) [0x6EB2420F]
	(No symbol) [0x6EB37E3B]
	BaseThreadInitThunk [0x763F8654+36]
	RtlGetAppContainerNamedObjectPath [0x77254B17+311]
	RtlGetAppContainerNamedObjectPath [0x77254AE7+263]

Original change's description:
> [Video Capture Service] Support accelerated jpeg decoding
> 
> * Move/rename class content::VideoCaptureGpuJpegDecoder to
>   media::VideoCaptureJpegDecoderImpl and break dependencies to |content| in order
>   to make it reusable for the video capture service. (I was unable to convince
>   Gerrit that this is a move/rename. Sorry for this making it harder to review.)
> * Split Gpu memory buffer factory methods from interface ui.mojom.Gpu to new interface
>   ui.mojom.GpuMemoryBufferFactory
> * Update class ui::ClientGpuMemoryBufferManager to depend on only the new interface
>   ui.mojom.GpuMemoryBufferFactory.
> * Inject dependencies on ui.mojom.GpuMemoryBufferFactory and viz.mojom.GpuService
>   from Browser into video capture service when starting up the service.
> * Enable the existing-but-disabled test cases for accelerated jpeg decoding in
>   combination with video capture service
> 
> Design Doc: https://docs.google.com/document/d/169LS3U0DD7hHpqZSli0gpCaCqE1eWN4QXFSIGoruPwQ/edit?usp=sharing
> 
> Bug: 820608, 720604
> Test: content_browsertests --gtest_filter=VideoCaptureBrowserTest.*
> Change-Id: Ic9860e4f846dc0abfc85fec673b1d9c15b99c7d1
> Reviewed-on: https://chromium-review.googlesource.com/971302
> Commit-Queue: Christian Fremerey <chfremer@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556197}

TBR=avi@chromium.org,sadrul@chromium.org,jcliang@chromium.org,tsepez@chromium.org,sandersd@chromium.org,emircan@chromium.org,mojahsu@chromium.org,piman@chromium.org,chfremer@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 820608, 720604
Change-Id: I518790cfb4eede5fd66d1f2862043285992c8af2
Reviewed-on: https://chromium-review.googlesource.com/1046525
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556397}
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/content/browser/BUILD.gn
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/content/browser/gpu/gpu_client_impl.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/content/browser/gpu/gpu_client_impl.h
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/content/browser/renderer_host/media/in_process_video_capture_device_launcher.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/content/browser/renderer_host/media/service_video_capture_provider.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/content/browser/renderer_host/media/service_video_capture_provider.h
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/content/browser/renderer_host/media/service_video_capture_provider_unittest.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/content/browser/renderer_host/media/video_capture_browsertest.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/content/browser/renderer_host/media/video_capture_controller_unittest.cc
[delete] https://crrev.com/e3d3e060a2b52d4267d5cb22929f3209fcf6aef5/content/browser/renderer_host/media/video_capture_dependencies.cc
[delete] https://crrev.com/e3d3e060a2b52d4267d5cb22929f3209fcf6aef5/content/browser/renderer_host/media/video_capture_dependencies.h
[add] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc
[rename] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/content/browser/utility_process_host.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/content/public/common/content_switches.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/content/public/common/content_switches.h
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/media/base/media_switches.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/media/base/media_switches.h
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/media/capture/BUILD.gn
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/media/capture/video/video_capture_device_client.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/media/capture/video/video_capture_device_client.h
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/media/capture/video/video_capture_jpeg_decoder.h
[delete] https://crrev.com/e3d3e060a2b52d4267d5cb22929f3209fcf6aef5/media/capture/video/video_capture_jpeg_decoder_impl.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/media/mojo/clients/BUILD.gn
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.h
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/ui/public/cpp/gpu/gpu.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/ui/public/cpp/tests/gpu_unittest.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/ui/public/interfaces/gpu.mojom
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/ui/ws/gpu_client.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/ui/ws/gpu_client.h
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/video_capture/BUILD.gn
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/video_capture/DEPS
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/video_capture/device_factory_media_to_mojo_adapter.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/video_capture/device_factory_media_to_mojo_adapter.h
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/video_capture/device_factory_provider_impl.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/video_capture/device_factory_provider_impl.h
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/video_capture/device_media_to_mojo_adapter.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/video_capture/device_media_to_mojo_adapter.h
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/video_capture/device_media_to_mojo_adapter_unittest.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/video_capture/public/mojom/BUILD.gn
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/video_capture/public/mojom/device_factory_provider.mojom
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/video_capture/receiver_mojo_to_media_adapter.cc
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/video_capture/receiver_mojo_to_media_adapter.h
[modify] https://crrev.com/e42999fc84a8ee08f8dacda8cb8471d14dd596b1/services/video_capture/test/mock_device_test.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23

commit e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23
Author: Christian Fremerey <chfremer@chromium.org>
Date: Tue Jun 05 14:43:52 2018

Reland [Video Capture Service] Support accelerated jpeg decoding

Relanding this as part of investigating the webrtc bot failure that required the
revert. The reland does not contain any changes compared to the reverted CL.
I am relanding in order to be able to get logs from the failure, because the
original logs are no longer accessible, see
https://bugs.chromium.org/p/chromium/issues/detail?id=848945 and
https://ci.chromium.org/buildbot/chromium.webrtc/Win10%20Tester/28286

This is assumed to cause the same bot failure as before, and I am going to
revert shortly after.

Original CL description:

* Move/rename class content::VideoCaptureGpuJpegDecoder to
  media::VideoCaptureJpegDecoderImpl and break dependencies to |content| in order
  to make it reusable for the video capture service. (I was unable to convince
  Gerrit that this is a move/rename. Sorry for this making it harder to review.)
* Split Gpu memory buffer factory methods from interface ui.mojom.Gpu to new interface
  ui.mojom.GpuMemoryBufferFactory
* Update class ui::ClientGpuMemoryBufferManager to depend on only the new interface
  ui.mojom.GpuMemoryBufferFactory.
* Inject dependencies on ui.mojom.GpuMemoryBufferFactory and viz.mojom.GpuService
  from Browser into video capture service when starting up the service.
* Enable the existing-but-disabled test cases for accelerated jpeg decoding in
  combination with video capture service

Design Doc: https://docs.google.com/document/d/169LS3U0DD7hHpqZSli0gpCaCqE1eWN4QXFSIGoruPwQ/edit?usp=sharing

Test: content_browsertests --gtest_filter=VideoCaptureBrowserTest.*
Bug: 820608, 720604
Change-Id: I6c77ce570aa8f0c3a54a12e0d3f14648c58005ac

TBR=avi@chromium.org,sadrul@chromium.org,jcliang@chromium.org,tsepez@chromium.org,sandersd@chromium.org,emircan@chromium.org,mojahsu@chromium.org,piman@chromium.org,chfremer@chromium.org

Change-Id: I6c77ce570aa8f0c3a54a12e0d3f14648c58005ac
Reviewed-on: https://chromium-review.googlesource.com/1086271
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564492}
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/content/browser/BUILD.gn
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/content/browser/gpu/gpu_client_impl.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/content/browser/gpu/gpu_client_impl.h
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/content/browser/renderer_host/media/in_process_video_capture_device_launcher.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/content/browser/renderer_host/media/service_video_capture_provider.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/content/browser/renderer_host/media/service_video_capture_provider.h
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/content/browser/renderer_host/media/service_video_capture_provider_unittest.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/content/browser/renderer_host/media/video_capture_browsertest.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/content/browser/renderer_host/media/video_capture_controller_unittest.cc
[add] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/content/browser/renderer_host/media/video_capture_dependencies.cc
[add] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/content/browser/renderer_host/media/video_capture_dependencies.h
[delete] https://crrev.com/f71c6a92aa8a35f7edd01d464cf0f7d38c0e9aac/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/content/browser/utility_process_host.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/content/public/common/content_switches.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/content/public/common/content_switches.h
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/media/base/media_switches.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/media/base/media_switches.h
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/media/capture/BUILD.gn
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/media/capture/video/video_capture_device_client.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/media/capture/video/video_capture_device_client.h
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/media/capture/video/video_capture_jpeg_decoder.h
[add] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/media/capture/video/video_capture_jpeg_decoder_impl.cc
[rename] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/media/capture/video/video_capture_jpeg_decoder_impl.h
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/media/mojo/clients/BUILD.gn
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.h
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/ui/public/cpp/gpu/gpu.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/ui/public/cpp/tests/gpu_unittest.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/ui/public/interfaces/gpu.mojom
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/ui/ws/gpu_client.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/ui/ws/gpu_client.h
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/video_capture/BUILD.gn
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/video_capture/DEPS
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/video_capture/device_factory_media_to_mojo_adapter.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/video_capture/device_factory_media_to_mojo_adapter.h
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/video_capture/device_factory_provider_impl.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/video_capture/device_factory_provider_impl.h
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/video_capture/device_media_to_mojo_adapter.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/video_capture/device_media_to_mojo_adapter.h
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/video_capture/device_media_to_mojo_adapter_unittest.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/video_capture/public/mojom/BUILD.gn
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/video_capture/public/mojom/device_factory_provider.mojom
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/video_capture/receiver_mojo_to_media_adapter.cc
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/video_capture/receiver_mojo_to_media_adapter.h
[modify] https://crrev.com/e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23/services/video_capture/test/mock_device_test.cc

Status: Started (was: Untriaged)
The build to watch for the webrtc Win10 tester failure is this one:
https://ci.chromium.org/buildbot/chromium.webrtc/Win10%20Tester/29171
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8267fa0633410103615151cbe52826c2bf0eef97

commit 8267fa0633410103615151cbe52826c2bf0eef97
Author: Christian Fremerey <chfremer@chromium.org>
Date: Tue Jun 05 16:33:54 2018

Revert "Reland [Video Capture Service] Support accelerated jpeg decoding"

This reverts commit e1bca9574eadf4baba88fb50f79bb8fa7b0cbc23.

Reason for revert: Still causes failure on webrtc Win10 Tester, see https://ci.chromium.org/buildbot/chromium.webrtc/Win10%20Tester/29171

Original change's description:
> Reland [Video Capture Service] Support accelerated jpeg decoding
> 
> Relanding this as part of investigating the webrtc bot failure that required the
> revert. The reland does not contain any changes compared to the reverted CL.
> I am relanding in order to be able to get logs from the failure, because the
> original logs are no longer accessible, see
> https://bugs.chromium.org/p/chromium/issues/detail?id=848945 and
> https://ci.chromium.org/buildbot/chromium.webrtc/Win10%20Tester/28286
> 
> This is assumed to cause the same bot failure as before, and I am going to
> revert shortly after.
> 
> Original CL description:
> 
> * Move/rename class content::VideoCaptureGpuJpegDecoder to
>   media::VideoCaptureJpegDecoderImpl and break dependencies to |content| in order
>   to make it reusable for the video capture service. (I was unable to convince
>   Gerrit that this is a move/rename. Sorry for this making it harder to review.)
> * Split Gpu memory buffer factory methods from interface ui.mojom.Gpu to new interface
>   ui.mojom.GpuMemoryBufferFactory
> * Update class ui::ClientGpuMemoryBufferManager to depend on only the new interface
>   ui.mojom.GpuMemoryBufferFactory.
> * Inject dependencies on ui.mojom.GpuMemoryBufferFactory and viz.mojom.GpuService
>   from Browser into video capture service when starting up the service.
> * Enable the existing-but-disabled test cases for accelerated jpeg decoding in
>   combination with video capture service
> 
> Design Doc: https://docs.google.com/document/d/169LS3U0DD7hHpqZSli0gpCaCqE1eWN4QXFSIGoruPwQ/edit?usp=sharing
> 
> Test: content_browsertests --gtest_filter=VideoCaptureBrowserTest.*
> Bug: 820608, 720604
> Change-Id: I6c77ce570aa8f0c3a54a12e0d3f14648c58005ac
> 
> TBR=avi@chromium.org,sadrul@chromium.org,jcliang@chromium.org,tsepez@chromium.org,sandersd@chromium.org,emircan@chromium.org,mojahsu@chromium.org,piman@chromium.org,chfremer@chromium.org
> 
> Change-Id: I6c77ce570aa8f0c3a54a12e0d3f14648c58005ac
> Reviewed-on: https://chromium-review.googlesource.com/1086271
> Reviewed-by: Christian Fremerey <chfremer@chromium.org>
> Commit-Queue: Christian Fremerey <chfremer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564492}

TBR=chfremer@chromium.org

Change-Id: Ica3e10019cc3b62f96e6b28836463ff197bf3384
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 820608, 720604
Reviewed-on: https://chromium-review.googlesource.com/1087367
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564533}
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/content/browser/BUILD.gn
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/content/browser/gpu/gpu_client_impl.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/content/browser/gpu/gpu_client_impl.h
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/content/browser/renderer_host/media/in_process_video_capture_device_launcher.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/content/browser/renderer_host/media/service_video_capture_provider.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/content/browser/renderer_host/media/service_video_capture_provider.h
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/content/browser/renderer_host/media/service_video_capture_provider_unittest.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/content/browser/renderer_host/media/video_capture_browsertest.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/content/browser/renderer_host/media/video_capture_controller_unittest.cc
[delete] https://crrev.com/88e2dc4f17fdf5e35b09e32ef8754acd256d0a35/content/browser/renderer_host/media/video_capture_dependencies.cc
[delete] https://crrev.com/88e2dc4f17fdf5e35b09e32ef8754acd256d0a35/content/browser/renderer_host/media/video_capture_dependencies.h
[add] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc
[rename] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/content/browser/utility_process_host.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/content/public/common/content_switches.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/content/public/common/content_switches.h
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/media/base/media_switches.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/media/base/media_switches.h
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/media/capture/BUILD.gn
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/media/capture/video/video_capture_device_client.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/media/capture/video/video_capture_device_client.h
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/media/capture/video/video_capture_jpeg_decoder.h
[delete] https://crrev.com/88e2dc4f17fdf5e35b09e32ef8754acd256d0a35/media/capture/video/video_capture_jpeg_decoder_impl.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/media/mojo/clients/BUILD.gn
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.h
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/ui/public/cpp/gpu/gpu.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/ui/public/cpp/tests/gpu_unittest.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/ui/public/interfaces/gpu.mojom
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/ui/ws/gpu_client.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/ui/ws/gpu_client.h
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/video_capture/BUILD.gn
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/video_capture/DEPS
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/video_capture/device_factory_media_to_mojo_adapter.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/video_capture/device_factory_media_to_mojo_adapter.h
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/video_capture/device_factory_provider_impl.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/video_capture/device_factory_provider_impl.h
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/video_capture/device_media_to_mojo_adapter.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/video_capture/device_media_to_mojo_adapter.h
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/video_capture/device_media_to_mojo_adapter_unittest.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/video_capture/public/mojom/BUILD.gn
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/video_capture/public/mojom/device_factory_provider.mojom
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/video_capture/receiver_mojo_to_media_adapter.cc
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/video_capture/receiver_mojo_to_media_adapter.h
[modify] https://crrev.com/8267fa0633410103615151cbe52826c2bf0eef97/services/video_capture/test/mock_device_test.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40cd31d1d8b7e496ca13227d8ae338e0f89b4061

commit 40cd31d1d8b7e496ca13227d8ae338e0f89b4061
Author: Christian Fremerey <chfremer@chromium.org>
Date: Wed Jun 06 17:23:51 2018

Reland 2 [Video Capture Service] Support accelerated jpeg decoding

This had been reverted because of a test failure on webrtc Win10 Tester for a
test that uses a real webcam.

Patchset 1 is the code as previously reviewed and reverted.
Patchset 2 adds a fix for the test failure.

Fix description:

The test failure revealed a mistake in the new code. Instead of operating the
Mojo connection to the jpeg decoder on the main task runner of the video capture
service, it would operate it from the thread the delivers the video frames from
the camera. On Windows, this thread is not a Chromium thread and as such does
not allow base::ThreadTaskRunnerHandle::Get(). The fix is to pass the correct
task runner to the factory code, see Patchset 2.

Original CL description:

* Move/rename class content::VideoCaptureGpuJpegDecoder to
  media::VideoCaptureJpegDecoderImpl and break dependencies to |content| in order
  to make it reusable for the video capture service. (I was unable to convince
  Gerrit that this is a move/rename. Sorry for this making it harder to review.)
* Split Gpu memory buffer factory methods from interface ui.mojom.Gpu to new interface
  ui.mojom.GpuMemoryBufferFactory
* Update class ui::ClientGpuMemoryBufferManager to depend on only the new interface
  ui.mojom.GpuMemoryBufferFactory.
* Inject dependencies on ui.mojom.GpuMemoryBufferFactory and viz.mojom.GpuService
  from Browser into video capture service when starting up the service.
* Enable the existing-but-disabled test cases for accelerated jpeg decoding in
  combination with video capture service

Design Doc: https://docs.google.com/document/d/169LS3U0DD7hHpqZSli0gpCaCqE1eWN4QXFSIGoruPwQ/edit?usp=sharing

Test: content_browsertests --gtest_filter=VideoCaptureBrowserTest.*
Bug: 820608, 720604
Change-Id: I6c77ce570aa8f0c3a54a12e0d3f14648c58005ac

TBR=avi@chromium.org,sadrul@chromium.org,jcliang@chromium.org,tsepez@chromium.org,sandersd@chromium.org,emircan@chromium.org,mojahsu@chromium.org,piman@chromium.org,chfremer@chromium.org

Change-Id: Id3493742537fa8a016dad391ee12e2869febf080
Reviewed-on: https://chromium-review.googlesource.com/1087867
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564942}
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/content/browser/BUILD.gn
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/content/browser/gpu/gpu_client_impl.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/content/browser/gpu/gpu_client_impl.h
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/content/browser/renderer_host/media/in_process_video_capture_device_launcher.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/content/browser/renderer_host/media/service_video_capture_provider.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/content/browser/renderer_host/media/service_video_capture_provider.h
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/content/browser/renderer_host/media/service_video_capture_provider_unittest.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/content/browser/renderer_host/media/video_capture_browsertest.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/content/browser/renderer_host/media/video_capture_controller_unittest.cc
[add] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/content/browser/renderer_host/media/video_capture_dependencies.cc
[add] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/content/browser/renderer_host/media/video_capture_dependencies.h
[delete] https://crrev.com/4671c00c498d74d9e4a0a9364b547bc85dda3704/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/content/browser/utility_process_host.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/content/public/common/content_switches.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/content/public/common/content_switches.h
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/media/base/media_switches.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/media/base/media_switches.h
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/media/capture/BUILD.gn
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/media/capture/video/video_capture_device_client.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/media/capture/video/video_capture_device_client.h
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/media/capture/video/video_capture_jpeg_decoder.h
[add] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/media/capture/video/video_capture_jpeg_decoder_impl.cc
[rename] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/media/capture/video/video_capture_jpeg_decoder_impl.h
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/media/mojo/clients/BUILD.gn
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.h
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/ui/public/cpp/gpu/gpu.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/ui/public/cpp/tests/gpu_unittest.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/ui/public/interfaces/gpu.mojom
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/ui/ws/gpu_client.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/ui/ws/gpu_client.h
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/video_capture/BUILD.gn
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/video_capture/DEPS
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/video_capture/device_factory_media_to_mojo_adapter.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/video_capture/device_factory_media_to_mojo_adapter.h
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/video_capture/device_factory_provider_impl.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/video_capture/device_factory_provider_impl.h
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/video_capture/device_media_to_mojo_adapter.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/video_capture/device_media_to_mojo_adapter.h
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/video_capture/device_media_to_mojo_adapter_unittest.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/video_capture/public/mojom/BUILD.gn
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/video_capture/public/mojom/device_factory_provider.mojom
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/video_capture/receiver_mojo_to_media_adapter.cc
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/video_capture/receiver_mojo_to_media_adapter.h
[modify] https://crrev.com/40cd31d1d8b7e496ca13227d8ae338e0f89b4061/services/video_capture/test/mock_device_test.cc

Sign in to add a comment