New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 720602 link

Starred by 1 user
Status: WontFix
Owner:
dmazz...@chromium.org
Closed: Oct 18
Cc:
█ nek...@chromium.org
dtseng@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Build flakiness generating ui/accessibility/ax_enums.h?

Project Member Reported by msw@chromium.org, May 10 2017 
Build flakiness generating ui/accessibility/ax_enums.h?

I got "fatal error: 'ui/accessibility/ax_enums.h' file not found" on this try run: 
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_chromeos_rel_ng%2F423168%2F%2B%2Frecipes%2Fsteps%2Fcompile__with_patch_%2F0%2Fstdout
FAILED: obj/chrome/browser/chromeos/test_support/mock_network_state_helper.o 
/b/c/goma_client/gomacc ... [MSW ELIDED FOR BREVITY] ...
In file included from ../../chrome/browser/chromeos/login/mock_network_state_helper.cc:5:
In file included from ../../chrome/browser/chromeos/login/mock_network_state_helper.h:8:
In file included from ../../chrome/browser/chromeos/login/helper.h:16:
../../ui/views/view.h:22:10: fatal error: 'ui/accessibility/ax_enums.h' file not found
#include "ui/accessibility/ax_enums.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I doubt my CL for the try job would have caused this: https://codereview.chromium.org/2870683002
Perhaps there's some flakiness in generating ui/accessibility/ax_enums.h (via under-specified dependencies)?

Comment 1 by thakis@chromium.org, Aug 16 2017 

I'm fixing a somewhat related thing here: https://chromium-review.googlesource.com/c/617768

So I think I know what's wrong here. :chromeos correctly has a public_deps here: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/BUILD.gn?type=cs&q=mock_network_state_helper&sq=package:chromium&l=34

But the test_support library here https://cs.chromium.org/chromium/src/chrome/browser/chromeos/BUILD.gn?type=cs&q=mock_network_state_helper&sq=package:chromium&l=1615 doesn't have a public_deps on :chromeos, only a regular deps. Making :chromeos a public_deps should fix things.

Comment 2 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Untriaged)

Comment 3 by dmazz...@chromium.org, Oct 18

Status: WontFix (was: Assigned)
Haven't seen reports of this in a long time
►

Sign in to add a comment