The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f5e66ed12f91be9c51916fa72f59e98cc927d1b

commit 3f5e66ed12f91be9c51916fa72f59e98cc927d1b
Author: engedy <engedy@chromium.org>
Date: Thu May 25 18:13:13 2017

Measure how often HTTPS credentials cannot be filled into HTTP forms.

When no matching HTTP credentials exist for a non-secure origin, but there are
credentials for the HTTPS version of that origin (which are obviously not filled
and hence called `suppressed` credentials), that could indicate:
 -- a premature `move-to-HTTPS` migration,
 -- the site serves its sign-up form over HTTPS, while sign-in forms over HTTP,
 -- some of its sign-in forms are served over HTTPS, some over HTTP.

BUG= 720599 

Review-Url: https://codereview.chromium.org/2895233002
Cr-Commit-Position: refs/heads/master@{#474708}

[modify] https://crrev.com/3f5e66ed12f91be9c51916fa72f59e98cc927d1b/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/3f5e66ed12f91be9c51916fa72f59e98cc927d1b/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/3f5e66ed12f91be9c51916fa72f59e98cc927d1b/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/3f5e66ed12f91be9c51916fa72f59e98cc927d1b/components/password_manager/core/browser/password_manager_unittest.cc
[modify] https://crrev.com/3f5e66ed12f91be9c51916fa72f59e98cc927d1b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3f5e66ed12f91be9c51916fa72f59e98cc927d1b/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05971b1368780700908f226db1ff99837463abf1

commit 05971b1368780700908f226db1ff99837463abf1
Author: engedy <engedy@chromium.org>
Date: Mon May 29 09:38:58 2017

Implement PasswordStore::GetLoginsForSameOrganizationName.

The method returns all stored credentials with SCHEME_HTTP that have an origin
whose organization-identifying name -- that is, the first domain name label
below the effective TLD -- matches that of a given origin.

For example, the organization-identifying name of "https://foo.example.org" is
`example`, and logins will be returned for "http://bar.example.co.uk", but not
for "http://notexample.com" or "https://example.foo.com".

BUG= 720599 

Review-Url: https://codereview.chromium.org/2899083004
Cr-Commit-Position: refs/heads/master@{#475322}

[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/chrome/browser/password_manager/password_store_mac.cc
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/chrome/browser/password_manager/password_store_mac.h
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/chrome/browser/password_manager/password_store_proxy_mac.cc
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/chrome/browser/password_manager/password_store_proxy_mac.h
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/chrome/browser/password_manager/password_store_x.cc
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/chrome/browser/password_manager/password_store_x.h
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/components/password_manager/core/browser/login_database.cc
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/components/password_manager/core/browser/login_database.h
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/components/password_manager/core/browser/login_database_unittest.cc
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/components/password_manager/core/browser/mock_password_store.h
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/components/password_manager/core/browser/password_store.cc
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/components/password_manager/core/browser/password_store.h
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/components/password_manager/core/browser/password_store_default.cc
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/components/password_manager/core/browser/password_store_default.h
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/components/password_manager/core/browser/password_store_unittest.cc
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/components/password_manager/core/browser/psl_matching_helper.cc
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/components/password_manager/core/browser/psl_matching_helper.h
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/components/password_manager/core/browser/psl_matching_helper_unittest.cc
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/components/password_manager/core/browser/test_password_store.cc
[modify] https://crrev.com/05971b1368780700908f226db1ff99837463abf1/components/password_manager/core/browser/test_password_store.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74d6ed5b631582550c0dd9bf5c5f37475dc9804d

commit 74d6ed5b631582550c0dd9bf5c5f37475dc9804d
Author: engedy <engedy@chromium.org>
Date: Mon May 29 09:45:20 2017

Refactor SuppressedHTTPSFormsFetcher to use GetLoginsForSameOrganizationName.

This results in no change in functionality, but is done in preparation for
refactoring SuppressedHTTPSFormsFetcher to return not only suppressed HTTPS
credentials, but also two other flavors of suppressed credentials. As an
immediate benefit, this CL allows cleaning up password_manager_unittests.

BUG= 720599 

Review-Url: https://codereview.chromium.org/2911433003
Cr-Commit-Position: refs/heads/master@{#475325}

[modify] https://crrev.com/74d6ed5b631582550c0dd9bf5c5f37475dc9804d/components/password_manager/core/browser/form_fetcher_impl.cc
[modify] https://crrev.com/74d6ed5b631582550c0dd9bf5c5f37475dc9804d/components/password_manager/core/browser/form_fetcher_impl_unittest.cc
[modify] https://crrev.com/74d6ed5b631582550c0dd9bf5c5f37475dc9804d/components/password_manager/core/browser/mock_password_store.h
[modify] https://crrev.com/74d6ed5b631582550c0dd9bf5c5f37475dc9804d/components/password_manager/core/browser/password_manager_unittest.cc
[modify] https://crrev.com/74d6ed5b631582550c0dd9bf5c5f37475dc9804d/components/password_manager/core/browser/password_store.h
[modify] https://crrev.com/74d6ed5b631582550c0dd9bf5c5f37475dc9804d/components/password_manager/core/browser/suppressed_https_form_fetcher.cc
[modify] https://crrev.com/74d6ed5b631582550c0dd9bf5c5f37475dc9804d/components/password_manager/core/browser/suppressed_https_form_fetcher.h
[modify] https://crrev.com/74d6ed5b631582550c0dd9bf5c5f37475dc9804d/components/password_manager/core/browser/suppressed_https_form_fetcher_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e373a531ac62344a5fe43c81e9511bc0df495c3d

commit e373a531ac62344a5fe43c81e9511bc0df495c3d
Author: engedy <engedy@chromium.org>
Date: Tue May 30 16:49:57 2017

Measure how often PSL and same-organization name credentials are suppressed.

To this end, the SuppressedHTTPSFormFetcher is extended into the
SuppressedFormFetcher, which now fetches the two new kinds of suppressed
credentials as well; and makes them available through the FormFetcher interface
to PasswordFormManager, which ultimately records the histograms.

BUG= 720599 

Review-Url: https://codereview.chromium.org/2912783002
Cr-Commit-Position: refs/heads/master@{#475561}

[modify] https://crrev.com/e373a531ac62344a5fe43c81e9511bc0df495c3d/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/e373a531ac62344a5fe43c81e9511bc0df495c3d/components/password_manager/core/browser/fake_form_fetcher.cc
[modify] https://crrev.com/e373a531ac62344a5fe43c81e9511bc0df495c3d/components/password_manager/core/browser/fake_form_fetcher.h
[modify] https://crrev.com/e373a531ac62344a5fe43c81e9511bc0df495c3d/components/password_manager/core/browser/form_fetcher.h
[modify] https://crrev.com/e373a531ac62344a5fe43c81e9511bc0df495c3d/components/password_manager/core/browser/form_fetcher_impl.cc
[modify] https://crrev.com/e373a531ac62344a5fe43c81e9511bc0df495c3d/components/password_manager/core/browser/form_fetcher_impl.h
[modify] https://crrev.com/e373a531ac62344a5fe43c81e9511bc0df495c3d/components/password_manager/core/browser/form_fetcher_impl_unittest.cc
[modify] https://crrev.com/e373a531ac62344a5fe43c81e9511bc0df495c3d/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/e373a531ac62344a5fe43c81e9511bc0df495c3d/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/e373a531ac62344a5fe43c81e9511bc0df495c3d/components/password_manager/core/browser/password_form_manager_unittest.cc
[add] https://crrev.com/e373a531ac62344a5fe43c81e9511bc0df495c3d/components/password_manager/core/browser/suppressed_form_fetcher.cc
[rename] https://crrev.com/e373a531ac62344a5fe43c81e9511bc0df495c3d/components/password_manager/core/browser/suppressed_form_fetcher.h
[rename] https://crrev.com/e373a531ac62344a5fe43c81e9511bc0df495c3d/components/password_manager/core/browser/suppressed_form_fetcher_unittest.cc
[delete] https://crrev.com/00797c765a5272808c6cafb3e165f401017f7cc9/components/password_manager/core/browser/suppressed_https_form_fetcher.cc
[modify] https://crrev.com/e373a531ac62344a5fe43c81e9511bc0df495c3d/tools/metrics/histograms/histograms.xml

Requesting merging the following commits:

05971b1368780700908f226db1ff99837463abf1
74d6ed5b631582550c0dd9bf5c5f37475dc9804d
e373a531ac62344a5fe43c81e9511bc0df495c3d

These are recording histograms in scenarios where the manager could have worked better, there are no user visible changes.

Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/517d0c7a0232d747b6a71f753cfb4c6274549049

commit 517d0c7a0232d747b6a71f753cfb4c6274549049
Author: Balazs Engedy <engedy@chromium.org>
Date: Thu Jun 01 12:33:00 2017

Implement PasswordStore::GetLoginsForSameOrganizationName.

The method returns all stored credentials with SCHEME_HTTP that have an origin
whose organization-identifying name -- that is, the first domain name label
below the effective TLD -- matches that of a given origin.

For example, the organization-identifying name of "https://foo.example.org" is
`example`, and logins will be returned for "http://bar.example.co.uk", but not
for "http://notexample.com" or "https://example.foo.com".

BUG= 720599 

Review-Url: https://codereview.chromium.org/2899083004
Cr-Original-Commit-Position: refs/heads/master@{#475322}
Review-Url: https://codereview.chromium.org/2916073002 .
Cr-Commit-Position: refs/branch-heads/3112@{#84}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/chrome/browser/password_manager/password_store_mac.cc
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/chrome/browser/password_manager/password_store_mac.h
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/chrome/browser/password_manager/password_store_proxy_mac.cc
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/chrome/browser/password_manager/password_store_proxy_mac.h
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/chrome/browser/password_manager/password_store_x.cc
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/chrome/browser/password_manager/password_store_x.h
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/components/password_manager/core/browser/login_database.cc
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/components/password_manager/core/browser/login_database.h
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/components/password_manager/core/browser/login_database_unittest.cc
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/components/password_manager/core/browser/mock_password_store.h
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/components/password_manager/core/browser/password_store.cc
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/components/password_manager/core/browser/password_store.h
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/components/password_manager/core/browser/password_store_default.cc
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/components/password_manager/core/browser/password_store_default.h
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/components/password_manager/core/browser/password_store_unittest.cc
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/components/password_manager/core/browser/psl_matching_helper.cc
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/components/password_manager/core/browser/psl_matching_helper.h
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/components/password_manager/core/browser/psl_matching_helper_unittest.cc
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/components/password_manager/core/browser/test_password_store.cc
[modify] https://crrev.com/517d0c7a0232d747b6a71f753cfb4c6274549049/components/password_manager/core/browser/test_password_store.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/863169d1b3f9bc3783d53fdbe686d715f1059c41

commit 863169d1b3f9bc3783d53fdbe686d715f1059c41
Author: Balazs Engedy <engedy@chromium.org>
Date: Thu Jun 01 12:34:12 2017

Refactor SuppressedHTTPSFormsFetcher to use GetLoginsForSameOrganizationName.

This results in no change in functionality, but is done in preparation for
refactoring SuppressedHTTPSFormsFetcher to return not only suppressed HTTPS
credentials, but also two other flavors of suppressed credentials. As an
immediate benefit, this CL allows cleaning up password_manager_unittests.

BUG= 720599 

Review-Url: https://codereview.chromium.org/2911433003
Cr-Original-Commit-Position: refs/heads/master@{#475325}
Review-Url: https://codereview.chromium.org/2918813002 .
Cr-Commit-Position: refs/branch-heads/3112@{#85}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/863169d1b3f9bc3783d53fdbe686d715f1059c41/components/password_manager/core/browser/form_fetcher_impl.cc
[modify] https://crrev.com/863169d1b3f9bc3783d53fdbe686d715f1059c41/components/password_manager/core/browser/form_fetcher_impl_unittest.cc
[modify] https://crrev.com/863169d1b3f9bc3783d53fdbe686d715f1059c41/components/password_manager/core/browser/mock_password_store.h
[modify] https://crrev.com/863169d1b3f9bc3783d53fdbe686d715f1059c41/components/password_manager/core/browser/password_manager_unittest.cc
[modify] https://crrev.com/863169d1b3f9bc3783d53fdbe686d715f1059c41/components/password_manager/core/browser/password_store.h
[modify] https://crrev.com/863169d1b3f9bc3783d53fdbe686d715f1059c41/components/password_manager/core/browser/suppressed_https_form_fetcher.cc
[modify] https://crrev.com/863169d1b3f9bc3783d53fdbe686d715f1059c41/components/password_manager/core/browser/suppressed_https_form_fetcher.h
[modify] https://crrev.com/863169d1b3f9bc3783d53fdbe686d715f1059c41/components/password_manager/core/browser/suppressed_https_form_fetcher_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d

commit 8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d
Author: Balazs Engedy <engedy@chromium.org>
Date: Thu Jun 01 12:35:24 2017

Measure how often PSL and same-organization name credentials are suppressed.

To this end, the SuppressedHTTPSFormFetcher is extended into the
SuppressedFormFetcher, which now fetches the two new kinds of suppressed
credentials as well; and makes them available through the FormFetcher interface
to PasswordFormManager, which ultimately records the histograms.

BUG= 720599 

Review-Url: https://codereview.chromium.org/2912783002
Cr-Original-Commit-Position: refs/heads/master@{#475561}
Review-Url: https://codereview.chromium.org/2920793002 .
Cr-Commit-Position: refs/branch-heads/3112@{#86}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d/components/password_manager/core/browser/fake_form_fetcher.cc
[modify] https://crrev.com/8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d/components/password_manager/core/browser/fake_form_fetcher.h
[modify] https://crrev.com/8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d/components/password_manager/core/browser/form_fetcher.h
[modify] https://crrev.com/8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d/components/password_manager/core/browser/form_fetcher_impl.cc
[modify] https://crrev.com/8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d/components/password_manager/core/browser/form_fetcher_impl.h
[modify] https://crrev.com/8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d/components/password_manager/core/browser/form_fetcher_impl_unittest.cc
[modify] https://crrev.com/8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d/components/password_manager/core/browser/password_form_manager_unittest.cc
[add] https://crrev.com/8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d/components/password_manager/core/browser/suppressed_form_fetcher.cc
[rename] https://crrev.com/8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d/components/password_manager/core/browser/suppressed_form_fetcher.h
[rename] https://crrev.com/8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d/components/password_manager/core/browser/suppressed_form_fetcher_unittest.cc
[delete] https://crrev.com/863169d1b3f9bc3783d53fdbe686d715f1059c41/components/password_manager/core/browser/suppressed_https_form_fetcher.cc
[modify] https://crrev.com/8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d/tools/metrics/histograms/histograms.xml