New issue
Advanced search Search tips

Issue 720593 link

Starred by 1 user
Status: Fixed
Owner:
ma...@chromium.org
Closed: May 2017
Cc:
anthonyvd@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Card input field too narrow

Project Member Reported by rouslan@chromium.org, May 10 2017 
Chrome Version       : 60.0.3095.0
OS Version: OS X 10.12.4

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3095.0 Safari/537.36
Screen Shot 2017-05-10 at 3.02.55 PM.png
83.2 KB View Download

Comment 1 by anthonyvd@chromium.org, May 10 2017

Cc: anthonyvd@chromium.org
Owner: ma...@chromium.org
Status: Assigned (was: Untriaged)
Math is fixing this in https://codereview.chromium.org/2871873003.

Comment 2 by ma...@chromium.org, May 10 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6449a52e98ecf9dcc888c0868935d9944375e7a

commit d6449a52e98ecf9dcc888c0868935d9944375e7a
Author: mathp <mathp@chromium.org>
Date: Thu May 11 16:59:46 2017

[Payments] Fix up field widths in desktop editors.

Width is now conformant to spec. See bug for screenshots.

Moved the billing address combobox to be handled by the base class now.
The credit card editor only adds the Add button as an extra view.
Modified the address combobox model to accept a default selected guid.

BUG=718548, 720593 
TEST=visual

Review-Url: https://codereview.chromium.org/2871873003
Cr-Commit-Position: refs/heads/master@{#470980}

[modify] https://crrev.com/d6449a52e98ecf9dcc888c0868935d9944375e7a/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc
[modify] https://crrev.com/d6449a52e98ecf9dcc888c0868935d9944375e7a/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
[modify] https://crrev.com/d6449a52e98ecf9dcc888c0868935d9944375e7a/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h
[modify] https://crrev.com/d6449a52e98ecf9dcc888c0868935d9944375e7a/chrome/browser/ui/views/payments/editor_view_controller.cc
[modify] https://crrev.com/d6449a52e98ecf9dcc888c0868935d9944375e7a/chrome/browser/ui/views/payments/editor_view_controller.h
[modify] https://crrev.com/d6449a52e98ecf9dcc888c0868935d9944375e7a/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/d6449a52e98ecf9dcc888c0868935d9944375e7a/chrome/browser/ui/views/payments/payment_request_views_util.h
[modify] https://crrev.com/d6449a52e98ecf9dcc888c0868935d9944375e7a/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/d6449a52e98ecf9dcc888c0868935d9944375e7a/components/autofill/core/browser/address_combobox_model.cc
[modify] https://crrev.com/d6449a52e98ecf9dcc888c0868935d9944375e7a/components/autofill/core/browser/address_combobox_model.h
[modify] https://crrev.com/d6449a52e98ecf9dcc888c0868935d9944375e7a/components/autofill/core/browser/address_combobox_model_unittest.cc

Comment 4 by ma...@chromium.org, May 11 2017

Status: Fixed (was: Started)

Comment 5 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment